On 01/13/21 09:54, Laszlo Ersek wrote:
> Repo: https://pagure.io/lersek/edk2.git
> Branch: shell_usability_improvements_v2
>
> Changes in v2:
>
> - no code changes in any of the v1 patches,
>
> - pick up v1 feedback tags from Ard and Zhichao,
>
> - add two new patches, for resolving OrderedCollectionLib in EmulatorPkg
> and UefiPayloadPkg.
Merged as commit range e68c2a22caae..6e5586863148, via
<https://github.com/tianocore/edk2/pull/1370>.
Thanks for the reviews; especially thanks to Phil for reviewing the
whole series!
Laszlo
>
> Additionally, I have posted the following pre-requisite series, for
> edk2-platforms:
>
> [edk2-devel] [edk2-platforms PATCH 0/3]
> add OrderedCollectionLib class resolution
>
> https://www.redhat.com/archives/edk2-devel-archive/2021-January/msg00694.html
> https://edk2.groups.io/g/devel/message/70210
> Message-Id: <20210113082843.9095-1-lersek@redhat.com>
>
> The v1 posting was at:
>
> https://edk2.groups.io/g/devel/message/69590
> https://www.redhat.com/archives/edk2-devel-archive/2021-January/msg00070.html
> Message-Id: <20210104154235.31785-1-lersek@redhat.com>
>
> v1 blurb:
>
> This series addresses various usability shortcomings that I've recently
> run into, while working with large directory trees on FAT and/or
> virtio-fs in the UEFI shell.
>
> * add file buffering to the COMP command
> https://bugzilla.tianocore.org/show_bug.cgi?id=3123
>
> * ArmVirtPkg, OvmfPkg: set PcdShellFileOperationSize to 0x20000
> https://bugzilla.tianocore.org/show_bug.cgi?id=3125
>
> * Shell: pathname / filename sorting
> https://bugzilla.tianocore.org/show_bug.cgi?id=3151
>
> * ArmVirtPkg, OvmfPkg: disable list length checks in NOOPT and DEBUG
> builds
> https://bugzilla.tianocore.org/show_bug.cgi?id=3152
>
> Beyond testing the series locally, I've also heavily subjected it to
> local CI runs, including ECC (relevant for ShellPkg).
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Peter Grehan <grehan@freebsd.org>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
>
> Thanks
> Laszlo
>
> Laszlo Ersek (10):
> ShellPkg/Comp: add file buffering
> OvmfPkg: raise PcdShellFileOperationSize to 128KB
> ArmVirtPkg: raise PcdShellFileOperationSize to 128KB
> EmulatorPkg: add OrderedCollectionLib class resolution
> UefiPayloadPkg: add OrderedCollectionLib class resolution
> ShellPkg/ShellCommandLib: add ShellSortFileList()
> ShellPkg/Ls: sort output by FileName in non-SFO mode
> ShellPkg/ShellProtocol: sort files by FullName in
> RemoveDupInFileList()
> OvmfPkg: disable list length checks in NOOPT and DEBUG builds
> ArmVirtPkg: disable list length checks in NOOPT and DEBUG builds
>
> ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
> ArmVirtPkg/ArmVirtQemu.dsc | 1 +
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 +
> EmulatorPkg/EmulatorPkg.dsc | 1 +
> OvmfPkg/AmdSev/AmdSevX64.dsc | 1 +
> OvmfPkg/Bhyve/BhyveX64.dsc | 1 +
> OvmfPkg/OvmfPkgIa32.dsc | 3 +
> OvmfPkg/OvmfPkgIa32X64.dsc | 3 +
> OvmfPkg/OvmfPkgX64.dsc | 3 +
> OvmfPkg/OvmfXen.dsc | 1 +
> ShellPkg/Application/Shell/ShellProtocol.c | 16 +
> ShellPkg/Include/Library/ShellCommandLib.h | 81 +++++
> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 312 ++++++++++++++++++++
> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.h | 19 ++
> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf | 1 +
> ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c | 127 +++++++-
> ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf | 1 +
> ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c | 14 +
> ShellPkg/ShellPkg.dsc | 1 +
> UefiPayloadPkg/UefiPayloadPkg.dsc | 1 +
> 20 files changed, 586 insertions(+), 4 deletions(-)
>
>
> base-commit: ebfe2d3eb5ac7fd92d74011edb31303a181920c7
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70556): https://edk2.groups.io/g/devel/message/70556
Mute This Topic: https://groups.io/mt/79646577/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-