[edk2-devel] [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution

Laszlo Ersek posted 3 patches 5 days, 6 hours ago
Failed in applying to current master (apply log)
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                          | 1 +
Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                            | 1 +
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                  | 2 ++
Platform/Hisilicon/D03/D03.dsc                                          | 1 +
Platform/Hisilicon/HiKey/HiKey.dsc                                      | 1 +
Platform/Hisilicon/HiKey960/HiKey960.dsc                                | 1 +
Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc     | 1 +
Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc         | 1 +
Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc       | 1 +
Platform/Intel/QuarkPlatformPkg/Quark.dsc                               | 1 +
Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc                            | 1 +
Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc        | 1 +
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc                    | 1 +
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc                     | 1 +
Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc        | 1 +
Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
Platform/LeMaker/CelloBoard/CelloBoard.dsc                              | 1 +
Platform/Socionext/DeveloperBox/DeveloperBox.dsc                        | 1 +
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc            | 1 +
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc             | 1 +
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc                           | 1 +
Silicon/NXP/NxpQoriqLs.dsc.inc                                          | 1 +
22 files changed, 23 insertions(+)

[edk2-devel] [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution

Posted by Laszlo Ersek 5 days, 6 hours ago
The edk2 patch

  ShellPkg/ShellCommandLib: add ShellSortFileList

for <https://bugzilla.tianocore.org/show_bug.cgi?id=3151> will make the

  ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf

instance dependent on the OrderedCollectionLib class. Because the shell
binaries in several silicon and platform DSCs in edk2-platforms consume
the above UefiShellCommandLib instance, resolve the OrderedCollectionLib
class in those DSCs.

Cc: Agyeman Prince <prince.agyeman@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
Cc: Jeremy Soller <jeremy@system76.com>
Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Marcin Wojtas <mw@semihalf.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Cc: Wenyi Xie <xiewenyi2@huawei.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>

Thanks
Laszlo

Laszlo Ersek (3):
  Platform/BeagleBoard: add missing TimeBaseLib resolution
  ARM Silicon and Platforms: add OrderedCollectionLib class resolution
  Intel Platforms: add OrderedCollectionLib class resolution

 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                          | 1 +
 Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                            | 1 +
 Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                  | 2 ++
 Platform/Hisilicon/D03/D03.dsc                                          | 1 +
 Platform/Hisilicon/HiKey/HiKey.dsc                                      | 1 +
 Platform/Hisilicon/HiKey960/HiKey960.dsc                                | 1 +
 Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc     | 1 +
 Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc         | 1 +
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc       | 1 +
 Platform/Intel/QuarkPlatformPkg/Quark.dsc                               | 1 +
 Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc                            | 1 +
 Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc        | 1 +
 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc                    | 1 +
 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc                     | 1 +
 Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc        | 1 +
 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
 Platform/LeMaker/CelloBoard/CelloBoard.dsc                              | 1 +
 Platform/Socionext/DeveloperBox/DeveloperBox.dsc                        | 1 +
 Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc            | 1 +
 Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc             | 1 +
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc                           | 1 +
 Silicon/NXP/NxpQoriqLs.dsc.inc                                          | 1 +
 22 files changed, 23 insertions(+)


base-commit: 47b4a1db02873ffe864486dfcc8a87c409bd3d4d
-- 
2.19.1.3.g30247aa5d201



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70210): https://edk2.groups.io/g/devel/message/70210
Mute This Topic: https://groups.io/mt/79646270/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution

Posted by Philippe Mathieu-Daudé 3 days, 5 hours ago
On 1/13/21 9:28 AM, Laszlo Ersek wrote:
> The edk2 patch
> 
>   ShellPkg/ShellCommandLib: add ShellSortFileList
> 
> for <https://bugzilla.tianocore.org/show_bug.cgi?id=3151> will make the
> 
>   ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> 
> instance dependent on the OrderedCollectionLib class. Because the shell
> binaries in several silicon and platform DSCs in edk2-platforms consume
> the above UefiShellCommandLib instance, resolve the OrderedCollectionLib
> class in those DSCs.
> 
> Cc: Agyeman Prince <prince.agyeman@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Wenyi Xie <xiewenyi2@huawei.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (3):
>   Platform/BeagleBoard: add missing TimeBaseLib resolution
>   ARM Silicon and Platforms: add OrderedCollectionLib class resolution
>   Intel Platforms: add OrderedCollectionLib class resolution
> 
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                          | 1 +
>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                            | 1 +
>  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                  | 2 ++
>  Platform/Hisilicon/D03/D03.dsc                                          | 1 +
>  Platform/Hisilicon/HiKey/HiKey.dsc                                      | 1 +
>  Platform/Hisilicon/HiKey960/HiKey960.dsc                                | 1 +
>  Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc     | 1 +
>  Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc         | 1 +
>  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc       | 1 +
>  Platform/Intel/QuarkPlatformPkg/Quark.dsc                               | 1 +
>  Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc                            | 1 +
>  Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc        | 1 +
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc                    | 1 +
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc                     | 1 +
>  Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc        | 1 +
>  Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
>  Platform/LeMaker/CelloBoard/CelloBoard.dsc                              | 1 +
>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc                        | 1 +
>  Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc            | 1 +
>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc             | 1 +
>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc                           | 1 +
>  Silicon/NXP/NxpQoriqLs.dsc.inc                                          | 1 +
>  22 files changed, 23 insertions(+)

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70415): https://edk2.groups.io/g/devel/message/70415
Mute This Topic: https://groups.io/mt/79646270/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution

Posted by Laszlo Ersek 3 days, 5 hours ago
Hi All,

sorry about the message; it's been only two days indeed.

This patch series is trivial, it adds one lib class resolution to each
of 22 platforms in edk2-platforms.

I build-tested the platforms modified by this change, so I'm planning to
push the series to edk2-platforms one week after posting it -- even if I
get no feedback. Thus, the reason I'm sending this email isn't really to
ping or urge reviewers, it's more like announcing my plan.

Thanks,
Laszlo


On 01/13/21 09:28, Laszlo Ersek wrote:
> The edk2 patch
> 
>   ShellPkg/ShellCommandLib: add ShellSortFileList
> 
> for <https://bugzilla.tianocore.org/show_bug.cgi?id=3151> will make the
> 
>   ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> 
> instance dependent on the OrderedCollectionLib class. Because the shell
> binaries in several silicon and platform DSCs in edk2-platforms consume
> the above UefiShellCommandLib instance, resolve the OrderedCollectionLib
> class in those DSCs.
> 
> Cc: Agyeman Prince <prince.agyeman@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Wenyi Xie <xiewenyi2@huawei.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (3):
>   Platform/BeagleBoard: add missing TimeBaseLib resolution
>   ARM Silicon and Platforms: add OrderedCollectionLib class resolution
>   Intel Platforms: add OrderedCollectionLib class resolution
> 
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                          | 1 +
>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                            | 1 +
>  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                  | 2 ++
>  Platform/Hisilicon/D03/D03.dsc                                          | 1 +
>  Platform/Hisilicon/HiKey/HiKey.dsc                                      | 1 +
>  Platform/Hisilicon/HiKey960/HiKey960.dsc                                | 1 +
>  Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc     | 1 +
>  Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc         | 1 +
>  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc       | 1 +
>  Platform/Intel/QuarkPlatformPkg/Quark.dsc                               | 1 +
>  Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc                            | 1 +
>  Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc        | 1 +
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc                    | 1 +
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc                     | 1 +
>  Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc        | 1 +
>  Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
>  Platform/LeMaker/CelloBoard/CelloBoard.dsc                              | 1 +
>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc                        | 1 +
>  Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc            | 1 +
>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc             | 1 +
>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc                           | 1 +
>  Silicon/NXP/NxpQoriqLs.dsc.inc                                          | 1 +
>  22 files changed, 23 insertions(+)
> 
> 
> base-commit: 47b4a1db02873ffe864486dfcc8a87c409bd3d4d
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70394): https://edk2.groups.io/g/devel/message/70394
Mute This Topic: https://groups.io/mt/79646270/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution

Posted by Leif Lindholm 2 days, 16 hours ago
Hi Laszlo,

On Fri, Jan 15, 2021 at 09:50:57 +0100, Laszlo Ersek wrote:
> Hi All,
> 
> sorry about the message; it's been only two days indeed.
> 
> This patch series is trivial, it adds one lib class resolution to each
> of 22 platforms in edk2-platforms.
> 
> I build-tested the platforms modified by this change, so I'm planning to
> push the series to edk2-platforms one week after posting it -- even if I
> get no feedback. Thus, the reason I'm sending this email isn't really to
> ping or urge reviewers, it's more like announcing my plan.
> 
> Thanks,
> Laszlo

Apologies, I woke up Wednesday to the news we had been acquired by
Qualcomm, and the week got a bit hazy at that point :)

Many thanks for fixing up BeagleBoard as well.

For the relevant patches:
Acked-by: Leif Lindholm <leif@nuviainc.com>

> On 01/13/21 09:28, Laszlo Ersek wrote:
> > The edk2 patch
> > 
> >   ShellPkg/ShellCommandLib: add ShellSortFileList
> > 
> > for <https://bugzilla.tianocore.org/show_bug.cgi?id=3151> will make the
> > 
> >   ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> > 
> > instance dependent on the OrderedCollectionLib class. Because the shell
> > binaries in several silicon and platform DSCs in edk2-platforms consume
> > the above UefiShellCommandLib instance, resolve the OrderedCollectionLib
> > class in those DSCs.
> > 
> > Cc: Agyeman Prince <prince.agyeman@intel.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> > Cc: Jeremy Soller <jeremy@system76.com>
> > Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> > Cc: Kelly Steele <kelly.steele@intel.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Marcin Wojtas <mw@semihalf.com>
> > Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> > Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > Cc: Thomas Abraham <thomas.abraham@arm.com>
> > Cc: Wenyi Xie <xiewenyi2@huawei.com>
> > Cc: Yi Qian <yi.qian@intel.com>
> > Cc: Zailiang Sun <zailiang.sun@intel.com>
> > 
> > Thanks
> > Laszlo
> > 
> > Laszlo Ersek (3):
> >   Platform/BeagleBoard: add missing TimeBaseLib resolution
> >   ARM Silicon and Platforms: add OrderedCollectionLib class resolution
> >   Intel Platforms: add OrderedCollectionLib class resolution
> > 
> >  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                          | 1 +
> >  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                            | 1 +
> >  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                  | 2 ++
> >  Platform/Hisilicon/D03/D03.dsc                                          | 1 +
> >  Platform/Hisilicon/HiKey/HiKey.dsc                                      | 1 +
> >  Platform/Hisilicon/HiKey960/HiKey960.dsc                                | 1 +
> >  Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc     | 1 +
> >  Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc         | 1 +
> >  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc       | 1 +
> >  Platform/Intel/QuarkPlatformPkg/Quark.dsc                               | 1 +
> >  Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc                            | 1 +
> >  Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc        | 1 +
> >  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc                    | 1 +
> >  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc                     | 1 +
> >  Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc        | 1 +
> >  Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
> >  Platform/LeMaker/CelloBoard/CelloBoard.dsc                              | 1 +
> >  Platform/Socionext/DeveloperBox/DeveloperBox.dsc                        | 1 +
> >  Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc            | 1 +
> >  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc             | 1 +
> >  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc                           | 1 +
> >  Silicon/NXP/NxpQoriqLs.dsc.inc                                          | 1 +
> >  22 files changed, 23 insertions(+)
> > 
> > 
> > base-commit: 47b4a1db02873ffe864486dfcc8a87c409bd3d4d
> > 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70460): https://edk2.groups.io/g/devel/message/70460
Mute This Topic: https://groups.io/mt/79646270/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution

Posted by Laszlo Ersek 7 hours ago
On 01/15/21 23:04, Leif Lindholm wrote:
> Hi Laszlo,
> 
> On Fri, Jan 15, 2021 at 09:50:57 +0100, Laszlo Ersek wrote:
>> Hi All,
>>
>> sorry about the message; it's been only two days indeed.
>>
>> This patch series is trivial, it adds one lib class resolution to each
>> of 22 platforms in edk2-platforms.
>>
>> I build-tested the platforms modified by this change, so I'm planning to
>> push the series to edk2-platforms one week after posting it -- even if I
>> get no feedback. Thus, the reason I'm sending this email isn't really to
>> ping or urge reviewers, it's more like announcing my plan.
>>
>> Thanks,
>> Laszlo
> 
> Apologies, I woke up Wednesday to the news we had been acquired by
> Qualcomm, and the week got a bit hazy at that point :)

Yes, that was a surprise.

> 
> Many thanks for fixing up BeagleBoard as well.
> 
> For the relevant patches:
> Acked-by: Leif Lindholm <leif@nuviainc.com>

Thanks!
Laszlo

> 
>> On 01/13/21 09:28, Laszlo Ersek wrote:
>>> The edk2 patch
>>>
>>>   ShellPkg/ShellCommandLib: add ShellSortFileList
>>>
>>> for <https://bugzilla.tianocore.org/show_bug.cgi?id=3151> will make the
>>>
>>>   ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>>>
>>> instance dependent on the OrderedCollectionLib class. Because the shell
>>> binaries in several silicon and platform DSCs in edk2-platforms consume
>>> the above UefiShellCommandLib instance, resolve the OrderedCollectionLib
>>> class in those DSCs.
>>>
>>> Cc: Agyeman Prince <prince.agyeman@intel.com>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>>> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
>>> Cc: Jeremy Soller <jeremy@system76.com>
>>> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
>>> Cc: Kelly Steele <kelly.steele@intel.com>
>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>> Cc: Marcin Wojtas <mw@semihalf.com>
>>> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
>>> Cc: Thomas Abraham <thomas.abraham@arm.com>
>>> Cc: Wenyi Xie <xiewenyi2@huawei.com>
>>> Cc: Yi Qian <yi.qian@intel.com>
>>> Cc: Zailiang Sun <zailiang.sun@intel.com>
>>>
>>> Thanks
>>> Laszlo
>>>
>>> Laszlo Ersek (3):
>>>   Platform/BeagleBoard: add missing TimeBaseLib resolution
>>>   ARM Silicon and Platforms: add OrderedCollectionLib class resolution
>>>   Intel Platforms: add OrderedCollectionLib class resolution
>>>
>>>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                          | 1 +
>>>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                            | 1 +
>>>  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                  | 2 ++
>>>  Platform/Hisilicon/D03/D03.dsc                                          | 1 +
>>>  Platform/Hisilicon/HiKey/HiKey.dsc                                      | 1 +
>>>  Platform/Hisilicon/HiKey960/HiKey960.dsc                                | 1 +
>>>  Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc     | 1 +
>>>  Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc         | 1 +
>>>  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc       | 1 +
>>>  Platform/Intel/QuarkPlatformPkg/Quark.dsc                               | 1 +
>>>  Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc                            | 1 +
>>>  Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc        | 1 +
>>>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc                    | 1 +
>>>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc                     | 1 +
>>>  Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc        | 1 +
>>>  Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
>>>  Platform/LeMaker/CelloBoard/CelloBoard.dsc                              | 1 +
>>>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc                        | 1 +
>>>  Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc            | 1 +
>>>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc             | 1 +
>>>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc                           | 1 +
>>>  Silicon/NXP/NxpQoriqLs.dsc.inc                                          | 1 +
>>>  22 files changed, 23 insertions(+)
>>>
>>>
>>> base-commit: 47b4a1db02873ffe864486dfcc8a87c409bd3d4d
>>>
>>
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70488): https://edk2.groups.io/g/devel/message/70488
Mute This Topic: https://groups.io/mt/79646270/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution

Posted by Ard Biesheuvel 3 days, 5 hours ago
On 1/15/21 9:50 AM, Laszlo Ersek wrote:
> Hi All,
> 
> sorry about the message; it's been only two days indeed.
> 
> This patch series is trivial, it adds one lib class resolution to each
> of 22 platforms in edk2-platforms.
> 
> I build-tested the platforms modified by this change, so I'm planning to
> push the series to edk2-platforms one week after posting it -- even if I
> get no feedback. Thus, the reason I'm sending this email isn't really to
> ping or urge reviewers, it's more like announcing my plan.
> 
> Thanks,
> Laszlo
> 
> 
> On 01/13/21 09:28, Laszlo Ersek wrote:
>> The edk2 patch
>>
>>   ShellPkg/ShellCommandLib: add ShellSortFileList
>>
>> for <https://bugzilla.tianocore.org/show_bug.cgi?id=3151> will make the
>>
>>   ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>>
>> instance dependent on the OrderedCollectionLib class. Because the shell
>> binaries in several silicon and platform DSCs in edk2-platforms consume
>> the above UefiShellCommandLib instance, resolve the OrderedCollectionLib
>> class in those DSCs.
>>
>> Cc: Agyeman Prince <prince.agyeman@intel.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
>> Cc: Jeremy Soller <jeremy@system76.com>
>> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
>> Cc: Kelly Steele <kelly.steele@intel.com>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Marcin Wojtas <mw@semihalf.com>
>> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
>> Cc: Thomas Abraham <thomas.abraham@arm.com>
>> Cc: Wenyi Xie <xiewenyi2@huawei.com>
>> Cc: Yi Qian <yi.qian@intel.com>
>> Cc: Zailiang Sun <zailiang.sun@intel.com>
>>

Where appropriate in the series,

Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

and

Acked-by: Ard Biesheuvel <ardb+tianocore@kernel.org>




>> Thanks
>> Laszlo
>>
>> Laszlo Ersek (3):
>>   Platform/BeagleBoard: add missing TimeBaseLib resolution
>>   ARM Silicon and Platforms: add OrderedCollectionLib class resolution
>>   Intel Platforms: add OrderedCollectionLib class resolution
>>
>>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                          | 1 +
>>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                            | 1 +
>>  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                  | 2 ++
>>  Platform/Hisilicon/D03/D03.dsc                                          | 1 +
>>  Platform/Hisilicon/HiKey/HiKey.dsc                                      | 1 +
>>  Platform/Hisilicon/HiKey960/HiKey960.dsc                                | 1 +
>>  Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc     | 1 +
>>  Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc         | 1 +
>>  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc       | 1 +
>>  Platform/Intel/QuarkPlatformPkg/Quark.dsc                               | 1 +
>>  Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc                            | 1 +
>>  Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc        | 1 +
>>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc                    | 1 +
>>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc                     | 1 +
>>  Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc        | 1 +
>>  Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
>>  Platform/LeMaker/CelloBoard/CelloBoard.dsc                              | 1 +
>>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc                        | 1 +
>>  Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc            | 1 +
>>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc             | 1 +
>>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc                           | 1 +
>>  Silicon/NXP/NxpQoriqLs.dsc.inc                                          | 1 +
>>  22 files changed, 23 insertions(+)
>>
>>
>> base-commit: 47b4a1db02873ffe864486dfcc8a87c409bd3d4d
>>
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70413): https://edk2.groups.io/g/devel/message/70413
Mute This Topic: https://groups.io/mt/79646270/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution

Posted by Laszlo Ersek 3 days, 5 hours ago
On 01/15/21 10:22, Ard Biesheuvel wrote:
> On 1/15/21 9:50 AM, Laszlo Ersek wrote:
>> Hi All,
>>
>> sorry about the message; it's been only two days indeed.
>>
>> This patch series is trivial, it adds one lib class resolution to each
>> of 22 platforms in edk2-platforms.
>>
>> I build-tested the platforms modified by this change, so I'm planning to
>> push the series to edk2-platforms one week after posting it -- even if I
>> get no feedback. Thus, the reason I'm sending this email isn't really to
>> ping or urge reviewers, it's more like announcing my plan.
>>
>> Thanks,
>> Laszlo
>>
>>
>> On 01/13/21 09:28, Laszlo Ersek wrote:
>>> The edk2 patch
>>>
>>>   ShellPkg/ShellCommandLib: add ShellSortFileList
>>>
>>> for <https://bugzilla.tianocore.org/show_bug.cgi?id=3151> will make the
>>>
>>>   ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>>>
>>> instance dependent on the OrderedCollectionLib class. Because the shell
>>> binaries in several silicon and platform DSCs in edk2-platforms consume
>>> the above UefiShellCommandLib instance, resolve the OrderedCollectionLib
>>> class in those DSCs.
>>>
>>> Cc: Agyeman Prince <prince.agyeman@intel.com>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>>> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
>>> Cc: Jeremy Soller <jeremy@system76.com>
>>> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
>>> Cc: Kelly Steele <kelly.steele@intel.com>
>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>> Cc: Marcin Wojtas <mw@semihalf.com>
>>> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
>>> Cc: Thomas Abraham <thomas.abraham@arm.com>
>>> Cc: Wenyi Xie <xiewenyi2@huawei.com>
>>> Cc: Yi Qian <yi.qian@intel.com>
>>> Cc: Zailiang Sun <zailiang.sun@intel.com>
>>>
> 
> Where appropriate in the series,
> 
> Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 
> and
> 
> Acked-by: Ard Biesheuvel <ardb+tianocore@kernel.org>

much appreciated everyone!
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70421): https://edk2.groups.io/g/devel/message/70421
Mute This Topic: https://groups.io/mt/79646270/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-