[edk2-devel] [PATCH v5 0/7] rpi4: Enable eMMC2 controller

Jeremy Linton posted 7 patches 3 years, 2 months ago
Failed in applying to current master (apply log)
.../Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c    | 131 ++++++++---
.../Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.h    |   1 +
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c |   7 +
.../Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c        | 240 ++++++++++++++++++++-
.../RaspberryPi/Include/IndustryStandard/RpiMbox.h |  94 +++++++-
.../RaspberryPi/Include/Protocol/RpiFirmware.h     |  25 +++
.../Library/PlatformBootManagerLib/PlatformBm.c    |   2 +-
.../Bcm283x/Include/IndustryStandard/Bcm2836Sdio.h |  42 ++--
8 files changed, 484 insertions(+), 58 deletions(-)
[edk2-devel] [PATCH v5 0/7] rpi4: Enable eMMC2 controller
Posted by Jeremy Linton 3 years, 2 months ago
The rpi4 has a secondary SD controller at offset
0xfe340000. This controller appears to be a mostly
compliant SDHCI controller (a newer more bugfree
Arasan?). So the existing Arasan driver should be
bound to it. This allows the rpi4 to boot
with its normal eMMC2->SD card, Arasan->wifi
configuration that is described in the Linux DT.

To achieve this, it appears we should be tweaking
some of the expansion gpios, and probably telling
the firmware to power everything up. To do that
the vpu mailbox headers are synced with a more recent
list of the mailbox commands, then the rpi
firmware dxe is extended to support some futher
gpio/power commands. Once that is complete we tweak
the arasan driver to use an alternate register base,
add a workaround for a known clock crossing bug, and
set the card voltage.

Of note, this set does _NOT_ change the HID/CID's
and add the additional eMMC2 controller to the
DSDT table.

v4->v5: variable rename
v3->v4: Commit message tweaks, variable rename.
v1->v3: Use some mailbox defines rather than opencoded constants

Jeremy Linton (7):
  Platform/RaspberryPi: Update VPU mailbox constants
  Platform/RaspberryPi: Add further mailbox helpers
  Platform/RaspberryPi: Split MMC register definitions
  Platform/RaspberryPi/Arasan: Add write delay and voltage/clock config
  Platform/RaspberryPi/Arasan: Select the correct base frequency
  Platform/RaspberryPi: Power up SD, and tweak GPIOs
  Platform/RaspberryPi: Correct device path removal.

 .../Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c    | 131 ++++++++---
 .../Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.h    |   1 +
 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c |   7 +
 .../Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c        | 240 ++++++++++++++++++++-
 .../RaspberryPi/Include/IndustryStandard/RpiMbox.h |  94 +++++++-
 .../RaspberryPi/Include/Protocol/RpiFirmware.h     |  25 +++
 .../Library/PlatformBootManagerLib/PlatformBm.c    |   2 +-
 .../Bcm283x/Include/IndustryStandard/Bcm2836Sdio.h |  42 ++--
 8 files changed, 484 insertions(+), 58 deletions(-)

-- 
2.13.7



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70013): https://edk2.groups.io/g/devel/message/70013
Mute This Topic: https://groups.io/mt/79518668/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v5 0/7] rpi4: Enable eMMC2 controller
Posted by Ard Biesheuvel 3 years, 2 months ago
On 1/8/21 7:14 AM, Jeremy Linton wrote:
> The rpi4 has a secondary SD controller at offset
> 0xfe340000. This controller appears to be a mostly
> compliant SDHCI controller (a newer more bugfree
> Arasan?). So the existing Arasan driver should be
> bound to it. This allows the rpi4 to boot
> with its normal eMMC2->SD card, Arasan->wifi
> configuration that is described in the Linux DT.
> 
> To achieve this, it appears we should be tweaking
> some of the expansion gpios, and probably telling
> the firmware to power everything up. To do that
> the vpu mailbox headers are synced with a more recent
> list of the mailbox commands, then the rpi
> firmware dxe is extended to support some futher
> gpio/power commands. Once that is complete we tweak
> the arasan driver to use an alternate register base,
> add a workaround for a known clock crossing bug, and
> set the card voltage.
> 
> Of note, this set does _NOT_ change the HID/CID's
> and add the additional eMMC2 controller to the
> DSDT table.
> 
> v4->v5: variable rename
> v3->v4: Commit message tweaks, variable rename.
> v1->v3: Use some mailbox defines rather than opencoded constants
> 
> Jeremy Linton (7):
>   Platform/RaspberryPi: Update VPU mailbox constants
>   Platform/RaspberryPi: Add further mailbox helpers
>   Platform/RaspberryPi: Split MMC register definitions
>   Platform/RaspberryPi/Arasan: Add write delay and voltage/clock config
>   Platform/RaspberryPi/Arasan: Select the correct base frequency
>   Platform/RaspberryPi: Power up SD, and tweak GPIOs
>   Platform/RaspberryPi: Correct device path removal.
> 

Pushed as f8958b86e886..dcb1fbff08bb

Thanks all,

>  .../Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c    | 131 ++++++++---
>  .../Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.h    |   1 +
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c |   7 +
>  .../Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c        | 240 ++++++++++++++++++++-
>  .../RaspberryPi/Include/IndustryStandard/RpiMbox.h |  94 +++++++-
>  .../RaspberryPi/Include/Protocol/RpiFirmware.h     |  25 +++
>  .../Library/PlatformBootManagerLib/PlatformBm.c    |   2 +-
>  .../Bcm283x/Include/IndustryStandard/Bcm2836Sdio.h |  42 ++--
>  8 files changed, 484 insertions(+), 58 deletions(-)
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70039): https://edk2.groups.io/g/devel/message/70039
Mute This Topic: https://groups.io/mt/79518668/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-