From nobody Fri Mar 29 00:39:55 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+70012+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70012+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1610078816; cv=none; d=zohomail.com; s=zohoarc; b=ZB6GYwCN76rwySupusrie12N/lu4rhWKR4GKbvJfFFo7o/ObCpMkTw+PROR/0foPw2KV58QPuWQfsU2NreBCiznTfSPXaSgifCQnhWgOMTA7U0C2g8yvsafHDUTm0t+CNcqvysNmwyWtnDgVNiA+J3YpU+bPed54pQFlNEoq2do= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610078816; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=PNXN3iijBc5AQDpJXI2hAM3y9kmyAid4Jkcs1C3OCuw=; b=SmZ4BOFSxuNtiUZaEoKkpva5qoQv5JS5BZDzEqM64JAkM27eTzKkMfq6w9tSo2Cwz0iN3tVMkg+u83e6FrSlw5dNxVCYtUU0Vtsfoq8u1NaEpPT5XvBOwAUFamMYhQFfjJIo7KceE2jSGjPjDRcZgZoIga5QCReUpkw53plt2ZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+70012+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 161007881672122.269086841256467; Thu, 7 Jan 2021 20:06:56 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id ggc8YY1788612xqflxx6y9FD; Thu, 07 Jan 2021 20:06:55 -0800 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web09.3596.1610078814635023904 for ; Thu, 07 Jan 2021 20:06:54 -0800 IronPort-SDR: Ixj3kb4dEroTDPFnD0FGKaGPt/nuCSyRcPTnIvDN7KgjAJPEEHpRt8ZS8g9+90xiKVAMKQllh/ fFmhtct1yXnA== X-IronPort-AV: E=McAfee;i="6000,8403,9857"; a="157317195" X-IronPort-AV: E=Sophos;i="5.79,330,1602572400"; d="scan'208";a="157317195" X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2021 20:06:53 -0800 IronPort-SDR: K1JbAuZYA7Av3Y11GvynHeeoDMRiVReW0I1fiUi7p9zirMAALrPHDHNvOPedG7BYzfjWeD9X02 hm8kthBjVf8w== X-IronPort-AV: E=Sophos;i="5.79,330,1602572400"; d="scan'208";a="463274984" X-Received: from svenur-desk1.amr.corp.intel.com ([10.9.69.84]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2021 20:06:53 -0800 From: "Sumana Venur" To: devel@edk2.groups.io Cc: Sumana Venur Subject: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow Date: Thu, 7 Jan 2021 20:05:43 -0800 Message-Id: <20210108040543.11140-1-sumana.venur@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sumana.venur@intel.com X-Gm-Message-State: PiLtTPdR3fkxnnKCj00aEv8Cx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1610078815; bh=aYkSFDRT2fcKDdBCDaBCDR03SJ2Pw8VUys5AkeCsxjw=; h=Cc:Date:From:Reply-To:Subject:To; b=Ote7MuhPiDsfSB419sffNLfpA9WqfU0+3saDeQk+GfO8zi1s3wPP5AK55GAKWAaERzx 0c/ZcAqgmEJLUKCELZL4lp0OJLZfchZpKHB4BJ1sJpYDpJUX5Z4XCGzofdjQOSYTTtPmf e9vkoxQgqFqEih92yuR8QRp+h8ErMwHyiic= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2989 Long times spent on shadowing oprom from graphics card to system memory. We= are currently using 8 bit read cycles. This needs to be wider, at least 32bit reads to reduce the time for oprom s= hadow Signed-off-by: Sumana Venur Reviewed-by: Ray Ni --- MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c b/MdeModu= lePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c index c994ed5fe3..a981f93f43 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c @@ -521,9 +521,9 @@ LoadOpRomImage ( // PciDevice->PciRootBridgeIo->Mem.Read ( PciDevice->PciRootBridgeIo, - EfiPciWidthUint8, + EfiPciWidthUint32, RomBar, - (UINT32) RomImageSize, + (UINT32) RomImageSize/sizeof(UINT32), Image ); RomInMemory =3D Image; --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70012): https://edk2.groups.io/g/devel/message/70012 Mute This Topic: https://groups.io/mt/79498239/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-