[edk2-devel] [PATCH] WhiskeylakeOpenBoardPkg: Disable resizable bar feature

Heng Luo posted 1 patch 3 months, 4 weeks ago
Failed in applying to current master (apply log)
Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc        | 3 ++-
Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)

[edk2-devel] [PATCH] WhiskeylakeOpenBoardPkg: Disable resizable bar feature

Posted by Heng Luo 3 months, 4 weeks ago
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3158

add:
gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE
in dsc file:

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Heng Luo <heng.luo@intel.com>
---
 Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc        | 3 ++-
 Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc
index 84d4ec1331..316a2a94e9 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc
@@ -1,7 +1,7 @@
 ## @file
 #  PCD configuration build description file for the UpXtreme board.
 #
-# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR>
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -181,6 +181,7 @@
 !endif
 
   gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE
+  gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE
   gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserFieldTextColor|0x01
   gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserSubtitleTextColor|0x0
   gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x00000800
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPcd.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPcd.dsc
index 4a7ba4d5f0..7b710109f0 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPcd.dsc
@@ -1,7 +1,7 @@
 ## @file
 #  PCD configuration build description file for the WhiskeylakeURvp board.
 #
-# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.<BR>
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -181,6 +181,7 @@
 !endif
 
   gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE
+  gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE
   gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserFieldTextColor|0x01
   gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserSubtitleTextColor|0x0
   gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x00000800
-- 
2.24.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69901): https://edk2.groups.io/g/devel/message/69901
Mute This Topic: https://groups.io/mt/79493970/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH] WhiskeylakeOpenBoardPkg: Disable resizable bar feature

Posted by Nate DeSimone 3 months, 4 weeks ago
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng
> Luo
> Sent: Wednesday, January 6, 2021 10:18 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [edk2-devel] [PATCH] WhiskeylakeOpenBoardPkg: Disable resizable
> bar feature
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3158
> 
> add:
> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE
> in dsc file:
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Heng Luo <heng.luo@intel.com>
> ---
> 
> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.ds
> c        | 3 ++-
> 
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk
> gPcd.dsc | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.
> dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.
> dsc
> index 84d4ec1331..316a2a94e9 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.
> dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.
> ds
> +++ c
> @@ -1,7 +1,7 @@
>  ## @file #  PCD configuration build description file for the UpXtreme board.
> #-# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>+#
> Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR> # #
> SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -181,6 +181,7 @@
>  !endif    gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE+
> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE
> gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserFieldTextColor|0x01
> gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserSubtitleTextColor|0x0
> gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x00000800diff --
> git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> PkgPcd.dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> PkgPcd.dsc
> index 4a7ba4d5f0..7b710109f0 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> PkgPcd.dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> Pk
> +++ gPcd.dsc
> @@ -1,7 +1,7 @@
>  ## @file #  PCD configuration build description file for the WhiskeylakeURvp
> board. #-# Copyright (c) 2019 - 2020, Intel Corporation. All rights
> reserved.<BR>+# Copyright (c) 2019 - 2021, Intel Corporation. All rights
> reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -
> 181,6 +181,7 @@
>  !endif    gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE+
> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE
> gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserFieldTextColor|0x01
> gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserSubtitleTextColor|0x0
> gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x00000800--
> 2.24.0.windows.2
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#69901): https://edk2.groups.io/g/devel/message/69901
> Mute This Topic: https://groups.io/mt/79493970/1767664
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [nathaniel.l.desimone@intel.com] -=-=-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69903): https://edk2.groups.io/g/devel/message/69903
Mute This Topic: https://groups.io/mt/79493970/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH] WhiskeylakeOpenBoardPkg: Disable resizable bar feature

Posted by Heng Luo 3 months, 3 weeks ago
https://github.com/tianocore/edk2/commit/ef23012e5439f14864630630d2e218aeab7df501 had been merged, abandon this patch.

> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Thursday, January 7, 2021 3:19 PM
> To: devel@edk2.groups.io; Luo, Heng <heng.luo@intel.com>
> Cc: Chiu, Chasel <chasel.chiu@intel.com>
> Subject: RE: [edk2-devel] [PATCH] WhiskeylakeOpenBoardPkg: Disable
> resizable bar feature
> 
> Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng
> > Luo
> > Sent: Wednesday, January 6, 2021 10:18 PM
> > To: devel@edk2.groups.io
> > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>
> > Subject: [edk2-devel] [PATCH] WhiskeylakeOpenBoardPkg: Disable
> > resizable bar feature
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3158
> >
> > add:
> > gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE
> > in dsc file:
> >
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Signed-off-by: Heng Luo <heng.luo@intel.com>
> > ---
> >
> > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.ds
> > c        | 3 ++-
> >
> > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk
> > gPcd.dsc | 3 ++-
> >  2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.
> > dsc
> > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.
> > dsc
> > index 84d4ec1331..316a2a94e9 100644
> > ---
> > a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.
> > dsc
> > +++
> > b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.
> > ds
> > +++ c
> > @@ -1,7 +1,7 @@
> >  ## @file #  PCD configuration build description file for the UpXtreme
> board.
> > #-# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>+#
> > Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR>
> > # #
> > SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -181,6 +181,7 @@
> >  !endif    gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE+
> > gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE
> > gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserFieldTextColor|0x01
> > gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserSubtitleTextColor|0x0
> > gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x00000800diff -
> -
> > git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> > PkgPcd.dsc
> > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> > PkgPcd.dsc
> > index 4a7ba4d5f0..7b710109f0 100644
> > ---
> > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> > PkgPcd.dsc
> > +++
> > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> > Pk
> > +++ gPcd.dsc
> > @@ -1,7 +1,7 @@
> >  ## @file #  PCD configuration build description file for the
> > WhiskeylakeURvp board. #-# Copyright (c) 2019 - 2020, Intel
> > Corporation. All rights reserved.<BR>+# Copyright (c) 2019 - 2021,
> > Intel Corporation. All rights reserved.<BR> # #
> > SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -
> > 181,6 +181,7 @@
> >  !endif    gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE+
> > gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE
> > gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserFieldTextColor|0x01
> > gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserSubtitleTextColor|0x0
> > gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x00000800--
> > 2.24.0.windows.2
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#69901):
> > https://edk2.groups.io/g/devel/message/69901
> > Mute This Topic: https://groups.io/mt/79493970/1767664
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > [nathaniel.l.desimone@intel.com] -=-=-=-=-=-=
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70270): https://edk2.groups.io/g/devel/message/70270
Mute This Topic: https://groups.io/mt/79493970/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH] WhiskeylakeOpenBoardPkg: Disable resizable bar feature

Posted by Chiu, Chasel 3 months, 4 weeks ago
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heng Luo
> Sent: Thursday, January 7, 2021 2:18 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [edk2-devel] [PATCH] WhiskeylakeOpenBoardPkg: Disable resizable bar
> feature
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3158
> 
> add:
> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE
> in dsc file:
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Heng Luo <heng.luo@intel.com>
> ---
>  Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc
> | 3 ++-
> 
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPc
> d.dsc | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc
> index 84d4ec1331..316a2a94e9 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.ds
> +++ c
> @@ -1,7 +1,7 @@
>  ## @file #  PCD configuration build description file for the UpXtreme board. #-#
> Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>+# Copyright (c)
> 2020 - 2021, Intel Corporation. All rights reserved.<BR> # # SPDX-License-
> Identifier: BSD-2-Clause-Patent #@@ -181,6 +181,7 @@
>  !endif    gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE+
> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE
> gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserFieldTextColor|0x01
> gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserSubtitleTextColor|0x0
> gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x00000800diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg
> Pcd.dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg
> Pcd.dsc
> index 4a7ba4d5f0..7b710109f0 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg
> Pcd.dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk
> +++ gPcd.dsc
> @@ -1,7 +1,7 @@
>  ## @file #  PCD configuration build description file for the WhiskeylakeURvp
> board. #-# Copyright (c) 2019 - 2020, Intel Corporation. All rights
> reserved.<BR>+# Copyright (c) 2019 - 2021, Intel Corporation. All rights
> reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -181,6
> +181,7 @@
>  !endif    gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE+
> gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|FALSE
> gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserFieldTextColor|0x01
> gEfiMdeModulePkgTokenSpaceGuid.PcdBrowserSubtitleTextColor|0x0
> gEfiMdeModulePkgTokenSpaceGuid.PcdHwErrStorageSize|0x00000800--
> 2.24.0.windows.2
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#69901): https://edk2.groups.io/g/devel/message/69901
> Mute This Topic: https://groups.io/mt/79493970/1777047
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com] -=-
> =-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69902): https://edk2.groups.io/g/devel/message/69902
Mute This Topic: https://groups.io/mt/79493970/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-