From nobody Sat Apr 20 05:34:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69880+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69880+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1609977297; cv=none; d=zohomail.com; s=zohoarc; b=Txgn+56c+5bfvahbLT9tAB9vn6wI/SIYsmb4FOBzEsRRs9tbFrXjxdSEkFCPqE/sL9wb0B2MPrl3I3H6wgp5PtCVGstKVkRNDRyQdpSiHojwTPMg6C3DPkyWA1JXmu6gFsarXtVCoQQmutsJAMc7py3eU7AlVnI+ycU3/hCIG/w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609977297; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=u3TwM7YvperyLgPMghqME4rWcJMV+iDOSOjbC3OF6xA=; b=OwCEGoCwQqBuHkQTacEB+f3vJPl19xx87OVXv/Tr2dsqHYLG31RcpXpo+HqTrP5bLlg3qPUTjQdWJqr4VJn41siulB6HvPj7BUW2OGGba0CmFUseLHg1oyJVhXXqkqIb3T1lXcCnleMF9IokyARLdxPVYt6NMMqdLeQNBycdU9k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69880+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1609977297191356.36655600523864; Wed, 6 Jan 2021 15:54:57 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id FHxgYY1788612xhBfzzC0iKK; Wed, 06 Jan 2021 15:54:55 -0800 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.1249.1609977209959864157 for ; Wed, 06 Jan 2021 15:53:30 -0800 IronPort-SDR: 3jbOWsJHF2iQtSSBTRtsPcNFtGaQyyvvU1j1irjLUzZbg5WMroNaURpEoxmQe6VXp0wNR5pvox QKKMGMTrKxIA== X-IronPort-AV: E=McAfee;i="6000,8403,9856"; a="176572522" X-IronPort-AV: E=Sophos;i="5.79,328,1602572400"; d="scan'208";a="176572522" X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2021 15:53:29 -0800 IronPort-SDR: jjE1p35mmy7VoP4CSJmHNfHdKd8liEYr+BXQnz0hOADbiUUGXH4POcqxkWIl5dpeDfszSjZhhq uBcGuGcNlBrg== X-IronPort-AV: E=Sophos;i="5.79,328,1602572400"; d="scan'208";a="422359436" X-Received: from gdong1-mobl.amr.corp.intel.com ([10.212.83.15]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2021 15:53:28 -0800 From: "Guo Dong" To: devel@edk2.groups.io Cc: eric.dong@intel.com, ray.ni@intel.com, lersek@redhat.com, rahul1.kumar@intel.com Subject: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Fix a hang in above 4GB case Date: Wed, 6 Jan 2021 16:53:23 -0700 Message-Id: <20210106235323.16164-1-guo.dong@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guo.dong@intel.com X-Gm-Message-State: 1bIqtmIgjs68oKqahxtMEEBmx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1609977295; bh=XJlEhV6Y0JpLpLMcx3CqiKrz6uHntMBjhC+AcqlBEaA=; h=Cc:Date:From:Reply-To:Subject:To; b=dgrSk2YEX/1DBuadowaHpVjJE3zEx/9NZ9BIMqDT2Saesej8Fj/Dv7bNcbqGvrJpFDx KxrAAoY1Huo33bkyb2DEpPdjZs04C8+0TV/nysoLVgy0ZQI2afntDwdsxz9Ib2yE8QwDe j+tPVFADudWPFkKrEm6UN1vYAZPJaZq8Msw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This patch fixed the hang in UEFICpuPkg when it is dispatched above 4GB. In UEFI BIOS case CpuInfoInHob is provided to DXE under 4GB from PEI. When using UEFI payload and bootloaders, CpuInfoInHob will be allocated above 4GB since it is not provided from bootloader. so we need update the code to make sure this hob could be accessed correctly in this case. Signed-off-by: Guo Dong Reviewed-by: Laszlo Ersek Reviewed-by: Ray Ni --- UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm b/UefiCpuPkg/Lib= rary/MpInitLib/X64/MpFuncs.nasm index 5532a1d391..aecfd07bc0 100644 --- a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm +++ b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm @@ -303,17 +303,17 @@ GetProcessorNumber: ; xor ebx, ebx lea eax, [esi + CpuInfoLocation] - mov edi, [eax] + mov rdi, [eax] =20 GetNextProcNumber: - cmp dword [edi], edx ; APIC ID match? + cmp dword [rdi], edx ; APIC ID match? jz ProgramStack - add edi, 20 + add rdi, 20 inc ebx jmp GetNextProcNumber =20 ProgramStack: - mov rsp, qword [edi + 12] + mov rsp, qword [rdi + 12] =20 CProcedureInvoke: push rbp ; Push BIST data at top of AP stack --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69880): https://edk2.groups.io/g/devel/message/69880 Mute This Topic: https://groups.io/mt/79488123/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-