From nobody Tue Feb 10 03:40:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69611+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69611+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1609781887; cv=none; d=zohomail.com; s=zohoarc; b=gb3v69ijSDiJKyXreCoDSAylAQ5cfy0uim2BUGWR95RrLVtqIDCe7Ds4BVGAmNXg76W6cqlWQrMnED1Krs4pTuwghh9j/Nzew0Tjgyt6tvss1Iyvbt6vNql5xkMuv6IPL1EjHdivfxSSWVPw6hHRNX7jIFgAtiRcuOL5P3P5DKk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609781887; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Iy41h1Zy9gkwmF5ltKsRs2nx69V92EqAmM9ZYVgZK2E=; b=IsTc+i5kCTsVk1/rttvZ1i6Zp0bA9wfw95WkvVuIIclA4TxwspTyNcexlAzpS1SAR+GFwWcRBk6cwm6t9DpYIy3Oum0+SGVcdmqcNhWMEN+ySjgAeqlaHYCHaJj1gfuFz+hO071LKaj7xtcVXKKo5bLrhD8tkn8AwL4t7BbeHU8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69611+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1609781887101743.9669659564596; Mon, 4 Jan 2021 09:38:07 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id TDpzYY1788612xtdefHMbFtk; Mon, 04 Jan 2021 09:38:06 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.17290.1609781877318043635 for ; Mon, 04 Jan 2021 09:37:57 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F8CE12FC; Mon, 4 Jan 2021 09:37:57 -0800 (PST) X-Received: from mammon-tx2.austin.arm.com (mammon-tx2.austin.arm.com [10.118.28.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id F41A83F66E; Mon, 4 Jan 2021 09:37:56 -0800 (PST) From: "Jeremy Linton" To: devel@edk2.groups.io Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, pete@akeo.ie, samer.el-haj-mahmoud@arm.com, Jeremy Linton , Andrei Warkentin Subject: [edk2-devel] [PATCH v3 7/7] Platform/RaspberryPi: Correct device path removal. Date: Mon, 4 Jan 2021 11:37:31 -0600 Message-Id: <20210104173731.1413044-8-jeremy.linton@arm.com> In-Reply-To: <20210104173731.1413044-1-jeremy.linton@arm.com> References: <20210104173731.1413044-1-jeremy.linton@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jeremy.linton@arm.com X-Gm-Message-State: 2okDzW6BjncxOJshPm4qcES3x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1609781886; bh=6fL67PzLm7z22ePCqAVJE18a7Tc0MJ4SysLJp5CEydc=; h=Cc:Date:From:Reply-To:Subject:To; b=IHithoHCvcv0jL1BX4uL5b0z5IuXWgSFFJAARAeVzBlyzzoilDroNCwB5e6flSztu1k FMHo1NVW9ZadNyTGqs9V0DL2hhpvzPkk1XdUoRTY2PQLvBRHIFTBSww0JE/iCUnTa9lGd AqGxZyyq1RRF8MuNm9WecmlzB7+3z/e4mDA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The "arasan" driver now works with the emmc2 device. This means that both the PcdSdIsArasan and the !PcdSdIsArasan result in valid SD controllers on the rpi4. Lets avoid removing the "stale" boot entry, in this case which also has the side effect of avoiding a boot assert when emmc2 is selected. Signed-off-by: Jeremy Linton Reviewed-by: Andrei Warkentin --- Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm= .c b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c index fa46be7917..c2fc40b8ea 100644 --- a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c +++ b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c @@ -431,7 +431,7 @@ RemoveStaleBootOptions ( EFI_DEVICE_PATH_PROTOCOL *DevicePath =3D BootOptions[Index].FilePath; =20 if (CompareMem (&mArasan, DevicePath, GetDevicePathSize (DevicePath)) = =3D=3D 0) { - if (PcdGet32 (PcdSdIsArasan)) { + if (PcdGet32 (PcdSdIsArasan) || RPI_MODEL =3D=3D 4) { continue; } } else if (CompareMem (&mSDHost, DevicePath, GetDevicePathSize (Device= Path)) =3D=3D 0) { --=20 2.13.7 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69611): https://edk2.groups.io/g/devel/message/69611 Mute This Topic: https://groups.io/mt/79429635/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-