[edk2-devel] [PATCH 0/8] ShellPkg, ArmVirtPkg, OvmfPkg: shell usability improvements

Laszlo Ersek posted 8 patches 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20210104154235.31785-1-lersek@redhat.com
ArmVirtPkg/ArmVirt.dsc.inc                                                 |   2 +-
ArmVirtPkg/ArmVirtQemu.dsc                                                 |   1 +
ArmVirtPkg/ArmVirtQemuKernel.dsc                                           |   1 +
OvmfPkg/AmdSev/AmdSevX64.dsc                                               |   1 +
OvmfPkg/Bhyve/BhyveX64.dsc                                                 |   1 +
OvmfPkg/OvmfPkgIa32.dsc                                                    |   3 +
OvmfPkg/OvmfPkgIa32X64.dsc                                                 |   3 +
OvmfPkg/OvmfPkgX64.dsc                                                     |   3 +
OvmfPkg/OvmfXen.dsc                                                        |   1 +
ShellPkg/Application/Shell/ShellProtocol.c                                 |  16 +
ShellPkg/Include/Library/ShellCommandLib.h                                 |  81 +++++
ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c                 | 312 ++++++++++++++++++++
ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.h                 |  19 ++
ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf               |   1 +
ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c                         | 127 +++++++-
ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf |   1 +
ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c                           |  14 +
ShellPkg/ShellPkg.dsc                                                      |   1 +
18 files changed, 584 insertions(+), 4 deletions(-)

[edk2-devel] [PATCH 0/8] ShellPkg, ArmVirtPkg, OvmfPkg: shell usability improvements

Posted by Laszlo Ersek 4 months ago
Repo:   https://pagure.io/lersek/edk2.git
Branch: shell_usability_improvements

This series addresses various usability shortcomings that I've recently
run into, while working with large directory trees on FAT and/or
virtio-fs in the UEFI shell.

* add file buffering to the COMP command
  https://bugzilla.tianocore.org/show_bug.cgi?id=3123

* ArmVirtPkg, OvmfPkg: set PcdShellFileOperationSize to 0x20000
  https://bugzilla.tianocore.org/show_bug.cgi?id=3125

* Shell: pathname / filename sorting
  https://bugzilla.tianocore.org/show_bug.cgi?id=3151

* ArmVirtPkg, OvmfPkg: disable list length checks in NOOPT and DEBUG
  builds
  https://bugzilla.tianocore.org/show_bug.cgi?id=3152

Beyond testing the series locally, I've also heavily subjected it to
local CI runs, including ECC (relevant for ShellPkg).

Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Julien Grall <julien@xen.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Peter Grehan <grehan@freebsd.org>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>

Thanks
Laszlo

Laszlo Ersek (8):
  ShellPkg/Comp: add file buffering
  OvmfPkg: raise PcdShellFileOperationSize to 128KB
  ArmVirtPkg: raise PcdShellFileOperationSize to 128KB
  ShellPkg/ShellCommandLib: add ShellSortFileList()
  ShellPkg/Ls: sort output by FileName in non-SFO mode
  ShellPkg/ShellProtocol: sort files by FullName in
    RemoveDupInFileList()
  OvmfPkg: disable list length checks in NOOPT and DEBUG builds
  ArmVirtPkg: disable list length checks in NOOPT and DEBUG builds

 ArmVirtPkg/ArmVirt.dsc.inc                                                 |   2 +-
 ArmVirtPkg/ArmVirtQemu.dsc                                                 |   1 +
 ArmVirtPkg/ArmVirtQemuKernel.dsc                                           |   1 +
 OvmfPkg/AmdSev/AmdSevX64.dsc                                               |   1 +
 OvmfPkg/Bhyve/BhyveX64.dsc                                                 |   1 +
 OvmfPkg/OvmfPkgIa32.dsc                                                    |   3 +
 OvmfPkg/OvmfPkgIa32X64.dsc                                                 |   3 +
 OvmfPkg/OvmfPkgX64.dsc                                                     |   3 +
 OvmfPkg/OvmfXen.dsc                                                        |   1 +
 ShellPkg/Application/Shell/ShellProtocol.c                                 |  16 +
 ShellPkg/Include/Library/ShellCommandLib.h                                 |  81 +++++
 ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c                 | 312 ++++++++++++++++++++
 ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.h                 |  19 ++
 ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf               |   1 +
 ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c                         | 127 +++++++-
 ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf |   1 +
 ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c                           |  14 +
 ShellPkg/ShellPkg.dsc                                                      |   1 +
 18 files changed, 584 insertions(+), 4 deletions(-)


base-commit: 0785c619a58a450091d2bf6755591012533b80b8
-- 
2.19.1.3.g30247aa5d201



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69590): https://edk2.groups.io/g/devel/message/69590
Mute This Topic: https://groups.io/mt/79426449/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 0/8] ShellPkg, ArmVirtPkg, OvmfPkg: shell usability improvements

Posted by Laszlo Ersek 4 months ago
Zhichao, Ray,

can you please start reviewing the ShellPkg patches in this series? (#1,
#4, #5, #6.)

Thanks,
Laszlo

On 01/04/21 16:42, Laszlo Ersek wrote:
> Repo:   https://pagure.io/lersek/edk2.git
> Branch: shell_usability_improvements
> 
> This series addresses various usability shortcomings that I've recently
> run into, while working with large directory trees on FAT and/or
> virtio-fs in the UEFI shell.
> 
> * add file buffering to the COMP command
>   https://bugzilla.tianocore.org/show_bug.cgi?id=3123
> 
> * ArmVirtPkg, OvmfPkg: set PcdShellFileOperationSize to 0x20000
>   https://bugzilla.tianocore.org/show_bug.cgi?id=3125
> 
> * Shell: pathname / filename sorting
>   https://bugzilla.tianocore.org/show_bug.cgi?id=3151
> 
> * ArmVirtPkg, OvmfPkg: disable list length checks in NOOPT and DEBUG
>   builds
>   https://bugzilla.tianocore.org/show_bug.cgi?id=3152
> 
> Beyond testing the series locally, I've also heavily subjected it to
> local CI runs, including ECC (relevant for ShellPkg).
> 
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Peter Grehan <grehan@freebsd.org>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (8):
>   ShellPkg/Comp: add file buffering
>   OvmfPkg: raise PcdShellFileOperationSize to 128KB
>   ArmVirtPkg: raise PcdShellFileOperationSize to 128KB
>   ShellPkg/ShellCommandLib: add ShellSortFileList()
>   ShellPkg/Ls: sort output by FileName in non-SFO mode
>   ShellPkg/ShellProtocol: sort files by FullName in
>     RemoveDupInFileList()
>   OvmfPkg: disable list length checks in NOOPT and DEBUG builds
>   ArmVirtPkg: disable list length checks in NOOPT and DEBUG builds
> 
>  ArmVirtPkg/ArmVirt.dsc.inc                                                 |   2 +-
>  ArmVirtPkg/ArmVirtQemu.dsc                                                 |   1 +
>  ArmVirtPkg/ArmVirtQemuKernel.dsc                                           |   1 +
>  OvmfPkg/AmdSev/AmdSevX64.dsc                                               |   1 +
>  OvmfPkg/Bhyve/BhyveX64.dsc                                                 |   1 +
>  OvmfPkg/OvmfPkgIa32.dsc                                                    |   3 +
>  OvmfPkg/OvmfPkgIa32X64.dsc                                                 |   3 +
>  OvmfPkg/OvmfPkgX64.dsc                                                     |   3 +
>  OvmfPkg/OvmfXen.dsc                                                        |   1 +
>  ShellPkg/Application/Shell/ShellProtocol.c                                 |  16 +
>  ShellPkg/Include/Library/ShellCommandLib.h                                 |  81 +++++
>  ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c                 | 312 ++++++++++++++++++++
>  ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.h                 |  19 ++
>  ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf               |   1 +
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c                         | 127 +++++++-
>  ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf |   1 +
>  ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c                           |  14 +
>  ShellPkg/ShellPkg.dsc                                                      |   1 +
>  18 files changed, 584 insertions(+), 4 deletions(-)
> 
> 
> base-commit: 0785c619a58a450091d2bf6755591012533b80b8
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70034): https://edk2.groups.io/g/devel/message/70034
Mute This Topic: https://groups.io/mt/79426449/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 0/8] ShellPkg, ArmVirtPkg, OvmfPkg: shell usability improvements

Posted by Ard Biesheuvel 4 months ago
On 1/4/21 4:42 PM, Laszlo Ersek wrote:
> Repo:   https://pagure.io/lersek/edk2.git
> Branch: shell_usability_improvements
> 
> This series addresses various usability shortcomings that I've recently
> run into, while working with large directory trees on FAT and/or
> virtio-fs in the UEFI shell.
> 
> * add file buffering to the COMP command
>   https://bugzilla.tianocore.org/show_bug.cgi?id=3123
> 
> * ArmVirtPkg, OvmfPkg: set PcdShellFileOperationSize to 0x20000
>   https://bugzilla.tianocore.org/show_bug.cgi?id=3125
> 
> * Shell: pathname / filename sorting
>   https://bugzilla.tianocore.org/show_bug.cgi?id=3151
> 
> * ArmVirtPkg, OvmfPkg: disable list length checks in NOOPT and DEBUG
>   builds
>   https://bugzilla.tianocore.org/show_bug.cgi?id=3152
> 
> Beyond testing the series locally, I've also heavily subjected it to
> local CI runs, including ECC (relevant for ShellPkg).
> 
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Peter Grehan <grehan@freebsd.org>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (8):
>   ShellPkg/Comp: add file buffering
>   OvmfPkg: raise PcdShellFileOperationSize to 128KB
>   ArmVirtPkg: raise PcdShellFileOperationSize to 128KB
>   ShellPkg/ShellCommandLib: add ShellSortFileList()
>   ShellPkg/Ls: sort output by FileName in non-SFO mode
>   ShellPkg/ShellProtocol: sort files by FullName in
>     RemoveDupInFileList()
>   OvmfPkg: disable list length checks in NOOPT and DEBUG builds
>   ArmVirtPkg: disable list length checks in NOOPT and DEBUG builds
> 

Where needed,

Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

-- 
Ard.

>  ArmVirtPkg/ArmVirt.dsc.inc                                                 |   2 +-
>  ArmVirtPkg/ArmVirtQemu.dsc                                                 |   1 +
>  ArmVirtPkg/ArmVirtQemuKernel.dsc                                           |   1 +
>  OvmfPkg/AmdSev/AmdSevX64.dsc                                               |   1 +
>  OvmfPkg/Bhyve/BhyveX64.dsc                                                 |   1 +
>  OvmfPkg/OvmfPkgIa32.dsc                                                    |   3 +
>  OvmfPkg/OvmfPkgIa32X64.dsc                                                 |   3 +
>  OvmfPkg/OvmfPkgX64.dsc                                                     |   3 +
>  OvmfPkg/OvmfXen.dsc                                                        |   1 +
>  ShellPkg/Application/Shell/ShellProtocol.c                                 |  16 +
>  ShellPkg/Include/Library/ShellCommandLib.h                                 |  81 +++++
>  ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c                 | 312 ++++++++++++++++++++
>  ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.h                 |  19 ++
>  ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf               |   1 +
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Comp.c                         | 127 +++++++-
>  ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf |   1 +
>  ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c                           |  14 +
>  ShellPkg/ShellPkg.dsc                                                      |   1 +
>  18 files changed, 584 insertions(+), 4 deletions(-)
> 
> 
> base-commit: 0785c619a58a450091d2bf6755591012533b80b8
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69596): https://edk2.groups.io/g/devel/message/69596
Mute This Topic: https://groups.io/mt/79426449/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-