From nobody Thu May 2 14:53:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69482+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69482+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1609197407; cv=none; d=zohomail.com; s=zohoarc; b=XqU9NgeK1ffxafRMn01BY7nlBLlbuCWLp6Vq8LPYOjejBHJg0Mnn/K6EgNioVujZ441fwk7lXiUOT/OmWi4W1qoVXNnI/CvYoyGXhhZhsFJ5qvFCz2FT1HNv5ifR1lQ7NVsDEZwL5s+Yuqi2cdBgE2CX7vugXToVzt4FtBT73j0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609197407; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=9dK9QiDKg9AMEMxpA4+dDlsIMUh2w37fB3RldwGeX/8=; b=C87KT0Rjq+x3X3OuhBvA7an9ml5g7GOWqJfbOhU+7uwjXLHd90f+it+sSGPRE/XUUCaJftz5cpD8vyI63DGK4G1NEifPi4/hsRxcZOZgQJhf6GSSwr2dQVoiKIMpvKOnAJ889iRw/EuRKto/yEqg2I/Tcf5dwUn6jbOx5K6Mq3g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69482+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 160919740711851.19191027023214; Mon, 28 Dec 2020 15:16:47 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id TKTaYY1788612xTC952fIAaf; Mon, 28 Dec 2020 15:16:46 -0800 X-Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by mx.groups.io with SMTP id smtpd.web11.4996.1609197405437391779 for ; Mon, 28 Dec 2020 15:16:45 -0800 X-Received: by mail-il1-f170.google.com with SMTP id x15so10783080ilq.1 for ; Mon, 28 Dec 2020 15:16:45 -0800 (PST) X-Gm-Message-State: ReOdusaUhnKBSFqmeVyfDWGCx1787277AA= X-Google-Smtp-Source: ABdhPJydSK2bp0bt08MRvZB68HZnwV2AFznle1rU6x+gRiDMAzOUGPBo+RuENMC4a0NFq7My/S4HNQ== X-Received: by 2002:a05:6e02:782:: with SMTP id q2mr43861669ils.225.1609197404596; Mon, 28 Dec 2020 15:16:44 -0800 (PST) X-Received: from cube.nuviainc.com (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id k76sm30727229ilk.36.2020.12.28.15.16.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Dec 2020 15:16:44 -0800 (PST) From: "Rebecca Cran" To: devel@edk2.groups.io Cc: Rebecca Cran , Ray Ni , Zhichao Gao Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Remove bogus "Bits" text from some smbiosview strings. Date: Mon, 28 Dec 2020 16:16:37 -0700 Message-Id: <20201228231637.17266-2-rebecca@nuviainc.com> In-Reply-To: <20201228231637.17266-1-rebecca@nuviainc.com> References: <20201228231637.17266-1-rebecca@nuviainc.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@nuviainc.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1609197406; bh=GBCJlqOQ/E1bRipKNuggzWP3SHzitF2dsL6lIutCb3Q=; h=Cc:Date:From:Reply-To:Subject:To; b=j/TFeOE2Nxogi5uayrESeDKDigkItKQlUhwOmFOtJ17IsMjMdQAPutGVCEIh9RbFs2I FW4w3CB0Xcd0IqkV9NWrhfcKrfxWCFEdbsx4CVWQ2pRpZK1cRZuT7pCCRLYOsR6NN0W+6 jxZKM/slDm/bfq486oP2DLIwNSlLj1N2UO0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Neither of the "CPU Socket Unpopulated" or "Do not reboot" messages should contain the word "Bits". Remove them and update the identifier for the "Do not reboot" message to remove the word "BITS". Signed-off-by: Rebecca Cran Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Zhichao Gao --- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c = | 2 +- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.u= ni | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintIn= fo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c index be8ae13c17d1..a3dc7b68c4d3 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c @@ -3025,7 +3025,7 @@ DisplaySystemResetCapabilities ( break; =20 case 3: - ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_DO_N= OT_REBOOT_BITS), gShellDebug1HiiHandle); + ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_DO_N= OT_REBOOT), gShellDebug1HiiHandle); break; } // diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosV= iewStrings.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/Smb= iosViewStrings.uni index b14d1cb6dac8..8bcba7ccf768 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStri= ngs.uni +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStri= ngs.uni @@ -269,7 +269,7 @@ #string STR_SMBIOSVIEW_PRINTINFO_BIT15_NOT_ZERO #language = en-US "Error, reserved BIT 15 must be zero\r\n" #string STR_SMBIOSVIEW_PRINTINFO_PROC_STATUS #language = en-US "Processor Status:\r\n" #string STR_SMBIOSVIEW_PRINTINFO_CPU_SOCKET_POPULATED #language = en-US "CPU Socket Populated\r\n" -#string STR_SMBIOSVIEW_PRINTINFO_CPU_SOCKET_UNPOPULATED #language = en-US "CPU Socket Unpopulated Bits\r\n" +#string STR_SMBIOSVIEW_PRINTINFO_CPU_SOCKET_UNPOPULATED #language = en-US "CPU Socket Unpopulated\r\n" #string STR_SMBIOSVIEW_PRINTINFO_CPU_ENABLED #language = en-US "CPU Enabled\r\n" #string STR_SMBIOSVIEW_PRINTINFO_CPU_DISABLED_BY_USER #language = en-US "CPU Disabled by User via BIOS Setup\r\n" #string STR_SMBIOSVIEW_PRINTINFO_CPU_DIABLED_BY_BIOS #language = en-US "CPU Disabled By BIOS (POST Error)\r\n" @@ -333,7 +333,7 @@ #string STR_SMBIOSVIEW_PRINTINFO_BOOT_OPTION_LIMIT #language = en-US "Boot Option on Limit: " #string STR_SMBIOSVIEW_PRINTINFO_OP_SYSTEM_2 #language = en-US "Operating system\r\n" #string STR_SMBIOSVIEW_PRINTINFO_SYSTEM_UTIL #language = en-US "System utilities\r\n" -#string STR_SMBIOSVIEW_PRINTINFO_DO_NOT_REBOOT_BITS #language = en-US "Do not reboot Bits\r\n" +#string STR_SMBIOSVIEW_PRINTINFO_DO_NOT_REBOOT #language = en-US "Do not reboot\r\n" #string STR_SMBIOSVIEW_PRINTINFO_BOOT_OPTION #language = en-US "Boot Option :" #string STR_SMBIOSVIEW_PRINTINFO_DO_NOT_REBOOT #language = en-US "Do not reboot\r\n" #string STR_SMBIOSVIEW_PRINTINFO_HARDWARE_SECURITY_SET #language = en-US "Hardware Security Settings: \r\n" --=20 2.26.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69482): https://edk2.groups.io/g/devel/message/69482 Mute This Topic: https://groups.io/mt/79280527/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-