From nobody Thu May 2 08:41:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69457+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69457+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1608840267; cv=none; d=zohomail.com; s=zohoarc; b=AWIDkwdoWRui1dt60XZvBF9+0CHpsnWWEx0qxFB90/sYI4Lc8i5U68zcUi4cS496hGjHejk6oWWuqVOaxq+bUyifEmgUjsXsvzFM7zuQQkyTBcyp/UZp/gZyRYLjjTit0sF/JolQI6CkPti3bK8fbjKXyKyZVW5w+H78EgdOIPs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608840267; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=aK+2Z9BrPCfmnKkm2Kv3PSCRW+72YsHMk9WfwBEd7pE=; b=A6+LQpFrWPkUFxmZv0W8xK/XLE9xg5brEX2AEviG9r23iQmRmU6dgFdi+hNGK92w3od/atJ156pCJRCPOdqdCUAciqoeFNR1lhizAUO8wg8YEa1plsEM/MH82tI4Tg99v2c4QPXoi0dlmruTU5Yvlb6uCuMHbGYfTNnkB6DPWkc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69457+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608840267192614.3983639808202; Thu, 24 Dec 2020 12:04:27 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 7RPCYY1788612xrExS4eveCC; Thu, 24 Dec 2020 12:04:26 -0800 X-Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.2081.1608840265446455769 for ; Thu, 24 Dec 2020 12:04:25 -0800 IronPort-SDR: LdfLN9Lg53GtGImvsDqfZFuqMxbDAOR5Wiao7/8mplUu60TLicMQrPDgMa4Z00+u71mEiW1Mze NF5HgLZYioFw== X-IronPort-AV: E=McAfee;i="6000,8403,9845"; a="155965742" X-IronPort-AV: E=Sophos;i="5.78,444,1599548400"; d="scan'208";a="155965742" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Dec 2020 12:04:24 -0800 IronPort-SDR: JtSsHE090NPAxGcokW3fsxYeeQkJ70wzwv4safcOVYVJc7O9Mr7gublX1XVmmd8tYY7HITM774 EL2wJ9sBmUIw== X-IronPort-AV: E=Sophos;i="5.78,444,1599548400"; d="scan'208";a="345752249" X-Received: from gdong1-mobl.amr.corp.intel.com ([10.212.176.23]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Dec 2020 12:04:23 -0800 From: "Guo Dong" To: devel@edk2.groups.io Cc: eric.dong@intel.com, ray.ni@intel.com, lersek@redhat.com, rahul1.kumar@intel.com Subject: [edk2-devel] [PATCH] UefiCpuPkg/CpuDxe: Fix boot error Date: Thu, 24 Dec 2020 13:04:20 -0700 Message-Id: <20201224200420.15692-1-guo.dong@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guo.dong@intel.com X-Gm-Message-State: p26QfpDmWWOO0TDYaexyjmzsx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608840266; bh=xD0tBcP9ms9bsmju8WMHyhbJAMUKKXGDXRd6rv+Zk/Y=; h=Cc:Date:From:Reply-To:Subject:To; b=K7rH0oGs8IguJu40SuVH9X88+acbF746u4qCMSvzLJhOLqp+w7INfzJnlecsZ6AvgEQ te0fCk9xugOFbfZ6K/Fumi2hiE3b1juiVsW+cLFrId4xBQZZfXsjaN5ndrg3HelhLSY62 i+sMx5lalxPD34eiRhSc+quvj6EbyxFkB8Y= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3084 When DXE drivers are dispatched above 4GB memory in 64bit mode, the address setCodeSelectorLongJump in stack will be override by parameter. Jump to Qword is not supported by some processors. So use retfq instead. Signed-off-by: Guo Dong --- UefiCpuPkg/CpuDxe/X64/CpuAsm.nasm | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/CpuDxe/X64/CpuAsm.nasm b/UefiCpuPkg/CpuDxe/X64/CpuA= sm.nasm index c3489bcc3e..e33ddb2784 100644 --- a/UefiCpuPkg/CpuDxe/X64/CpuAsm.nasm +++ b/UefiCpuPkg/CpuDxe/X64/CpuAsm.nasm @@ -20,13 +20,11 @@ ;-------------------------------------------------------------------------= ----- global ASM_PFX(SetCodeSelector) ASM_PFX(SetCodeSelector): - sub rsp, 0x10 + push rcx, lea rax, [setCodeSelectorLongJump] - mov [rsp], rax - mov [rsp+4], cx - jmp dword far [rsp] + push rax + DB 0x48, 0xcb ; retfq setCodeSelectorLongJump: - add rsp, 0x10 ret =20 ;-------------------------------------------------------------------------= ----- --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69457): https://edk2.groups.io/g/devel/message/69457 Mute This Topic: https://groups.io/mt/79209121/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-