[edk2-devel] [PATCH 0/2] EmbeddedPkg/TimeBaseLib: remove useless truncation to 32-bit

Laszlo Ersek posted 2 patches 3 years, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20201221113657.6779-1-lersek@redhat.com
EmbeddedPkg/Include/Library/TimeBaseLib.h                            | 2 +-
ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 2 +-
EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c                        | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
[edk2-devel] [PATCH 0/2] EmbeddedPkg/TimeBaseLib: remove useless truncation to 32-bit
Posted by Laszlo Ersek 3 years, 3 months ago
Repo:   https://pagure.io/lersek/edk2.git
Branch: timebaselib_uintn

Through the virtio-fs driver, EmbeddedPkg/TimeBaseLib got exposed to
VS2019 for the first time. VS2019 flagged an arguably unintended,
implicit UINTN->UINT32 conversion in EfiTimeToEpoch(); let's remedy
that.

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks!
Laszlo

Laszlo Ersek (2):
  ArmPlatformPkg/PL031RealTimeClockLib: cast EfiTimeToEpoch() val. to
    UINT32
  EmbeddedPkg/TimeBaseLib: remove useless truncation to 32-bit

 EmbeddedPkg/Include/Library/TimeBaseLib.h                            | 2 +-
 ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 2 +-
 EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c                        | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

-- 
2.19.1.3.g30247aa5d201



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69313): https://edk2.groups.io/g/devel/message/69313
Mute This Topic: https://groups.io/mt/79123601/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 0/2] EmbeddedPkg/TimeBaseLib: remove useless truncation to 32-bit
Posted by Ard Biesheuvel 3 years, 3 months ago
On 12/21/20 12:36 PM, Laszlo Ersek wrote:
> Repo:   https://pagure.io/lersek/edk2.git
> Branch: timebaselib_uintn
> 
> Through the virtio-fs driver, EmbeddedPkg/TimeBaseLib got exposed to
> VS2019 for the first time. VS2019 flagged an arguably unintended,
> implicit UINTN->UINT32 conversion in EfiTimeToEpoch(); let's remedy
> that.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> 

Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>



> 
> Laszlo Ersek (2):
>   ArmPlatformPkg/PL031RealTimeClockLib: cast EfiTimeToEpoch() val. to
>     UINT32
>   EmbeddedPkg/TimeBaseLib: remove useless truncation to 32-bit
> 
>  EmbeddedPkg/Include/Library/TimeBaseLib.h                            | 2 +-
>  ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 2 +-
>  EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c                        | 6 +++---
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69319): https://edk2.groups.io/g/devel/message/69319
Mute This Topic: https://groups.io/mt/79123601/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 0/2] EmbeddedPkg/TimeBaseLib: remove useless truncation to 32-bit
Posted by Laszlo Ersek 3 years, 3 months ago
On 12/21/20 13:17, Ard Biesheuvel wrote:
> On 12/21/20 12:36 PM, Laszlo Ersek wrote:
>> Repo:   https://pagure.io/lersek/edk2.git
>> Branch: timebaselib_uintn
>>
>> Through the virtio-fs driver, EmbeddedPkg/TimeBaseLib got exposed to
>> VS2019 for the first time. VS2019 flagged an arguably unintended,
>> implicit UINTN->UINT32 conversion in EfiTimeToEpoch(); let's remedy
>> that.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>>
> 
> Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Merged as commit range 3ce3274a5ea4..c06635ea3f4b, via
<https://github.com/tianocore/edk2/pull/1254>.

Thank you!
Laszlo


>> Laszlo Ersek (2):
>>   ArmPlatformPkg/PL031RealTimeClockLib: cast EfiTimeToEpoch() val. to
>>     UINT32
>>   EmbeddedPkg/TimeBaseLib: remove useless truncation to 32-bit
>>
>>  EmbeddedPkg/Include/Library/TimeBaseLib.h                            | 2 +-
>>  ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 2 +-
>>  EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c                        | 6 +++---
>>  3 files changed, 5 insertions(+), 5 deletions(-)
>>
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69334): https://edk2.groups.io/g/devel/message/69334
Mute This Topic: https://groups.io/mt/79123601/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-