From nobody Mon May 6 07:13:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69265+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69265+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608472448; cv=none; d=zohomail.com; s=zohoarc; b=Z30Gil/HN29Y3vvNFqsQNHTZBYbOk6pgS9dwmCu7xj1kMuOIifXRuFaMeG0TszMApNy2MjEvYDKHTKWW2+p8TJAyZrZvaFdGAMxB5TCT5az4DNzwXZSpawoMY/YKUrB1GHRVWvhEWG8FWEEmVUWKh/AJPegC4UHLaYYPIESDm5s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608472448; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=YcKSUML9KK/+17X/IprL+5vEcAtGXyHZ+hWfqzpA9RE=; b=lI5ttcgq3ZYaEzI/AdoljonhtdXNyhLvQKeixVfge+syKgKszpUtijzgWE2cx1673hvQKJfNMqRJOuSbNYha4y05PMEOowNFMhUK+c33c438yznNrpDkUoFKr6mnt5JiECi9tZIps68bt9Vd0krc3o4h9XnwL5QqoZvtSMJOhtU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69265+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608472448512332.6084221299642; Sun, 20 Dec 2020 05:54:08 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id i5uUYY1788612xwbJ9hqXD8u; Sun, 20 Dec 2020 05:54:08 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.23893.1608472447423026274 for ; Sun, 20 Dec 2020 05:54:07 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 128F41042; Sun, 20 Dec 2020 05:53:57 -0800 (PST) X-Received: from U203705.Arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B7A923F66B; Sun, 20 Dec 2020 05:53:56 -0800 (PST) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Zhichao Gao , Ray Ni , Ard Biesheuvel , Pete Batard Subject: [edk2-devel] [edk2-platform][PATCH v2 1/3] MdeModulePkg/GraphicsConsoleDxe: Change default CursorVisible to FALSE Date: Sun, 20 Dec 2020 08:53:53 -0500 Message-Id: <20201220135355.12814-2-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20201220135355.12814-1-Samer.El-Haj-Mahmoud@arm.com> References: <20201220135355.12814-1-Samer.El-Haj-Mahmoud@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,samer.el-haj-mahmoud@arm.com X-Gm-Message-State: uAfMiKe07DdGkJPoSmc78CVux1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608472448; bh=OcMs/dMo4AUEE0mOSfZI7Msyfp/5hMAA0Ft0sZSSx7k=; h=Cc:Date:From:Reply-To:Subject:To; b=UzRV/Mu4Y8DxVzeHQWlzzzrZPHIGVcwqLJ8JzEgnR2Jqje72mu4s0MoYivPboYsTl4i /4nMf2azUBCK3sZEtJ8GHsDKCPQhE3QpfdnFRzuqHafwZPGqyhtpQEPP4KYz72zFI37yC 5Pmu+PFOoffCyZ95qmm3MTkX6M8ske8NIn0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://github.com/pftf/RPi4/issues/115 GraphicsConsoleDxe defaults the ConOut Mode.CursorVisible to TRUE. However, the driver never draws the cursor during init. This results in the first call to disable the cursor (using ConOut->EnableCursor(FALSE)) to actually draw the cursor on the screen, as the logic in FlushCursor depe= nds on the Mode.CursorVisible state to determine if it should draw or erase the cursor. Fix by changing the default CursorVisible in this driver to FALSE. Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Cc: Ard Biesheuvel Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud Reviewed-by: Zhichao Gao Reviewed-by: Pete Batard Tested-by: Pete Batard (On an RPi4 platform where we had=20 --- MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsCons= ole.c b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c index c042451a9b52..6b8d11d587d1 100644 --- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c +++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c @@ -33,7 +33,7 @@ GRAPHICS_CONSOLE_DEV mGraphicsConsoleDevTemplate =3D { EFI_TEXT_ATTR(EFI_LIGHTGRAY, EFI_BLACK), 0, 0, - TRUE + FALSE }, (GRAPHICS_CONSOLE_MODE_DATA *) NULL, (EFI_GRAPHICS_OUTPUT_BLT_PIXEL *) NULL --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69265): https://edk2.groups.io/g/devel/message/69265 Mute This Topic: https://groups.io/mt/79103138/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 07:13:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69266+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69266+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608472449; cv=none; d=zohomail.com; s=zohoarc; b=PvFBrCdSmTx5mfAlOOMpwbhnaipRLRO8oSziOeCzqls/tMxlmNYcUIwQkSsx8EUAzXz5BwDpaW1IffVSdECCV96HDLaCDFuIyFOIb2aQjiTRc1i40rPGz6kWxqk6oNH135xE9h25GZbdnteQ1k7dLiq2k8glesJ4WdiHj0YmSyM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608472449; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=K/o/y63cSfG/GqIjAFexNzS2+6rMAGTtiNactPT+lKY=; b=iDBt0x2lB6GZHsKT3ROqbuGPo17/EEPSU5TrMi0+9c4XZR9PZTWDJ/0ZfIeJ6bilyFzjk0ko4JmTBOx+TK/opoTOX87T0wtZ6KHyZtE0PQSGtdPR95exPaYb/TC4j5aBXreaN9lrp5yIfAEciZEQfYpwacQV6GQeLsOY6YQAZy8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69266+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608472449752772.4726503422015; Sun, 20 Dec 2020 05:54:09 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id MBLjYY1788612x25ZWFTNzjK; Sun, 20 Dec 2020 05:54:09 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.23593.1608472447806263143 for ; Sun, 20 Dec 2020 05:54:07 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 712C31063; Sun, 20 Dec 2020 05:53:57 -0800 (PST) X-Received: from U203705.Arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 20E263F66B; Sun, 20 Dec 2020 05:53:57 -0800 (PST) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Zhichao Gao , Ray Ni , Ard Biesheuvel , Pete Batard Subject: [edk2-devel] [edk2-platform][PATCH v2 2/3] MdeModulePkg/Graphics: Fix spelling mistakes Date: Sun, 20 Dec 2020 08:53:54 -0500 Message-Id: <20201220135355.12814-3-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20201220135355.12814-1-Samer.El-Haj-Mahmoud@arm.com> References: <20201220135355.12814-1-Samer.El-Haj-Mahmoud@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,samer.el-haj-mahmoud@arm.com X-Gm-Message-State: SqOIaMVKqK0IwwlKOfRyyDfbx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608472449; bh=8CrmDCdFbVmeynm93M/VDHI+qgaRHDl128JNBU1m7e0=; h=Cc:Date:From:Reply-To:Subject:To; b=kcOol4p/q+V8jVJ7AwMsWazlm6vlWGIhrDUYjPUdoI7eZSY0GTv8zaFvx/fFWjmzeIP 8LFAVM7XliL5or8GXusgqXXyZ3khiTOiO0rv8fjLGvZzE9PvOm5/qjG0cybhrwqbDNBDi tj3PgTHBMY6t1hUq+u290uDU7Ll4rnJEGh0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Fix various spelling mistakes in GraphicsConsoleDxe, ConsPlitter, and SimpleTextOut header Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Cc: Ard Biesheuvel Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud Reviewed-by: Zhichao Gao --- MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.h | 8 += -- MdePkg/Include/Protocol/SimpleTextOut.h | 6 +- MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 66 += +++++++++---------- MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c | 12 += +-- 4 files changed, 46 insertions(+), 46 deletions(-) diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsCons= ole.h b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.h index 28d47ac7cb1e..11d254b70f32 100644 --- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.h +++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.h @@ -205,7 +205,7 @@ GraphicsConsoleComponentNameGetControllerName ( Reset the text output device hardware and optionally run diagnostics. =20 Implements SIMPLE_TEXT_OUTPUT.Reset(). - If ExtendeVerification is TRUE, then perform dependent Graphics Console + If ExtendedVerification is TRUE, then perform dependent Graphics Console device reset, and set display mode to mode 0. If ExtendedVerification is FALSE, only set display mode to mode 0. =20 @@ -286,7 +286,7 @@ GraphicsConsoleConOutTestString ( supports =20 Implements SIMPLE_TEXT_OUTPUT.QueryMode(). - It returnes information for an available text mode that the Graphics Con= sole supports. + It returns information for an available text mode that the Graphics Cons= ole supports. In this driver,we only support text mode 80x25, which is defined as mode= 0. =20 @param This Protocol instance pointer. @@ -422,7 +422,7 @@ GraphicsConsoleConOutEnableCursor ( /** Test to see if Graphics Console could be supported on the Controller. =20 - Graphics Console could be supported if Graphics Output Protocol or UGA D= raw + Graphics Console could be supported if Graphics Output Protocol or UGADr= aw Protocol exists on the Controller. (UGA Draw Protocol could be skipped if PcdUgaConsumeSupport is set to FALSE.) =20 @@ -510,7 +510,7 @@ EfiLocateHiiProtocol ( =20 =20 /** - Gets Graphics Console devcie's foreground color and background color. + Gets Graphics Console device's foreground color and background color. =20 @param This Protocol instance pointer. @param Foreground Returned text foreground color. diff --git a/MdePkg/Include/Protocol/SimpleTextOut.h b/MdePkg/Include/Proto= col/SimpleTextOut.h index a849c08d66df..100d69a23a9b 100644 --- a/MdePkg/Include/Protocol/SimpleTextOut.h +++ b/MdePkg/Include/Protocol/SimpleTextOut.h @@ -32,7 +32,7 @@ typedef struct _EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL EFI_SIMPL= E_TEXT_OUTPUT_PROTOCOL; typedef EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL SIMPLE_TEXT_OUTPUT_INTERFACE; =20 // -// Define's for required EFI Unicode Box Draw characters +// Defines for required EFI Unicode Box Draw characters // #define BOXDRAW_HORIZONTAL 0x2500 #define BOXDRAW_VERTICAL 0x2502 @@ -151,7 +151,7 @@ typedef EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL SIMPLE_TEXT_O= UTPUT_INTERFACE; #define EFI_WIDE_ATTRIBUTE 0x80 =20 /** - Reset the text output device hardware and optionaly run diagnostics + Reset the text output device hardware and optionally run diagnostics =20 @param This The protocol instance pointer. @param ExtendedVerification Driver may perform more exhaustive verifica= tion @@ -373,7 +373,7 @@ typedef struct { /// INT32 CursorRow; /// - /// The cursor is currently visbile or not. + /// The cursor is currently visible or not. /// BOOLEAN CursorVisible; } EFI_SIMPLE_TEXT_OUTPUT_MODE; diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/= MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c index 9c38271b65f9..b090de288517 100644 --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c @@ -1,5 +1,5 @@ /** @file - Console Splitter Driver. Any Handle that attatched console I/O protocols + Console Splitter Driver. Any Handle that attached console I/O protocols (Console In device, Console Out device, Console Error device, Simple Poi= nter protocol, Absolute Pointer protocol) can be bound by this driver. =20 @@ -13,7 +13,7 @@ =20 Each virtual handle, that supports the Console I/O protocol, will be pro= duced in the driver entry point. The virtual handle are added on driver entry = and - never removed. Such design ensures sytem function well during none conso= le + never removed. Such design ensures system function well during none cons= ole device situation. =20 Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
@@ -381,7 +381,7 @@ ToggleStateSyncInitialization ( } =20 /** - Reinitialization for toggle state sync. + Re-initialization for toggle state sync. =20 @param Private Text In Splitter pointer. =20 @@ -594,7 +594,7 @@ ConSplitterDriverEntry( structure. =20 @retval EFI_OUT_OF_RESOURCES Out of resources. - @retval EFI_SUCCESS Text Input Devcie's private data has be= en constructed. + @retval EFI_SUCCESS Text Input Device's private data has be= en constructed. @retval other Failed to construct private data. =20 **/ @@ -761,7 +761,7 @@ ConSplitterTextOutConstructor ( } =20 // - // Initilize console output splitter's private data. + // Initialize console output splitter's private data. // ConOutPrivate->TextOut.Mode =3D &ConOutPrivate->TextOutMode; =20 @@ -860,7 +860,7 @@ ConSplitterTextOutConstructor ( @param Guid The specified protocol. =20 @retval EFI_SUCCESS The specified protocol is supported on this = device. - @retval EFI_UNSUPPORTED The specified protocol attempts to be instal= led on virtul handle. + @retval EFI_UNSUPPORTED The specified protocol attempts to be instal= led on virtual handle. @retval other Failed to open specified protocol on this de= vice. =20 **/ @@ -1108,7 +1108,7 @@ ConSplitterStart ( } =20 // - // Open InterfaceGuid on the virtul handle. + // Open InterfaceGuid on the virtual handle. // Status =3D gBS->OpenProtocol ( ControllerHandle, @@ -1174,7 +1174,7 @@ ConSplitterConInDriverBindingStart ( =20 // // Start ConSplitter on ControllerHandle, and create the virtual - // agrogated console device on first call Start for a SimpleTextIn handl= e. + // aggregated console device on first call Start for a SimpleTextIn hand= le. // Status =3D ConSplitterStart ( This, @@ -1241,7 +1241,7 @@ ConSplitterSimplePointerDriverBindingStart ( =20 // // Start ConSplitter on ControllerHandle, and create the virtual - // agrogated console device on first call Start for a SimplePointer hand= le. + // aggregated console device on first call Start for a SimplePointer han= dle. // Status =3D ConSplitterStart ( This, @@ -1287,7 +1287,7 @@ ConSplitterAbsolutePointerDriverBindingStart ( =20 // // Start ConSplitter on ControllerHandle, and create the virtual - // agrogated console device on first call Start for a AbsolutePointer ha= ndle. + // aggregated console device on first call Start for a AbsolutePointer h= andle. // Status =3D ConSplitterStart ( This, @@ -1338,7 +1338,7 @@ ConSplitterConOutDriverBindingStart ( =20 // // Start ConSplitter on ControllerHandle, and create the virtual - // agrogated console device on first call Start for a ConsoleOut handle. + // aggregated console device on first call Start for a ConsoleOut handle. // Status =3D ConSplitterStart ( This, @@ -1451,7 +1451,7 @@ ConSplitterStdErrDriverBindingStart ( =20 // // Start ConSplitter on ControllerHandle, and create the virtual - // agrogated console device on first call Start for a StandardError hand= le. + // aggregated console device on first call Start for a StandardError han= dle. // Status =3D ConSplitterStart ( This, @@ -1522,7 +1522,7 @@ ConSplitterStop ( return Status; } // - // close the protocol refered. + // close the protocol referred. // gBS->CloseProtocol ( ControllerHandle, @@ -1543,7 +1543,7 @@ ConSplitterStop ( =20 =20 /** - Stop Console In ConSplitter on ControllerHandle by closing Console In De= vcice GUID. + Stop Console In ConSplitter on ControllerHandle by closing Console In De= vice GUID. =20 @param This Driver Binding protocol instance pointer. @param ControllerHandle Handle of device to stop driver on @@ -1718,7 +1718,7 @@ ConSplitterAbsolutePointerDriverBindingStop ( =20 =20 /** - Stop Console Out ConSplitter on device handle by closing Console Out Dev= cice GUID. + Stop Console Out ConSplitter on device handle by closing Console Out Dev= cie GUID. =20 @param This Driver Binding protocol instance pointer. @param ControllerHandle Handle of device to stop driver on @@ -2725,7 +2725,7 @@ ConSplitterGetIntersectionBetweenConOutAndStrErr ( =20 =20 /** - Add Grahpics Output modes into Consplitter Text Out list. + Add Graphics Output modes into Consplitter Text Out list. =20 @param Private Text Out Splitter pointer. @param GraphicsOutput Graphics Output protocol pointer. @@ -3392,7 +3392,7 @@ ConSplitterTextOutDeleteDevice ( return EFI_SUCCESS; } // - // Max Mode is realy an intersection of the QueryMode command to all + // Max Mode is really an intersection of the QueryMode command to all // devices. So we must copy the QueryMode of the first device to // QueryData. // @@ -3430,7 +3430,7 @@ ConSplitterTextOutDeleteDevice ( =20 =20 /** - Reset the input device and optionaly run diagnostics + Reset the input device and optionally run diagnostics =20 @param This Protocol instance pointer. @param ExtendedVerification Driver may perform diagnostics on reset. @@ -3514,7 +3514,7 @@ ConSplitterTextInExDequeueKey ( =20 /** Reads the next keystroke from the input device. The WaitForKey Event can - be used to test for existance of a keystroke via WaitForEvent () call. + be used to test for existence of a keystroke via WaitForEvent () call. =20 @param Private Protocol instance pointer. @param Key Driver may perform diagnostics on reset. @@ -3587,7 +3587,7 @@ ConSplitterTextInPrivateReadKeyStroke ( =20 /** Reads the next keystroke from the input device. The WaitForKey Event can - be used to test for existance of a keystroke via WaitForEvent () call. + be used to test for existence of a keystroke via WaitForEvent () call. =20 @param This Protocol instance pointer. @param Key Driver may perform diagnostics on reset. @@ -3631,7 +3631,7 @@ ConSplitterTextInReadKeyStroke ( spliter event. This will cause the calling code to call ConSplitterTextInReadKeyStroke (). =20 - @param Event The Event assoicated with callback. + @param Event The Event associated with callback. @param Context Context registered when Event was creat= ed. =20 **/ @@ -3681,7 +3681,7 @@ ConSplitterTextInWaitForKey ( pressed. =20 @retval TRUE Key be pressed matches a registered key. - @retval FLASE Match failed. + @retval FALSE Match failed. =20 **/ BOOLEAN @@ -3715,7 +3715,7 @@ IsKeyRegistered ( =20 =20 /** - Reset the input device and optionaly run diagnostics + Reset the input device and optionally run diagnostics =20 @param This Protocol instance pointer. @param ExtendedVerification Driver may perform diagnostics on reset. @@ -3769,7 +3769,7 @@ ConSplitterTextInResetEx ( =20 /** Reads the next keystroke from the input device. The WaitForKey Event can - be used to test for existance of a keystroke via WaitForEvent () call. + be used to test for existence of a keystroke via WaitForEvent () call. =20 @param This Protocol instance pointer. @param KeyData A pointer to a buffer that is filled in= with the @@ -3978,7 +3978,7 @@ ConSplitterTextInSetState ( =20 @retval EFI_SUCCESS The notification function was registered successfully. - @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necess= sary data + @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necess= ary data structures. @retval EFI_INVALID_PARAMETER KeyData or KeyNotificationFunction or N= otifyHandle is NULL. =20 @@ -4126,7 +4126,7 @@ ConSplitterTextInUnregisterKeyNotify ( =20 =20 /** - Reset the input device and optionaly run diagnostics + Reset the input device and optionally run diagnostics =20 @param This Protocol instance pointer. @param ExtendedVerification Driver may perform diagnostics on reset. @@ -4174,7 +4174,7 @@ ConSplitterSimplePointerReset ( =20 /** Reads the next keystroke from the input device. The WaitForKey Event can - be used to test for existance of a keystroke via WaitForEvent () call. + be used to test for existence of a keystroke via WaitForEvent () call. =20 @param Private Protocol instance pointer. @param State The state information of simple pointer= device. @@ -4279,12 +4279,12 @@ ConSplitterSimplePointerGetState ( =20 =20 /** - This event agregates all the events of the ConIn devices in the spliter. + This event aggregates all the events of the ConIn devices in the spliter. If any events of physical ConIn devices are signaled, signal the ConIn spliter event. This will cause the calling code to call ConSplitterTextInReadKeyStroke (). =20 - @param Event The Event assoicated with callback. + @param Event The Event associated with callback. @param Context Context registered when Event was creat= ed. =20 **/ @@ -4493,12 +4493,12 @@ ConSplitterAbsolutePointerGetState ( =20 =20 /** - This event agregates all the events of the pointer devices in the splitt= er. + This event aggregates all the events of the pointer devices in the split= ter. If any events of physical pointer devices are signaled, signal the point= er splitter event. This will cause the calling code to call ConSplitterAbsolutePointerGetState (). =20 - @param Event The Event assoicated with callback. + @param Event The Event associated with callback. @param Context Context registered when Event was creat= ed. =20 **/ @@ -4537,10 +4537,10 @@ ConSplitterAbsolutePointerWaitForInput ( =20 =20 /** - Reset the text output device hardware and optionaly run diagnostics + Reset the text output device hardware and optionally run diagnostics =20 @param This Protocol instance pointer. - @param ExtendedVerification Driver may perform more exhaustive verf= ication + @param ExtendedVerification Driver may perform more exhaustive veri= fication operation of the device during reset. =20 @retval EFI_SUCCESS The text output device was reset. diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsCons= ole.c b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c index 6b8d11d587d1..d6d8db51d5e9 100644 --- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c +++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c @@ -214,7 +214,7 @@ Error: =20 @param[in] HorizontalResolution The size of video screen in pixels = in the X dimension. @param[in] VerticalResolution The size of video screen in pixels = in the Y dimension. - @param[in] GopModeNumber The graphics mode number which grap= his console is based on. + @param[in] GopModeNumber The graphics mode number which grap= hics console is based on. @param[out] TextModeCount The total number of text modes that= graphics console supports. @param[out] TextModeData The buffer to the text modes column= and row information. Caller is responsible to free it wh= en it's non-NULL. @@ -491,7 +491,7 @@ GraphicsConsoleControllerDriverStart ( Mode =3D Private->GraphicsOutput->Mode; if (EFI_ERROR (Status) && Mode->MaxMode !=3D 0) { // - // Set default mode failed or device don't support default mode,= then get the current mode information + // If set default mode failed or device doesn't support default = mode, then get the current mode information // HorizontalResolution =3D Mode->Info->HorizontalResolution; VerticalResolution =3D Mode->Info->VerticalResolution; @@ -501,7 +501,7 @@ GraphicsConsoleControllerDriverStart ( } if (ModeNumber !=3D Private->GraphicsOutput->Mode->Mode) { // - // Current graphics mode is not set or is not set to the mode which = we has found, + // Current graphics mode is not set or is not set to the mode which = we have found, // set the new graphic mode. // Status =3D Private->GraphicsOutput->SetMode (Private->GraphicsOutput= , ModeNumber); @@ -740,7 +740,7 @@ GraphicsConsoleControllerDriverStop ( Check if the current specific mode supported the user defined resolution for the Graphics Console device based on Graphics Output Protocol. =20 - If yes, set the graphic devcice's current mode to this specific mode. + If yes, set the graphic device's current mode to this specific mode. =20 @param GraphicsOutput Graphics Output Protocol instance pointer. @param HorizontalResolution User defined horizontal resolution @@ -843,7 +843,7 @@ EfiLocateHiiProtocol ( Reset the text output device hardware and optionally run diagnostics. =20 Implements SIMPLE_TEXT_OUTPUT.Reset(). - If ExtendeVerification is TRUE, then perform dependent Graphics Console + If ExtendedVerification is TRUE, then perform dependent Graphics Console device reset, and set display mode to mode 0. If ExtendedVerification is FALSE, only set display mode to mode 0. =20 @@ -1713,7 +1713,7 @@ GraphicsConsoleConOutEnableCursor ( } =20 /** - Gets Graphics Console devcie's foreground color and background color. + Gets Graphics Console device's foreground color and background color. =20 @param This Protocol instance pointer. @param Foreground Returned text foreground color. --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69266): https://edk2.groups.io/g/devel/message/69266 Mute This Topic: https://groups.io/mt/79103139/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 07:13:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69267+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69267+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608472449; cv=none; d=zohomail.com; s=zohoarc; b=WiCcjpQVVl0tIxbtFnjWWnvC7OooeOGf/g3VNI+yvdvM17jeRvW2LmxltrzAyGBULRKj04vR2N8v6HPZ0ckzHcYqtw+eZk0Iml5u5jWY+TZ9EKNH49sFAuLCpWq6T6ByrRCzc2qj+R+zdCiMhoiN/fcngJZKe5T6TxV0VsifWX4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608472449; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=hk6mNyutt9lQPc8d/1GtIWCdOUnzvyKUeWyubHehOGg=; b=WLuX0e16v86J5zqvjckdZMO+zCAMQB3rbjNYe5yO2O9AQlqY08qYgThurDZLqq8lYcp4ZgwB5e5gmdMAI/KdHiQ1EHngQcJt3mI++lwg4tkP6mCs1+bxi+9sM0+PCs6roAmm5C9OAJ2SGqvJFdM6aNo99NWf2AW8DXFCWr1MuN0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69267+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608472449927839.1458620971661; Sun, 20 Dec 2020 05:54:09 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id yaeDYY1788612xVb7CDtw8q5; Sun, 20 Dec 2020 05:54:09 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.23699.1608472448063056197 for ; Sun, 20 Dec 2020 05:54:08 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C6A37106F; Sun, 20 Dec 2020 05:53:57 -0800 (PST) X-Received: from U203705.Arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 80D8A3F66B; Sun, 20 Dec 2020 05:53:57 -0800 (PST) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Zhichao Gao , Ray Ni , Ard Biesheuvel Subject: [edk2-devel] [edk2-platform][PATCH v2 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY Date: Sun, 20 Dec 2020 08:53:55 -0500 Message-Id: <20201220135355.12814-4-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20201220135355.12814-1-Samer.El-Haj-Mahmoud@arm.com> References: <20201220135355.12814-1-Samer.El-Haj-Mahmoud@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,samer.el-haj-mahmoud@arm.com X-Gm-Message-State: ICLMu0FY8LepnwqIvjdCMcIux1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608472449; bh=0u0BWjrQALm6h4VzwSbvqdBH1UBxGOotuiNhCjmzUNM=; h=Cc:Date:From:Reply-To:Subject:To; b=OdPhHAb00LoJwXTFZOv7Wrlbo2kLg9foHfnWMWWkRycKbuPOdkUkoYZapqFec5w/t8r mE8/fYFBPoWZD++uu4fiNV1pbuO8YPsVaUji+iIkTz7I26+eZeWVZoCl374JFD1MxtwUW JGERt6zPFAPlcPolJ9QXCBXRD0OekXvEMUM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" ConSplitter is using EFI_LIGHTGRAY foreground color for ConOut and EFI_MAGENTA for StdErr consoles. This is impacting the DebugLib output on that same serial console (e.g. DebugLibSerialPort) after gEfiStandardErrorDeviceGuid is installed on that port. The impact also extends to Linux serial console output in OVMF because it inherits the color setting from the firmware. This is inconsistent and annoying, with MAGENTA being barely legible on a black background. Let's change StdErr default color to LIGHTGRAY for consistency and readability. This results in the same color being used for all consoles sharing the same serial port (ConOut, StdErr, DebugLib, OS console). Platforms wishing to distinguish the colors of consoles can do so in their own Platform BDS initialization. Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud Reviewed-by: Pete Batard Reviewed-by: Zhichao Gao Tested-by: Pete Batard (On an RPi 4 platform where this=20 --- MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/= MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c index b090de288517..e8cd4ce120a0 100644 --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c @@ -1476,7 +1476,7 @@ ConSplitterStdErrDriverBindingStart ( // their MaxMode and QueryData should be the intersection of both. // Status =3D ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL, NULL); - ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_MAG= ENTA, EFI_BLACK)); + ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_LIG= HTGRAY, EFI_BLACK)); =20 return Status; } --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69267): https://edk2.groups.io/g/devel/message/69267 Mute This Topic: https://groups.io/mt/79103140/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-