From nobody Mon Apr 29 11:04:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69075+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69075+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1608167431; cv=none; d=zohomail.com; s=zohoarc; b=QwBhb++9jjMvhczL9myUdS8uq73XTASoStlvOIsVb367IBHbI2vIuspUKBsLoodbFwG7y8q/ZvXrY+HS2Ph66dfqN6WmQHBUk4tg+Zy+veZaS70strXUEyKY74hNDXc9Ch8YP3OGrFX4yRXHKo3v7QP3xPiklS1qYmSn9XJG92g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608167431; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=E6dGCjidKXDkhQHTR0gX25+rgJYuIaLQB3e+Tqhz5Z0=; b=R2668TJt/Ail5Nmas/EJgPxHhostW6DhuhKsrh7+x6C/Wit/mo2obK8V6TOI7m8kb0iqAtWo9ZLq98omTBKphRIBdvBUJNOvNdhVZfLBK8JXRjLbLRRxAXneJySXVHFA2LHMi4vZ8EOktYpkTg4x+1u+BWpVqQ0OyAlk8D37XVQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69075+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608167431622380.0236737205307; Wed, 16 Dec 2020 17:10:31 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id n9DvYY1788612xeVGxa716fJ; Wed, 16 Dec 2020 17:10:31 -0800 X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.1295.1608167429917414935 for ; Wed, 16 Dec 2020 17:10:30 -0800 X-Received: from localhost.localdomain ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 17 Dec 2020 09:10:24 +0800 X-WM-Sender: fengyunhua@byosoft.com.cn From: "fengyunhua" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Yuwei Chen Subject: [edk2-devel] [PATCH v2] BaseTools: Should always define PCD TOKEN value as Zero for static PCD Date: Thu, 17 Dec 2020 09:09:51 +0800 Message-Id: <20201217010951.2098-1-fengyunhua@byosoft.com.cn> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,fengyunhua@byosoft.com.cn X-Gm-Message-State: IXArYQR30Dc5miv7gn15eRYsx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608167431; bh=7+jMMV9neTDh/2/ZmviJW4G1tG83XhEk+ml6Bg6X1Z4=; h=Cc:Date:From:Reply-To:Subject:To; b=dsGsux2GyOZjT7r0Zw+OeD78BCbRAEd2uv63l1uz7iOIhoGUXuCILM+Thy6YLayx5hD 28dGKs28C87FUUyu/WHv579UTzPE7KRXspCzhClZNcmymotOn6w3HYQjs98D45RPGLkwk 7s7uRy39SKWSHudqVYJn5+XfPrqS1O9z0vo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3120 FixedAtBuild, PatchableInModule and FeatureFlag PCD don't use PCD TOKEN. Their PCD TOKEN value can always be zero. AutoGen.h will not be changed when static PCD is added or removed. Dynamic PCD add or remove will still cause dynamic PCD token value be changed. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Yunhua Feng Reviewed-by: Bob Feng Reviewed-by: Liming Gao --- BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py b/BaseTools= /Source/Python/AutoGen/PlatformAutoGen.py index c001828937..7d8e7b3c7c 100644 --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py @@ -1037,8 +1037,7 @@ class PlatformAutoGen(AutoGen): TokenNumber +=3D 1 =20 for Pcd in self.NonDynamicPcdList: - RetVal[Pcd.TokenCName, Pcd.TokenSpaceGuidCName] =3D TokenNumber - TokenNumber +=3D 1 + RetVal[Pcd.TokenCName, Pcd.TokenSpaceGuidCName] =3D 0 return RetVal =20 @cached_property --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69075): https://edk2.groups.io/g/devel/message/69075 Mute This Topic: https://groups.io/mt/79027257/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-