From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68984+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68984+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139374; cv=none; d=zohomail.com; s=zohoarc; b=bdYSpXuCdEqJJm1C9RLJwICvAEi56/mutL6v7ZeSDvEPRTH1BS/X7uoJJaDd4/cjmb9zNzJpHThmuISqRojKdl2M98cBF8xAXKsjDvlDM6X6OsNnfrRhTGgDAdbmt9R5tHjBoPVnDIF49Kgp04J1yWmOJ/dwKX6/wViH+Vv1YLA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139374; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=aLXxpxAaXwZGZQUSruwJFsUePLkF0roRqwORjfXVcNQ=; b=PK6GN4ZUnfbfgzHPHR61LHM1JLLMx1Glaz4PwBHxdlLfe8a3ZkfQLf6HOdw/ZA3O5m5jDPlcG3WlU8j+GKmq7zwsXiIxCLDd56rOT6dfU+z6zr2jcqqewkGls8k020U6TXAESX1FKt3trz0fTtxxTc6tBy2uJAhg4zHcFYZaVDo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68984+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139374508901.0533435625824; Wed, 16 Dec 2020 09:22:54 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id FDhPYY1788612xpVd0YpLSQe; Wed, 16 Dec 2020 09:22:50 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.51.1608139342473904167 for ; Wed, 16 Dec 2020 09:22:22 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 23EA9D6E; Wed, 16 Dec 2020 09:22:22 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 205443F66E; Wed, 16 Dec 2020 09:22:20 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 01/25] ArmPkg: Format header to fix Ecc crash in ArmMmuLib Date: Wed, 16 Dec 2020 17:21:36 +0000 Message-Id: <20201216172200.25846-2-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 8XA7WP4EaNC2c5OXlQS4aOrlx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139370; bh=3i/6TAaJvGyQtawdJZc/xsvqLztOkf5mjzV77tAK85I=; h=Cc:Date:From:Reply-To:Subject:To; b=CBbkxuhjAv/fq3J9VRNS/kyO686u4XBGr48u8IF61TslJCOFABQq53wRORVaofZrvhm APPhjEePQs8CrNStwlovsgX+NkEvYW79a7lMeB0u5bt/rSI2UDr+y3c42goU6RKL2hAB/ kbfgZdRXdZc7A72KHgvpAtrKTpRkcgvWn3M= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois The header of the file is not formatted properly, making the Ecc tool crash when running on the ArmPkg. The following command was run: ./BaseTools/BinWrappers/PosixLike/Ecc -c BaseTools/Source/Python/Ecc/config.ini -e BaseTools/Source/Python/Ecc/exception.xml -t ArmPkg -r ArmPkgEcc.xls Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 .../ArmMmuLib/AArch64/ArmMmuPeiLibConstructor.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuPeiLibConstructor.c b/A= rmPkg/Library/ArmMmuLib/AArch64/ArmMmuPeiLibConstructor.c index 4fc3c92fdbf5..56edaade779b 100644 --- a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuPeiLibConstructor.c +++ b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuPeiLibConstructor.c @@ -1,10 +1,10 @@ -#/* @file -# -# Copyright (c) 2016, Linaro Limited. All rights reserved. -# -# SPDX-License-Identifier: BSD-2-Clause-Patent -# -#*/ +/** @file + + Copyright (c) 2016, Linaro Limited. All rights reserved. + Copyright (c) 2020, Arm Limited. All rights reserved.
+ + SPDX-License-Identifier: BSD-2-Clause-Patent +*/ #include -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68984): https://edk2.groups.io/g/devel/message/68984 Mute This Topic: https://groups.io/mt/79006180/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68985+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68985+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139355; cv=none; d=zohomail.com; s=zohoarc; b=XRqQUnNJPbCWPkUerQuwqDSVXYlcl6e1UdkIozjZCr2IaauLMoGF45EzYYI1frsUMXlViGkUWZyWSgujx+E/R2UtcG/LFwIkKWjwIjs6QUNzD7CpMGUcQ3WlkS+EuW1DMP8eOKe4JR/crBwNUOYPfhCstRfGM+5b7UKfR7vmyKE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139355; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=NsNw0D/XORAqiqr5M1OVmKC4Y9GgEOUAzeNQIhLMVOA=; b=Nn4hkdoxsuMUayq3i/fvDMMKSC/bRCw2qFTEcsh+dHVcpJ1ptOD8+gWpNCwr31bb/j5ZQI2umU2NIDyGCK4CPYejHdAAJ+VacCY9eUXLx3hd5oVH+S5/vTALqfeHuJafTnFujMufh/ixC0sB43eWoJwiDeNwnFWOQgs5NjylkcE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68985+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 160813935572441.601702846573744; Wed, 16 Dec 2020 09:22:35 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id DJCLYY1788612xjZslSU6Qrz; Wed, 16 Dec 2020 09:22:33 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.53.1608139344043945646 for ; Wed, 16 Dec 2020 09:22:24 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AC5D01FB; Wed, 16 Dec 2020 09:22:23 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8A05C3F66E; Wed, 16 Dec 2020 09:22:22 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 02/25] ArmPkg: Fix Ecc error 3002 in CompilerIntrinsicsLib Date: Wed, 16 Dec 2020 17:21:37 +0000 Message-Id: <20201216172200.25846-3-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: A2MobeBDq7xrXiTbIA9njb5kx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139353; bh=nEsvOwPjZEMQFawfatKixgWw6Twnff2p7iCBAX4I/E0=; h=Cc:Date:From:Reply-To:Subject:To; b=JOFmrm6VVpvsFdXaOfka0ZgtT0IaT0LwJSiW+PJtUHF+KAEeRqrO6mC0q8mCXn5ykLO Zf2qjV2QB3AwVOlXHNwFrLTQm+Hk+mfYOKb1Rg11qlaMCqJ4E0a33AfNJY5v31jZ6QyOj XwBpzskCAiD1xNYEg5NLiZuB0DutVZk4kcM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D) Brackets are also added to comply to with the coding standard. Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Library/CompilerIntrinsicsLib/memcmp_ms.c | 3 ++- ArmPkg/Library/CompilerIntrinsicsLib/memcpy.c | 4 +++- ArmPkg/Library/CompilerIntrinsicsLib/memcpy_ms.c | 4 +++- ArmPkg/Library/CompilerIntrinsicsLib/memmove_ms.c | 7 +++++-- ArmPkg/Library/CompilerIntrinsicsLib/memset.c | 4 +++- ArmPkg/Library/CompilerIntrinsicsLib/memset_ms.c | 4 +++- 6 files changed, 19 insertions(+), 7 deletions(-) diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/memcmp_ms.c b/ArmPkg/Libr= ary/CompilerIntrinsicsLib/memcmp_ms.c index 551f8e77c12f..8491e2401f1e 100644 --- a/ArmPkg/Library/CompilerIntrinsicsLib/memcmp_ms.c +++ b/ArmPkg/Library/CompilerIntrinsicsLib/memcmp_ms.c @@ -1,6 +1,7 @@ //------------------------------------------------------------------------= ------ // // Copyright (c) 2019, Pete Batard. All rights reserved. +// Copyright (c) 2020, Arm Limited. All rights reserved.
// // SPDX-License-Identifier: BSD-2-Clause-Patent // @@ -20,7 +21,7 @@ int memcmp(const void *s1, const void *s2, size_t n) unsigned char const *t1 =3D s1; unsigned char const *t2 =3D s2; - while (n--) { + while (n-- !=3D 0) { if (*t1 !=3D *t2) return (int)*t1 - (int)*t2; t1++; diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/memcpy.c b/ArmPkg/Library= /CompilerIntrinsicsLib/memcpy.c index 6e9c85f4bafd..d4827531dd04 100644 --- a/ArmPkg/Library/CompilerIntrinsicsLib/memcpy.c +++ b/ArmPkg/Library/CompilerIntrinsicsLib/memcpy.c @@ -1,6 +1,7 @@ //------------------------------------------------------------------------= ------ // // Copyright (c) 2016, Linaro Ltd. All rights reserved.
+// Copyright (c) 2020, Arm Limited. All rights reserved.
// // SPDX-License-Identifier: BSD-2-Clause-Patent // @@ -13,8 +14,9 @@ static void __memcpy(void *dest, const void *src, size_t = n) unsigned char *d =3D dest; unsigned char const *s =3D src; - while (n--) + while (n-- !=3D 0) { *d++ =3D *s++; + } } void *memcpy(void *dest, const void *src, size_t n) diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/memcpy_ms.c b/ArmPkg/Libr= ary/CompilerIntrinsicsLib/memcpy_ms.c index 34feef5a4bb9..a9590df68054 100644 --- a/ArmPkg/Library/CompilerIntrinsicsLib/memcpy_ms.c +++ b/ArmPkg/Library/CompilerIntrinsicsLib/memcpy_ms.c @@ -1,6 +1,7 @@ //------------------------------------------------------------------------= ------ // // Copyright (c) 2017, Pete Batard. All rights reserved.
+// Copyright (c) 2020, Arm Limited. All rights reserved.
// // SPDX-License-Identifier: BSD-2-Clause-Patent // @@ -20,8 +21,9 @@ void* memcpy(void *dest, const void *src, size_t n) unsigned char *d =3D dest; unsigned char const *s =3D src; - while (n--) + while (n-- !=3D 0) { *d++ =3D *s++; + } return dest; } diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/memmove_ms.c b/ArmPkg/Lib= rary/CompilerIntrinsicsLib/memmove_ms.c index 5b261ef8b948..a2e1ef9c8883 100644 --- a/ArmPkg/Library/CompilerIntrinsicsLib/memmove_ms.c +++ b/ArmPkg/Library/CompilerIntrinsicsLib/memmove_ms.c @@ -1,6 +1,7 @@ //------------------------------------------------------------------------= ------ // // Copyright (c) 2019, Pete Batard. All rights reserved. +// Copyright (c) 2020, Arm Limited. All rights reserved.
// // SPDX-License-Identifier: BSD-2-Clause-Patent // @@ -21,13 +22,15 @@ void* memmove(void *dest, const void *src, size_t n) unsigned char const *s =3D src; if (d < s) { - while (n--) + while (n-- !=3D 0) { *d++ =3D *s++; + } } else { d +=3D n; s +=3D n; - while (n--) + while (n-- !=3D 0) { *--d =3D *--s; + } } return dest; diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/memset.c b/ArmPkg/Library= /CompilerIntrinsicsLib/memset.c index 24398d591f79..57fc776333b0 100644 --- a/ArmPkg/Library/CompilerIntrinsicsLib/memset.c +++ b/ArmPkg/Library/CompilerIntrinsicsLib/memset.c @@ -1,6 +1,7 @@ //------------------------------------------------------------------------= ------ // // Copyright (c) 2016, Linaro Ltd. All rights reserved.
+// Copyright (c) 2020, Arm Limited. All rights reserved.
// // SPDX-License-Identifier: BSD-2-Clause-Patent // @@ -13,8 +14,9 @@ void *__memset(void *s, int c, size_t n) { unsigned char *d =3D s; - while (n--) + while (n-- !=3D 0) { *d++ =3D c; + } return s; } diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/memset_ms.c b/ArmPkg/Libr= ary/CompilerIntrinsicsLib/memset_ms.c index 4de55d845718..463fc21d3184 100644 --- a/ArmPkg/Library/CompilerIntrinsicsLib/memset_ms.c +++ b/ArmPkg/Library/CompilerIntrinsicsLib/memset_ms.c @@ -1,6 +1,7 @@ //------------------------------------------------------------------------= ------ // // Copyright (c) 2017, Pete Batard. All rights reserved.
+// Copyright (c) 2020, Arm Limited. All rights reserved.
// // SPDX-License-Identifier: BSD-2-Clause-Patent // @@ -19,8 +20,9 @@ void *memset(void *s, int c, size_t n) { unsigned char *d =3D s; - while (n--) + while (n-- !=3D 0) { *d++ =3D (unsigned char)c; + } return s; } -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68985): https://edk2.groups.io/g/devel/message/68985 Mute This Topic: https://groups.io/mt/79006181/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68986+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68986+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139359; cv=none; d=zohomail.com; s=zohoarc; b=J4WC3Nse03kRdCyiH7WBlo5fZgZ+dK0E+yFOSmB66r1HCdC2pqMf4xegfFlVrDCY2+zi3b8/rljYWqg6qmIbTyveJz8dCNPyPtmlpJNYWEghOCGu+11myJdiOCfwnyjjTPHSj9tuy1tRjEWoe1Dm7kmWbbOIoyUE7ArhExDfKQA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139359; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=Lsj0e6P+HveipfH2qYYP/rGfri6uUcy5J4w8UBtDSBw=; b=NraK/rcPwSLYhHO0r6h85mOeNQUrQR3OfB9Ed/tSiNY9AjRD7PCWJ0+oyc9OHq171wzI7rkJMdqrhZQ4QzkWPuqzKtx78NOLKPBjIsIb9aRlJSYqRHegTZQTbK0kYSlyQbHfTNH0/K9M8Wd+O5wBcnsuXgvIb81znooTURzaovY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68986+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139359795989.0270136875956; Wed, 16 Dec 2020 09:22:39 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id kjTPYY1788612xHhol9CLvPO; Wed, 16 Dec 2020 09:22:36 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.43.1608139345570532699 for ; Wed, 16 Dec 2020 09:22:25 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3B16B1FB; Wed, 16 Dec 2020 09:22:25 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 18DFA3F66E; Wed, 16 Dec 2020 09:22:23 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 03/25] ArmPkg: Fix Ecc error 3002 in OpteeLib Date: Wed, 16 Dec 2020 17:21:38 +0000 Message-Id: <20201216172200.25846-4-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: Q8yzEKiqRoogFr8HjPb93z3wx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139356; bh=tq7uEqIAulVV00yRqSk5PYSRyBetrB66ukBwTIAUBcs=; h=Cc:Date:From:Reply-To:Subject:To; b=fwwf1Pe/klRsuCGuBDBwedO1934ZpvdWFbqM70I7SRAB70thu79/Jedry0EqpKKDP/D JKEYvZ9pEHpcVJqK9/sUR7z80/NTLrfgxK69o1KiLG4KJ0/R9RK0xIBo9uc+COxjH0R5a 2o7/VWeY+kw9N4o9PPxk6W3dihpOGPNBT5A= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D) Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Library/OpteeLib/Optee.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ArmPkg/Library/OpteeLib/Optee.c b/ArmPkg/Library/OpteeLib/Opte= e.c index 2562bc093b61..e763228e9cd3 100644 --- a/ArmPkg/Library/OpteeLib/Optee.c +++ b/ArmPkg/Library/OpteeLib/Optee.c @@ -3,6 +3,7 @@ secure monitor calls. Copyright (c) 2018, Linaro Ltd. All rights reserved.
+ Copyright (c) 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -227,7 +228,7 @@ OpteeOpenSession ( MessageArg->NumParams =3D 2; - if (OpteeCallWithArg ((UINTN)MessageArg)) { + if (OpteeCallWithArg ((UINTN)MessageArg) !=3D 0) { MessageArg->Return =3D OPTEE_ERROR_COMMUNICATION; MessageArg->ReturnOrigin =3D OPTEE_ORIGIN_COMMUNICATION; } @@ -431,7 +432,7 @@ OpteeInvokeFunction ( MessageArg->NumParams =3D OPTEE_MAX_CALL_PARAMS; - if (OpteeCallWithArg ((UINTN)MessageArg)) { + if (OpteeCallWithArg ((UINTN)MessageArg) !=3D 0) { MessageArg->Return =3D OPTEE_ERROR_COMMUNICATION; MessageArg->ReturnOrigin =3D OPTEE_ORIGIN_COMMUNICATION; } @@ -440,7 +441,7 @@ OpteeInvokeFunction ( InvokeFunctionArg->Params, OPTEE_MAX_CALL_PARAMS, MessageArg->Params - )) { + ) !=3D 0) { MessageArg->Return =3D OPTEE_ERROR_COMMUNICATION; MessageArg->ReturnOrigin =3D OPTEE_ORIGIN_COMMUNICATION; } -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68986): https://edk2.groups.io/g/devel/message/68986 Mute This Topic: https://groups.io/mt/79006182/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68987+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68987+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139369; cv=none; d=zohomail.com; s=zohoarc; b=F3ofkY7G3H/PGwBsFDsm+Rgxz8ShN3X15+x8D4HWJR9sLpmYE6/BodQi1VbnlDklbkbefim34nq4HyHiS1AlOr324lwpvp59jY8yRLmU6LQ0u6UOcN10+0qgaQUTv/rdkI1idqydIYcryB5tcjXbofbzGERGzeQnlpYI2MLjR2Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139369; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=1+FJktkGwz+i3gwhw9KmNiNJ7d7rOdhLEO2phjzEtj0=; b=PqXXNhfc/iQRjiMCzms7jNcCWdyV/aGuSU1tjvyLSZ+ADjSKN55l0csXjPYmSzP5n04DJJ+NznjKKSeSKhvGOYay+n+8RUY89cDEtaD29pkrvJIWntMJc1TdcXts1dubhBdBIp6ZklYJ9SOTmP4CHyi2kwVtJjuu5Jk3oWzGh9Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68987+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139369544517.8944055706953; Wed, 16 Dec 2020 09:22:49 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id zBEAYY1788612xQ7xwIgAMYL; Wed, 16 Dec 2020 09:22:48 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.53.1608139347071405895 for ; Wed, 16 Dec 2020 09:22:27 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BF0541FB; Wed, 16 Dec 2020 09:22:26 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9CE5E3F66E; Wed, 16 Dec 2020 09:22:25 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 04/25] ArmPkg: Fix Ecc error 3002 in ArmMmuLib Date: Wed, 16 Dec 2020 17:21:39 +0000 Message-Id: <20201216172200.25846-5-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: nMh95SUXDNjKJoA5CNd2uFmIx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139368; bh=Nwet3cFwwr6v56hmdgAVgKRQgsQDa74jn+mIzNS/3Gs=; h=Cc:Date:From:Reply-To:Subject:To; b=tA/Eva7aK3EvU/xxYfC3PLRLO4w1fJAYWpthl/f4Oa/zb3iGx3rixmQYF4xEbWcs+/r 3awGyCWzZ3Ew0j1O7pdA60+FbMFgGWNs2NTIQ4qyY/hf+hXfkvlGYsqvmK1Da92cwvR1d heVXat8PLRxhdh6nHY9a8of/QCOyZC7p8mE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D) Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 .../Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 2 +- .../Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c | 30 +++++++++---------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c b/ArmPkg/Libr= ary/ArmMmuLib/AArch64/ArmMmuLibCore.c index 513a763e6e87..8c736d25bb80 100644 --- a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c +++ b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c @@ -294,7 +294,7 @@ UpdateRegionMapping ( { UINTN T0SZ; - if (((RegionStart | RegionLength) & EFI_PAGE_MASK)) { + if (((RegionStart | RegionLength) & EFI_PAGE_MASK) !=3D 0) { return EFI_INVALID_PARAMETER; } diff --git a/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c b/ArmPkg/Librar= y/ArmMmuLib/Arm/ArmMmuLibUpdate.c index 6f18604f799f..c7f2744c4fac 100644 --- a/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c +++ b/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c @@ -1,7 +1,7 @@ /** @file * File managing the MMU for ARMv7 architecture * -* Copyright (c) 2011-2016, ARM Limited. All rights reserved. +* Copyright (c) 2011-2020, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -105,7 +105,7 @@ UpdatePageEntries ( // EntryMask: bitmask of values to change (1 =3D change this value, 0 = =3D leave alone) // EntryValue: values at bit positions specified by EntryMask EntryMask =3D TT_DESCRIPTOR_PAGE_TYPE_MASK | TT_DESCRIPTOR_PAGE_AP_MASK; - if (Attributes & EFI_MEMORY_XP) { + if ((Attributes & EFI_MEMORY_XP) !=3D 0) { EntryValue =3D TT_DESCRIPTOR_PAGE_TYPE_PAGE_XN; } else { EntryValue =3D TT_DESCRIPTOR_PAGE_TYPE_PAGE; @@ -116,33 +116,33 @@ UpdatePageEntries ( // is irrelevant. If no memory attribute is specified, we preserve whate= ver // memory type is set in the page tables, and update the permission attr= ibutes // only. - if (Attributes & EFI_MEMORY_UC) { + if ((Attributes & EFI_MEMORY_UC) !=3D 0) { // modify cacheability attributes EntryMask |=3D TT_DESCRIPTOR_PAGE_CACHE_POLICY_MASK; // map to strongly ordered EntryValue |=3D TT_DESCRIPTOR_PAGE_CACHE_POLICY_STRONGLY_ORDERED; // T= EX[2:0] =3D 0, C=3D0, B=3D0 - } else if (Attributes & EFI_MEMORY_WC) { + } else if ((Attributes & EFI_MEMORY_WC) !=3D 0) { // modify cacheability attributes EntryMask |=3D TT_DESCRIPTOR_PAGE_CACHE_POLICY_MASK; // map to normal non-cachable EntryValue |=3D TT_DESCRIPTOR_PAGE_CACHE_POLICY_NON_CACHEABLE; // TEX = [2:0]=3D 001 =3D 0x2, B=3D0, C=3D0 - } else if (Attributes & EFI_MEMORY_WT) { + } else if ((Attributes & EFI_MEMORY_WT) !=3D 0) { // modify cacheability attributes EntryMask |=3D TT_DESCRIPTOR_PAGE_CACHE_POLICY_MASK; // write through with no-allocate EntryValue |=3D TT_DESCRIPTOR_PAGE_CACHE_POLICY_WRITE_THROUGH_NO_ALLOC= ; // TEX [2:0] =3D 0, C=3D1, B=3D0 - } else if (Attributes & EFI_MEMORY_WB) { + } else if ((Attributes & EFI_MEMORY_WB) !=3D 0) { // modify cacheability attributes EntryMask |=3D TT_DESCRIPTOR_PAGE_CACHE_POLICY_MASK; // write back (with allocate) EntryValue |=3D TT_DESCRIPTOR_PAGE_CACHE_POLICY_WRITE_BACK_ALLOC; // T= EX [2:0] =3D 001, C=3D1, B=3D1 - } else if (Attributes & CACHE_ATTRIBUTE_MASK) { + } else if ((Attributes & CACHE_ATTRIBUTE_MASK) !=3D 0) { // catch unsupported memory type attributes ASSERT (FALSE); return EFI_UNSUPPORTED; } - if (Attributes & EFI_MEMORY_RO) { + if ((Attributes & EFI_MEMORY_RO) !=3D 0) { EntryValue |=3D TT_DESCRIPTOR_PAGE_AP_RO_RO; } else { EntryValue |=3D TT_DESCRIPTOR_PAGE_AP_RW_RW; @@ -244,39 +244,39 @@ UpdateSectionEntries ( // is irrelevant. If no memory attribute is specified, we preserve whate= ver // memory type is set in the page tables, and update the permission attr= ibutes // only. - if (Attributes & EFI_MEMORY_UC) { + if ((Attributes & EFI_MEMORY_UC) !=3D 0) { // modify cacheability attributes EntryMask |=3D TT_DESCRIPTOR_SECTION_CACHE_POLICY_MASK; // map to strongly ordered EntryValue |=3D TT_DESCRIPTOR_SECTION_CACHE_POLICY_STRONGLY_ORDERED; /= / TEX[2:0] =3D 0, C=3D0, B=3D0 - } else if (Attributes & EFI_MEMORY_WC) { + } else if ((Attributes & EFI_MEMORY_WC) !=3D 0) { // modify cacheability attributes EntryMask |=3D TT_DESCRIPTOR_SECTION_CACHE_POLICY_MASK; // map to normal non-cachable EntryValue |=3D TT_DESCRIPTOR_SECTION_CACHE_POLICY_NON_CACHEABLE; // T= EX [2:0]=3D 001 =3D 0x2, B=3D0, C=3D0 - } else if (Attributes & EFI_MEMORY_WT) { + } else if ((Attributes & EFI_MEMORY_WT) !=3D 0) { // modify cacheability attributes EntryMask |=3D TT_DESCRIPTOR_SECTION_CACHE_POLICY_MASK; // write through with no-allocate EntryValue |=3D TT_DESCRIPTOR_SECTION_CACHE_POLICY_WRITE_THROUGH_NO_AL= LOC; // TEX [2:0] =3D 0, C=3D1, B=3D0 - } else if (Attributes & EFI_MEMORY_WB) { + } else if ((Attributes & EFI_MEMORY_WB) !=3D 0) { // modify cacheability attributes EntryMask |=3D TT_DESCRIPTOR_SECTION_CACHE_POLICY_MASK; // write back (with allocate) EntryValue |=3D TT_DESCRIPTOR_SECTION_CACHE_POLICY_WRITE_BACK_ALLOC; /= / TEX [2:0] =3D 001, C=3D1, B=3D1 - } else if (Attributes & CACHE_ATTRIBUTE_MASK) { + } else if ((Attributes & CACHE_ATTRIBUTE_MASK) !=3D 0) { // catch unsupported memory type attributes ASSERT (FALSE); return EFI_UNSUPPORTED; } - if (Attributes & EFI_MEMORY_RO) { + if ((Attributes & EFI_MEMORY_RO) !=3D 0) { EntryValue |=3D TT_DESCRIPTOR_SECTION_AP_RO_RO; } else { EntryValue |=3D TT_DESCRIPTOR_SECTION_AP_RW_RW; } - if (Attributes & EFI_MEMORY_XP) { + if ((Attributes & EFI_MEMORY_XP) !=3D 0) { EntryValue |=3D TT_DESCRIPTOR_SECTION_XN_MASK; } -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68987): https://edk2.groups.io/g/devel/message/68987 Mute This Topic: https://groups.io/mt/79006187/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68988+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68988+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139379; cv=none; d=zohomail.com; s=zohoarc; b=hmWSXf4iPymTqBl7fpnxSkLdkUl6t84nj0iaxrP2EH3hXr0o7v22wfIPLjnV1YgpOrouGqSuhuv8Ry/77WQDUyKDm26YlHLtnX/cYBSiea6WdTAt3eB5+J3OOeVbBg+DOU8trpLOXONJwIvm4yI9hi1T1+rIV25kXs1GDEIGC9Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139379; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=6BuERad9tsxJJUDEQKURn2raILYX1xC1N/TXOSOlkvk=; b=OYStWZAIrLAcj7gphSiASViWtmjERsgRi7G1HN/IaQpik++w7DgRQe8qZPanY6xGt0AWqC/TV6w9aXvgoBP7ZJz/AleKX/whiCF1AiSGQtc4uo4UHXY38B1dK3tpMsbQNBAdO4tLBAars+IwZaxLhm3JEmoI6L0pRS9eevHqnn8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68988+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139379783715.3996881468082; Wed, 16 Dec 2020 09:22:59 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id WkyJYY1788612xaRvffdJ8b4; Wed, 16 Dec 2020 09:22:57 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.54.1608139348751350163 for ; Wed, 16 Dec 2020 09:22:28 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6595F1FB; Wed, 16 Dec 2020 09:22:28 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1139F3F66E; Wed, 16 Dec 2020 09:22:26 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 05/25] ArmPkg: Fix Ecc error 3002 in TimerDxe Date: Wed, 16 Dec 2020 17:21:40 +0000 Message-Id: <20201216172200.25846-6-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: EovXRiVRkQS3SXKTQUv16Tstx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139377; bh=6tAZcl/KwrJEHX0dw7xv0gn0A8Ux27Mv+kEVMI+pVAk=; h=Cc:Date:From:Reply-To:Subject:To; b=MsIvjKOWDYBkSVo/WC+47N7yB6mvmhgnQCun6HDyT9W3jQ4s4LQRnuJ6KXT/Xnvgv2b WmuV5FH9Y64gPv8RxSWFHgfHQOHbSilYnyPMTLuqYUG61QqRXXzNDFJ6ilfDW3yBVc42u ksOKA36JdOJNJqozArBFvBEOofKkp9BjrT4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D) Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Drivers/TimerDxe/TimerDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Drivers/TimerDxe/TimerDxe.c b/ArmPkg/Drivers/TimerDxe/T= imerDxe.c index dccaeae23c29..69f31e880a68 100644 --- a/ArmPkg/Drivers/TimerDxe/TimerDxe.c +++ b/ArmPkg/Drivers/TimerDxe/TimerDxe.c @@ -1,7 +1,7 @@ /** @file Timer Architecture Protocol driver of the ARM flavor - Copyright (c) 2011-2013 ARM Ltd. All rights reserved.
+ Copyright (c) 2011-2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -307,7 +307,7 @@ TimerInterruptHandler ( // Check if the timer interrupt is active if ((ArmGenericTimerGetTimerCtrlReg () ) & ARM_ARCH_TIMER_ISTATUS) { - if (mTimerNotifyFunction) { + if (mTimerNotifyFunction !=3D 0) { mTimerNotifyFunction (mTimerPeriod * mElapsedPeriod); } -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68988): https://edk2.groups.io/g/devel/message/68988 Mute This Topic: https://groups.io/mt/79006190/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68989+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68989+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139383; cv=none; d=zohomail.com; s=zohoarc; b=LQT5qlprnJos2SOMZaXySiW+0fpFV/Piri/9Y5186WgGBRdnq6D4hrjzUUZJS5j+iKl2d4/3c2e52EeqoVDsecjnztYx6SiuNGZxj0AWL9chOhNtJ6Cspb4G0p/QzWyROE6h4AsZMpRIMe5THBuA9JmKv9wPXrdeWfMl8tq596g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139383; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=HowGjY+WJYmJYiar7osij1j8wiwLHs9M0Fl9/RRPo5w=; b=CTtqNUk26eRGTqQT7R+SettEnTEF5DJSBANLBfnriK+Qf9rF7rzeJRnPe4qiCW2mNTqRKI18M4WVIQWRRTle5flElFwDAc3h980zHURKCQZYh68o16T90SKfb3IcDLtqNtoK0qWpdC1MWgoaA3TVYH3MrleCJIjx6W+3IkIjE3g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68989+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139383465903.6990182508182; Wed, 16 Dec 2020 09:23:03 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id JbN2YY1788612xCLD5hEz1FM; Wed, 16 Dec 2020 09:23:01 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.58.1608139350484862001 for ; Wed, 16 Dec 2020 09:22:30 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 25F8F1FB; Wed, 16 Dec 2020 09:22:30 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C68273F66E; Wed, 16 Dec 2020 09:22:28 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 06/25] ArmPkg: Fix Ecc error 3002 in MmCommunicationDxe Date: Wed, 16 Dec 2020 17:21:41 +0000 Message-Id: <20201216172200.25846-7-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: LIzc4W5x4wbJxRAmKf1SXegEx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139381; bh=qaAvKs2BzBXclnBnf+dVfmpUzCoaydBEOQnIGdp07HQ=; h=Cc:Date:From:Reply-To:Subject:To; b=QLHcy5Lse7RTj4s3Kqm3jpU1J7/kRxi957neSX4CUgWeTTfyn9AWac3GC0ff/ZXjn2b 8nwJYQn0Irgt1Dk2IFTTvThZGQN+ggzBmZ5sbqC5bPZsslRCW+E1jO21+Rcd/T0TYX0AK rTM0IyYO0idl8CqYCnS4KJ9K8YAeSSy151Q= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D) Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c b/ArmPkg/D= rivers/MmCommunicationDxe/MmCommunication.c index 9457eaf1d809..fc3f9ffb4338 100644 --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2016-2019, ARM Limited. All rights reserved. + Copyright (c) 2016-2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -96,7 +96,7 @@ MmCommunication2Communicate ( sizeof (CommunicateHeader->MessageLength); // If the length of the CommBuffer is 0 then return the expected length. - if (CommSize) { + if (CommSize !=3D 0) { // This case can be used by the consumer of this driver to find out the // max size that can be used for allocating CommBuffer. if ((*CommSize =3D=3D 0) || -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68989): https://edk2.groups.io/g/devel/message/68989 Mute This Topic: https://groups.io/mt/79006191/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68990+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68990+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139625; cv=none; d=zohomail.com; s=zohoarc; b=Ye+fQ8zBxt98chHAbma45mpk1ZDWuOwwrdraJmvpQx34fHZzDXZQ97uEKaHLUMG5+a9apPDLs43LKnSoVMsUSygud8T2La4egXTMM9JDhJpwcaxigcB4crL49RiiXIwsP7+3YMIpZG7HBuT0QSpxOBg8ZsJpPNPSFGOyRjO1u44= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139625; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=Z+MNbrBz/xr5vdxb7yNzQvq8FoyY8rwou3Fym8dEN2I=; b=n4XR7fUYzU2D2g83Mweo+vt4Zz9QToCb50OPIZAsORtcXq8gSpD4G3JVPd8p9ut/XgPobKztfWo5CFXUPCjm80AYCQKuPm0zq+ViW9z1vq7YgjNB0p23MB1D0frzKN3NOulrHS+OYmz3eycAwCq6mhlPJpkF8NNsIs4qoSliQ8c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68990+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139625065693.9349784061623; Wed, 16 Dec 2020 09:27:05 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 81HPYY1788612xTJa5zTIF9n; Wed, 16 Dec 2020 09:27:02 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.56.1608139351910148922 for ; Wed, 16 Dec 2020 09:22:32 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 90590D6E; Wed, 16 Dec 2020 09:22:31 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 75A2B3F66E; Wed, 16 Dec 2020 09:22:30 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 07/25] ArmPkg: Fix Ecc error 3002 in CpuDxe Date: Wed, 16 Dec 2020 17:21:42 +0000 Message-Id: <20201216172200.25846-8-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: fxQTlRhG7ZoCb8Q9pe9qK4vox1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139622; bh=DzMX0UhPryex5E9EXOiXnjdBW8rjIPo2/SL5ztvUpdc=; h=Cc:Date:From:Reply-To:Subject:To; b=e6l3wzVsOITA41rAr04YsjhaocuO9+TJkv/K0qtUucWFRLpAw7j2nrxCiAzbRgrmG7f IJB+e55WdmtCyKQ58B2HQiQ8Ly6A8Cp3WnbaCiJKUB3lsAejXgRBxIL3eqARLONYEGE/6 UeTPbipAMdcDQ5RCwVHGaI+wREFO1RfMJII= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D) Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c | 6 +++--- ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c b/ArmPkg/Drivers/CpuDxe/AA= rch64/Mmu.c index fca2d4f7638a..9f894a743ae7 100644 --- a/ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c +++ b/ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c @@ -2,7 +2,7 @@ Copyright (c) 2009, Hewlett-Packard Company. All rights reserved.
Portions copyright (c) 2010, Apple Inc. All rights reserved.
-Portions copyright (c) 2011-2013, ARM Ltd. All rights reserved.
+Portions copyright (c) 2011-2020, Arm Limited. All rights reserved.
Copyright (c) 2017, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -282,12 +282,12 @@ EfiAttributeToArmAttribute ( ArmAttributes |=3D TT_AF; // Determine protection attributes - if (EfiAttributes & EFI_MEMORY_RO) { + if ((EfiAttributes & EFI_MEMORY_RO) !=3D 0) { ArmAttributes |=3D TT_AP_RO_RO; } // Process eXecute Never attribute - if (EfiAttributes & EFI_MEMORY_XP) { + if ((EfiAttributes & EFI_MEMORY_XP) !=3D 0) { ArmAttributes |=3D TT_PXN_MASK; } diff --git a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c b/ArmPkg/Drivers/CpuDxe/Arm/Mm= u.c index 6fb5112a1a8e..40bb8760f40d 100644 --- a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c +++ b/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c @@ -2,7 +2,7 @@ Copyright (c) 2009, Hewlett-Packard Company. All rights reserved.
Portions copyright (c) 2010, Apple Inc. All rights reserved.
-Portions copyright (c) 2013, ARM Ltd. All rights reserved.
+Portions copyright (c) 2013-2020, Arm Limited. All rights reserved.
Copyright (c) 2017, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -366,14 +366,14 @@ EfiAttributeToArmAttribute ( } // Determine protection attributes - if (EfiAttributes & EFI_MEMORY_RO) { + if ((EfiAttributes & EFI_MEMORY_RO) !=3D 0) { ArmAttributes |=3D TT_DESCRIPTOR_SECTION_AP_RO_RO; } else { ArmAttributes |=3D TT_DESCRIPTOR_SECTION_AP_RW_RW; } // Determine eXecute Never attribute - if (EfiAttributes & EFI_MEMORY_XP) { + if ((EfiAttributes & EFI_MEMORY_XP) !=3D 0) { ArmAttributes |=3D TT_DESCRIPTOR_SECTION_XN_MASK; } -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68990): https://edk2.groups.io/g/devel/message/68990 Mute This Topic: https://groups.io/mt/79006192/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68991+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68991+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139450; cv=none; d=zohomail.com; s=zohoarc; b=KqOPydIb039nkACBXrAjOi3UobEZaPhDzgGyCLLcjX79EecoEOYE/6l9NKh8QocCDCIfwj2dCUsTn7SL0E1VbtK924OEYSb6cOECsSe8SlUkhTftcUOi54Hn7ONl19DVxF26vnhEcxzjiIQ7tOnlyLGwmXN4AGwoC0x/LPewoU8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139450; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=hg1YO8ds2DL8Ig+BTIv0yqhRWnmr4mwwf7EhRlog1gU=; b=Wdp3iaPaR3roELTCQxpq9zzVQWbMiaVtLnNoDPjBtzi7jqpFGhv0j1WaxPyCbOhVuObifmEgTdvp+Ch1XDBdBIheMUo2+q25xYY39g0Dysl3PCA4u9z0CxfqIOvw/Zl/jRkcNosPf8+IkEK7uwlIaAlDgFciuf4y7Gy4ydIqheA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68991+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139450216373.2726299704128; Wed, 16 Dec 2020 09:24:10 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id GjKAYY1788612xtiKrFGWnlV; Wed, 16 Dec 2020 09:24:08 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.48.1608139353360702276 for ; Wed, 16 Dec 2020 09:22:33 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 05E971FB; Wed, 16 Dec 2020 09:22:33 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D8FE53F66E; Wed, 16 Dec 2020 09:22:31 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 08/25] ArmPkg: Fix Ecc error 3002 in SemihostFs Date: Wed, 16 Dec 2020 17:21:43 +0000 Message-Id: <20201216172200.25846-9-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 999NC1Q7zG29Osax9MzS9bNZx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139448; bh=pKZq6SdLaHIiuVWfMqSXfXqU/MinBxwybNIUove/hBo=; h=Cc:Date:From:Reply-To:Subject:To; b=JtQ7trH9c6eHkMmkWiluaQqfMkz9jwb8REhYSddxfLsNbMLENEZiMmyFK+HjDZZeR1F IUJCo6zOPUbJILatyiYvOG/mjL84WYCej/+ta67KAYhM+Wc+EdFCgKsXqecjO88iNkWjz t7UFidxO3XYnBPSGOY0CHq4Wa5A442tf2aE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D) Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c b/ArmPkg/Filesys= tem/SemihostFs/Arm/SemihostFs.c index a66bcb136918..3b07d979182f 100644 --- a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c +++ b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c @@ -2,7 +2,7 @@ Support a Semi Host file system over a debuggers JTAG Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Portions copyright (c) 2011 - 2014, ARM Ltd. All rights reserved.
+ Portions copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -196,8 +196,8 @@ FileOpen ( return EFI_INVALID_PARAMETER; } - if ((OpenMode & EFI_FILE_MODE_CREATE) && - (Attributes & EFI_FILE_DIRECTORY) ) { + if (((OpenMode & EFI_FILE_MODE_CREATE) !=3D 0) && + ((Attributes & EFI_FILE_DIRECTORY) !=3D 0)) { return EFI_WRITE_PROTECTED; } @@ -234,7 +234,7 @@ FileOpen ( Return =3D SemihostFileOpen (AsciiFileName, SemihostMode, &SemihostHandl= e); if (RETURN_ERROR (Return)) { - if (OpenMode & EFI_FILE_MODE_CREATE) { + if ((OpenMode & EFI_FILE_MODE_CREATE) !=3D 0) { // // In the create if does not exist case, if the opening in update // mode failed, create it and open it in update mode. The update @@ -277,7 +277,8 @@ FileOpen ( FileFcb->Info.FileSize =3D Length; FileFcb->Info.PhysicalSize =3D Length; - FileFcb->Info.Attribute =3D (OpenMode & EFI_FILE_MODE_CREATE) ? Attri= butes : 0; + FileFcb->Info.Attribute =3D ((OpenMode & EFI_FILE_MODE_CREATE) !=3D 0= ) ? + Attributes : 0; InsertTailList (&gFileList, &FileFcb->Link); -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68991): https://edk2.groups.io/g/devel/message/68991 Mute This Topic: https://groups.io/mt/79006193/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68992+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68992+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139458; cv=none; d=zohomail.com; s=zohoarc; b=NquRoVGOxEvs5mKbQdRDC1fyr0DQeu4Lxc1OYBbDDu6x72HUi9efCORid5hLmkPSk2NW19AAjDWgmLFqg2W1GLPsIUXs97sdtSKp9bq2bDgMVTv7pQsHNQ1gY7+0YsaovTRDsUooOr3YaSL8NgGGfoA6ZwWVkPzM+yQIrxsCmyE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139458; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=V71bX65bdEP+a1OfT0fMJ4kASHQSwn9ZzTJwDkUjYkE=; b=h4h7ad6RK9tHMuio7XJnX4Hhycgfq7c+9zBDuLC4a1wb9ER1skYTf64yfPNoBYnVe1zMqAZDueQkw18pNVBi3kmvzcIz054Xc1cljLk7ykTV3op2Jsz0el+su7oEG+lwxyaNa/HsyLP76yxTNp1ysXJczHPa+zBmj5fLIN3p2xw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68992+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139457974433.85007618488373; Wed, 16 Dec 2020 09:24:17 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id QhnCYY1788612xIhKDPWmm0y; Wed, 16 Dec 2020 09:24:15 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.54.1608139354948443396 for ; Wed, 16 Dec 2020 09:22:35 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A18AAD6E; Wed, 16 Dec 2020 09:22:34 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 55DF03F66E; Wed, 16 Dec 2020 09:22:33 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 09/25] ArmPkg: Fix Ecc error 3002 in ArmDisassemblerLib Date: Wed, 16 Dec 2020 17:21:44 +0000 Message-Id: <20201216172200.25846-10-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: dtWwKkXazIIiCWYe7pcJJp28x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139455; bh=onBR0Sj//XPuRNAAqtFzYVChJ1cv2luDe5KDB8JiFB8=; h=Cc:Date:From:Reply-To:Subject:To; b=inpbo+gDsSN30LkINQTEzXTV2YAOVni8WUbtTxGem8/xaeX4ZIW3hukThmxSYrsrRbq g017bZESiweYwr4sOp9YrTMJ39JC/qfPFX8TzlU2WLkY8XPrcwJ/eXl/LL4LY58ATpbks hVPhUJvQwQRrfiWB7RJPQ6He3ALJuXUYSYk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D) Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c b/ArmPkg/L= ibrary/ArmDisassemblerLib/ArmDisassembler.c index d206cf4ea908..04b6c2cd21e0 100644 --- a/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c +++ b/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c @@ -2,6 +2,7 @@ Default exception handler Copyright (c) 2008 - 2010, Apple Inc. All rights reserved.
+ Copyright (c) 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -367,7 +368,11 @@ DisassembleArmInstruction ( AsciiSPrint (Buf, Size, "CPS #0x%x", (OpCode & 0x2f)); } else { imode =3D (OpCode >> 18) & 0x3; - Index =3D AsciiSPrint (Buf, Size, "CPS%a %a%a%a", (imode =3D=3D 3) ?= "ID":"IE", (OpCode & BIT8) ? "A":"", (OpCode & BIT7) ? "I":"", (OpCode & B= IT6) ? "F":""); + Index =3D AsciiSPrint (Buf, Size, "CPS%a %a%a%a", + (imode =3D=3D 3) ? "ID":"IE", + ((OpCode & BIT8) !=3D 0) ? "A":"", + ((OpCode & BIT7) !=3D 0) ? "I":"", + ((OpCode & BIT6) !=3D 0) ? "F":""); if ((OpCode & BIT17) !=3D 0) { AsciiSPrint (&Buf[Index], Size - Index, ", #0x%x", OpCode & 0x1f); } -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68992): https://edk2.groups.io/g/devel/message/68992 Mute This Topic: https://groups.io/mt/79006195/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68993+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68993+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139470; cv=none; d=zohomail.com; s=zohoarc; b=SmUE2qJzNtiD+QnMxRHHPsfohLHOM4htCoGAYouJZvb1P6lA99TARf1qk1gr1dU8jrXUwuEATweCVlnqvjbR6uXdc71eo19kvM66bklAvajRCuts1YQc17mjSLKqtOXl5pbZ7EZtL5ZIyjhsMBPnd7VMWJzDmr/XZf6Gz9f0y8Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139470; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=D0agY4cSowNo5EbnlC9k9y7A0ab+X8WM9Aouf0eX/D4=; b=m+e3T3S27iq36rv1pfZ6X4DyaHLuBXfHG5CO0vP0Ojz7WdzhJbK9RupdRUe6dl8tWZzWITtWlXFJTzzOXABd51GBECTyFKKpysq2NBrAG/ggsnSRYFnaIKUCop7xtZaR+ln9RIue3Vpb+owUBAvVsLl2/Oidd34OW7d+3LImXy0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68993+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139470246458.3581300234589; Wed, 16 Dec 2020 09:24:30 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id tQL2YY1788612xHfavXYMb11; Wed, 16 Dec 2020 09:24:25 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.55.1608139356488111410 for ; Wed, 16 Dec 2020 09:22:36 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 30BC11FB; Wed, 16 Dec 2020 09:22:36 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0EA153F66E; Wed, 16 Dec 2020 09:22:34 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 10/25] ArmPkg: Fix Ecc error 3001 in SemihostFs Date: Wed, 16 Dec 2020 17:21:45 +0000 Message-Id: <20201216172200.25846-11-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 0rD7CEhrwseDEkNxy5zsFvLLx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139465; bh=0Ni9PFHDsUO1FkXbzpSM1PAEnOaq0OmEjAbQiRPfBpk=; h=Cc:Date:From:Reply-To:Subject:To; b=oFUGHs6aDm7shKGxxjggfXkPi5OaFR4+qTHyct99xuPkkXejXoImQuPAa6+Z/9PVWos NDflhpG3XrUYoHrp8k+tYixCi0FYD27iemeo0dO7Snco+Mj+aqMG22E4MsFTy5PuOZPLC h6P8QtvWN/SVNzS73WQrGYlFi8Ww9myYKZM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Boolean values and variable type BOOLEAN should not use explicit comparisons to TRUE or FALSE Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c b/ArmPkg/Filesys= tem/SemihostFs/Arm/SemihostFs.c index 3b07d979182f..c03c1a462285 100644 --- a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c +++ b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c @@ -764,7 +764,7 @@ GetFileInfo ( UINTN ResultSize; UINTN Index; - if (Fcb->IsRoot =3D=3D TRUE) { + if (Fcb->IsRoot) { ResultSize =3D SIZE_OF_EFI_FILE_INFO + sizeof(CHAR16); } else { NameSize =3D AsciiStrLen (Fcb->FileName) + 1; @@ -784,7 +784,7 @@ GetFileInfo ( // Fill in the structure Info->Size =3D ResultSize; - if (Fcb->IsRoot =3D=3D TRUE) { + if (Fcb->IsRoot) { Info->FileName[0] =3D L'\0'; } else { for (Index =3D 0; Index < NameSize; Index++) { -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68993): https://edk2.groups.io/g/devel/message/68993 Mute This Topic: https://groups.io/mt/79006197/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68994+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68994+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139478; cv=none; d=zohomail.com; s=zohoarc; b=bIwpMdm7IH3/b4S2E/R6vdpcCSXKgnrAHZlZ9uR8yapLatqc5L3UcqP2hMx32dP9xjUbR4Uqe4eSaAUwjfKFRi4qGCqzvCiMVJ62FKdvHqUYCnY9VYh3PumKQ3HlYzxo6gXMP4Dgh4LF904r2yn5tGRlwaLSHqfpvrQygiuS+iE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139478; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=Xnnx7b7Ra4dLMTxafhSVgdMTCkl8qLT6VZ66JxsMi4M=; b=Okl1ZwClXYS/CuUCLYHckl2ed2sjVp5Hna838ipFs/lWhaX6IIJBTUwcRB4iqrGaE/8c4DnRsUMH1xUpPkeU9HcZiPiUV/g+V9VuBLkwp/9qh3dv8p0E6ORkcDzCrWJOqZoM2+Mw9hBO9EQ8ZJoDR4cLcV+6UTgCyPyf+dJh6aE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68994+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139478743118.1357102907258; Wed, 16 Dec 2020 09:24:38 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id zyUpYY1788612xS08PRaFcPS; Wed, 16 Dec 2020 09:24:35 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.62.1608139357846375626 for ; Wed, 16 Dec 2020 09:22:37 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9073AD6E; Wed, 16 Dec 2020 09:22:37 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 918233F66E; Wed, 16 Dec 2020 09:22:36 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 11/25] ArmPkg: Fix Ecc error 5005 in CpuDxe Date: Wed, 16 Dec 2020 17:21:46 +0000 Message-Id: <20201216172200.25846-12-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 9GOnD1dEff40PZKuCXpQI7xvx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139475; bh=BvQMeMaJHvp+0b3fjREg85E4M0NaPr2Q8bzFOVUY1AA=; h=Cc:Date:From:Reply-To:Subject:To; b=qYBHZe4dR8ddYSbapVYfUO8DFGD3K/Mp5cbksWdi0hgAL2g3bcbP24pI0wO7bybk0OT tnIHQieSzZzOnb194+4rUoghoGva23a16+QaD14eFN2INII/iTsq3b9URZlR1hnQ01gIU eOOmBuyap7yuo3wZEuSFTlAAx2qamg4fRg4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: The body of a function should be contained by open and close braces that must be in the first column Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Drivers/CpuDxe/Exception.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ArmPkg/Drivers/CpuDxe/Exception.c b/ArmPkg/Drivers/CpuDxe/Exce= ption.c index 50ed50ebb046..3050ba60e7c4 100644 --- a/ArmPkg/Drivers/CpuDxe/Exception.c +++ b/ArmPkg/Drivers/CpuDxe/Exception.c @@ -1,7 +1,7 @@ /** @file Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Portions Copyright (c) 2011 - 2014, ARM Ltd. All rights reserved.
+ Portions Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -14,7 +14,8 @@ EFI_STATUS InitializeExceptions ( IN EFI_CPU_ARCH_PROTOCOL *Cpu - ) { + ) +{ EFI_STATUS Status; EFI_VECTOR_HANDOFF_INFO *VectorInfoList; EFI_VECTOR_HANDOFF_INFO *VectorInfo; @@ -92,7 +93,8 @@ EFI_STATUS RegisterInterruptHandler( IN EFI_EXCEPTION_TYPE InterruptType, IN EFI_CPU_INTERRUPT_HANDLER InterruptHandler - ) { + ) +{ // pass down to CpuExceptionHandlerLib return (EFI_STATUS)RegisterCpuInterruptHandler(InterruptType, InterruptH= andler); } -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68994): https://edk2.groups.io/g/devel/message/68994 Mute This Topic: https://groups.io/mt/79006198/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68995+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68995+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139494; cv=none; d=zohomail.com; s=zohoarc; b=Spq/kMvAR3MBluFmbejLscvlY9tU2X8UoW7M0QOZnzY/v/fgKXZmlUTqD00hBLHnD/qOBUBNjDwm8iuv1aKiTdk6ZxUqfW2cuNn4pif9qk+GoXq0U+/ze9uR2EJk3nm39kiJL8mSKpc3Wl3XE1yADjPBXLmnAYi13mIEdy4aCL4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139494; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=jFSE9UJeeqsJyHyK9eCW42HyGWLc2yBv52Tc97jS4n8=; b=lxQG9Zu8VjHhYKeAT/bu+haGITBCPbVUnSFGlCsrZY/6m4uFq/vyWMnH5GcE0Z+FUlyR3g6VTFmW2WIt4/KR7fExGTRv+zqNyFzM0Ai1PPwW59fxLZDKwH3jz9V45Flm5U2M2VxOR73CeOpyJcJ3mDZBhUa2EccrW5YWYRcf0CU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68995+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139493865968.7505977693401; Wed, 16 Dec 2020 09:24:53 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 8J0vYY1788612xd6bRX91G7I; Wed, 16 Dec 2020 09:24:45 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.63.1608139359220442984 for ; Wed, 16 Dec 2020 09:22:39 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EBB991FB; Wed, 16 Dec 2020 09:22:38 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CFA203F66E; Wed, 16 Dec 2020 09:22:37 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 12/25] ArmPkg: Fix Ecc error 5005 in ArmExceptionLib Date: Wed, 16 Dec 2020 17:21:47 +0000 Message-Id: <20201216172200.25846-13-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: mW63Efj8A5bFAKGf4bRXaauKx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139485; bh=10OhL6Vi7QfSDNYnZPSDmKpDIYf3axSVqT4VSkdiMrg=; h=Cc:Date:From:Reply-To:Subject:To; b=m6hgwAaJHaqvmAb8HP984C8EQwG2hss1jTyIZXVOye30qZbZezJfqMyNI60TQQBxMaC UVXklPOIJruOq/XBx18Rm1aqDtnPk8aaPzo+OecEt6820oa20usfShejr3jKljBy1CQqG HDk2zCCHdS6ZtSjxOo9E38EO+1chKv4MhK4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: The body of a function should be contained by open and close braces that must be in the first column Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.c b/ArmPkg/Libr= ary/ArmExceptionLib/ArmExceptionLib.c index 1ff90dede57f..0fba64a17507 100644 --- a/ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.c +++ b/ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.c @@ -2,7 +2,7 @@ * Main file supporting the SEC Phase for Versatile Express * * Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
-* Copyright (c) 2011-2014, ARM Limited. All rights reserved. +* Copyright (c) 2011-2020, Arm Limited. All rights reserved.
* Copyright (c) 2016 HP Development Company, L.P. * * SPDX-License-Identifier: BSD-2-Clause-Patent @@ -253,7 +253,8 @@ RETURN_STATUS RegisterCpuInterruptHandler( IN EFI_EXCEPTION_TYPE ExceptionType, IN EFI_CPU_INTERRUPT_HANDLER ExceptionHandler - ) { + ) +{ if (ExceptionType > gMaxExceptionNumber) { return RETURN_UNSUPPORTED; } -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68995): https://edk2.groups.io/g/devel/message/68995 Mute This Topic: https://groups.io/mt/79006199/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68996+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68996+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139629; cv=none; d=zohomail.com; s=zohoarc; b=cjm23GJiOrRiTl4gMxNddEjEtEWKJbREs7og4ohxs1fPEmzJUS4sfCZQ/KyEY63si/oeNhoxaazu5zOgJwLD4+gGgfj+JR5yzRGO7pUfuYPwHz5PM0tbpo+0W2EtDcnvMnVcFv3CL+78AMMonJxnJo/k4kNxc/roY67dSPGIbV0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139629; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=85vyjmXof6ROf9HaimkESd5Er2PqJXDEKJtj+vboqFM=; b=TvOdwZRkrROxonrp18NQEDw+GcgMtVQOp8hkkoTKAzLEQr8QMB8odTn0DU+A5QqL6VnILOUcrbOVtuleW3QX6slJvdwFgJaileSqQlixVUoH5ze6tnrAau1VaHIYBO032Wf9ZuOsi674tixdWbTfgqn3TixIsxffsSTMHfXEWZ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68996+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139629109597.4392998824806; Wed, 16 Dec 2020 09:27:09 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id X0gRYY1788612xbYvI9yaKvR; Wed, 16 Dec 2020 09:27:06 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.60.1608139360668163234 for ; Wed, 16 Dec 2020 09:22:40 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 635F2D6E; Wed, 16 Dec 2020 09:22:40 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3EC7C3F66E; Wed, 16 Dec 2020 09:22:39 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 13/25] ArmPkg: Fix Ecc error 5007 in CompilerIntrinsicsLib Date: Wed, 16 Dec 2020 17:21:48 +0000 Message-Id: <20201216172200.25846-14-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 1fweT5Oc5lQwaUR05M8mzyHmx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139626; bh=JS6KrAhVt+PYOTwwowhmbX4y3Je62n7L8F2SYXXwNiA=; h=Cc:Date:From:Reply-To:Subject:To; b=LTmfplq3hg7g9KsYDbByQUR3mNVqovu1RZkbvNHVDxl5qb0Dn/YO+JCozfgsTlJW5gs E+rSsdLvEhUTgVVgw5NFBl9yK/xFqTacQK3HS4Veq3JlMWDVwPAj5RK2ysh4woE4HvQ2t bijivmvuRZivW8d3Rr/b3al32M9q1nWjckc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Library/CompilerIntrinsicsLib/memcmp_ms.c | 7 +++++-- ArmPkg/Library/CompilerIntrinsicsLib/memcpy.c | 7 +++++-- ArmPkg/Library/CompilerIntrinsicsLib/memcpy_ms.c | 7 +++++-- ArmPkg/Library/CompilerIntrinsicsLib/memmove_ms.c | 7 +++++-- ArmPkg/Library/CompilerIntrinsicsLib/memset.c | 4 +++- ArmPkg/Library/CompilerIntrinsicsLib/memset_ms.c | 4 +++- 6 files changed, 26 insertions(+), 10 deletions(-) diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/memcmp_ms.c b/ArmPkg/Libr= ary/CompilerIntrinsicsLib/memcmp_ms.c index 8491e2401f1e..5e46a7345d84 100644 --- a/ArmPkg/Library/CompilerIntrinsicsLib/memcmp_ms.c +++ b/ArmPkg/Library/CompilerIntrinsicsLib/memcmp_ms.c @@ -18,8 +18,11 @@ int memcmp(void *, void *, size_t); #pragma function(memcmp) int memcmp(const void *s1, const void *s2, size_t n) { - unsigned char const *t1 =3D s1; - unsigned char const *t2 =3D s2; + unsigned char const *t1; + unsigned char const *t2; + + t1 =3D s1; + t2 =3D s2; while (n-- !=3D 0) { if (*t1 !=3D *t2) diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/memcpy.c b/ArmPkg/Library= /CompilerIntrinsicsLib/memcpy.c index d4827531dd04..6d40c423c608 100644 --- a/ArmPkg/Library/CompilerIntrinsicsLib/memcpy.c +++ b/ArmPkg/Library/CompilerIntrinsicsLib/memcpy.c @@ -11,8 +11,11 @@ typedef __SIZE_TYPE__ size_t; static void __memcpy(void *dest, const void *src, size_t n) { - unsigned char *d =3D dest; - unsigned char const *s =3D src; + unsigned char *d; + unsigned char const *s; + + d =3D dest; + s =3D src; while (n-- !=3D 0) { *d++ =3D *s++; diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/memcpy_ms.c b/ArmPkg/Libr= ary/CompilerIntrinsicsLib/memcpy_ms.c index a9590df68054..616a08a05f4d 100644 --- a/ArmPkg/Library/CompilerIntrinsicsLib/memcpy_ms.c +++ b/ArmPkg/Library/CompilerIntrinsicsLib/memcpy_ms.c @@ -18,8 +18,11 @@ void* memcpy(void *, const void *, size_t); #pragma function(memcpy) void* memcpy(void *dest, const void *src, size_t n) { - unsigned char *d =3D dest; - unsigned char const *s =3D src; + unsigned char *d; + unsigned char const *s; + + d =3D dest; + s =3D src; while (n-- !=3D 0) { *d++ =3D *s++; diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/memmove_ms.c b/ArmPkg/Lib= rary/CompilerIntrinsicsLib/memmove_ms.c index a2e1ef9c8883..36b0a1101515 100644 --- a/ArmPkg/Library/CompilerIntrinsicsLib/memmove_ms.c +++ b/ArmPkg/Library/CompilerIntrinsicsLib/memmove_ms.c @@ -18,8 +18,11 @@ void* memmove(void *, const void *, size_t); #pragma function(memmove) void* memmove(void *dest, const void *src, size_t n) { - unsigned char *d =3D dest; - unsigned char const *s =3D src; + unsigned char *d; + unsigned char const *s; + + d =3D dest; + s =3D src; if (d < s) { while (n-- !=3D 0) { diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/memset.c b/ArmPkg/Library= /CompilerIntrinsicsLib/memset.c index 57fc776333b0..1d53c2644566 100644 --- a/ArmPkg/Library/CompilerIntrinsicsLib/memset.c +++ b/ArmPkg/Library/CompilerIntrinsicsLib/memset.c @@ -12,7 +12,9 @@ typedef __SIZE_TYPE__ size_t; static __attribute__((__used__)) void *__memset(void *s, int c, size_t n) { - unsigned char *d =3D s; + unsigned char *d; + + d =3D s; while (n-- !=3D 0) { *d++ =3D c; diff --git a/ArmPkg/Library/CompilerIntrinsicsLib/memset_ms.c b/ArmPkg/Libr= ary/CompilerIntrinsicsLib/memset_ms.c index 463fc21d3184..86dcf3b08c07 100644 --- a/ArmPkg/Library/CompilerIntrinsicsLib/memset_ms.c +++ b/ArmPkg/Library/CompilerIntrinsicsLib/memset_ms.c @@ -18,7 +18,9 @@ void* memset(void *, int, size_t); #pragma function(memset) void *memset(void *s, int c, size_t n) { - unsigned char *d =3D s; + unsigned char *d; + + d =3D s; while (n-- !=3D 0) { *d++ =3D (unsigned char)c; -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68996): https://edk2.groups.io/g/devel/message/68996 Mute This Topic: https://groups.io/mt/79006200/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68997+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68997+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139527; cv=none; d=zohomail.com; s=zohoarc; b=TaJ4LSRX0ssw+o8A777CmWK3bj9KpaF/SAio2ELXF+KlAjfhnnq6OdyGm0H80qfdSU91mABJEBKAOa6TYne+rnY9F4agKFOMHF1dwCA29Ic9cLtzAErRwyLPr4OTyvSjN9c2nWNZJ1HE7aSYLAOBQDq1mBMEatUaV721RihZxqk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139527; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=7PXhC3/wjRNwY5m7yR0p+3HMflWch0dWS6rpV8jxgbw=; b=j1RTwYNFX7Xl0na/zVtJrFHMCtJLmiimznMBgS0b9sqp15eUmxXDsFnVN6nv/cc+Wn/7xJioLm6i0LfSDRtitKvRCe/fZAhChbgBUAaNLLhuoJD8FYAUXi4H2VSK8JJOlPj5AkCl5J0CHgbTzWOIjq5M+0GgSg7fvXDl7JAFaRU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68997+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139527671496.88090762466425; Wed, 16 Dec 2020 09:25:27 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id kcp8YY1788612xUDdADAtToX; Wed, 16 Dec 2020 09:25:24 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.61.1608139362259890732 for ; Wed, 16 Dec 2020 09:22:42 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E42821FB; Wed, 16 Dec 2020 09:22:41 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CC2AD3F66E; Wed, 16 Dec 2020 09:22:40 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 14/25] ArmPkg: Fix Ecc error 5007 in ArmScmiDxe Date: Wed, 16 Dec 2020 17:21:49 +0000 Message-Id: <20201216172200.25846-15-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 0IC7Zk8sCdPzwFCaXCXfqtz0x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139524; bh=m50Pg77N6WO9NNK5t1RHMsU+a4PNXs3hCdTA4XgNmh4=; h=Cc:Date:From:Reply-To:Subject:To; b=Hfsj6vp2qJvS+xfumDRQgonTD5P6AmvZI0V/ZTxgubUULPc5Dfil2rq96lIOzk8K1mo WYqgCCSrxKbswrFImlMIK4egePPOb6EKwBUDL2zes2v+gm+IKvXWzK+TBLRZ505ou2KCW avbY+lj0Mja5sFoFrnUAE5rTJy9OUU46QfA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 5 +++-- ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 8 +++++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/S= cmi.c index c4af3ec4ecc1..3e62f2b1a48c 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c +++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2017-2018, Arm Limited. All rights reserved. + Copyright (c) 2017-2020, Arm Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent @@ -161,8 +161,9 @@ ScmiProtocolDiscoveryCommon ( ) { SCMI_COMMAND Command; - UINT32 PayloadLength =3D 0; + UINT32 PayloadLength; + PayloadLength =3D 0; Command.ProtocolId =3D ProtocolId; Command.MessageId =3D MessageId; diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c b/ArmPkg/Drivers= /ArmScmiDxe/ScmiClockProtocol.c index ac0d21d862b3..8002e039c98a 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2017-2018, Arm Limited. All rights reserved. + Copyright (c) 2017-2020, Arm Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent @@ -189,12 +189,14 @@ ClockDescribeRates ( CLOCK_DESCRIBE_RATES *DescribeRates; CLOCK_RATE_DWORD *Rate; - UINT32 RequiredArraySize =3D 0; - UINT32 RateIndex =3D 0; + UINT32 RequiredArraySize; + UINT32 RateIndex; UINT32 RateNo; UINT32 RateOffset; *TotalRates =3D 0; + RequiredArraySize =3D 0; + RateIndex =3D 0; Status =3D ScmiCommandGetPayload (&MessageParams); if (EFI_ERROR (Status)) { -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68997): https://edk2.groups.io/g/devel/message/68997 Mute This Topic: https://groups.io/mt/79006201/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68998+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68998+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139533; cv=none; d=zohomail.com; s=zohoarc; b=TJ2QtGZbMh8xKOp8LqvA6JHVMeIv9wQdNxQrH/OcsrE7Jk4jVlGoypJiWCtj0gw41Jxz0NcCzp8kp8D8KhnrPHA36b/i1jbt1FxbtiVNge0zAXe9uH1+2FF1lXVftkQwFNbqAd7AaqerrHdYe9sPEd2f+rxRExnwxsYIMypOp5g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139533; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=WdlB2lOyEttLgZ6a4INkROjR62v8wufFgZceArF+hp4=; b=XvcOUJvqDCNUzF3G/ZQvTs6+AK15clNWaOjyuq2WgWs7koKgLpUpPop7BDlzyH9snEUvpJTts4P01KWLAzgW8FoN00SdwVpznxrFwjhP7GcrQjDAkHpPDw8NtjP5cbD9tv8Bg7oCuNBO8FdUi/ABl80VMUWoJhArVrcGnd5AlFk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68998+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139533445341.8828817800355; Wed, 16 Dec 2020 09:25:33 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id vLSvYY1788612xGq6KVBg7Kw; Wed, 16 Dec 2020 09:25:28 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.60.1608139363574980598 for ; Wed, 16 Dec 2020 09:22:43 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4F084D6E; Wed, 16 Dec 2020 09:22:43 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 503CC3F66E; Wed, 16 Dec 2020 09:22:42 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 15/25] ArmPkg: Fix Ecc error 5007 in CpuDxe Date: Wed, 16 Dec 2020 17:21:50 +0000 Message-Id: <20201216172200.25846-16-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 90JWggoNEYfNcQVXVtoxrHRSx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139528; bh=dQwyfnILeouTZoVaxmyc1jQFS+jsdpES7HJfdEkEr2U=; h=Cc:Date:From:Reply-To:Subject:To; b=Ke2pxeM9M6ih4SPHmxua/xPwBJivRU4/GpxsD/sMhF4ML+rCHIXEHKFmbvbqtiPTxhO Jg7v1yur9k/TFk4EhaMVazWjSemg5ySjZD/pbwO5GPHAEsFYs9J6EWoRw6lsO9niZ8Wln CclOC2fWVkENcDjqvhltWVAU2wo1Do4u5UA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c | 2 +- ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c b/ArmPkg/Drivers/CpuDxe/AA= rch64/Mmu.c index 9f894a743ae7..529aeaefa17e 100644 --- a/ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c +++ b/ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c @@ -189,7 +189,7 @@ SyncCacheConfig ( ) { EFI_STATUS Status; - UINT32 PageAttribute =3D 0; + UINT32 PageAttribute; UINT64 *FirstLevelTableAddress; UINTN TableLevel; UINTN TableCount; diff --git a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c b/ArmPkg/Drivers/CpuDxe/Arm/Mm= u.c index 40bb8760f40d..cd8073418dba 100644 --- a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c +++ b/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c @@ -155,8 +155,8 @@ SyncCacheConfigPage ( EFI_STATUS Status; UINT32 i; volatile ARM_PAGE_TABLE_ENTRY *SecondLevelTable; - UINT32 NextPageAttributes =3D 0; - UINT32 PageAttributes =3D 0; + UINT32 NextPageAttributes; + UINT32 PageAttributes; UINT32 BaseAddress; UINT64 GcdAttributes; @@ -226,8 +226,8 @@ SyncCacheConfig ( UINT32 i; EFI_PHYSICAL_ADDRESS NextRegionBase; UINT64 NextRegionLength; - UINT32 NextSectionAttributes =3D 0; - UINT32 SectionAttributes =3D 0; + UINT32 NextSectionAttributes; + UINT32 SectionAttributes; UINT64 GcdAttributes; volatile ARM_FIRST_LEVEL_DESCRIPTOR *FirstLevelTable; UINTN NumberOfDescriptors; -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68998): https://edk2.groups.io/g/devel/message/68998 Mute This Topic: https://groups.io/mt/79006202/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68999+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68999+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139586; cv=none; d=zohomail.com; s=zohoarc; b=Vb8+t1lhX4XkwC09fl3K6kg8NAg2NyAesXaNYrHh1xBUdRvPey1B1w+b79M/h21RPWZmAFhnn04uH4v8dpFl3Hb20jztP+opfyaRfWI+4AEMSLcLhGNbIfwVkXdgMML8aZKM3oXcirEc7Gt+B0JYHEeanrha+hGsEwzr3o1dHoU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139586; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=IttaStYgKrWWERBwW4HM8YqgpTmQTLjtx9j7YimXspo=; b=BR+SRyxT1ByBAu1xQN0Wfl51JBYOSIMg/yZWnrfVe0miQT6jR27jvJoGsng/paVH0kVhWSHA+JCSjpsbONdTJslRS529BE5tL/CsfZ3llc6ZLgW6fek/YbZmyHj9Wf3uukYtpPXox2hFp/+x2MQ4zb/o2BqVBNPwbaZUqBvHvu4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68999+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139586155348.89202548827836; Wed, 16 Dec 2020 09:26:26 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 6oFQYY1788612xBLZVqq62Zo; Wed, 16 Dec 2020 09:26:24 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.61.1608139364874719479 for ; Wed, 16 Dec 2020 09:22:44 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 979EF1FB; Wed, 16 Dec 2020 09:22:44 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A15FC3F66E; Wed, 16 Dec 2020 09:22:43 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 16/25] ArmPkg: Fix Ecc error 5007 in TimerDxe Date: Wed, 16 Dec 2020 17:21:51 +0000 Message-Id: <20201216172200.25846-17-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: S07aUnKktHOdZG0GWS9XC3iDx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139584; bh=ikDXS3gMd4fuv4CRw9XlS7x6PfKmj42SLf86VcVIwYk=; h=Cc:Date:From:Reply-To:Subject:To; b=I6oZkiD13Suys5mbSKsryX0CImwy/+3pROGi5VAx5ibkhJdPuDkSf7l7DIYGienfx9r KK7TLqUNu2IYo+ensCF+3OV0EL6vewXp/5VnqEYoYLbTU2FamyfVMqOOtD5AKGP6hIxuL i3o5eyFbuiETdsYYS1JNeLHYAZxXPqyPXbs= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Drivers/TimerDxe/TimerDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/TimerDxe/TimerDxe.c b/ArmPkg/Drivers/TimerDxe/T= imerDxe.c index 69f31e880a68..7a69f3882696 100644 --- a/ArmPkg/Drivers/TimerDxe/TimerDxe.c +++ b/ArmPkg/Drivers/TimerDxe/TimerDxe.c @@ -359,7 +359,7 @@ TimerInitialize ( IN EFI_SYSTEM_TABLE *SystemTable ) { - EFI_HANDLE Handle =3D NULL; + EFI_HANDLE Handle; EFI_STATUS Status; UINTN TimerCtrlReg; UINT32 TimerHypIntrNum; @@ -408,6 +408,7 @@ TimerInitialize ( Status =3D TimerDriverSetTimerPeriod (&gTimer, FixedPcdGet32(PcdTimerPer= iod)); // TIMER_DEFAULT_PERIOD ASSERT_EFI_ERROR (Status); + Handle =3D NULL; // Install the Timer Architectural Protocol onto a new handle Status =3D gBS->InstallMultipleProtocolInterfaces( &Handle, -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68999): https://edk2.groups.io/g/devel/message/68999 Mute This Topic: https://groups.io/mt/79006203/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69000+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69000+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139540; cv=none; d=zohomail.com; s=zohoarc; b=dYHwMX4JkOHjl1iV/MSMkDJG9p1xn22ybryT7jD1e6IVG1gJ8vkc2lQv0lTs0yqnhdzwT7P2xmYInYvKtdXBm+JGp96r5+FJWS9xl8IKQCfPU+maXHvCGCZ2uK/T7vITrdel5CcNfsKc5IuF1k+H0J/OSaiGoUF8PPaSc9wyipU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139540; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=DPxcDK25FD/jGvI1IllQx+Ur0MZi6KEXskuXrnJyBn4=; b=izMdant5YBtSYmRJujaDlogXMQ2qhAA775q/6UFv/NjdTTp+5rTUOhhsYoYk6cYUiNbLTR3EN+m2zijkuPTbzlSBGgRx/n0xDmK2ArlSxIqRa77SFIGMNGVDboTZK4KbJLv11VZWFBWsXNNNhe7csGAAPOihscqG+G3TEB8RmE4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69000+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 160813954079749.92257860695099; Wed, 16 Dec 2020 09:25:40 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id jgw3YY1788612xxujDImxbvk; Wed, 16 Dec 2020 09:25:38 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.50.1608139365965543724 for ; Wed, 16 Dec 2020 09:22:46 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AF2771FB; Wed, 16 Dec 2020 09:22:45 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DA5C43F66E; Wed, 16 Dec 2020 09:22:44 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 17/25] ArmPkg: Fix Ecc error 5007 in SemihostFs Date: Wed, 16 Dec 2020 17:21:52 +0000 Message-Id: <20201216172200.25846-18-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: ahARZq4NneYQB4bpB3iNwOmLx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139538; bh=T2BouEwSTTHS3xsT1kR/QPiGkPeZiNUJTLfJp1+5A4w=; h=Cc:Date:From:Reply-To:Subject:To; b=LtR3v7cQwcrhv7T4SJQkTXJbCxWRZaO84gXBZbC7GZz8QtJGlBFvvNXt3J6Tq92b44C fXunP8XKMtNE6qQkJ0EGvycErT83MZTIHAWU03vYD22BUhdXdoE2IbH9wa+T9Xvdvk021 ziYYvUJ1PreJhzCXLfDE6lA3AKlGxLXNHmQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c b/ArmPkg/Filesys= tem/SemihostFs/Arm/SemihostFs.c index c03c1a462285..0468d242f7e4 100644 --- a/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c +++ b/ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c @@ -90,8 +90,9 @@ AllocateFCB ( VOID ) { - SEMIHOST_FCB *Fcb =3D AllocateZeroPool (sizeof (SEMIHOST_FCB)); + SEMIHOST_FCB *Fcb; + Fcb =3D AllocateZeroPool (sizeof (SEMIHOST_FCB)); if (Fcb !=3D NULL) { CopyMem (&Fcb->File, &gSemihostFsFile, sizeof (gSemihostFsFile)); Fcb->Signature =3D SEMIHOST_FCB_SIGNATURE; @@ -122,7 +123,7 @@ VolumeOpen ( OUT EFI_FILE **Root ) { - SEMIHOST_FCB *RootFcb =3D NULL; + SEMIHOST_FCB *RootFcb; if (Root =3D=3D NULL) { return EFI_INVALID_PARAMETER; @@ -759,12 +760,13 @@ GetFileInfo ( OUT VOID *Buffer ) { - EFI_FILE_INFO *Info =3D NULL; - UINTN NameSize =3D 0; + EFI_FILE_INFO *Info; + UINTN NameSize; UINTN ResultSize; UINTN Index; if (Fcb->IsRoot) { + NameSize =3D 0; ResultSize =3D SIZE_OF_EFI_FILE_INFO + sizeof(CHAR16); } else { NameSize =3D AsciiStrLen (Fcb->FileName) + 1; -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69000): https://edk2.groups.io/g/devel/message/69000 Mute This Topic: https://groups.io/mt/79006204/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69001+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69001+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139565; cv=none; d=zohomail.com; s=zohoarc; b=SBLV+vAPo+zGFz15Cb1B80+HTGgFT+V5SiCGAyhDiEIqaYWDazd8bfem6hOlFObq8Pw/jrpATLLUZSYg2DgVB9vebQSe0u2PuoAA/G7R2cIPKHDIE0dZjVwDiWOedD2p5iRtL4ygIIIa8JZTUwridub3IMvwkLI5Wsmxt5WCiYE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139565; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=aeunGgWEMYrzrH8Zr0PffUX853CNgLwfiSJCxz6+HUw=; b=M12hlYdeqHJGWRk0UTAA2kBS2AyP0BZY2OE/MYbVawnuZD3APAHPv5TCf/kwjij46aMAD2+81PluoT/FQrN/v98gUNkqOp5ZVoY9fSCSq+JOGEd9fth9HJ25mmG7eJ4I/b4kMJaa+dqiz4PDSu2DCNQ85q6zXFxxKTga47/IGPU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69001+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139565420671.1503833677745; Wed, 16 Dec 2020 09:26:05 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id YF3CYY1788612xHFqRlWvXpJ; Wed, 16 Dec 2020 09:26:02 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.52.1608139367345608826 for ; Wed, 16 Dec 2020 09:22:47 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0DC571FB; Wed, 16 Dec 2020 09:22:47 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1D3363F66E; Wed, 16 Dec 2020 09:22:45 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 18/25] ArmPkg: Fix Ecc error 5007 in ArmCacheMaintenanceLib Date: Wed, 16 Dec 2020 17:21:53 +0000 Message-Id: <20201216172200.25846-19-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: mOL9DCVpItWo2mKfvif6sGazx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139562; bh=4xNcLRTUBCGbTQoFeLkVfirRV9GLd7njbFWXQbtIwZs=; h=Cc:Date:From:Reply-To:Subject:To; b=ut3BA5Ie2nRx/r+1s0DfacgBtOQ4FsLkmZIgNIP3d9X3fv6IiGl3FJjIRWoSTpp6R7L GleFM0xOre63HVFYdaTYuqE7TMq+/1Nc8kCIkw4kPDdON3/ZsH9qHM0sPM+XOWyxwYrmE N9CdkFv02RAdZQz4ZTFxJYK3BBwD0yP3IBA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 .../ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.c= b/ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.c index 440a5c372566..e14c40b3beb4 100644 --- a/ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.c +++ b/ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.c @@ -1,7 +1,7 @@ /** @file Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Copyright (c) 2011 - 2014, ARM Limited. All rights reserved. + Copyright (c) 2011 - 2020, ARM Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent @@ -20,11 +20,14 @@ CacheRangeOperation ( IN UINTN LineLength ) { - UINTN ArmCacheLineAlignmentMask =3D LineLength - 1; - + UINTN ArmCacheLineAlignmentMask; // Align address (rounding down) - UINTN AlignedAddress =3D (UINTN)Start - ((UINTN)Start & ArmCacheLineAlig= nmentMask); - UINTN EndAddress =3D (UINTN)Start + Length; + UINTN AlignedAddress; + UINTN EndAddress; + + ArmCacheLineAlignmentMask =3D LineLength - 1; + AlignedAddress =3D (UINTN)Start - ((UINTN)Start & ArmCacheLineAlignmentM= ask); + EndAddress =3D (UINTN)Start + Length; // Perform the line operation on an address in each cache line while (AlignedAddress < EndAddress) { -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69001): https://edk2.groups.io/g/devel/message/69001 Mute This Topic: https://groups.io/mt/79006208/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69002+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69002+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139572; cv=none; d=zohomail.com; s=zohoarc; b=OdcERVUXbkpNluxpgePoxGd8qdQo5JzKCxI2wPm5bfFyV91gyU5SAV5kqRA1aHyZZrMZi2C9x3EzOHL+YfAqEHCm7/RFDwEY1xmERjD5I+KBvwSNaQbAzoQlwP313FAM01m7XgVqGw7IFtXXF8A9pezce8IBAsdh4hlFTCdND5w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139572; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=TBMnX12D4pwJ1sALsu3kRBKaqUmhXSgj/coolUzl+AY=; b=nLHI3oL27Pb39jN/RThD61pp/ulHcxAtZT5x46UYB3hzdgpnoYz2vkKckCyxtu0h2VOpnndjxMgZM3FuduBrFJ+Oc8enGQX/XSuHROpMR+YN63I3doDcXVboR2exy6MTmBq8ImpyePXhSeVJs171Y+c5u4AjcArgV/UXHgnRoqA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69002+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 160813957199313.96152949993018; Wed, 16 Dec 2020 09:26:11 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id O8pjYY1788612x7OMvsuzY7h; Wed, 16 Dec 2020 09:26:09 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.70.1608139368532961739 for ; Wed, 16 Dec 2020 09:22:48 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 451E4D6E; Wed, 16 Dec 2020 09:22:48 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 54CCE3F66E; Wed, 16 Dec 2020 09:22:47 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 19/25] ArmPkg: Fix Ecc error 5007 in ArmDisassemblerLib Date: Wed, 16 Dec 2020 17:21:54 +0000 Message-Id: <20201216172200.25846-20-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 9ZMBD4iO434bNFO19gtcAi6lx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139569; bh=LyZ/3vaUTHrnJX/+P4yhOBBSXuEFfa+yxoZo5DT07sk=; h=Cc:Date:From:Reply-To:Subject:To; b=LCHhfKA9ZVkVvIFEUl981ALFuoqpExpOnWuTxB5fbHRnuOzmKVYuic2069D8tkXqLG2 um2Jcl4XTXi7FNhWygdUldVQPgbt9lafR5n7NpHjaRCfGPOxVQqRtL2p6/o1g7mu4nHp6 vBuyy5HVI9lrk9URCpLTt8uWNWJUgPXhqq8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c b/ArmPkg/L= ibrary/ArmDisassemblerLib/ArmDisassembler.c index 04b6c2cd21e0..1882163522d9 100644 --- a/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c +++ b/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c @@ -158,7 +158,7 @@ DisassembleArmInstruction ( IN BOOLEAN Extended ) { - UINT32 OpCode =3D **OpCodePtr; + UINT32 OpCode; CHAR8 *Type, *Root; BOOLEAN I, P, U, B, W, L, S, H; UINT32 Rn, Rd, Rm; @@ -166,6 +166,8 @@ DisassembleArmInstruction ( UINT32 Index; UINT32 shift_imm, shift; + OpCode =3D =3D **OpCodePtr; + I =3D (OpCode & BIT25) =3D=3D BIT25; P =3D (OpCode & BIT24) =3D=3D BIT24; U =3D (OpCode & BIT23) =3D=3D BIT23; -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69002): https://edk2.groups.io/g/devel/message/69002 Mute This Topic: https://groups.io/mt/79006209/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69003+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69003+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139574; cv=none; d=zohomail.com; s=zohoarc; b=XlMuMvedGA1jYJZrfkMX1Ph+HM0GQFNa9O6BVGjlK0GiizGrKz0G5+AjAcK2h8AoEfQkDh5oQtXNC7SsHT34rSE7eBCIg2o3sh9Zf68tC0nNB1lMOgFDg9qir9ghqHMEvURTft3rBtmP5F8uSgoSniSo903rJ1yceioJxMI+vSY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139574; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=0ApE/Fd4fQdPybZ7j7lkcgUDQLNiinrBF51v2ucPALc=; b=RnMqypWHDK5RfnwcQqlzkRjgYJB27DjucONyVbVZ7HAgvngSEkLn+DhRR6Qu01wrNBPvxAo7TJYk813hwkQrHfoa6U9HmA213FT5YLwmFLzlrLX2TyxDVqK7WoIumA4f2qJDthvBjftLNPSvlccRPV2SVLwr3dVcOwsJP37QpDA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69003+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139574764378.78378078190576; Wed, 16 Dec 2020 09:26:14 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id IsJVYY1788612xthJMSY3tLx; Wed, 16 Dec 2020 09:26:13 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.72.1608139370171385607 for ; Wed, 16 Dec 2020 09:22:50 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E0A231FB; Wed, 16 Dec 2020 09:22:49 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 88BB73F66E; Wed, 16 Dec 2020 09:22:48 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 20/25] ArmPkg: Fix Ecc error 5007 in ArmLib Date: Wed, 16 Dec 2020 17:21:55 +0000 Message-Id: <20201216172200.25846-21-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: lXttwme5DXdLwqTdP1GL5Pj9x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139573; bh=/SrtEqcdBcbMYUkIvFIq0XPwJy4a3aN8Wf3f7mTYHd8=; h=Cc:Date:From:Reply-To:Subject:To; b=s62RWdTLUSMDw9uNpZBCLW5leVttSL0sHXPFgthjcSAeofvqjkU+YUe8qotKjalBWGC 1JQ81QtnsaEIMp2z+56+xsG3ikNYcUuyvKjiiG5t1ceDt7ll+w5nSdhFNDYmswK2U7BWp qUTtCebJEDOGYE7tC6uknq/VnFMpM3kIkLo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Library/ArmLib/ArmLib.c | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/ArmPkg/Library/ArmLib/ArmLib.c b/ArmPkg/Library/ArmLib/ArmLib.c index 3905d02c5e7e..c454ce5b99ad 100644 --- a/ArmPkg/Library/ArmLib/ArmLib.c +++ b/ArmPkg/Library/ArmLib/ArmLib.c @@ -1,7 +1,7 @@ /** @file Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Copyright (c) 2011 - 2014, ARM Ltd. All rights reserved.
+ Copyright (c) 2011 - 2020, ARM Ltd. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -19,9 +19,7 @@ ArmSetAuxCrBit ( IN UINT32 Bits ) { - UINT32 val =3D ArmReadAuxCr(); - val |=3D Bits; - ArmWriteAuxCr(val); + ArmWriteAuxCr(ArmReadAuxCr() | Bits); } VOID @@ -30,9 +28,7 @@ ArmUnsetAuxCrBit ( IN UINT32 Bits ) { - UINT32 val =3D ArmReadAuxCr(); - val &=3D ~Bits; - ArmWriteAuxCr(val); + ArmWriteAuxCr(ArmReadAuxCr() & ~Bits); } // @@ -45,10 +41,7 @@ ArmSetCpuActlrBit ( IN UINTN Bits ) { - UINTN Value; - Value =3D ArmReadCpuActlr (); - Value |=3D Bits; - ArmWriteCpuActlr (Value); + ArmWriteCpuActlr (ArmReadCpuActlr () | Bits); } VOID @@ -57,10 +50,7 @@ ArmUnsetCpuActlrBit ( IN UINTN Bits ) { - UINTN Value; - Value =3D ArmReadCpuActlr (); - Value &=3D ~Bits; - ArmWriteCpuActlr (Value); + ArmWriteCpuActlr (ArmReadCpuActlr () & ~Bits); } UINTN -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69003): https://edk2.groups.io/g/devel/message/69003 Mute This Topic: https://groups.io/mt/79006210/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69004+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69004+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139590; cv=none; d=zohomail.com; s=zohoarc; b=Axm9rUX9UYHwrmX8KYdXvjVtdcl29Mpe2MDiLiofCuA/pKilJdnY6j91O67x9XzZPXQMNMl5HIGjNXxz34ZbExWFsrgy217c4F6GYhNfJ0ZkswbP1tIh7X1SYWqyuEw704mtys9n9mAKLlVPNUFL1bbrGrZghpbLP0JQWunaYTs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139590; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=NS4hKRSf8sK3JRHht7dxFXjW5j+Jg3GSCANFL4rSHwU=; b=NaeiJMZfkT8t8Cr/t4k3wW28JfE8gRW3kirRiuioJWdVKl7tBP5O+5ufthZAFB2EBMX+8hbxqfulDuCAv/qQIViEnyHIA5zP3Lw6uCX0PioXNqJVS9FrLRpmf7NqUzrrCGfCsVXLhv5uMKIxsXOwQSxXn0rsdX+nh+e1EKQ6c9I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69004+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139590778439.76176973573615; Wed, 16 Dec 2020 09:26:30 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id tztsYY1788612xTaKzKzrK4S; Wed, 16 Dec 2020 09:26:28 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.64.1608139371715989067 for ; Wed, 16 Dec 2020 09:22:51 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 713E21FB; Wed, 16 Dec 2020 09:22:51 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4B6F73F66E; Wed, 16 Dec 2020 09:22:50 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 21/25] ArmPkg: Fix Ecc error 5007 in ArmMmuLib Date: Wed, 16 Dec 2020 17:21:56 +0000 Message-Id: <20201216172200.25846-22-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: KgeHg6qs7EChAALwx8HVDPYcx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139588; bh=7op5Yo5ElW0sFz8yyM9vz8gf9pXGYjLp/gPs2nkpAtU=; h=Cc:Date:From:Reply-To:Subject:To; b=XYTNFxP4CkeK1ju9Mx1hn1oXFSwjDefLc5XYrDIAEWK2o4HrfFSnGtdxfEBwW0JV9Oa 4XxPJP51XIZoPGPIdHQPAXzOJp9VueMlZextSXnQmfPB7kXtGHSotUc3MAr+N0vzyyOi6 7KUv2mcCBnC/FjNEEVYQOw9D0Sr54pUGNn8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c b/ArmPkg/Librar= y/ArmMmuLib/Arm/ArmMmuLibUpdate.c index c7f2744c4fac..6d8249510bbf 100644 --- a/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c +++ b/ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c @@ -220,7 +220,7 @@ UpdateSectionEntries ( IN UINT64 Attributes ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; UINT32 EntryMask; UINT32 EntryValue; UINT32 FirstLevelIdx; @@ -231,6 +231,8 @@ UpdateSectionEntries ( VOID *Mva; volatile ARM_FIRST_LEVEL_DESCRIPTOR *FirstLevelTable; + Status =3D EFI_SUCCESS; + // EntryMask: bitmask of values to change (1 =3D change this value, 0 = =3D leave alone) // EntryValue: values at bit positions specified by EntryMask -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69004): https://edk2.groups.io/g/devel/message/69004 Mute This Topic: https://groups.io/mt/79006211/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69005+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69005+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139595; cv=none; d=zohomail.com; s=zohoarc; b=nwxZeSd3XvU15hNvDiCShcDagUef2ulXT21Q7k8+yi/00u1gBzN3N+si/lt1RF/J4W6a+SNx22mYbLXRoNFQdmQQ2/rRxuJ2/kO91ktKp78wwOKlKEpTRfX/d6tvmFpLyWLgixTpA8kh7/Figy1TFdGl0laKX/MY/eZwQTJRHXo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139595; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=S2QanGKK27sEQpsdNMtL2fnNO0R9/plVX7u7+4pslaw=; b=N/fWLf04FixM4T7ym5xVSn4eJLHUSuwbW2GQM9rywvFYaonkDAyGZd432d2dutmVo1w587UMPFAvXV7qRbKAWKRfK4gRLR1r1g6DV1lCIk17h3lLVD6sWtQPYkdk4ZzrlTQPkKcZVLmrvnxfYnwxCOmeNEZJ9EjwOZeMQ6385p8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69005+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139595706437.67811990055964; Wed, 16 Dec 2020 09:26:35 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 4jD8YY1788612xgYdNZIT2i8; Wed, 16 Dec 2020 09:26:32 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.53.1608139373255185139 for ; Wed, 16 Dec 2020 09:22:53 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EA00ED6E; Wed, 16 Dec 2020 09:22:52 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D04473F66E; Wed, 16 Dec 2020 09:22:51 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 22/25] ArmPkg: Fix Ecc error 5007 in SemiHostingSerialPortLib Date: Wed, 16 Dec 2020 17:21:57 +0000 Message-Id: <20201216172200.25846-23-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: mn4BSO5BEgqNQraA6n3Q1tyBx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139592; bh=64m047JZyiHPegqm45BZAnhh1c2kSikQzgXNQYpE664=; h=Cc:Date:From:Reply-To:Subject:To; b=faO1Q9fDxYP4jLkWchTAnrFJBpf1nY1dF3YrqTd9wBP/W9q4OKj9l8q9mYPUNCRltZa Pi9EsCNbQkjNSzj/rVK0MIGcp3QCmojN8Q1zsDoBXMxLHcNE5kwTt9NPhuFXXIZ9BQ2No M1VQMnmdAOp1agCdBb57L40/P/dt3Uf2olo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c b/ArmP= kg/Library/SemiHostingSerialPortLib/SerialPortLib.c index 7e5c61fad4bd..2973d107a323 100644 --- a/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c +++ b/ArmPkg/Library/SemiHostingSerialPortLib/SerialPortLib.c @@ -2,6 +2,7 @@ Serial I/O Port library functions with no library constructor/destructor Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
+ Copyright (c) 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -55,10 +56,13 @@ SerialPortWrite ( ) { UINT8 PrintBuffer[PRINT_BUFFER_SIZE]; - UINTN SourceIndex =3D 0; - UINTN DestinationIndex =3D 0; + UINTN SourceIndex; + UINTN DestinationIndex; UINT8 CurrentCharacter; + SourceIndex =3D 0; + DestinationIndex =3D 0; + while (SourceIndex < NumberOfBytes) { CurrentCharacter =3D Buffer[SourceIndex++]; -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69005): https://edk2.groups.io/g/devel/message/69005 Mute This Topic: https://groups.io/mt/79006212/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69006+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69006+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139613; cv=none; d=zohomail.com; s=zohoarc; b=NusuYeCWTDXOHs/XNpuHfGip87WTxqvGLEp1SskAnSyEM0tnX+eJxYE2znUos9XdshIOQfeM5J/v63kOMRdciS9fMLn7KQB1OEXMsNrTGeecfkoGYOembiClBr3Dg7Zgv21B0jCqBArg2T3YRO3nUKyHAh8GbepfPaMX+/y5glo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139613; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=7oxzBBFcDeenM8F9pEDJBX2ueg3SnL4B33mUYqSuQYk=; b=PfevZLwVrB2xJXnMCS/3ldKT87tx03/MgFb62f+boCeb2MCXSYwyjuCuRWT6AuxAwT3yfeQaXRKusm1pMPfEBCt98d8+Vk9ET/NOaapTMjb3czqdELGuQmrs8M0e2dnlp08t+0di4lWFl0APLsX+8Meo4zSe2/O19UPTB+z0gIg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69006+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139613448748.5756160860701; Wed, 16 Dec 2020 09:26:53 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id zlpcYY1788612xBLN9pjsDQH; Wed, 16 Dec 2020 09:26:50 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.65.1608139374397376618 for ; Wed, 16 Dec 2020 09:22:54 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 247CD1FB; Wed, 16 Dec 2020 09:22:54 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4660B3F66E; Wed, 16 Dec 2020 09:22:53 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 23/25] ArmPkg: Fix Ecc error 5007 in SemihostLib Date: Wed, 16 Dec 2020 17:21:58 +0000 Message-Id: <20201216172200.25846-24-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: Fi259QhDTPq6UWXw6afRcRcax1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139610; bh=YSGOdV2PoibAaqs7potuR5LfEwmWJfd3WPeBdGbmiJE=; h=Cc:Date:From:Reply-To:Subject:To; b=RK6nw5K4CQmEaCWmy8kqDjdCyYQG13osrELpMkQRrvZHSPFCMwYoS+fHiARp58bxPoU nkapGVpgXqXX0/+4ktkONRfDfaLbdtMsh4Eir6fsSmlNMqLRojEdPpWC8zT8bSJxvV/D2 IpjoljrVbF7L9wG1eofyJkNr+Fu5ASTYoxY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 ArmPkg/Library/SemihostLib/SemihostLib.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Library/SemihostLib/SemihostLib.c b/ArmPkg/Library/Semi= hostLib/SemihostLib.c index 78b862468b10..481c46fc24f7 100644 --- a/ArmPkg/Library/SemihostLib/SemihostLib.c +++ b/ArmPkg/Library/SemihostLib/SemihostLib.c @@ -1,7 +1,7 @@ /** @file Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Copyright (c) 2013 - 2014, ARM Ltd. All rights reserved.
+ Copyright (c) 2013 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -135,9 +135,7 @@ SemihostFileClose ( IN UINTN FileHandle ) { - INT32 Result =3D Semihost_SYS_CLOSE(&FileHandle); - - if (Result =3D=3D -1) { + if (Semihost_SYS_CLOSE (&FileHandle) =3D=3D -1) { return RETURN_INVALID_PARAMETER; } else { return RETURN_SUCCESS; -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69006): https://edk2.groups.io/g/devel/message/69006 Mute This Topic: https://groups.io/mt/79006214/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69007+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69007+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139606; cv=none; d=zohomail.com; s=zohoarc; b=jt4PC3fKjeD+yJx9bDN/Vi04TqXxp2jcIbDaKo7cAHuG3EFpGkb7xiUVzr2Fp4kbyr68u5PWODiymo/+pnVHM13dXUfm2UVGfO35mE9afTzDiyoMdogXNJ1DhmNgnAtv0qeaN+ytFOeMt4lBP+ix2j570i/u1pLODT0NA+7G2RE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139606; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=FzdbFKAmFNZC/KFpT/+vQ/f7e4jcKA+Fnr76g4V0i9U=; b=CAm/YMosoOrLx3Wdd/5hBB8ApF/9UcL0heKSuHUc/reomXHpj4dCKwJWKkoHmyctc6nJJ5VmuC30kLiqzG5igAJOVN2H3AE8v5teuhKon8gKtmol1TfxdYVm2QTTJrUbXuxm5SD7ULWKEzVRe9vG3xvM2Jz6MtxzDqAdAzn3pnE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69007+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139606784800.2256888897602; Wed, 16 Dec 2020 09:26:46 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id ILDxYY1788612x7xFwIgpwLk; Wed, 16 Dec 2020 09:26:43 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.76.1608139376113031139 for ; Wed, 16 Dec 2020 09:22:56 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D1B061FB; Wed, 16 Dec 2020 09:22:55 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7DABB3F66E; Wed, 16 Dec 2020 09:22:54 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 24/25] ArmPkg: Fix Ecc error 5007 in StandaloneMmMmuLib Date: Wed, 16 Dec 2020 17:21:59 +0000 Message-Id: <20201216172200.25846-25-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: l49P3MD0mkW7FqVwuFP23Id7x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139603; bh=3CoTI7FkLqz/1IZwxR/geHRM1OhTuDtbQ0GMf4PMN1o=; h=Cc:Date:From:Reply-To:Subject:To; b=ae1JEI1eDa9aPAbHD7MjqRe4ZDooLTOvbXsND4OQTA1D46dCBFcIRoW72dpJvX0pqyw OFoVapZ2nB2y0CdX+UmoThM9pPm1GNhe+jlm/2NUBoNNGuTacoRKEWyxD4cyEx/nW7rM5 9DUIEWJaUtUbMgzAJru+e/HnWvNBlYzUQO4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 .../AArch64/ArmMmuStandaloneMmLib.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLi= b.c b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c index 3806490f7006..0b64e3384e6d 100644 --- a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c +++ b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c @@ -1,7 +1,7 @@ /** @file * File managing the MMU for ARMv8 architecture in S-EL0 * -* Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. +* Copyright (c) 2017 - 2020, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -14,6 +14,7 @@ #include #include #include +#include #include STATIC @@ -23,12 +24,12 @@ GetMemoryPermissions ( OUT UINT32 *MemoryAttributes ) { - ARM_SVC_ARGS GetMemoryPermissionsSvcArgs =3D {0}; + ARM_SVC_ARGS GetMemoryPermissionsSvcArgs; + + ZeroMem (&GetMemoryPermissionsSvcArgs, sizeof (ARM_SVC_ARGS)); GetMemoryPermissionsSvcArgs.Arg0 =3D ARM_SVC_ID_SP_GET_MEM_ATTRIBUTES_AA= RCH64; GetMemoryPermissionsSvcArgs.Arg1 =3D BaseAddress; - GetMemoryPermissionsSvcArgs.Arg2 =3D 0; - GetMemoryPermissionsSvcArgs.Arg3 =3D 0; ArmCallSvc (&GetMemoryPermissionsSvcArgs); if (GetMemoryPermissionsSvcArgs.Arg0 =3D=3D ARM_SVC_SPM_RET_INVALID_PARA= MS) { @@ -49,7 +50,9 @@ RequestMemoryPermissionChange ( ) { EFI_STATUS Status; - ARM_SVC_ARGS ChangeMemoryPermissionsSvcArgs =3D {0}; + ARM_SVC_ARGS ChangeMemoryPermissionsSvcArgs; + + ZeroMem (&ChangeMemoryPermissionsSvcArgs, sizeof (ARM_SVC_ARGS)); ChangeMemoryPermissionsSvcArgs.Arg0 =3D ARM_SVC_ID_SP_SET_MEM_ATTRIBUTES= _AARCH64; ChangeMemoryPermissionsSvcArgs.Arg1 =3D BaseAddress; -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69007): https://edk2.groups.io/g/devel/message/69007 Mute This Topic: https://groups.io/mt/79006215/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 14:32:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+69008+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69008+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1608139618; cv=none; d=zohomail.com; s=zohoarc; b=IBwgvoXJd2mMNpajRHe9eIM7FlsZoNhBLtlNqST5846rbebsYNgD2cGnlfe3+3r5h/3wxHJbnzcY7TQVyWmYL49GZD2rxGvZ2Mk07ZbUR6A9B3KTxnQlqU+ZoSENN5x8vIp0mWtuVB6RFmriDGxREpaVTlnST05icrQxQ5jly/w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608139618; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=/j7JWVhoAsT4fBPvk4Hcbm8/KK41a+3P0FBhtwdSChg=; b=NHQn7ov6Zw9/dKIR83Y0Q46y+CmLYdxAks/mZzDIVFtGX6ITvevHBt/FbiNpYBciVRRXTSxKZmFe0n9OyzBQeh1/1aGvYOZB5sslHkkl4akAeNmMTHE9jbblqr6bTAhiPmHyuw6ruWtGq3KYvNZJeM8vaYom6A33XwMfAd7Q8yw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+69008+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608139618739503.8862819542485; Wed, 16 Dec 2020 09:26:58 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id aJpSYY1788612xMDdMN3cs5Q; Wed, 16 Dec 2020 09:26:54 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.69.1608139377746662088 for ; Wed, 16 Dec 2020 09:22:57 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 795791FB; Wed, 16 Dec 2020 09:22:57 -0800 (PST) X-Received: from e120189.arm.com (unknown [10.57.25.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3E2383F66E; Wed, 16 Dec 2020 09:22:56 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 25/25] ArmPkg: Fix Ecc error 5007 in DefaultExceptionHandlerLib Date: Wed, 16 Dec 2020 17:22:00 +0000 Message-Id: <20201216172200.25846-26-Pierre.Gondois@arm.com> In-Reply-To: <20201216172200.25846-1-Pierre.Gondois@arm.com> References: <20201216172200.25846-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: Jn4ehuMiqQfSL5hyRaTSRObix1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608139614; bh=d1dP38AkmPguDMS/iTfJVN2ysWHpkydJfAn/cFemJBc=; h=Cc:Date:From:Reply-To:Subject:To; b=pdazPO6EUbH4D92tS6bfY7C3Y2opdb5Qxqb3gRm9idk0yUDZQ/T0UBs+B65QqpvvFUZ bIhNmQipuRlQcEzwZBf4Tb32UH4Pz5AXFfiEjWvQJERcCl2AClGH1YfCrCPWg0p7r9Uiu 0icNkH7L62sPfz2SNNdju5MqXjLonQj29Mg= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Fixing this error implies extracting the CpsrChar array from CpsrString and making it a static variable. Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/commits/1552_= Ecc_ArmPkg_v1 .../Arm/DefaultExceptionHandler.c | 41 ++++++++++--------- 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultException= Handler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionH= andler.c index fa9af8c410b9..ad205a5a1ebf 100644 --- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler= .c +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler= .c @@ -2,7 +2,7 @@ Default exception handler Copyright (c) 2008 - 2010, Apple Inc. All rights reserved.
- Copyright (c) 2012, ARM Ltd. All rights reserved.
+ Copyright (c) 2012 - 2020, Arm Ltd. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -34,6 +34,20 @@ typedef struct { CHAR8 Char; } CPSR_CHAR; +STATIC CONST CPSR_CHAR mCpsrChar[] =3D { + { 31, 'n' }, + { 30, 'z' }, + { 29, 'c' }, + { 28, 'v' }, + + { 9, 'e' }, + { 8, 'a' }, + { 7, 'i' }, + { 6, 'f' }, + { 5, 't' }, + { 0, '?' } +}; + CHAR8 * GetImageName ( IN UINTN FaultAddress, @@ -45,7 +59,7 @@ GetImageName ( Convert the Current Program Status Register (CPSR) to a string. The stri= ng is a defacto standard in the ARM world. - It is possible to add extra bits by adding them to CpsrChar array. + It is possible to add extra bits by adding them to mCpsrChar array. @param Cpsr ARM CPSR register value @param ReturnStr CPSR_STRING_SIZE byte string that contains string @@ -61,25 +75,12 @@ CpsrString ( UINTN Index; CHAR8* Str; CHAR8* ModeStr; - CPSR_CHAR CpsrChar[] =3D { - { 31, 'n' }, - { 30, 'z' }, - { 29, 'c' }, - { 28, 'v' }, - - { 9, 'e' }, - { 8, 'a' }, - { 7, 'i' }, - { 6, 'f' }, - { 5, 't' }, - { 0, '?' } - }; Str =3D ReturnStr; - for (Index =3D 0; CpsrChar[Index].BIT !=3D 0; Index++, Str++) { - *Str =3D CpsrChar[Index].Char; - if ((Cpsr & (1 << CpsrChar[Index].BIT)) !=3D 0) { + for (Index =3D 0; mCpsrChar[Index].BIT !=3D 0; Index++, Str++) { + *Str =3D mCpsrChar[Index].Char; + if ((Cpsr & (1 << mCpsrChar[Index].BIT)) !=3D 0) { // Concert to upper case if bit is set *Str &=3D ~0x20; } @@ -186,7 +187,9 @@ DefaultExceptionHandler ( UINT32 DfsrStatus; UINT32 IfsrStatus; BOOLEAN DfsrWrite; - UINT32 PcAdjust =3D 0; + UINT32 PcAdjust; + + PcAdjust =3D 0; CharCount =3D AsciiSPrint (Buffer,sizeof (Buffer),"\n%a Exception PC at = 0x%08x CPSR 0x%08x ", gExceptionTypeString[ExceptionType], SystemContext.SystemContextA= rm->PC, SystemContext.SystemContextArm->CPSR); -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#69008): https://edk2.groups.io/g/devel/message/69008 Mute This Topic: https://groups.io/mt/79006217/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-