From nobody Mon Feb 9 06:54:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68916+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68916+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1608080617; cv=none; d=zohomail.com; s=zohoarc; b=JT903577JOX+BzjpbcoWlr21D1rpj+dyuVoBAOO1jMFX72mzFJhHY/75eYZwb4H0vumWp2ZJlqQR5rK0qLErt08nIVQ0Mtrs6VIVUCmFHv8sgbDFowJzORzfvRzqlnIoPM+nGCadVrjF+pok3SlfIbu36oZlScptFNF/ZmbQ9yc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608080617; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=ZC/DKM+duNcZKxUFao1G3NI40AocTfe/U74MRv1lQFA=; b=BioYl/ULBuYrO6gNlHLWtW1OsHPyocBttYi8mNwHNZYggnbk59LWvxRtHpqvJFdRVKpg7H/als48kH5IS+2ACR9DJgLOYejgn0hwo4jF/4h1O6BhWkrPt+wPgUrPEReCym5/+YRDeluU6IvORr/KCGTNuwPifMf3uNWNxUaamw4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68916+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1608080616970799.6435278733311; Tue, 15 Dec 2020 17:03:36 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id UmJhYY1788612xEA3Y2Akef5; Tue, 15 Dec 2020 17:03:36 -0800 X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.544.1608080615001746946 for ; Tue, 15 Dec 2020 17:03:36 -0800 X-Received: from localhost.localdomain ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 16 Dec 2020 09:03:30 +0800 X-WM-Sender: fengyunhua@byosoft.com.cn From: "fengyunhua" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Yuwei Chen Subject: [edk2-devel] [PATCH] BaseTools: Should always define PCD TOKEN value as Zero for static PCD Date: Wed, 16 Dec 2020 09:03:01 +0800 Message-Id: <20201216010301.2467-1-fengyunhua@byosoft.com.cn> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,fengyunhua@byosoft.com.cn X-Gm-Message-State: 1WGayxUo1HFrzbTuyY8sQOBCx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1608080616; bh=V+rTsitdUdldoxjUJnJ6oOSILlOATNkEN4LJgEwKOC8=; h=Cc:Date:From:Reply-To:Subject:To; b=RKVNgKf7jbim+45tbusCC4VeTCOVbnG84dWj7V4dVDi5BUaJ1k5HfgZl2ZNOABZiS8w ab8a1yN5eKQlOF9oCO/VtOVk0b8AHnHcP+VSw3n9r7ZEo2TPQyTiRj1QM8MK+h9uG2HDc qJPsodbl76W3LZmU8yhcUFQ0gbfTog1vLXA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3120 FixedAtBuild, PatchableInModule and FeatureFlag PCD don't use PCD TOKEN. Their PCD TOKEN value can always be zero. If so, AutoGen.h will not be changed when PCD is added or removed. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/AutoGen/GenC.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/BaseTools/Source/Python/AutoGen/GenC.py b/BaseTools/Source/Pyt= hon/AutoGen/GenC.py index a2053d5485..ac561ba82e 100755 --- a/BaseTools/Source/Python/AutoGen/GenC.py +++ b/BaseTools/Source/Python/AutoGen/GenC.py @@ -913,6 +913,8 @@ def CreateModulePcdCode(Info, AutoGenC, AutoGenH, Pcd): ExtraData=3D"[%s]" % str(Info)) else: TokenNumber =3D PcdTokenNumber[Pcd.TokenCName, Pcd.TokenSpaceG= uidCName] + if Pcd.Type not in PCD_DYNAMIC_TYPE_SET: + TokenNumber =3D 0 AutoGenH.Append('\n#define %s %dU\n' % (PcdTokenName, TokenNumber= )) =20 EdkLogger.debug(EdkLogger.DEBUG_3, "Creating code for " + TokenCName += "." + Pcd.TokenSpaceGuidCName) --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68916): https://edk2.groups.io/g/devel/message/68916 Mute This Topic: https://groups.io/mt/78990854/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-