From nobody Fri May 17 23:05:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68748+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68748+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1607910241; cv=none; d=zohomail.com; s=zohoarc; b=JQUM9uwmjGxiiGxB9Je2MIhybzmGsaIjBie0QiY3B4+RRdc4LE3NJrozox6Ea3R3pcPn32iW3By3cVkDHmyijoHc4GMV46Mg6LxhUSLDzWYnqCrHAZ7+uw8KpQFGEOdLUWslBTb94AR9sFTch7SqFCUcjQhL81nV/q6+9U5pYoY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607910241; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=9avLDo/2TKL8llhIikDH2hCOKw608PJYzKLyeVsztQ8=; b=QS+qVsWtmp0xAEMl6X4sIrQBaXqX2SRQx8l8q1XeIuQZ6HFr0/sLokUfgGtMD+jG/cC7iE82cS1GJtgcAIHZQvTRP7U0pd162a/qln7YnR/2lui2r7EGmXTKGXo197p0uXUT9oKfZROL7eszaspYWtncq13YuXluAwTvWyMmXFM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68748+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 160791024121659.577363370600324; Sun, 13 Dec 2020 17:44:01 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id RU85YY1788612xgez3E7DK17; Sun, 13 Dec 2020 17:44:00 -0800 X-Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web08.28362.1607910240423938282 for ; Sun, 13 Dec 2020 17:44:00 -0800 IronPort-SDR: h3MWtKsA43DjdONiKW445FXID7pJAhp0VyiV1n6p4R21gBSORdxDYNp8rrc9lb1crScUsbcDOd Y2Oy02aVhejA== X-IronPort-AV: E=McAfee;i="6000,8403,9834"; a="236230099" X-IronPort-AV: E=Sophos;i="5.78,417,1599548400"; d="scan'208";a="236230099" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2020 17:43:57 -0800 IronPort-SDR: odATo7pzNobrTx2Y/iD0Et99IOdpzkNNOdl96VQzIzXGOChcXh/nnhcYoVskUyZh7F/F8dMBTg njPZWZFx863Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,417,1599548400"; d="scan'208";a="331624901" X-Received: from hengluo-dev.ccr.corp.intel.com ([10.239.153.154]) by fmsmga008.fm.intel.com with ESMTP; 13 Dec 2020 17:43:56 -0800 From: "Heng Luo" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone Subject: [edk2-devel] [Patch V2] WhiskeylakeOpenBoardPkg: Add USB DCI debug suport Date: Mon, 14 Dec 2020 09:43:52 +0800 Message-Id: <20201214014352.1087-1-heng.luo@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,heng.luo@intel.com X-Gm-Message-State: dOu6FiiYydcGrWkS0BWhHLupx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607910240; bh=gwt0DmVKqekfDG625Nihcjd72NaNIkh1BtaR1pVm6Mw=; h=Cc:Date:From:Reply-To:Subject:To; b=lzsUpJT74tibmVF7rdtY4v5jJiraeL/YuU6vtio8E7CaKuCpuHAMpWA5qmkYzJp6nPv V/uFOKj4ZZu//t/VpBaTboRplnU63lvTwJnUpJcawszgQwMdX2JiN0Ugf8qJZvNyM7Xj3 lYBVSBMLLBQKV0SkZLC5rN5WiGOl+iM9wdU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3081 Add gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable for USB DCI debug feature, feature is enabled if PcdDciEnable is TRUE, it allows to debug BIOS via DCI cable. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Heng Luo Reviewed-by: Nate DeSimone --- Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec = | 1 + Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/P= eiPchPolicyUpdatePreMem.c | 8 +++++++- Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/P= eiPolicyUpdateLib.inf | 4 ++++ Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc = | 2 ++ Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPcd.dsc= | 2 ++ 5 files changed, 16 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec b/Plat= form/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec index fbb9549e44..196460e170 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec @@ -554,6 +554,7 @@ gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdNCT6776FHWMON= | [PcdsDynamicEx] =20 [PcdsDynamic, PcdsDynamicEx] +gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable |FALSE|BOOLE= AN|0x20000001 =20 [PcdsPatchableInModule] =20 diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolic= yUpdateLib/PeiPchPolicyUpdatePreMem.c b/Platform/Intel/WhiskeylakeOpenBoard= Pkg/Policy/Library/PeiPolicyUpdateLib/PeiPchPolicyUpdatePreMem.c index 2d48b09175..bb34f89fb5 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPchPolicyUpdatePreMem.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPchPolicyUpdatePreMem.c @@ -83,7 +83,13 @@ UpdatePeiPchPolicyPreMem ( Status =3D GetConfigBlock ((VOID *) SiPreMemPolicy, &gIshPreMemConfigGui= d, (VOID *) &IshPreMemConfig); ASSERT_EFI_ERROR (Status); =20 - DciPreMemConfig->DciUsb3TypecUfpDbg =3D 2; + if (PcdGetBool (PcdDciEnable)) { + DciPreMemConfig->PlatformDebugConsent =3D 3; + DciPreMemConfig->DciUsb3TypecUfpDbg =3D 1; + } else { + DciPreMemConfig->DciUsb3TypecUfpDbg =3D 2; + } + PchTraceHubPreMemConfig->MemReg0Size =3D 3; PchTraceHubPreMemConfig->MemReg1Size =3D 3; // diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolic= yUpdateLib/PeiPolicyUpdateLib.inf b/Platform/Intel/WhiskeylakeOpenBoardPkg/= Policy/Library/PeiPolicyUpdateLib/PeiPolicyUpdateLib.inf index 478e2d0512..252f92f487 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPolicyUpdateLib.inf +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPolicyUpdateLib.inf @@ -230,6 +230,9 @@ =20 gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdEcPresent =20 + # Enable/Disable USB DCI Debug + gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable = ## CONSUMES + gIntelSiliconPkgTokenSpaceGuid.PcdIntelGraphicsVbtFileGuid = ## CONSUMES gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdSmbusAlertEnable = ## CONSUMES gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdSataLedEnable = ## CONSUMES @@ -243,6 +246,7 @@ gEfiMdeModulePkgTokenSpaceGuid.PcdSystemFmpCapsuleImageTypeIdGuid ## C= ONSUMES gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber ## C= ONSUMES =20 + [FixedPcd] gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize ## CO= NSUMES gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiNvsMemorySize ## CO= NSUMES diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPc= d.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc index e161bf06f4..84d4ec1331 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkgPcd.dsc @@ -399,6 +399,8 @@ gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3Tbt|0x1 gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3TbtClkReq|0x1 =20 + gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable|FALSE + [PcdsDynamicHii.X64.DEFAULT] ###################################### # Edk2 Configuration diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoa= rdPkgPcd.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenB= oardPkgPcd.dsc index 83ada3c95c..4a7ba4d5f0 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPc= d.dsc +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPc= d.dsc @@ -389,6 +389,8 @@ gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3Tbt|0x1 gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdRtd3TbtClkReq|0x1 =20 + gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDciEnable|FALSE + [PcdsDynamicHii.X64.DEFAULT] ###################################### # Edk2 Configuration --=20 2.24.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68748): https://edk2.groups.io/g/devel/message/68748 Mute This Topic: https://groups.io/mt/78941913/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-