From nobody Mon Feb 9 14:34:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68743+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68743+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1607905944; cv=none; d=zohomail.com; s=zohoarc; b=UpvcSq/+ve3jNUYiVW9kSgfGbP/LnfKxZiJwKpkI2fyQUvhL0IXFxD8K8ks1CY9ojGXTPwDRI+55AYJHuyy+GXf8QdvPPkNkYwGU05JmiTjj2U2/Dcj+m+BF4dtxqbwIqlj62ZWxKju2aC1Rg48Sbez7S0Z71tA/01GdFXCodt4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607905944; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=VjNQAfYvAPuP+eycGUcQYTO3v8ZAa4LwbgmhXIdL4gA=; b=UjQawTD3nLetx0sj9fFsc/svIuJ74PWRbiT/aC2p/6hxcCSSWX/dcJBq3o/OrES9fnMvoBUmAf2736X0g+aAQsuMAhBzBufq5S/ilvq43JaeLz55HNx2DwtCftnzknYy6rDNaGbjKfAo5C0sGOCdC8Ca5SrAJ+Uu3smGFMkimTE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68743+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607905944475245.67863128432737; Sun, 13 Dec 2020 16:32:24 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id tqfJYY1788612xhyFlCbrAGc; Sun, 13 Dec 2020 16:32:24 -0800 X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.27470.1607905942449770899 for ; Sun, 13 Dec 2020 16:32:22 -0800 X-Received: from localhost.localdomain ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 14 Dec 2020 08:32:20 +0800 X-WM-Sender: fengyunhua@byosoft.com.cn From: "fengyunhua" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Yuwei Chen Subject: [edk2-devel] [PATCH] BaseTools/Scripts: Check for added newline at end of file Date: Mon, 14 Dec 2020 08:32:00 +0800 Message-Id: <20201214003200.1252-1-fengyunhua@byosoft.com.cn> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,fengyunhua@byosoft.com.cn X-Gm-Message-State: Pb67XFw0Yv10nvdeuiktm9Yax1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607905944; bh=Ljzup/zrmIfm7WRG27uMPMeOjIspKYNtvv3AkdqmGUA=; h=Cc:Date:From:Reply-To:Subject:To; b=bf23KKZHnfYGjbi/Ub6aWqY2n2TJ2AwZlwDSK0CdYbD0RGKGjum6Qohy8TkB3f1KRra 0ZId7XGeC1vQ3/vHZUoS7PukxpPWJanFExtnCahAe1d0/XXI5KxcqDPaf/0aFoUAHZy2g 5SxVPl8qHyxl49/bnOVk3ZWuXI5HAXLSQx4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2685 Adding blank lines at end of file is bad enough practice that git complains about it when importing patches (with git am): .git/rebase-apply/patch:105: new blank line at EOF. + warning: 1 line adds whitespace errors. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Yunhua Feng --- BaseTools/Scripts/PatchCheck.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 68c984ed0e..1859cdc580 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -316,6 +316,8 @@ class GitDiffCheck: self.new_bin =3D [] while self.line_num < self.count and self.format_ok: line_num =3D self.line_num + if line_num =3D=3D self.count - 1 and self.lines[line_num].str= ip() =3D=3D '+': + self.format_error('New blank line at EOF.') self.run() assert(self.line_num > line_num) self.report_message_result() --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68743): https://edk2.groups.io/g/devel/message/68743 Mute This Topic: https://groups.io/mt/78940455/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-