From nobody Sat May 4 18:57:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68316+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68316+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607052092; cv=none; d=zohomail.com; s=zohoarc; b=APyYa2CJdtleWmCGyPW5AK/E5brAey93wB4dW5O4shZYzesI7LUZq21CcriPxrGj/PoGF1nE+o8sgsbSOalJyHazEZGAjUGONkKAZSfhf5pROcwf6FGPd8KRGv03uVGmrqqhiCH5Coi+6ub3POR/XOI3DgIkU6F4SmkACoFIYBA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607052092; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=a6SQnYuzMDhLQeulapbU+4j0dd0QtWoTu6K4VH+mOJ0=; b=R7efWmEugN52n3UvBc+eymDA6R8y6B5Z/2OR58sHILNfCCN2wsfqolXF5hHD8kHUYREGZPPnyetNgIRudu6DVS9LLSkB6leKjCcnmrmWgS7t6M5mR1yGIYDyRYAjXteafFGsgjX2a8NsYOEkIH+RmiiFJ/tZVxcfaGYHsZt2SRw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68316+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607052092305299.56647523136326; Thu, 3 Dec 2020 19:21:32 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id r2kgYY1788612xRsIpW0Du37; Thu, 03 Dec 2020 19:21:31 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web09.9306.1607052090192004598 for ; Thu, 03 Dec 2020 19:21:30 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-47-cs9DaVRhNIyc31XXAPUs3w-1; Thu, 03 Dec 2020 22:21:23 -0500 X-MC-Unique: cs9DaVRhNIyc31XXAPUs3w-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EFD978030A0; Fri, 4 Dec 2020 03:21:21 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-157.ams2.redhat.com [10.36.114.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C71F1A4D0; Fri, 4 Dec 2020 03:21:20 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , James Bottomley , Jordan Justen , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Tom Lendacky Subject: [edk2-devel] [PATCH 1/2] OvmfPkg: start using the ECC plugin exception list Date: Fri, 4 Dec 2020 04:21:15 +0100 Message-Id: <20201204032116.31321-2-lersek@redhat.com> In-Reply-To: <20201204032116.31321-1-lersek@redhat.com> References: <20201204032116.31321-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: XraobWbzIO4tZqmJA3zNRhlTx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607052091; bh=a6SQnYuzMDhLQeulapbU+4j0dd0QtWoTu6K4VH+mOJ0=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=YyKZ5dB/2G5bqckME8a0C//ngBAJrF5lK2Cbh0juWstE/9bgUYvCG12YwcaFDJf1tmv 51lJsd4S+m8P77gCWNRXoizs5gpoVEVElgTsUVt1oHQvlpiEfij4iuNV37nKSFd6b1eoj NB/Y+trOAXoKRyvQjCssour6u5E9J0sVaF8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" In the recent past, ECC has wreaked havoc at least twice: - rejected Tom Lendacky's perfectly valid and clean code: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3008#c5 https://edk2.groups.io/g/devel/message/67097 - rejected James Bottomley's series for bogus reasons: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3077#c4 https://edk2.groups.io/g/devel/message/68302 There isn't capacity to improve ECC: - Liming filed an ECC bug about the first case noted above, but it has received no feedback in 25 days (as of this writing): https://bugzilla.tianocore.org/show_bug.cgi?id=3D3060 And running CI or ECC on developer machines is difficult: - I had to set up a separate VM for it, - Shenglei gave Windows-based usage instructions only, https://edk2.groups.io/g/devel/message/61966 - experimenting with a CI outside of a VM is somewhat risky: https://github.com/tianocore/edk2-pytool-extensions/issues/231 ECC should be considered an experimental tool; I agreed to its enablement in CI specifically because we were offered an exception list: https://edk2.groups.io/g/devel/message/60961 https://www.redhat.com/archives/edk2-devel-archive/2020-June/msg00473.html The github.com-based pull request process is already very inefficient for both contributors and maintainers; it's time to put the ECC exception list to use. Now, I've tried adding those error codes that were reported against James's series (after evaluating each entry in the report at ), namely 4001, 4002, 5007, 8001, 8004, 8005. However, to my horror, "EccCheck.ExceptionList" only supports the following format: "", "", "", "", ... where each pair binds a particular error ID to a particular "offending" identifier, such as C variable name. There is no wildcard support, so it's impossible to disable entire classes of ECC reports. Therefore, I have to use "EccCheck.IgnoreFiles". It also doesn't support the "." subdirectory or the "*" wildcard. But, with some sweat, I can still use it to disable ECC for all of OvmfPkg. Cc: Ard Biesheuvel Cc: James Bottomley Cc: Jordan Justen Cc: Philippe Mathieu-Daud=C3=A9 Cc: Tom Lendacky Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel --- OvmfPkg/OvmfPkg.ci.yaml | 49 ++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/OvmfPkg/OvmfPkg.ci.yaml b/OvmfPkg/OvmfPkg.ci.yaml index 3128aefe9ed1..68d2de704d19 100644 --- a/OvmfPkg/OvmfPkg.ci.yaml +++ b/OvmfPkg/OvmfPkg.ci.yaml @@ -22,6 +22,55 @@ ], ## Both file path and directory path are accepted. "IgnoreFiles": [ + "8254TimerDxe", + "8259InterruptControllerDxe", + "AcpiPlatformDxe", + "AcpiTables", + "AmdSev", + "AmdSevDxe", + "Bhyve", + "CompatImageLoaderDxe", + "CpuHotplugSmm", + "CpuS3DataDxe", + "Csm", + "EmuVariableFvbRuntimeDxe", + "EnrollDefaultKeys", + "Include", + "IncompatiblePciDeviceSupportDxe", + "IoMmuDxe", + "Library", + "LinuxInitrdDynamicShellCommand", + "LsiScsiDxe", + "MptScsiDxe", + "OvmfXenElfHeaderGenerator.c", + "PciHotPlugInitDxe", + "PlatformDxe", + "PlatformPei", + "PvScsiDxe", + "QemuFlashFvbServicesRuntimeDxe", + "QemuKernelLoaderFsDxe", + "QemuRamfbDxe", + "QemuVideoDxe", + "SataControllerDxe", + "Sec", + "SioBusDxe", + "SmbiosPlatformDxe", + "SmmAccess", + "SmmControl2Dxe", + "Tcg", + "Virtio10Dxe", + "VirtioBlkDxe", + "VirtioGpuDxe", + "VirtioNetDxe", + "VirtioPciDeviceDxe", + "VirtioRngDxe", + "VirtioScsiDxe", + "XenBusDxe", + "XenIoPciDxe", + "XenIoPvhDxe", + "XenPlatformPei", + "XenPvBlkDxe", + "XenTimerDxe" ] }, ## options defined .pytool/Plugin/CompilerPlugin --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68316): https://edk2.groups.io/g/devel/message/68316 Mute This Topic: https://groups.io/mt/78702238/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 18:57:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68315+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68315+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607052090; cv=none; d=zohomail.com; s=zohoarc; b=HnoVX+jDyoitz2sgSJs+gMGCyjGml/LTSicnM4gVW8dF9UFtuyVOOgDAR+bRJfjhUMulRJVkFmfUv4z2LGofDJGExUbaiz6Dy2vTwALbqxOFoP2PyYmOWR6l/9M0WLFMK3H4fE+6WCe9YnUDYtkxf33kTsWkRDFqYvx2j0qR364= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607052090; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=QwBq3GjHjcMp3iC3CnU9lHncIARqFjU/bbjYK5Em2Y0=; b=FyNF7C52RUTNyqWAfnpov0lLhKiCy1B1kn8L+ubId08gn/Aa0iHNhVqltwcPvGFSaF3EhX3XnsFDk446MWO8GERH/lTdb175ExSSJCvReaTxq/oLM6WxHO/v9mJ29dR1aXcGatQt7b+h4OiDSWqqvu+A2EaXDZf6UK2aEkNlHnY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68315+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16070520908392.8124453149873716; Thu, 3 Dec 2020 19:21:30 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id uentYY1788612xEDsiEZlcTT; Thu, 03 Dec 2020 19:21:30 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.9172.1607052089513807955 for ; Thu, 03 Dec 2020 19:21:30 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-150-EYDtQX8jMWi33qc1zdFPLQ-1; Thu, 03 Dec 2020 22:21:24 -0500 X-MC-Unique: EYDtQX8jMWi33qc1zdFPLQ-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BB5B8858181; Fri, 4 Dec 2020 03:21:23 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-157.ams2.redhat.com [10.36.114.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id 504721A4D0; Fri, 4 Dec 2020 03:21:22 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , James Bottomley , Jordan Justen , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Tom Lendacky Subject: [edk2-devel] [PATCH 2/2] OvmfPkg: add "gGrubFileGuid=Grub" to GuidCheck.IgnoreDuplicates Date: Fri, 4 Dec 2020 04:21:16 +0100 Message-Id: <20201204032116.31321-3-lersek@redhat.com> In-Reply-To: <20201204032116.31321-1-lersek@redhat.com> References: <20201204032116.31321-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: z70eqaCwd3ZUwCQzGt9JaWFix1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607052090; bh=QwBq3GjHjcMp3iC3CnU9lHncIARqFjU/bbjYK5Em2Y0=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=EJKSda8IAlGa/hPgZp3TTCMDrv3mfNN3zHaklYkorMozbcu0YeWf1Wt4VebU4YCxfxQ uYm6J6iYERw41N6qk7UCHvZE4qJi6+j6RsZdEsW+e21UaUzprpR0ztO18UwqY6TsFZKxj pR9TJsqhxSHD68vivt4KGhP+ZxIb52P/Yro= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The patch series linked at https://bugzilla.tianocore.org/show_bug.cgi?id=3D3077#c4 is rejected by GuidCheck with the following error message: > GUID: B5AE312C-BC8A-43B1-9C62-EBB826DD5D07 > NAME: gGrubFileGuid FILE: /home/vsts/work/1/s/OvmfPkg/OvmfPkg.dec > GUID: B5AE312C-BC8A-43B1-9C62-EBB826DD5D07 > NAME: Grub FILE: /home/vsts/work/1/s/OvmfPkg/AmdSev/Grub/Grub.inf This GUID identity is by design in the TianoCore#3077 feature; add a CI exception for it. Cc: Ard Biesheuvel Cc: James Bottomley Cc: Jordan Justen Cc: Philippe Mathieu-Daud=C3=A9 Cc: Tom Lendacky Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daude --- OvmfPkg/OvmfPkg.ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/OvmfPkg.ci.yaml b/OvmfPkg/OvmfPkg.ci.yaml index 68d2de704d19..8e2da2803b30 100644 --- a/OvmfPkg/OvmfPkg.ci.yaml +++ b/OvmfPkg/OvmfPkg.ci.yaml @@ -127,7 +127,7 @@ "IgnoreGuidName": ["ResetVector", "XenResetVector"], # Expected du= plication for gEfiFirmwareVolumeTopFileGuid "IgnoreGuidValue": [], "IgnoreFoldersAndFiles": [], - "IgnoreDuplicates": [], + "IgnoreDuplicates": ["gGrubFileGuid=3DGrub"], }, =20 ## options defined .pytool/Plugin/LibraryClassCheck --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68315): https://edk2.groups.io/g/devel/message/68315 Mute This Topic: https://groups.io/mt/78702237/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-