From nobody Mon Feb 9 22:38:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68267+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68267+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019612; cv=none; d=zohomail.com; s=zohoarc; b=g76EBorxko6V8YV+M7sIckTWZD7ignFQeolGEJd1iZyImApM3NIZ0xnGL6yv79hWsCgwnAlroESJ7RR9qLoiuw0tewkdyzs2O4SaZcunNwbu3j9y2M/qRJCOAQ2LUH1JCt82CyL89jEzSi0Z5Sl6WQGEUP5NETSDY/rZkFJlPxk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019612; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=dwbI9hz2dIL3xrBPQz43UBraoxbj15vEXXvv73BL5dY=; b=Xnte2LjJq1q0OFg0AGZMzkDLsPHbOZ1+/dyJe7jK+WV2KPUAhnglfobng9OBdh5sEVGE2sK77uzw9Kd5VgWJfUT/7WBReUoC1E2nY/BHGvDEo/W0rhmLArNQ4EpDsd6pmHI9kNSpVaHkqp7jfTo6bbQOxnvrJmA4qByXVMIwyLY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68267+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 160701961228965.28296356202236; Thu, 3 Dec 2020 10:20:12 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id EaPGYY1788612xyxOifFexCZ; Thu, 03 Dec 2020 10:20:11 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.861.1607019605851653893 for ; Thu, 03 Dec 2020 10:20:06 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9235A11D4; Thu, 3 Dec 2020 10:20:05 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 571233F575; Thu, 3 Dec 2020 10:20:04 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 04/16] ArmPlatformPkg: Fix Ecc error 5007 in LcdGraphicsOutputDxe Date: Thu, 3 Dec 2020 18:19:33 +0000 Message-Id: <20201203181945.10880-5-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: ODd0EbqZbQPzUVjdWRhY688Qx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019611; bh=Pyb+koEnrkHKF+ZAJm8XWm+T6sVg1YyAxJ83o0G8RWE=; h=Cc:Date:From:Reply-To:Subject:To; b=ieRfGl/gsTpEkMwOa2qBXawdMnuLcmCVWm+xSTzFv1TucWyrPS9G34P71jIzjyfKkkN +G1no9p4YQRZyN5VMO+cgUZbJXkpJnehEakxMQATs4edVU6X7n+jBoAhZCiN9F2ZUEQJU WsXoP2NewClOBtxP0/5YWFIJQxcvfaij2To= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c | 10 ++= +++++--- ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c | 10 ++= +++----- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputB= lt.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c index c865215ec68ecba1e809108cffec9354f042561e..07d2cb0d5dec0f85219fe5cdc43= 8e18ae3a32a38 100644 --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2011-2013, ARM Ltd. All rights reserved.
+ Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -36,7 +36,7 @@ VideoCopyNoHorizontalOverlap ( IN UINTN Height ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; UINTN SourceLine; UINTN DestinationLine; UINTN WidthInBytes; @@ -45,6 +45,8 @@ VideoCopyNoHorizontalOverlap ( VOID *SourceAddr; VOID *DestinationAddr; + Status =3D EFI_SUCCESS; + if( DestinationY <=3D SourceY ) { // scrolling up (or horizontally but without overlap) SourceLine =3D SourceY; @@ -128,7 +130,7 @@ VideoCopyHorizontalOverlap ( IN UINTN Height ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; UINT32 *PixelBuffer32bit; UINT32 *SourcePixel32bit; @@ -143,6 +145,8 @@ VideoCopyHorizontalOverlap ( UINTN SizeIn32Bits; UINTN SizeIn16Bits; + Status =3D EFI_SUCCESS; + switch (BitsPerPixel) { case LCD_BITS_PER_PIXEL_24: diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputD= xe.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c index f1f104858d8ed456089180e6e82bcc54d4b46b62..bfd03d8f84258158e76690cc5a0= d9333f11d67f0 100644 --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c @@ -1,7 +1,7 @@ /** @file This file implements the Graphics Output protocol for Arm platforms - Copyright (c) 2011-2018, ARM Ltd. All rights reserved.
+ Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -102,7 +102,7 @@ InitializeDisplay ( IN LCD_INSTANCE* Instance ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; EFI_PHYSICAL_ADDRESS VramBaseAddress; UINTN VramSize; @@ -148,7 +148,7 @@ LcdGraphicsOutputDxeInitialize ( IN EFI_SYSTEM_TABLE *SystemTable ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; LCD_INSTANCE* Instance; Status =3D LcdIdentify (); @@ -246,7 +246,7 @@ LcdGraphicsQueryMode ( OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION **Info ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; LCD_INSTANCE *Instance; Instance =3D LCD_INSTANCE_FROM_GOP_THIS (This); @@ -296,7 +296,7 @@ LcdGraphicsSetMode ( IN UINT32 ModeNumber ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; EFI_GRAPHICS_OUTPUT_BLT_PIXEL FillColour; LCD_INSTANCE* Instance; LCD_BPP Bpp; -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68267): https://edk2.groups.io/g/devel/message/68267 Mute This Topic: https://groups.io/mt/78690950/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-