From nobody Tue Feb 10 15:46:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68266+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68266+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019610; cv=none; d=zohomail.com; s=zohoarc; b=aDZnabjo0uH9s88zl6zhxd2jTsTp40uGUTBlyFFzSSowyVFZrO9IAhbxubd35yeGmVEnGrWsHfWwOvLLsuYgp+lgE4vKk56VVK3JOkx+uPCu0IOgQ32q2DEMZqR6NJiSNWgmuhpU7t2Nsx3hXMA+cO9JyvhBxoZieabJyDUgocg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019610; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=HgyyWolbDmw5MVu0gVOjYQk4SpTCg5vcfKiDWLfcsVs=; b=ZTGSn2lOMJbptvjFo/GUjPX5d+9mxSdpO/pvI8bC4tywiVtx3IZxNgurbd1cCap6g1YO94rz1JQJSkmR8ZsdGByx5pqC+X0cJXGs/mLKhFsHMPLUwdUPjnHGzNtKrnjJRo5qBlNJE+ZpDMenfTp1Qy1CPIs6mpf8UAej54n4B+E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68266+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607019610302236.11880120343028; Thu, 3 Dec 2020 10:20:10 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id TO0pYY1788612xUhVjpNrbnz; Thu, 03 Dec 2020 10:20:09 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.838.1607019604215892973 for ; Thu, 03 Dec 2020 10:20:04 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EA48B11FB; Thu, 3 Dec 2020 10:20:03 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B278E3F575; Thu, 3 Dec 2020 10:20:02 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 03/16] ArmPlatformPkg: Fix Ecc error 3002 in PL061GpioDxe Date: Thu, 3 Dec 2020 18:19:32 +0000 Message-Id: <20201203181945.10880-4-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: gJ3OHWzpE7P52o6GH6zPMIVix1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019609; bh=DRYi3lygk+9mpMwtnjAyEFHtiP7eLHzjIDvV7Wb4YRw=; h=Cc:Date:From:Reply-To:Subject:To; b=bSg2mCGNh5TLPCd+U5Y26PaBreSe/w05EBXSU6+h2up8r1MAcUkwE0lrd5xhIm5aTys OIqkqA9LBd2kKciIHLvPpjZ+wa3Tn0vCQQcyIZhM3XZJx9tmxGNYJKMDefknwvNIqnk4u gk2vY8xju3cTyoJO5R65KK+ZFQ2jGK8v5V8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D) Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c b/ArmPlatformP= kg/Drivers/PL061GpioDxe/PL061Gpio.c index 778bd6858f41f972734b0ea57058c18a053e4338..020d8c9fd92a38783305680980c= c9159345e380e 100644 --- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c +++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011, ARM Limited. All rights reserved. +* Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
* Copyright (c) 2016, Linaro Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent @@ -181,7 +181,7 @@ Get ( return EFI_INVALID_PARAMETER; } - if (PL061GetPins (RegisterBase, GPIO_PIN_MASK(Offset))) { + if (PL061GetPins (RegisterBase, GPIO_PIN_MASK(Offset)) !=3D 0) { *Value =3D 1; } else { *Value =3D 0; @@ -292,7 +292,7 @@ GetMode ( // Check if it is input or output if (MmioRead8 (RegisterBase + PL061_GPIO_DIR_REG) & GPIO_PIN_MASK(Offset= )) { // Pin set to output - if (PL061GetPins (RegisterBase, GPIO_PIN_MASK(Offset))) { + if (PL061GetPins (RegisterBase, GPIO_PIN_MASK(Offset)) !=3D 0) { *Mode =3D GPIO_MODE_OUTPUT_1; } else { *Mode =3D GPIO_MODE_OUTPUT_0; -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68266): https://edk2.groups.io/g/devel/message/68266 Mute This Topic: https://groups.io/mt/78690949/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-