From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68264+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68264+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019607; cv=none; d=zohomail.com; s=zohoarc; b=KGKPy9naujmTuMZ5KqdnkKOkJ0gaHac7bJAbqg23TOCS7aVWQCVAXN+0lPhyPtaRvlevARvxNvZ1kV9iDBbAmSudJDceipVjnAnfk1OuzQYrKlS9MpPbrzvTro6RLwPIL1YRWllIlsHCuhaSpzlqxtJoUfUcUzgBmDxYMts2E7Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019607; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=edzUE/+Q5ILiGiyVdR0UpyWhzjHwvLbYsRTZ7BFBpn4=; b=NEwIYm5e//hJTOYey9VS4mW3v6c8pk2+6uEzXJc4J/N1n3K36ZDGRkVlt9YPdOCqpANqPjn2l8Ny4d05ufDhSSuytUecmqzu2z4gQBo6Mj0AO9D9QTkkndclq7sDyGYVuQ507uSTXqS8DNW6JXeh+wkLI/Dv4ungjZllg72v1Fw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68264+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607019607382353.06666455299865; Thu, 3 Dec 2020 10:20:07 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id ERtjYY1788612x1UWrKoRKjx; Thu, 03 Dec 2020 10:20:06 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.859.1607019601357518777 for ; Thu, 03 Dec 2020 10:20:01 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F8BA11FB; Thu, 3 Dec 2020 10:20:01 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9D8173F575; Thu, 3 Dec 2020 10:19:59 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 01/16] ArmPlatformPkg: Fix Ecc error 3001 in NorFlashDxe Date: Thu, 3 Dec 2020 18:19:30 +0000 Message-Id: <20201203181945.10880-2-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 2YM6yHaFgrRkGM08NDfBfR0mx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019606; bh=nr42WPikJVdnQ3f/Vw+lIUw3SN+UQlJYLC2a8Sbe8gg=; h=Cc:Date:From:Reply-To:Subject:To; b=siyrq83k9Po951oS00r1VBxKb69cbQr+oLTCPOs9y60dnAYGiYqRyWzDE3LPuIAhshy CKr1+WqHQZ2u7z9gryWqAtCkN8UG4mgDup6/S8fvB+8eMldgjXk10PU+jH3ngxeNS9g14 wg0v49ypl5KkUF6MkEoeZDKOOzI8ZbmKQbw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Boolean values and variable type BOOLEAN should not use explicit comparisons to TRUE or FALSE Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c b/ArmPlatform= Pkg/Drivers/NorFlashDxe/NorFlashDxe.c index d9e196cbf18c32fe5306cc3c0674a7b5798a9191..b681c4b4668630de8a9585363a3= 28b3e3f1bc324 100644 --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c @@ -1,6 +1,6 @@ /** @file NorFlashDxe.c - Copyright (c) 2011 - 2014, ARM Ltd. All rights reserved.
+ Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -259,7 +259,7 @@ NorFlashUnlockSingleBlockIfNecessary ( Status =3D EFI_SUCCESS; - if (NorFlashBlockIsLocked (Instance, BlockAddress) =3D=3D TRUE) { + if (NorFlashBlockIsLocked (Instance, BlockAddress)) { Status =3D NorFlashUnlockSingleBlock (Instance, BlockAddress); } -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68264): https://edk2.groups.io/g/devel/message/68264 Mute This Topic: https://groups.io/mt/78690944/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68265+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68265+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019609; cv=none; d=zohomail.com; s=zohoarc; b=boJb/VTwzCTJ0xkAtziNLkrjZMH2I3ayiZlDl+uyBYEYVtg5wG1aFA4z7IRAnaXeuevgN+hC83q9i5h30GpVjuQcJ7lh8pNj0Ih2xB+MaQWyb5NWN7AXHVKd/fwKhkdUhojfsjwRv6rmG8hiK12u2Ixqrsrirsv3e53NWyq9BaE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019609; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=szUYzxlfTb1Mr9q3WGXzweP88hHou9H+hHsX4O3yb/k=; b=fz+DRH6CHSazOwPZg1SYfohyOMRQgjVsT/LyQe3iNPgQ0s8elE/w7j5fUNr2mx2KKs94nr1fwBM4ghQFMZHz3Dr3M4dD8588B9CCmCGnfIiJwbUCI5dIee97o8gIh36Jb7vfqE7bZMkiKL3c1pA0bn0+AKI0IUKHEdET098y/lY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68265+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607019609417330.6500832515511; Thu, 3 Dec 2020 10:20:09 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id uRyjYY1788612xGlIs6mcTTu; Thu, 03 Dec 2020 10:20:08 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.882.1607019602830343836 for ; Thu, 03 Dec 2020 10:20:02 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E8DE11D4; Thu, 3 Dec 2020 10:20:02 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5E45B3F575; Thu, 3 Dec 2020 10:20:01 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 02/16] ArmPlatformPkg: Fix Ecc error 3002 in PL011UartLib Date: Thu, 3 Dec 2020 18:19:31 +0000 Message-Id: <20201203181945.10880-3-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: cWGtSXbSn1saMiuzYabutjvax1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019608; bh=U8iZxS97qJZQC45WoPcxyql/gcareRCxrx5inMtjego=; h=Cc:Date:From:Reply-To:Subject:To; b=OSIcl0tk41uZ46ZWAzYtbCkb9PorF1BFy0T7m7melnS4Aedqw9o4NlZqZxMO+pziM7p 7xLfvjHblB7ZfTgUmDJlDEtqV/5rAGdWntr3yr9RI3iDCTx75UKb5lR6V3+wBxGirpEMV BaB7lsOfAc3n09iPleYKg2fgIBBofh04hkc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D) Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c b/ArmPlatfo= rmPkg/Library/PL011UartLib/PL011UartLib.c index f1015b1fce33a8188915b3bbeda81c2c37e35cb0..3c58a0f39acb3867048f46c25ec= 1d41930a2b2ee 100644 --- a/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c +++ b/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c @@ -2,7 +2,7 @@ Serial I/O Port library functions with no library constructor/destructor Copyright (c) 2008 - 2010, Apple Inc. All rights reserved.
- Copyright (c) 2011 - 2016, ARM Ltd. All rights reserved.
+ Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -269,31 +269,31 @@ PL011UartSetControl ( { UINT32 Bits; - if (Control & (mInvalidControlBits)) { + if ((Control & mInvalidControlBits) !=3D 0) { return RETURN_UNSUPPORTED; } Bits =3D MmioRead32 (UartBase + UARTCR); - if (Control & EFI_SERIAL_REQUEST_TO_SEND) { + if ((Control & EFI_SERIAL_REQUEST_TO_SEND) !=3D 0) { Bits |=3D PL011_UARTCR_RTS; } else { Bits &=3D ~PL011_UARTCR_RTS; } - if (Control & EFI_SERIAL_DATA_TERMINAL_READY) { + if ((Control & EFI_SERIAL_DATA_TERMINAL_READY) !=3D 0) { Bits |=3D PL011_UARTCR_DTR; } else { Bits &=3D ~PL011_UARTCR_DTR; } - if (Control & EFI_SERIAL_HARDWARE_LOOPBACK_ENABLE) { + if ((Control & EFI_SERIAL_HARDWARE_LOOPBACK_ENABLE) !=3D 0) { Bits |=3D PL011_UARTCR_LBE; } else { Bits &=3D ~PL011_UARTCR_LBE; } - if (Control & EFI_SERIAL_HARDWARE_FLOW_CONTROL_ENABLE) { + if ((Control & EFI_SERIAL_HARDWARE_FLOW_CONTROL_ENABLE) !=3D 0) { Bits |=3D (PL011_UARTCR_CTSEN | PL011_UARTCR_RTSEN); } else { Bits &=3D ~(PL011_UARTCR_CTSEN | PL011_UARTCR_RTSEN); -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68265): https://edk2.groups.io/g/devel/message/68265 Mute This Topic: https://groups.io/mt/78690947/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68266+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68266+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019610; cv=none; d=zohomail.com; s=zohoarc; b=aDZnabjo0uH9s88zl6zhxd2jTsTp40uGUTBlyFFzSSowyVFZrO9IAhbxubd35yeGmVEnGrWsHfWwOvLLsuYgp+lgE4vKk56VVK3JOkx+uPCu0IOgQ32q2DEMZqR6NJiSNWgmuhpU7t2Nsx3hXMA+cO9JyvhBxoZieabJyDUgocg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019610; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=HgyyWolbDmw5MVu0gVOjYQk4SpTCg5vcfKiDWLfcsVs=; b=ZTGSn2lOMJbptvjFo/GUjPX5d+9mxSdpO/pvI8bC4tywiVtx3IZxNgurbd1cCap6g1YO94rz1JQJSkmR8ZsdGByx5pqC+X0cJXGs/mLKhFsHMPLUwdUPjnHGzNtKrnjJRo5qBlNJE+ZpDMenfTp1Qy1CPIs6mpf8UAej54n4B+E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68266+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607019610302236.11880120343028; Thu, 3 Dec 2020 10:20:10 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id TO0pYY1788612xUhVjpNrbnz; Thu, 03 Dec 2020 10:20:09 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.838.1607019604215892973 for ; Thu, 03 Dec 2020 10:20:04 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EA48B11FB; Thu, 3 Dec 2020 10:20:03 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B278E3F575; Thu, 3 Dec 2020 10:20:02 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 03/16] ArmPlatformPkg: Fix Ecc error 3002 in PL061GpioDxe Date: Thu, 3 Dec 2020 18:19:32 +0000 Message-Id: <20201203181945.10880-4-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: gJ3OHWzpE7P52o6GH6zPMIVix1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019609; bh=DRYi3lygk+9mpMwtnjAyEFHtiP7eLHzjIDvV7Wb4YRw=; h=Cc:Date:From:Reply-To:Subject:To; b=bSg2mCGNh5TLPCd+U5Y26PaBreSe/w05EBXSU6+h2up8r1MAcUkwE0lrd5xhIm5aTys OIqkqA9LBd2kKciIHLvPpjZ+wa3Tn0vCQQcyIZhM3XZJx9tmxGNYJKMDefknwvNIqnk4u gk2vY8xju3cTyoJO5R65KK+ZFQ2jGK8v5V8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, < >=3D, <=3D) Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c b/ArmPlatformP= kg/Drivers/PL061GpioDxe/PL061Gpio.c index 778bd6858f41f972734b0ea57058c18a053e4338..020d8c9fd92a38783305680980c= c9159345e380e 100644 --- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c +++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011, ARM Limited. All rights reserved. +* Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
* Copyright (c) 2016, Linaro Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent @@ -181,7 +181,7 @@ Get ( return EFI_INVALID_PARAMETER; } - if (PL061GetPins (RegisterBase, GPIO_PIN_MASK(Offset))) { + if (PL061GetPins (RegisterBase, GPIO_PIN_MASK(Offset)) !=3D 0) { *Value =3D 1; } else { *Value =3D 0; @@ -292,7 +292,7 @@ GetMode ( // Check if it is input or output if (MmioRead8 (RegisterBase + PL061_GPIO_DIR_REG) & GPIO_PIN_MASK(Offset= )) { // Pin set to output - if (PL061GetPins (RegisterBase, GPIO_PIN_MASK(Offset))) { + if (PL061GetPins (RegisterBase, GPIO_PIN_MASK(Offset)) !=3D 0) { *Mode =3D GPIO_MODE_OUTPUT_1; } else { *Mode =3D GPIO_MODE_OUTPUT_0; -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68266): https://edk2.groups.io/g/devel/message/68266 Mute This Topic: https://groups.io/mt/78690949/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68267+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68267+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019612; cv=none; d=zohomail.com; s=zohoarc; b=g76EBorxko6V8YV+M7sIckTWZD7ignFQeolGEJd1iZyImApM3NIZ0xnGL6yv79hWsCgwnAlroESJ7RR9qLoiuw0tewkdyzs2O4SaZcunNwbu3j9y2M/qRJCOAQ2LUH1JCt82CyL89jEzSi0Z5Sl6WQGEUP5NETSDY/rZkFJlPxk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019612; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=dwbI9hz2dIL3xrBPQz43UBraoxbj15vEXXvv73BL5dY=; b=Xnte2LjJq1q0OFg0AGZMzkDLsPHbOZ1+/dyJe7jK+WV2KPUAhnglfobng9OBdh5sEVGE2sK77uzw9Kd5VgWJfUT/7WBReUoC1E2nY/BHGvDEo/W0rhmLArNQ4EpDsd6pmHI9kNSpVaHkqp7jfTo6bbQOxnvrJmA4qByXVMIwyLY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68267+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 160701961228965.28296356202236; Thu, 3 Dec 2020 10:20:12 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id EaPGYY1788612xyxOifFexCZ; Thu, 03 Dec 2020 10:20:11 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.861.1607019605851653893 for ; Thu, 03 Dec 2020 10:20:06 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9235A11D4; Thu, 3 Dec 2020 10:20:05 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 571233F575; Thu, 3 Dec 2020 10:20:04 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 04/16] ArmPlatformPkg: Fix Ecc error 5007 in LcdGraphicsOutputDxe Date: Thu, 3 Dec 2020 18:19:33 +0000 Message-Id: <20201203181945.10880-5-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: ODd0EbqZbQPzUVjdWRhY688Qx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019611; bh=Pyb+koEnrkHKF+ZAJm8XWm+T6sVg1YyAxJ83o0G8RWE=; h=Cc:Date:From:Reply-To:Subject:To; b=ieRfGl/gsTpEkMwOa2qBXawdMnuLcmCVWm+xSTzFv1TucWyrPS9G34P71jIzjyfKkkN +G1no9p4YQRZyN5VMO+cgUZbJXkpJnehEakxMQATs4edVU6X7n+jBoAhZCiN9F2ZUEQJU WsXoP2NewClOBtxP0/5YWFIJQxcvfaij2To= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c | 10 ++= +++++--- ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c | 10 ++= +++----- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputB= lt.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c index c865215ec68ecba1e809108cffec9354f042561e..07d2cb0d5dec0f85219fe5cdc43= 8e18ae3a32a38 100644 --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2011-2013, ARM Ltd. All rights reserved.
+ Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -36,7 +36,7 @@ VideoCopyNoHorizontalOverlap ( IN UINTN Height ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; UINTN SourceLine; UINTN DestinationLine; UINTN WidthInBytes; @@ -45,6 +45,8 @@ VideoCopyNoHorizontalOverlap ( VOID *SourceAddr; VOID *DestinationAddr; + Status =3D EFI_SUCCESS; + if( DestinationY <=3D SourceY ) { // scrolling up (or horizontally but without overlap) SourceLine =3D SourceY; @@ -128,7 +130,7 @@ VideoCopyHorizontalOverlap ( IN UINTN Height ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; UINT32 *PixelBuffer32bit; UINT32 *SourcePixel32bit; @@ -143,6 +145,8 @@ VideoCopyHorizontalOverlap ( UINTN SizeIn32Bits; UINTN SizeIn16Bits; + Status =3D EFI_SUCCESS; + switch (BitsPerPixel) { case LCD_BITS_PER_PIXEL_24: diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputD= xe.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c index f1f104858d8ed456089180e6e82bcc54d4b46b62..bfd03d8f84258158e76690cc5a0= d9333f11d67f0 100644 --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c @@ -1,7 +1,7 @@ /** @file This file implements the Graphics Output protocol for Arm platforms - Copyright (c) 2011-2018, ARM Ltd. All rights reserved.
+ Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -102,7 +102,7 @@ InitializeDisplay ( IN LCD_INSTANCE* Instance ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; EFI_PHYSICAL_ADDRESS VramBaseAddress; UINTN VramSize; @@ -148,7 +148,7 @@ LcdGraphicsOutputDxeInitialize ( IN EFI_SYSTEM_TABLE *SystemTable ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; LCD_INSTANCE* Instance; Status =3D LcdIdentify (); @@ -246,7 +246,7 @@ LcdGraphicsQueryMode ( OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION **Info ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; LCD_INSTANCE *Instance; Instance =3D LCD_INSTANCE_FROM_GOP_THIS (This); @@ -296,7 +296,7 @@ LcdGraphicsSetMode ( IN UINT32 ModeNumber ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; EFI_GRAPHICS_OUTPUT_BLT_PIXEL FillColour; LCD_INSTANCE* Instance; LCD_BPP Bpp; -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68267): https://edk2.groups.io/g/devel/message/68267 Mute This Topic: https://groups.io/mt/78690950/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68268+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68268+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019608; cv=none; d=zohomail.com; s=zohoarc; b=Xk965fnNnNDIMW6K1+9HIxUQXGfk/pyp0WYsLZQIKwA6RDIizfRwVVQFiiBzIcQ12rgZYFVyZU8y9mG36QUEH6jPMW8NiwDK1lB2+kFEEiRko/XK2lOZImlYLL9ARk/zsKQGgwJqvHO3AL60F8tiPSmIBAifyvvoGEaLJLQ0MXo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019608; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=5pMVuPx653ug4YY1S9EPh+OyaOHCl7C3aHyrEra0NVk=; b=CBkL9Ro4QxJS6b2VcFbxfbtdt8LlLJuFKzASsg/r3BgHLQ9jlTAQUNfHpW3Kvw7zmukKCuMs3y19ai93rGRUoMp8NEe8Vtrw7OIU1UGs76rBzvHG4xcCBc3pmihk9pJ5adg9Ozwf0z29ffT9iDVVvIUJSlfR2uvtZQWHhPZd4nw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68268+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607019608536311.73179428435844; Thu, 3 Dec 2020 10:20:08 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id m8U5YY1788612xjRbPRL5XJu; Thu, 03 Dec 2020 10:20:08 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.870.1607019607535295423 for ; Thu, 03 Dec 2020 10:20:07 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 39C7F11D4; Thu, 3 Dec 2020 10:20:07 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DBC883F575; Thu, 3 Dec 2020 10:20:05 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 05/16] ArmPlatformPkg: Fix Ecc error 5007 in NorFlashDxe Date: Thu, 3 Dec 2020 18:19:34 +0000 Message-Id: <20201203181945.10880-6-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: DNnVZBnEaWdqT5wFjlTBKkVqx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019608; bh=WmXV4OqTsWQztmQJGYTpGd5k6p6KsS+/Y3k2tRpqXIA=; h=Cc:Date:From:Reply-To:Subject:To; b=AuW+SgbCgk31r0r0LdeCeSD5WHwDrcPNUKvKJWs79EjltUCbyXWZlJOCYWS5ooOhWHk AEOi8G8l1tanqWMozjwhnxKO+8bjcbPDLX6aw+E8uHOZcAnqC0oL7yiOAHzNR8Ak1MkYw bacI8pmctC1g6Ppc9PuB97MhGqDZ7JA6LD0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c b/ArmPlatform= Pkg/Drivers/NorFlashDxe/NorFlashDxe.c index b681c4b4668630de8a9585363a328b3e3f1bc324..20134094badcb5bee14f66a9c38= b8d5bbf68ceaa 100644 --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c @@ -676,12 +676,14 @@ NorFlashWriteBlocks ( ) { UINT32 *pWriteBuffer; - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; EFI_LBA CurrentBlock; UINT32 BlockSizeInWords; UINT32 NumBlocks; UINT32 BlockCount; + Status =3D EFI_SUCCESS; + // The buffer must be valid if (Buffer =3D=3D NULL) { return EFI_INVALID_PARAMETER; -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68268): https://edk2.groups.io/g/devel/message/68268 Mute This Topic: https://groups.io/mt/78690951/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68269+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68269+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019614; cv=none; d=zohomail.com; s=zohoarc; b=GiONFFJlBkE2aKN7RsjeQwY4SXPRfIey11ufG9DPIkzGu5ga0c7hMWdL4s1jcQMaxqkAXUG+xIarA/bCgnHd1PsC/aFOeceJISlKRIYPWmyGP3qxI5EEtKcwvAOAvucISHuCXmKCqLUcfF/Rl3yiP+o+pB4oOSs0l87/AOYaHVY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019614; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=nlEgrGoEmxmwtGqWNXP7TnP/TzskprpimVI/v3VvVws=; b=jkZNASMF/fHrAPJliVWyobbdRjwy8SaGEEixJaUi1c2UHf9LWwhWJkwk2qjVxk6PsR1EnitTsdUbZVJiriJNC7Y61hw1w+MjgEEBa8EFgT9Bt9pIwBZ7qL+Aue8SwkieM57PaA0qv3962qF2sjQAeU6Nm9bqQhtu4lQbdhLFauw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68269+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607019614593458.5062154570023; Thu, 3 Dec 2020 10:20:14 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id yQWMYY1788612xwdMjsS3wfc; Thu, 03 Dec 2020 10:20:14 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.887.1607019608782526936 for ; Thu, 03 Dec 2020 10:20:08 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 71CB311FB; Thu, 3 Dec 2020 10:20:08 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6F9B33F575; Thu, 3 Dec 2020 10:20:07 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 06/16] ArmPlatformPkg: Fix Ecc error 5007 in PL061GpioDxe Date: Thu, 3 Dec 2020 18:19:35 +0000 Message-Id: <20201203181945.10880-7-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: rj6VM1zomnUc13PS0uIdWWp4x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019614; bh=3cImXYSEn1kDZvCiTRNkoRxSoBfOQ0KpPVPqGZFeku8=; h=Cc:Date:From:Reply-To:Subject:To; b=PkaH0+WzkX9onSP910AZ15YVCwFniB+o0h73cU+JnqsxtYp8w0iEGDyg1eVmXzF+/AA v47CbPX5nvZbwvgTJ5KRxNXt9gljUVam/SiKpX35sOCf3F05H8RCVIfAvZQRMg4SMO/MH lzzoP5DY9NxufzpuEQ/LPKKO1bZWA+uI0UI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c b/ArmPlatformP= kg/Drivers/PL061GpioDxe/PL061Gpio.c index 020d8c9fd92a38783305680980cc9159345e380e..be0e1c096360d08d9da6888d77d= d0e4556fd4b02 100644 --- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c +++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c @@ -171,7 +171,7 @@ Get ( OUT UINTN *Value ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; UINTN Index, Offset, RegisterBase; Status =3D PL061Locate (Gpio, &Index, &Offset, &RegisterBase); @@ -216,7 +216,7 @@ Set ( IN EMBEDDED_GPIO_MODE Mode ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; UINTN Index, Offset, RegisterBase; Status =3D PL061Locate (Gpio, &Index, &Offset, &RegisterBase); @@ -278,7 +278,7 @@ GetMode ( OUT EMBEDDED_GPIO_MODE *Mode ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; UINTN Index, Offset, RegisterBase; Status =3D PL061Locate (Gpio, &Index, &Offset, &RegisterBase); -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68269): https://edk2.groups.io/g/devel/message/68269 Mute This Topic: https://groups.io/mt/78690952/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68270+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68270+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019616; cv=none; d=zohomail.com; s=zohoarc; b=isiOJexY9FAicMAdL8dOts4M2b+LLXowwvdI7kTW+PFh0o4YzFPHr3kOdy8yl7sFa4KH+TLmhNZOkgFwgSXqc0HAdIJMhcS5vmWscKsHU85FRdVePlw/jzwQ+Sf0OTz16SqJSq2wySjDjSPgnAOsYXA6oWpaM3f87M44NmbjGJ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019616; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=M3myCYgiICTde6F+hcvpQmTe3ISYNInzlrYPcHOmSZo=; b=QfajmhviYOfRHTP1f0o7qAJbWEKSVvOEHOG2LXpaIWtW9JI7g47k9Qn1vZmNh5cfnZlWLJ/KeszVu1feBDcIwV/D+UCl2ieFAra133TfLZNPaAJXkAdOQwMpV0Iavjm8dlzOsO0r7KBk8LDHPvoFakNWwdFgS6xx9XRwp7tTKq0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68270+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607019616529400.5045072679127; Thu, 3 Dec 2020 10:20:16 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 1meyYY1788612x4iL7DDiX80; Thu, 03 Dec 2020 10:20:16 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.871.1607019610608688183 for ; Thu, 03 Dec 2020 10:20:10 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4B31911D4; Thu, 3 Dec 2020 10:20:10 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D2BBA3F575; Thu, 3 Dec 2020 10:20:08 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 07/16] ArmPlatformPkg: Fix Ecc error 5007 in PL031RealTimeClockLib Date: Thu, 3 Dec 2020 18:19:36 +0000 Message-Id: <20201203181945.10880-8-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: PBOs1dpYWedWtXlJprxarcBmx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019616; bh=L4x57ZFiJ1R9ckTVda5Ad7rDPVSG3Sqy2YtNLwIA6x4=; h=Cc:Date:From:Reply-To:Subject:To; b=J0Z1eQzs2VmXfx27RdbxMX1VtqIMfHGPqN6qhVKzpZfHgbz6z/q8sFrDP2a94PVQQm+ IhaV6q3y9vHWnFWv5edybQp6njjifUc2kA9Z1L6yIrZ20lpr2TGl9T82GYsWbB7sMqgi5 5gVuBPkq58YfIS4i6lznQSC/GXlyE+JIfBE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no initialization of a variable as part of its declaration Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 4 += +-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeCloc= kLib.c b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib= .c index 75c95985d4707022c87da2e29c799e726aab0bce..0df4ceb1cb39fec80553a61d8a5= 0df415862f502 100644 --- a/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c +++ b/ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c @@ -2,7 +2,7 @@ Implement EFI RealTimeClock runtime services via RTC Lib. Copyright (c) 2008 - 2010, Apple Inc. All rights reserved.
- Copyright (c) 2011 - 2014, ARM Ltd. All rights reserved.
+ Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
Copyright (c) 2019, Linaro Ltd. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -121,7 +121,7 @@ LibGetTime ( OUT EFI_TIME_CAPABILITIES *Capabilities ) { - EFI_STATUS Status =3D EFI_SUCCESS; + EFI_STATUS Status; UINT32 EpochSeconds; // Ensure Time is a valid pointer -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68270): https://edk2.groups.io/g/devel/message/68270 Mute This Topic: https://groups.io/mt/78690953/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68271+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68271+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019613; cv=none; d=zohomail.com; s=zohoarc; b=WOcxlcWG/2UlTiDWaNiMdZt+1yrv9DX8LlbeMD2FCWYGHb7SUU8HSjZEknadN2fXk3HvG4r+qH7B5VZGVbOeqwNiPVaUcUI+V+F0wmle9AkpGhMJaJmpbd/UhO2KAGtgJ2RljSLGvDG1oOlvyJs/f8MDaNcv0Wv71GJdIZdBOQM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019613; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=ZW2EP0hDEwQAVt8SlSOFgvgnrUk9klYYwZOjvUfLXCE=; b=DTsbihInwKA/EYEXXieKb9j/s/OEWq5EfwaZjZ4T1ga7Kn73IC6SmPnRjWEdQMZ6h3izXkFLeTKPrrE74SRkN7mUFVDPxkIDHhTy272WNyAHJMFtJiH4LFl9C0l2QT60aYhp9yY54i+hKzQKc3gfWMxELMIsMgwpqlnPGQmkrtc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68271+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607019613243680.8290567045301; Thu, 3 Dec 2020 10:20:13 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id bRsvYY1788612xz5t97Uouuu; Thu, 03 Dec 2020 10:20:12 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.890.1607019612254064799 for ; Thu, 03 Dec 2020 10:20:12 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E714411FB; Thu, 3 Dec 2020 10:20:11 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9A4B43F575; Thu, 3 Dec 2020 10:20:10 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 08/16] ArmPlatformPkg: Fix Ecc error 10016 in PrePi Date: Thu, 3 Dec 2020 18:19:37 +0000 Message-Id: <20201203181945.10880-9-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: JoUmLsFb1mpMqpy1ElN1c7Hxx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019612; bh=+yPWBYPEQR2cSskR3ndUGBB+OSWts+0WmaE9OjMTzms=; h=Cc:Date:From:Reply-To:Subject:To; b=dLLStuRxJbz8YOhgE66Lt7/OGS3nNJb3RzGTb6FLXRkm1WK3m5q+cc2T6OmzdjKofzq xTEl00pFjZAKvnU9qz/JMqnQu1+dF0GKV0MPmWOQTrFzyxm7ipGQR0rizv2htX/VzAew5 DH1nLEYaO30QAPaUFEe1k1KWwfhsthRSAaw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Module file has FILE_GUID collision with other module file The two .inf files with clashing GUID are: edk2\ArmPlatformPkg\PrePi\PeiUniCore.inf edk2\ArmPlatformPkg\PrePi\PeiMPCore.inf Both files seem to have been imported from the previous svn repository as the same time. Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/PrePi/PeiUniCore.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ArmPlatformPkg/PrePi/PeiUniCore.inf b/ArmPlatformPkg/PrePi/Pei= UniCore.inf index 78d218ae09ca86aa2d77759174118146b97b4576..83a3df78ac26a11366a7bd69d9b= 29c751d9c01fc 100644 --- a/ArmPlatformPkg/PrePi/PeiUniCore.inf +++ b/ArmPlatformPkg/PrePi/PeiUniCore.inf @@ -2,6 +2,7 @@ # # (C) Copyright 2015 Hewlett-Packard Development Company, L.P.
# Copyright (c) 2011-2017, ARM Ltd. All rights reserved.
+# Copyright (c) 2020, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -10,7 +11,7 @@ [Defines] INF_VERSION =3D 0x00010005 BASE_NAME =3D ArmPlatformPrePiUniCore - FILE_GUID =3D d959e387-7b91-452c-90e0-a1dbac90ddb8 + FILE_GUID =3D 3e401783-cc94-4fcd-97bc-bd35ac369d2f MODULE_TYPE =3D SEC VERSION_STRING =3D 1.0 -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68271): https://edk2.groups.io/g/devel/message/68271 Mute This Topic: https://groups.io/mt/78690955/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68272+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68272+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019619; cv=none; d=zohomail.com; s=zohoarc; b=AgyVrf2Tj2gxaGG34DXrqv5QBhsi7pHOJklEs9MxOcHe7M2uwKjHHxnUjsa+Bqay5hgKw4m2hYSCQb8u7zSi2Rjd3IV3Z8pxr1DnhoDlXbAXF8lKLmS3QEyeVQ5J6vu8g67QVJuzXgkkHnGKEiqSJxUkFT+4Orvyhbzleb9TRqo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019619; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=ZdWhkezZR2mj4C2Qqs9FKxQpyanc01i39LOrf37K4X0=; b=DhwkRkzEVhQ3o1Dlhkbo9u29wMB4RYRoYYqMM6I6GYGjJ8i76Y4fkq7aRgs8CFvwaRI320iAwAxBtyDXuwKQdmlYnb2YQvjTmi66XI2CLqCay3KNLXD+zrR5YxUIHmr7JJno3njD6sET46PMvwFrxSAVJwD/ajVw6k8H38irGCw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68272+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607019619893317.88666236250526; Thu, 3 Dec 2020 10:20:19 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id WuHpYY1788612xSNyBNMNCFQ; Thu, 03 Dec 2020 10:20:19 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.843.1607019613908841397 for ; Thu, 03 Dec 2020 10:20:14 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8EF3911D4; Thu, 3 Dec 2020 10:20:13 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 54EEE3F575; Thu, 3 Dec 2020 10:20:12 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 09/16] ArmPlatformPkg: Fix Ecc error 10016 in LcdPlatformNullLib Date: Thu, 3 Dec 2020 18:19:38 +0000 Message-Id: <20201203181945.10880-10-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: o9YMPaupNW8sn9EAOpuasOuZx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019619; bh=xWaILyyroq/3koiv2r7HWrSRjMVrAC5wu3rjWPRH8xk=; h=Cc:Date:From:Reply-To:Subject:To; b=JKmzCE07+BAikZClbao6HYr8iuEE/iqm/djyN2p17kRfzzML/qXKKl7LNFfc6fUtrYY VZe6J75zZYVP3oLC7a2J7VftCyIhKh7Q8X9VofANlRxrc5Gf+PAMbQyU+Nl3EbsxTWwih HxWE6k6qfCD0MuP1NqiphQeplI+gr5BNAuI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Module file has FILE_GUID collision with other module file The two .inf files with clashing GUID are: edk2\ArmPlatformPkg\PrePeiCore\PrePeiCoreMPCore.inf edk2\ArmPlatformPkg\Library\LcdPlatformNullLib\LcdPlatformNullLib.inf The PrePeiCoreMPCore module has been omported in 2011 and the LcdPlatformNullLib module has been created in 2017. The PrePeiCoreMPCore has the precedence. Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.i= nf b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf index 55857081692d639e9b010dfdd60f9af676494fb6..21bbe0571f69971070075a89228= e6af2cd7e011f 100644 --- a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf +++ b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf @@ -1,6 +1,7 @@ #/** @file # # Copyright (c) 2017, Linaro, Ltd. All rights reserved. +# Copyright (c) 2020, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -9,7 +10,7 @@ [Defines] INF_VERSION =3D 0x0001001A BASE_NAME =3D LcdPlatformNullLib - FILE_GUID =3D b78d02bb-d0b5-4389-bc7f-b39ee846c784 + FILE_GUID =3D f8bb120b-528f-46e2-92c2-130870af1a20 MODULE_TYPE =3D BASE VERSION_STRING =3D 1.0 LIBRARY_CLASS =3D LcdPlatformLib -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68272): https://edk2.groups.io/g/devel/message/68272 Mute This Topic: https://groups.io/mt/78690956/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68273+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68273+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019616; cv=none; d=zohomail.com; s=zohoarc; b=YMz78HzXevqIJEqWvH2qGhWv85iLqWO3diRVYbQnPZs0a/3TNuEZTSX4vwguEf9NfcBG0kVoA5vzil50Bx0se7+dA5kU4tQmPRMLJWPXn0WYQD36+z4ybyfwvQidFkved/4eKRhwucrdsUaD+LS/kDNfyrbEPjzNJuBG3ONeGg0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019616; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=aDO70WR2TyxfIkUlq3h4YNd+jij4I3q0GjkLWfhjD0o=; b=ObhWtccp9U5TnK03EuV+yVPoN0/7l+/MPu/Dbzyv+6cNhCMlMM1J0dvWszlrcsffeAKLXzHN9/BCa/DV8FKQlbyIW3nEqO/CEEMQy0s1ZpC+CaOBBeSSxftfL2zUiLsPHOFBSH7KQorZHnmMjB/lxalsLE1F3rXlMOG35VOt7a8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68273+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607019616587898.4688622114434; Thu, 3 Dec 2020 10:20:16 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id TMV5YY1788612x8WXozsrozl; Thu, 03 Dec 2020 10:20:16 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.865.1607019615771997574 for ; Thu, 03 Dec 2020 10:20:15 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 549FD11D4; Thu, 3 Dec 2020 10:20:15 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 01CFD3F575; Thu, 3 Dec 2020 10:20:13 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 10/16] ArmPlatformPkg: Fix Ecc error 10014 in LcdGraphicsOutputDxe Date: Thu, 3 Dec 2020 18:19:39 +0000 Message-Id: <20201203181945.10880-11-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: DdMHDks3cPlIFmG0H8nuzGL1x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019616; bh=xM1UvkJjvBM6BKEgigUNvvyBRI6k3zRIApuJ8R5OcoY=; h=Cc:Date:From:Reply-To:Subject:To; b=iSqJJzZJ9R+PencHWhuJ4EUl0DJebn1+gmIGl+C6ZTQPH/UmtSrvCqs++GcHl4XXBvx PQdHMjFZDKQGixBCU8447XZsP4W7XVnCgugKRweofxYJ0nKKL6H2L/DK4aDG7LjMC+xYo hSxGAXNZtUhLFaTJcmpSSP/7SXUvoJo/FKM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source file [ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.h] is existing in module directory but it is not described in INF file. Files in [Sources.common] are also alphabetically re-ordered. Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf | 5 += ++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputD= xe.inf b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.i= nf index 27453b2656117ff015cd584787e8647820f59097..51bec36aed38e82449e6ba01165= a6c60663318ae 100644 --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf @@ -2,7 +2,7 @@ # # Component description file for LcdGraphicsOutputDxe module # -# Copyright (c) 2011-2012, ARM Ltd. All rights reserved.
+# Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -17,8 +17,9 @@ [Defines] ENTRY_POINT =3D LcdGraphicsOutputDxeInitialize [Sources.common] - LcdGraphicsOutputDxe.c LcdGraphicsOutputBlt.c + LcdGraphicsOutputDxe.c + LcdGraphicsOutputDxe.h [Packages] ArmPlatformPkg/ArmPlatformPkg.dec -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68273): https://edk2.groups.io/g/devel/message/68273 Mute This Topic: https://groups.io/mt/78690957/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68274+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68274+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019623; cv=none; d=zohomail.com; s=zohoarc; b=MfHjJqe2+cz+wGP2lu6MIuGMKoJFXsQcNi2/vH3SytvniSylbvYYyXYfujg05NJ7EK4H9qRsa0heN2Z9N5aroRFCp7wuk7pgk0XXXKACjZxkCZsN1DylPhsL1JuKi/0ayHdCJ4p6jBqNN+ZZWjJqKD3dpgxvgmiqG79qOmjYT8E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019623; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=6y4vK3UEwD4MZKzkN5aBkm1grXtZirkPgdJj/onfvzE=; b=YK056Hzd/2VPn6hCg02yNKamRXu/bgR9xv4127vsdDb6TzemHen8pjIdB9CKhdh0wZPidHVJE7Tx7CqfBqdnPCOYbzKoKytFZ2h8f4AWzY+5KDBzYdBIGrC5HA1OjQfug5qcpXi53y+tNmrxFp2Q2plhZ+F3N5Gvv51zoe3a53E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68274+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607019623235198.03417675601418; Thu, 3 Dec 2020 10:20:23 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id njelYY1788612xLu79vn0OJE; Thu, 03 Dec 2020 10:20:22 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.886.1607019617400740420 for ; Thu, 03 Dec 2020 10:20:17 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CDDC411FB; Thu, 3 Dec 2020 10:20:16 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A64E73F575; Thu, 3 Dec 2020 10:20:15 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 11/16] ArmPlatformPkg: Fix Ecc error 10014 in PL061GpioDxe Date: Thu, 3 Dec 2020 18:19:40 +0000 Message-Id: <20201203181945.10880-12-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: JGwjtFIudFlogqZLNWc4hOI4x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019622; bh=gtKftaMuryU91FiFrpFb1R2D85RIWNFUFmd8wUmKDdw=; h=Cc:Date:From:Reply-To:Subject:To; b=ut6KUNzIAkvLMK7Ytp3Hz/RxU4WIFYZdbFhLdJjGeCeQ+uRJy6b2zaRHg0vLns8O5cL +YZiYjOe+6tSHYo70UBVVZ1fogZFbmWxgwJ9t2Yohfbri2ecgIiBO1Mbxdj6oYdN95n74 2YSye2f9zEDiE2UDmWUY+kBFTj4JL151Rug= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source file [ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.h] is existing in module directory but it is not described in INF file. Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf b/ArmPlat= formPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf index 132f09ce2bf64f9110f1fb8c850aebb5cd427076..9c598bb66c76b7b9b9ff973ae6e= 84cf08e575e50 100644 --- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf +++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061GpioDxe.inf @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011, ARM Limited. All rights reserved. +* Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -16,6 +16,7 @@ [Defines] ENTRY_POINT =3D PL061InstallProtocol [Sources.common] PL061Gpio.c + PL061Gpio.h [Packages] MdePkg/MdePkg.dec -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68274): https://edk2.groups.io/g/devel/message/68274 Mute This Topic: https://groups.io/mt/78690958/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68275+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68275+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019624; cv=none; d=zohomail.com; s=zohoarc; b=DOSYiynMvwFkG4AhO42lJpquu2SqjeDIPlbZS0G8dhqfz7xRrbO9WrA0ZlbA3SAm7OwmNjuHL9xzovJDNXx4LBKOTK2Nmu7quH7CkkgVrmC9fUyQkA7v1XDuX0bmUjrhUYxv+y8phcUrV4cbs1e45eRnJwMkGkB1wH+Iepc6+Ao= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019624; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=fwx5VyPz5tw8Xtz8fZ7ZtHMvizFb25b+e2DLw8pLGIo=; b=RxkCKOr4cnevHxdqpfoGnB7KysM9t0hmXJXLo6qCo3RDW+OBzV3E1REzBOMvG0uW92cFVF+IqzK0wJ9erMuuRyhtEWnXNkRo06eL4AjqRnoiWog6LyWwDSk5qGDbgPyCve9MBN2r8uRNAlOHf773acloHaizqwMcvfUZimYy64w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68275+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 160701962430428.190886229861917; Thu, 3 Dec 2020 10:20:24 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id yBYaYY1788612xGaYpLCLKHv; Thu, 03 Dec 2020 10:20:23 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.872.1607019618560604769 for ; Thu, 03 Dec 2020 10:20:18 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 402DF11FB; Thu, 3 Dec 2020 10:20:18 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 32FE93F575; Thu, 3 Dec 2020 10:20:17 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 12/16] ArmPlatformPkg: Fix Ecc error 10014 in SP805WatchdogDxe Date: Thu, 3 Dec 2020 18:19:41 +0000 Message-Id: <20201203181945.10880-13-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: 15OGxhJQjIwSTzeCoUXAVUtVx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019623; bh=8sYailif7fwyEL+Wa6urBL+u3VwIKmbCo5OHyXD8ezM=; h=Cc:Date:From:Reply-To:Subject:To; b=b4VHbrJUrJgg73wJrLnhdsmM2TQXfW/y2B/2UBcFiu9IS69SSi2Kjtroa5vYwE6kfRk Kgsv/I/JOd3kmXCUxM8GJuRGVEXYaBC2ZTKJ+UjJDmGjd8YV61G1ekMz294IQZ5SLFe6T q9awuma7LeVVYKtTSHFYJ0zYUS6deUjHcds= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source file [ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.h] is existing in module directory but it is not described in INF file. Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf b= /ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf index 048f6697e93d702c5ec878ccc827e64e583893ea..fa87d92359ac4c62a6b72258b1e= 307e81e19f512 100644 --- a/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf +++ b/ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805WatchdogDxe.inf @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011-2012, ARM Limited. All rights reserved. +* Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
* Copyright (c) 2018, Linaro Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent @@ -17,6 +17,7 @@ [Defines] [Sources.common] SP805Watchdog.c + SP805Watchdog.h [Packages] ArmPkg/ArmPkg.dec -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68275): https://edk2.groups.io/g/devel/message/68275 Mute This Topic: https://groups.io/mt/78690960/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68276+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68276+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019621; cv=none; d=zohomail.com; s=zohoarc; b=MCqQwUGPuOSlRqMZm8pYnq4+81fJXZWGWfhAYYY7ejwLIQZH5dLObe2qY0swjETC0ayZsjuI53HLTLWMSI17WIUKZdPmyz2F4OTIxeSXGBljBl0BI84sitr4ckuwna3yn9P3WLV7OAZ4enCtmcmjj8LgNtcwa1mj97N8fE7HgT4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019621; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=prMwQJziyLwZhN1453CnckC/hUUrmw7gNz/Whw5BKms=; b=ZZnCwzXME7rnRYXzszp4XEGBdzbKWviTv1savnP7zQXPLnF/6CVIpkuN8yO/VO/atRnYrA7CdZxO1r95icGut+ERRGcOP1gSdyTKQJaHrWwb0u/Pm6TipouU9mYh2s0EfnejNc4dqaIHBA5/F0arLWPJRrKAiA5R/0L2E9MT0EQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68276+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607019621249668.218720147726; Thu, 3 Dec 2020 10:20:21 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id DjuHYY1788612xmPQajzQl0o; Thu, 03 Dec 2020 10:20:20 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.891.1607019620357453852 for ; Thu, 03 Dec 2020 10:20:20 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0D4A511FB; Thu, 3 Dec 2020 10:20:20 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8FEE03F575; Thu, 3 Dec 2020 10:20:18 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 13/16] ArmPlatformPkg: Fix Ecc error 10006 in ArmPlatformPkg.dsc Date: Thu, 3 Dec 2020 18:19:42 +0000 Message-Id: <20201203181945.10880-14-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: wSktrS118dGI2pJJzqUN0Ij2x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019620; bh=fMYmyxspyAZvU9zyWbCcOkfAxA3t8K8AmRyHVuPUKQs=; h=Cc:Date:From:Reply-To:Subject:To; b=uNr4ljs8/hw7fpBOiT0lIXOS/eNTw6gep/u2dmWXlygv/Ahy1mpqnTbUUb8wmroCgGm emgSgZjjVjgMTKNusUhYVqVdzhNsbjtrDaRlUZqpVpDUT7EDjVE+7bYMRG5V8O1r7foJz pqdET7mtFq2OG45HC5DJdY26zyWEhQkRhfc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no unnecessary inclusion of library classes in the INF file This comes with the additional information: "The Library Class [TimeBaseLib] is not used in any platform" "The Library Class [PL011UartClockLib] is not used in any platform" "The Library Class [PL011UartLib] is not used in any platform" Indeed, the PL011SerialPortLib module requires the PL011UartClockLib and PL011UartLib libraries. The PL031RealTimeClockLib module requires the TimeBaseLib library. ArmPlatformPkg/ArmPlatformPkg.dsc builds the two modules, but doesn't build the required libraries. This patch adds the missing libraries to the [LibraryClasses.common] section. Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/ArmPlatformPkg.dsc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ArmPlatformPkg/ArmPlatformPkg.dsc b/ArmPlatformPkg/ArmPlatform= Pkg.dsc index 5381c95af245e155e94adb315d4cd851a737c0a2..877b12b3b430393e1d8031bf261= 1c82e0785f2a6 100644 --- a/ArmPlatformPkg/ArmPlatformPkg.dsc +++ b/ArmPlatformPkg/ArmPlatformPkg.dsc @@ -2,7 +2,7 @@ # ARM platform package. # # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.
-# Copyright (c) 2011 - 2018, ARM Ltd. All rights reserved.
+# Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
# Copyright (c) 2016 - 2017, Linaro Ltd. All rights reserved.
# Copyright (c) Microsoft Corporation.
# @@ -58,10 +58,13 @@ [LibraryClasses.common] PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeC= offExtraActionLibNull.inf PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibN= ull.inf + PL011UartClockLib|ArmPlatformPkg/Library/PL011UartClockLib/PL011UartCloc= kLib.inf + PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf PlatformPeiLib|ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull= .inf + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplat= e.inf UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBoo= tServicesTableLib.inf UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompres= sLib.inf -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68276): https://edk2.groups.io/g/devel/message/68276 Mute This Topic: https://groups.io/mt/78690962/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68277+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68277+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019628; cv=none; d=zohomail.com; s=zohoarc; b=ed9XLT26FS8DXc7Pi3WWpIYtDO6pMyJdbnKd+4IgzsL1lrZASFqQ/NDV+xg4wmfrV1OvOMOVn5cqz9J4cQlAil/txjpJ79KK3VpNrzGeh3LiGcXB2IJerLr7QdD2MgthdMo78g+blUmSSDQLiP3mhM7PGVfFUmlsWeNJeu3G8SQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019628; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=YIH4oWBb33eO9MYesIphLtcZNc/iKogaJoQs3PuI4Bw=; b=C771UDJwpOoA0vs/IQxwGYhq8EBQRCXoUTmneUDJgSCzWt/cOHiaUpyZBo4EZdpVeoLGKr7BP/TytcOb1e/Yaw5p04SCrGDs8gsLwCLoQisuj/YiXInCbaoWX/UsLKuvBIpE+BZS0ARXldz0+PqtrBzQC/Ee4jGRLR0HjJQ8yH0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68277+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607019628157884.6411682770796; Thu, 3 Dec 2020 10:20:28 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id xnz9YY1788612xtGAn7Vr6t0; Thu, 03 Dec 2020 10:20:27 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.888.1607019621934251404 for ; Thu, 03 Dec 2020 10:20:22 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A4FA611D4; Thu, 3 Dec 2020 10:20:21 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 69B8A3F575; Thu, 3 Dec 2020 10:20:20 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 14/16] ArmPlatformPkg: Fix Ecc error 8001 in PrePi Date: Thu, 3 Dec 2020 18:19:43 +0000 Message-Id: <20201203181945.10880-15-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: Zy6STJPf9MhRn7JKWb0AXpmtx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019627; bh=lPDj9lh+Fkl8mBrY4FzPWL1UsK4yb1LP/I32v+Th1fg=; h=Cc:Date:From:Reply-To:Subject:To; b=so1VbpNEOcTn7nR2mZcnn0XnDkeBJBvPbb/x7kSHLcxOYf7NRON6HIDCBg0xpuramai XMZjec0GYQ2/m0pa4eh7l389ocYsfLa2gJIyWwud3DDJLtnGIbOT+IIQbn2k1tRlJiFiZ EtgtRH3+Q5rgmOstzydTaQcyHFEoBSPlXZ8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Only capital letters are allowed to be used for #define declarations The "SerialPrint" macro is definied for the PrePi module residing in the ArmPlatformPkg. It is never used in the module. The macro is thus removed. Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/PrePi/PrePi.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ArmPlatformPkg/PrePi/PrePi.h b/ArmPlatformPkg/PrePi/PrePi.h index b64dd764a435579db23532fa59f99a2dab7e3a34..2dce8c83024ec8301d294f12f10= b4ea6d2b7a61a 100644 --- a/ArmPlatformPkg/PrePi/PrePi.h +++ b/ArmPlatformPkg/PrePi/PrePi.h @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011-2015, ARM Limited. All rights reserved. +* Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
* * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -21,8 +21,6 @@ #include #include -#define SerialPrint(txt) SerialPortWrite (txt, AsciiStrLen(txt)+1); - extern UINT64 mSystemMemoryEnd; RETURN_STATUS -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68277): https://edk2.groups.io/g/devel/message/68277 Mute This Topic: https://groups.io/mt/78690964/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68278+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68278+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019634; cv=none; d=zohomail.com; s=zohoarc; b=FLbtJ32Jv37eZLLjR7FxunopQwQ4ritLKhPRfDDKQxVAB+E8TtQnEZjIZ/hnIRtBNJqi2XqCA2f/2SLDlRgar+BcVmgtc8hOyBp89dMpB6Wk36FpmILiS7e8Z4U0y9kLF6OXHwAr1cnM3XOpfFaIHE+HBV6eyxyNUg0AvYkcbFU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019634; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=sY+yFeh3gqaw2PenbU+NNjLCLPn7kZpbB35ZkIZs6so=; b=M4PJ4yXSSp/E/wzJVGC31koUNq5MKLPYp+jh1D8mviU01Y+Uw685TAOwkNkUmXAlJN0pGyY67E546f1YB0MlnFOumZvEJ2DqG0uL17Ns0K0PYqLNvkjzMp69ghc4vWlRP0BaN5Cl47r8zMP85mvJ7F6HUBqkG++8YAonJhe6I44= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68278+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607019634727475.82724899557195; Thu, 3 Dec 2020 10:20:34 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id t8NsYY1788612xSczVA1ftP6; Thu, 03 Dec 2020 10:20:34 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.895.1607019623536694866 for ; Thu, 03 Dec 2020 10:20:23 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2E21111FB; Thu, 3 Dec 2020 10:20:23 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 118503F575; Thu, 3 Dec 2020 10:20:21 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 15/16] ArmPlatformPkg: Fix Ecc error 8005 Date: Thu, 3 Dec 2020 18:19:44 +0000 Message-Id: <20201203181945.10880-16-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: GroPhU03jskutYZRlw88YHZrx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019634; bh=x7ywtoCPKFiUlx23w0+ofbUuNVp5JTKalrRAyzBoacE=; h=Cc:Date:From:Reply-To:Subject:To; b=DyVHQhx8P4b6w7LCJs4sse3dP5KwmJzqHdVUX9g2DTinB5jPOEfHkvCHuAMyj/OD0ia ydl9PweHWXDnxPkhx2WR0nKS3maMiVqwlPRTWM0weOcfvURW54UJ7kqz4zJt6tQUA5Fmn VOvHBNT8DLSUqqYT44K/pPjXM+1vXpHZ5h4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Indeed, according to the EDK II C Coding Standards Specification, s5.6.2.2 "Enumerated Types" and s4.3.4 Function and Data Names, elements of an enumerated type shoud be a mixed upper- and lower-case text. A max element is also added, as adviced by s5.6.2.2.3 of the same document. Reference: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/ Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c | 88 ++= ++++++++---------- ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c | 20 ++= --- ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.h | 4 +- ArmPlatformPkg/Include/Library/LcdPlatformLib.h | 21 ++= --- ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c | 4 +- ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 4 +- 6 files changed, 71 insertions(+), 70 deletions(-) diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputB= lt.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c index 07d2cb0d5dec0f85219fe5cdc438e18ae3a32a38..30b93900d223f550dab50741e7a= d8e5442bac245 100644 --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c @@ -61,7 +61,7 @@ VideoCopyNoHorizontalOverlap ( switch (BitsPerPixel) { - case LCD_BITS_PER_PIXEL_24: + case ELcdBitsPerPixel_24: WidthInBytes =3D Width * 4; @@ -79,9 +79,9 @@ VideoCopyNoHorizontalOverlap ( } break; - case LCD_BITS_PER_PIXEL_16_555: - case LCD_BITS_PER_PIXEL_16_565: - case LCD_BITS_PER_PIXEL_12_444: + case ELcdBitsPerPixel_16_555: + case ELcdBitsPerPixel_16_565: + case ELcdBitsPerPixel_12_444: WidthInBytes =3D Width * 2; @@ -99,10 +99,10 @@ VideoCopyNoHorizontalOverlap ( } break; - case LCD_BITS_PER_PIXEL_8: - case LCD_BITS_PER_PIXEL_4: - case LCD_BITS_PER_PIXEL_2: - case LCD_BITS_PER_PIXEL_1: + case ELcdBitsPerPixel_8: + case ELcdBitsPerPixel_4: + case ELcdBitsPerPixel_2: + case ELcdBitsPerPixel_1: default: // Can't handle this case DEBUG((DEBUG_ERROR, "ArmVeGraphics_Blt: EfiBltVideoToVideo: INVALID Nu= mber of Bits Per Pixel: %d\n", BitsPerPixel)); @@ -149,7 +149,7 @@ VideoCopyHorizontalOverlap ( switch (BitsPerPixel) { - case LCD_BITS_PER_PIXEL_24: + case ELcdBitsPerPixel_24: // Allocate a temporary buffer PixelBuffer32bit =3D (UINT32 *) AllocatePool((Height * Width) * sizeof= (UINT32)); @@ -191,9 +191,9 @@ VideoCopyHorizontalOverlap ( break; - case LCD_BITS_PER_PIXEL_16_555: - case LCD_BITS_PER_PIXEL_16_565: - case LCD_BITS_PER_PIXEL_12_444: + case ELcdBitsPerPixel_16_555: + case ELcdBitsPerPixel_16_565: + case ELcdBitsPerPixel_12_444: // Allocate a temporary buffer PixelBuffer16bit =3D (UINT16 *) AllocatePool((Height * Width) * sizeof= (UINT16)); @@ -236,10 +236,10 @@ VideoCopyHorizontalOverlap ( break; - case LCD_BITS_PER_PIXEL_8: - case LCD_BITS_PER_PIXEL_4: - case LCD_BITS_PER_PIXEL_2: - case LCD_BITS_PER_PIXEL_1: + case ELcdBitsPerPixel_8: + case ELcdBitsPerPixel_4: + case ELcdBitsPerPixel_2: + case ELcdBitsPerPixel_1: default: // Can't handle this case DEBUG((DEBUG_ERROR, "ArmVeGraphics_Blt: EfiBltVideoToVideo: INVALID Nu= mber of Bits Per Pixel: %d\n", BitsPerPixel)); @@ -270,7 +270,7 @@ BltVideoFill ( EFI_PIXEL_BITMASK* PixelInformation; EFI_STATUS Status; UINT32 HorizontalResolution; - LCD_BPP BitsPerPixel; + ELCD_BPP BitsPerPixel; VOID *FrameBufferBase; VOID *DestinationAddr; UINT16 *DestinationPixel16bit; @@ -287,7 +287,7 @@ BltVideoFill ( LcdPlatformGetBpp (This->Mode->Mode,&BitsPerPixel); switch (BitsPerPixel) { - case LCD_BITS_PER_PIXEL_24: + case ELcdBitsPerPixel_24: WidthInBytes =3D Width * 4; // Copy the SourcePixel into every pixel inside the target rectangle @@ -303,7 +303,7 @@ BltVideoFill ( } break; - case LCD_BITS_PER_PIXEL_16_555: + case ELcdBitsPerPixel_16_555: // Convert the EFI pixel at the start of the BltBuffer(0,0) into a vid= eo display pixel Pixel16bit =3D (UINT16) ( ( (EfiSourcePixel->Red << 7) & PixelInformation->RedMask = ) @@ -330,7 +330,7 @@ BltVideoFill ( } break; - case LCD_BITS_PER_PIXEL_16_565: + case ELcdBitsPerPixel_16_565: // Convert the EFI pixel at the start of the BltBuffer(0,0) into a vid= eo display pixel Pixel16bit =3D (UINT16) ( ( (EfiSourcePixel->Red << 8) & PixelInformation->RedMask = ) @@ -356,7 +356,7 @@ BltVideoFill ( } break; - case LCD_BITS_PER_PIXEL_12_444: + case ELcdBitsPerPixel_12_444: // Convert the EFI pixel at the start of the BltBuffer(0,0) into a vid= eo display pixel Pixel16bit =3D (UINT16) ( ( (EfiSourcePixel->Red >> 4) & PixelInformation->RedMask = ) @@ -382,10 +382,10 @@ BltVideoFill ( } break; - case LCD_BITS_PER_PIXEL_8: - case LCD_BITS_PER_PIXEL_4: - case LCD_BITS_PER_PIXEL_2: - case LCD_BITS_PER_PIXEL_1: + case ELcdBitsPerPixel_8: + case ELcdBitsPerPixel_4: + case ELcdBitsPerPixel_2: + case ELcdBitsPerPixel_1: default: // Can't handle this case DEBUG((DEBUG_ERROR, "LcdGraphicsBlt: EfiBltVideoFill: INVALID Number o= f Bits Per Pixel: %d\n", BitsPerPixel)); @@ -412,7 +412,7 @@ BltVideoToBltBuffer ( { EFI_STATUS Status; UINT32 HorizontalResolution; - LCD_BPP BitsPerPixel; + ELCD_BPP BitsPerPixel; EFI_PIXEL_BITMASK *PixelInformation; EFI_GRAPHICS_OUTPUT_BLT_PIXEL *EfiDestinationPixel; VOID *FrameBufferBase; @@ -443,7 +443,7 @@ BltVideoToBltBuffer ( LcdPlatformGetBpp (This->Mode->Mode,&BitsPerPixel); switch (BitsPerPixel) { - case LCD_BITS_PER_PIXEL_24: + case ELcdBitsPerPixel_24: WidthInBytes =3D Width * 4; // Access each line inside the Video Memory @@ -460,7 +460,7 @@ BltVideoToBltBuffer ( } break; - case LCD_BITS_PER_PIXEL_16_555: + case ELcdBitsPerPixel_16_555: // Access each pixel inside the Video Memory for (SourceLine =3D SourceY, DestinationLine =3D DestinationY; SourceLine < SourceY + Height; @@ -487,7 +487,7 @@ BltVideoToBltBuffer ( } break; - case LCD_BITS_PER_PIXEL_16_565: + case ELcdBitsPerPixel_16_565: // Access each pixel inside the Video Memory for (SourceLine =3D SourceY, DestinationLine =3D DestinationY; SourceLine < SourceY + Height; @@ -515,7 +515,7 @@ BltVideoToBltBuffer ( } break; - case LCD_BITS_PER_PIXEL_12_444: + case ELcdBitsPerPixel_12_444: // Access each pixel inside the Video Memory for (SourceLine =3D SourceY, DestinationLine =3D DestinationY; SourceLine < SourceY + Height; @@ -542,10 +542,10 @@ BltVideoToBltBuffer ( } break; - case LCD_BITS_PER_PIXEL_8: - case LCD_BITS_PER_PIXEL_4: - case LCD_BITS_PER_PIXEL_2: - case LCD_BITS_PER_PIXEL_1: + case ELcdBitsPerPixel_8: + case ELcdBitsPerPixel_4: + case ELcdBitsPerPixel_2: + case ELcdBitsPerPixel_1: default: // Can't handle this case DEBUG((DEBUG_ERROR, "LcdGraphicsBlt: EfiBltVideoToBltBuffer: INVALID N= umber of Bits Per Pixel: %d\n", BitsPerPixel)); @@ -571,7 +571,7 @@ BltBufferToVideo ( { EFI_STATUS Status; UINT32 HorizontalResolution; - LCD_BPP BitsPerPixel; + ELCD_BPP BitsPerPixel; EFI_PIXEL_BITMASK *PixelInformation; EFI_GRAPHICS_OUTPUT_BLT_PIXEL *EfiSourcePixel; VOID *FrameBufferBase; @@ -601,7 +601,7 @@ BltBufferToVideo ( LcdPlatformGetBpp (This->Mode->Mode,&BitsPerPixel); switch (BitsPerPixel) { - case LCD_BITS_PER_PIXEL_24: + case ELcdBitsPerPixel_24: WidthInBytes =3D Width * 4; // Access each pixel inside the BltBuffer Memory @@ -618,7 +618,7 @@ BltBufferToVideo ( } break; - case LCD_BITS_PER_PIXEL_16_555: + case ELcdBitsPerPixel_16_555: // Access each pixel inside the BltBuffer Memory for (SourceLine =3D SourceY, DestinationLine =3D DestinationY; SourceLine < SourceY + Height; @@ -645,7 +645,7 @@ BltBufferToVideo ( } break; - case LCD_BITS_PER_PIXEL_16_565: + case ELcdBitsPerPixel_16_565: // Access each pixel inside the BltBuffer Memory for (SourceLine =3D SourceY, DestinationLine =3D DestinationY; SourceLine < SourceY + Height; @@ -672,7 +672,7 @@ BltBufferToVideo ( } break; - case LCD_BITS_PER_PIXEL_12_444: + case ELcdBitsPerPixel_12_444: // Access each pixel inside the BltBuffer Memory for (SourceLine =3D SourceY, DestinationLine =3D DestinationY; SourceLine < SourceY + Height; @@ -699,10 +699,10 @@ BltBufferToVideo ( } break; - case LCD_BITS_PER_PIXEL_8: - case LCD_BITS_PER_PIXEL_4: - case LCD_BITS_PER_PIXEL_2: - case LCD_BITS_PER_PIXEL_1: + case ELcdBitsPerPixel_8: + case ELcdBitsPerPixel_4: + case ELcdBitsPerPixel_2: + case ELcdBitsPerPixel_1: default: // Can't handle this case DEBUG((DEBUG_ERROR, "LcdGraphicsBlt: EfiBltBufferToVideo: INVALID Numb= er of Bits Per Pixel: %d\n", BitsPerPixel)); @@ -728,7 +728,7 @@ BltVideoToVideo ( { EFI_STATUS Status; UINT32 HorizontalResolution; - LCD_BPP BitsPerPixel; + ELCD_BPP BitsPerPixel; VOID *FrameBufferBase; HorizontalResolution =3D This->Mode->Info->HorizontalResolution; diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputD= xe.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c index bfd03d8f84258158e76690cc5a0d9333f11d67f0..d85a3830355d6d091c94c1fa33c= ed4f8a6313947 100644 --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c @@ -299,7 +299,7 @@ LcdGraphicsSetMode ( EFI_STATUS Status; EFI_GRAPHICS_OUTPUT_BLT_PIXEL FillColour; LCD_INSTANCE* Instance; - LCD_BPP Bpp; + ELCD_BPP Bpp; Instance =3D LCD_INSTANCE_FROM_GOP_THIS (This); @@ -370,22 +370,22 @@ EXIT: UINTN GetBytesPerPixel ( - IN LCD_BPP Bpp + IN ELCD_BPP Bpp ) { switch (Bpp) { - case LCD_BITS_PER_PIXEL_24: + case ELcdBitsPerPixel_24: return 4; - case LCD_BITS_PER_PIXEL_16_565: - case LCD_BITS_PER_PIXEL_16_555: - case LCD_BITS_PER_PIXEL_12_444: + case ELcdBitsPerPixel_16_565: + case ELcdBitsPerPixel_16_555: + case ELcdBitsPerPixel_12_444: return 2; - case LCD_BITS_PER_PIXEL_8: - case LCD_BITS_PER_PIXEL_4: - case LCD_BITS_PER_PIXEL_2: - case LCD_BITS_PER_PIXEL_1: + case ELcdBitsPerPixel_8: + case ELcdBitsPerPixel_4: + case ELcdBitsPerPixel_2: + case ELcdBitsPerPixel_1: return 1; default: diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputD= xe.h b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.h index c49afd3b058f2d2b3c91b1a2d4446a8fcde5202d..6a64fc2bb9dfb10b7d9ca9e4c34= cc33a83ff08e6 100644 --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.h +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.h @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2011-2018, ARM Ltd. All rights reserved.
+ Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -83,7 +83,7 @@ LcdGraphicsBlt ( UINTN GetBytesPerPixel ( - IN LCD_BPP Bpp + IN ELCD_BPP Bpp ); EFI_STATUS diff --git a/ArmPlatformPkg/Include/Library/LcdPlatformLib.h b/ArmPlatformP= kg/Include/Library/LcdPlatformLib.h index ba24487073bb32296104270d78b0e1928193c9e8..eecf2920537d951feb6c76a51f8= d66854806acbc 100644 --- a/ArmPlatformPkg/Include/Library/LcdPlatformLib.h +++ b/ArmPlatformPkg/Include/Library/LcdPlatformLib.h @@ -197,15 +197,16 @@ Register **/ typedef enum { - LCD_BITS_PER_PIXEL_1 =3D 0, - LCD_BITS_PER_PIXEL_2, - LCD_BITS_PER_PIXEL_4, - LCD_BITS_PER_PIXEL_8, - LCD_BITS_PER_PIXEL_16_555, - LCD_BITS_PER_PIXEL_24, - LCD_BITS_PER_PIXEL_16_565, - LCD_BITS_PER_PIXEL_12_444 -} LCD_BPP; + ELcdBitsPerPixel_1 =3D 0, + ELcdBitsPerPixel_2, + ELcdBitsPerPixel_4, + ELcdBitsPerPixel_8, + ELcdBitsPerPixel_16_555, + ELcdBitsPerPixel_24, + ELcdBitsPerPixel_16_565, + ELcdBitsPerPixel_12_444, + ELcdBitsPerPixel_Max +} ELCD_BPP; // Display timing settings. typedef struct { @@ -320,7 +321,7 @@ LcdPlatformGetTimings ( EFI_STATUS LcdPlatformGetBpp ( IN UINT32 ModeNumber, - OUT LCD_BPP* Bpp + OUT ELCD_BPP* Bpp ); #endif /* LCD_PLATFORM_LIB_H_ */ diff --git a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c= b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c index dca3cf706ee12e2c1e1545e43b862ea87e16395b..ca80eeb83993cfdce6d2428b94b= 9b8163f0e55ad 100644 --- a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c +++ b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c @@ -1,7 +1,7 @@ /** @file Copyright (c) 2017, Linaro, Ltd. All rights reserved. - Copyright (c) 2018, Arm Limited. All rights reserved. + Copyright (c) 2018 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -137,7 +137,7 @@ LcdPlatformGetTimings ( EFI_STATUS LcdPlatformGetBpp ( IN UINT32 ModeNumber, - OUT LCD_BPP* Bpp + OUT ELCD_BPP* Bpp ) { ASSERT (FALSE); diff --git a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c b/ArmPlatformPkg/Li= brary/PL111Lcd/PL111Lcd.c index 05b6f8974f12fafd53cdff2314d33f9c93d79670..ace6c5eb3cbbaa784c5d1f40ee3= b372551d83820 100644 --- a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c +++ b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c @@ -1,7 +1,7 @@ /** @file This file contains the platform independent parts of PL111Lcd - Copyright (c) 2011-2018, ARM Ltd. All rights reserved.
+ Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -80,7 +80,7 @@ LcdSetMode ( SCAN_TIMINGS *Horizontal; SCAN_TIMINGS *Vertical; UINT32 LcdControl; - LCD_BPP LcdBpp; + ELCD_BPP LcdBpp; EFI_GRAPHICS_OUTPUT_MODE_INFORMATION ModeInfo; -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68278): https://edk2.groups.io/g/devel/message/68278 Mute This Topic: https://groups.io/mt/78690966/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 13:35:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68279+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68279+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1607019626; cv=none; d=zohomail.com; s=zohoarc; b=RzJ4Q5MTs0QuIvvbcKCg9E6vasBdoHh69cIXpcF3rcjsZ2qI2bsors71g0uCyQdLeZ0eZSRtRXNglJC6SCTDG70eze161kNXNtPEOIfcPmbtVwFvL1JQFVUdthYZFr5lZxVWALQxbeTZFp2kSYM1uFAMTjS3i694kBBqY2qej3M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607019626; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=0GEJkZs6WHT0WZMUaUvxl6aRSFGMb7X5azR55g1dNX0=; b=i6owO2w/ejeNg1lgEiYgV27xGuajfujJf8vKNUL15UjNKrfU7C1heqobFrBvTBqLKmwMXxMAuKVrvI1NrTb0ju31ovYcdm9/pXWWbvleGvGq/ptw4Kz/8LUjuDjY6Lpecrr0/MSTvYwVwBvomsUzp2Id4Lw7vlNb9xZS0bvF0zg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68279+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607019626141860.4629976689868; Thu, 3 Dec 2020 10:20:26 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 0fs4YY1788612xKu1Df3XV40; Thu, 03 Dec 2020 10:20:25 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.847.1607019624921413775 for ; Thu, 03 Dec 2020 10:20:25 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8875811D4; Thu, 3 Dec 2020 10:20:24 -0800 (PST) X-Received: from e120189.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 68C223F575; Thu, 3 Dec 2020 10:20:23 -0800 (PST) From: "PierreGondois" To: leif@nuviainc.com, ard.biesheuvel@arm.com, thomas.abraham@arm.com, devel@edk2.groups.io Cc: sami.mujawar@arm.com Subject: [edk2-devel] [PATCH v1 16/16] ArmPlatformPkg: Fix cspell reported spelling/wording Date: Thu, 3 Dec 2020 18:19:45 +0000 Message-Id: <20201203181945.10880-17-Pierre.Gondois@arm.com> In-Reply-To: <20201203181945.10880-1-Pierre.Gondois@arm.com> References: <20201203181945.10880-1-Pierre.Gondois@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: Jhm1lOZhSALYDXxqSmkrRNFsx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607019625; bh=i8IHjQ3SrnTOh4AwpWDkVSs3vVss663+ATCCYOBhOC4=; h=Cc:Date:From:Reply-To:Subject:To; b=pMCxtOH+5qR61uybsMBGR6uxIzuAtBCsfS4ZC/so3/vgzovbp7mUHR7t3EBwCX/nIsN uIer9NqNMVLwgmFBnsyXPtNenI4KRgWVV1+CM9Fb1oXAZyTgH4oqOJfsj9Qn6XP2gE4Iy q7f02BvO3h8rvBUlqrEl4huszShkhw9z9OQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois The edk2 CI runs the "cspell" spell checker tool. Some words are not recognized by the tool, triggering errors. This patch modifies some spelling/wording detected by cspell. Signed-off-by: Pierre Gondois Reviewed-by: Ard Biesheuvel --- The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tr= ee/1537_Ecc_ArmPlatformPkg_v1 ArmPlatformPkg/ArmPlatformPkg.dsc | 4 ++-- ArmPlatformPkg/PrePi/AArch64/ModuleEntryPoint.S | 4 ++-- ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S | 4 ++-- ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/ArmPlatformPkg/ArmPlatformPkg.dsc b/ArmPlatformPkg/ArmPlatform= Pkg.dsc index 877b12b3b430393e1d8031bf2611c82e0785f2a6..b92ef712be870168c3097e20d2b= 88070553ab175 100644 --- a/ArmPlatformPkg/ArmPlatformPkg.dsc +++ b/ArmPlatformPkg/ArmPlatformPkg.dsc @@ -26,8 +26,8 @@ [Defines] SKUID_IDENTIFIER =3D DEFAULT [BuildOptions] - RELEASE_*_*_CC_FLAGS =3D -DMDEPKG_NDEBUG - *_*_*_CC_FLAGS =3D -DDISABLE_NEW_DEPRECATED_INTERFACES + RELEASE_*_*_CC_FLAGS =3D -D MDEPKG_NDEBUG + *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES [PcdsFixedAtBuild] gArmTokenSpaceGuid.PcdFdBaseAddress|0x0 diff --git a/ArmPlatformPkg/PrePi/AArch64/ModuleEntryPoint.S b/ArmPlatformP= kg/PrePi/AArch64/ModuleEntryPoint.S index 4929ca42edcede492b1303ccd05a9bb0d4b06ccb..e3aa546897cb0c2131edd352f08= 75f43d91ba86e 100644 --- a/ArmPlatformPkg/PrePi/AArch64/ModuleEntryPoint.S +++ b/ArmPlatformPkg/PrePi/AArch64/ModuleEntryPoint.S @@ -1,5 +1,5 @@ // -// Copyright (c) 2011-2015, ARM Limited. All rights reserved. +// Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
// // SPDX-License-Identifier: BSD-2-Clause-Patent // @@ -11,7 +11,7 @@ ASM_FUNC(_ModuleEntryPoint) // Do early platform specific actions bl ASM_PFX(ArmPlatformPeiBootAction) - // Get ID of this CPU in Multicore system + // Get ID of this CPU in multi-core system bl ASM_PFX(ArmReadMpidr) // Keep a copy of the MpId register value mov x10, x0 diff --git a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S b/ArmPlatformPkg/P= rePi/Arm/ModuleEntryPoint.S index ff7e3a4548539d80b5dc94e6688dfde8dd0b8c8f..6709dad0b9d1a75b505c88a8bb5= 9c7000f622f8f 100644 --- a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S +++ b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S @@ -1,5 +1,5 @@ // -// Copyright (c) 2011-2015, ARM Limited. All rights reserved. +// Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
// // SPDX-License-Identifier: BSD-2-Clause-Patent // @@ -13,7 +13,7 @@ ASM_FUNC(_ModuleEntryPoint) // Do early platform specific actions bl ASM_PFX(ArmPlatformPeiBootAction) - // Get ID of this CPU in Multicore system + // Get ID of this CPU in multi-core system bl ASM_PFX(ArmReadMpidr) // Keep a copy of the MpId register value mov r8, r0 diff --git a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm b/ArmPlatformPkg= /PrePi/Arm/ModuleEntryPoint.asm index 3da789205124525b9278dc49b92af6f30573cf16..eaba90cc3d7c329a40d3d80c17a= 0e5132aeccd77 100644 --- a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm +++ b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.asm @@ -1,5 +1,5 @@ // -// Copyright (c) 2011-2015, ARM Limited. All rights reserved. +// Copyright (c) 2011 - 2020, Arm Limited. All rights reserved.
// // SPDX-License-Identifier: BSD-2-Clause-Patent // @@ -28,7 +28,7 @@ _ModuleEntryPoint // Do early platform specific actions bl ArmPlatformPeiBootAction - // Get ID of this CPU in Multicore system + // Get ID of this CPU in multi-core system bl ArmReadMpidr // Keep a copy of the MpId register value mov r8, r0 -- 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68279): https://edk2.groups.io/g/devel/message/68279 Mute This Topic: https://groups.io/mt/78690967/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-