From nobody Tue Feb 10 04:16:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67906+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67906+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1606245365; cv=none; d=zohomail.com; s=zohoarc; b=hKvLab/PYoFxjbSebV6yFGIyNlTFvDvYeqAJcGZql5dY12hm7hSyfTOF70ab5rlu3pCOGFIumIE/x6nv/PBYxWRo/JMCDhl2VO/lqsrV+5Zi3wumOdE5lmZeQ757eb/UV4LMq0Wxpobc52kU3iSgsW84i4jGT3bqtte7fddOgvI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606245365; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=fQjhSH6mhhk+fAV+ZjTerrGr2eUk0Ocm3NE4p53aH0E=; b=KldfQIUvXI2v7wQ4s6hQDNP9i5vubgVe+AcKL178kKvHBRnqJEe1XcTiBrN9MGHrDZbYXdjq7L4C5Wgfm29EgNPS4MZOGRapvUlG2COnkzFiCFktZcWEDqLyvyTtS735HRJ9TxKHBRINb1byvvef2zbCvaQ9N1H8c0vKoGoOLWo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67906+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1606245365445132.5492447702668; Tue, 24 Nov 2020 11:16:05 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id b5U2YY1788612xvQrGQa9ZCY; Tue, 24 Nov 2020 11:16:05 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.1918.1606245354439792764 for ; Tue, 24 Nov 2020 11:15:54 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E4B8143D; Tue, 24 Nov 2020 11:15:54 -0800 (PST) X-Received: from U203705.Arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A86F83F70D; Tue, 24 Nov 2020 11:15:53 -0800 (PST) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Zhichao Gao , Ray Ni , Ard Biesheuvel , Pete Batard Subject: [edk2-devel] [PATCH v1 1/3] MdeModulePkg/GraphicsConsoleDxe: Change default CursorVisible to FALSE Date: Tue, 24 Nov 2020 14:15:44 -0500 Message-Id: <20201124191546.17403-2-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20201124191546.17403-1-Samer.El-Haj-Mahmoud@arm.com> References: <20201124191546.17403-1-Samer.El-Haj-Mahmoud@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,samer.el-haj-mahmoud@arm.com X-Gm-Message-State: rrkrNjZ8BVuRTPhkwUdpzq7Hx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1606245365; bh=t29L1mh3xybvS2+kKzzRKJ4p21Jc2XZmjDIcUjCRbb4=; h=Cc:Date:From:Reply-To:Subject:To; b=SErxz7w2bCJRrklbp4NKWVJZkCqyyEi9ZA3CjcBofYcEZsa5/ueN6u1kcUYrfrzcjZF WzIKfFl/qmHGraf5dY7iXVzVy+gJ7HqMZ2vPH9McgeNWbh3IISFkeeOXPEuZrEgrPGr5c RcwPOkvTByfS+R4bTfx7xjRBrN2ueXKMn8M= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://github.com/pftf/RPi4/issues/115 GraphicsConsoleDxe defaults the ConOut Mode.CursorVisible to TRUE. However, the driver never draws the cursor during init. This results in the first call to disable the cursor (using ConOut->EnableCursor(FALSE)) to actually draw the cursor on the screen, as the logic in FlushCursor depe= nds on the Mode.CursorVisible state to determine if it should draw or erase the cursor. Fix by changing the default CursorVisible in this driver to FALSE. Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Cc: Ard Biesheuvel Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud Reviewed-by: Zhichao Gao --- MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsCons= ole.c b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c index c042451a9b52..6b8d11d587d1 100644 --- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c +++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c @@ -33,7 +33,7 @@ GRAPHICS_CONSOLE_DEV mGraphicsConsoleDevTemplate =3D { EFI_TEXT_ATTR(EFI_LIGHTGRAY, EFI_BLACK), 0, 0, - TRUE + FALSE }, (GRAPHICS_CONSOLE_MODE_DATA *) NULL, (EFI_GRAPHICS_OUTPUT_BLT_PIXEL *) NULL --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67906): https://edk2.groups.io/g/devel/message/67906 Mute This Topic: https://groups.io/mt/78484573/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-