From nobody Mon May 6 19:46:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67906+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67906+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1606245365; cv=none; d=zohomail.com; s=zohoarc; b=hKvLab/PYoFxjbSebV6yFGIyNlTFvDvYeqAJcGZql5dY12hm7hSyfTOF70ab5rlu3pCOGFIumIE/x6nv/PBYxWRo/JMCDhl2VO/lqsrV+5Zi3wumOdE5lmZeQ757eb/UV4LMq0Wxpobc52kU3iSgsW84i4jGT3bqtte7fddOgvI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606245365; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=fQjhSH6mhhk+fAV+ZjTerrGr2eUk0Ocm3NE4p53aH0E=; b=KldfQIUvXI2v7wQ4s6hQDNP9i5vubgVe+AcKL178kKvHBRnqJEe1XcTiBrN9MGHrDZbYXdjq7L4C5Wgfm29EgNPS4MZOGRapvUlG2COnkzFiCFktZcWEDqLyvyTtS735HRJ9TxKHBRINb1byvvef2zbCvaQ9N1H8c0vKoGoOLWo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67906+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1606245365445132.5492447702668; Tue, 24 Nov 2020 11:16:05 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id b5U2YY1788612xvQrGQa9ZCY; Tue, 24 Nov 2020 11:16:05 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.1918.1606245354439792764 for ; Tue, 24 Nov 2020 11:15:54 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E4B8143D; Tue, 24 Nov 2020 11:15:54 -0800 (PST) X-Received: from U203705.Arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A86F83F70D; Tue, 24 Nov 2020 11:15:53 -0800 (PST) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Zhichao Gao , Ray Ni , Ard Biesheuvel , Pete Batard Subject: [edk2-devel] [PATCH v1 1/3] MdeModulePkg/GraphicsConsoleDxe: Change default CursorVisible to FALSE Date: Tue, 24 Nov 2020 14:15:44 -0500 Message-Id: <20201124191546.17403-2-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20201124191546.17403-1-Samer.El-Haj-Mahmoud@arm.com> References: <20201124191546.17403-1-Samer.El-Haj-Mahmoud@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,samer.el-haj-mahmoud@arm.com X-Gm-Message-State: rrkrNjZ8BVuRTPhkwUdpzq7Hx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1606245365; bh=t29L1mh3xybvS2+kKzzRKJ4p21Jc2XZmjDIcUjCRbb4=; h=Cc:Date:From:Reply-To:Subject:To; b=SErxz7w2bCJRrklbp4NKWVJZkCqyyEi9ZA3CjcBofYcEZsa5/ueN6u1kcUYrfrzcjZF WzIKfFl/qmHGraf5dY7iXVzVy+gJ7HqMZ2vPH9McgeNWbh3IISFkeeOXPEuZrEgrPGr5c RcwPOkvTByfS+R4bTfx7xjRBrN2ueXKMn8M= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://github.com/pftf/RPi4/issues/115 GraphicsConsoleDxe defaults the ConOut Mode.CursorVisible to TRUE. However, the driver never draws the cursor during init. This results in the first call to disable the cursor (using ConOut->EnableCursor(FALSE)) to actually draw the cursor on the screen, as the logic in FlushCursor depe= nds on the Mode.CursorVisible state to determine if it should draw or erase the cursor. Fix by changing the default CursorVisible in this driver to FALSE. Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Cc: Ard Biesheuvel Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud Reviewed-by: Zhichao Gao --- MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsCons= ole.c b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c index c042451a9b52..6b8d11d587d1 100644 --- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c +++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c @@ -33,7 +33,7 @@ GRAPHICS_CONSOLE_DEV mGraphicsConsoleDevTemplate =3D { EFI_TEXT_ATTR(EFI_LIGHTGRAY, EFI_BLACK), 0, 0, - TRUE + FALSE }, (GRAPHICS_CONSOLE_MODE_DATA *) NULL, (EFI_GRAPHICS_OUTPUT_BLT_PIXEL *) NULL --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67906): https://edk2.groups.io/g/devel/message/67906 Mute This Topic: https://groups.io/mt/78484573/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 19:46:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67907+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67907+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1606245361; cv=none; d=zohomail.com; s=zohoarc; b=WIMwCCcumUqxW5TeZm2pYxwczXm+G9r1q/VOVQrWK0/l3VNKJzV1hWyRmKOA7vKtIktGPHo652QR5VX1wdEVedndbtjsf8qMKRaPlvv2Sl9kOKTNAlfSstoyxRtRQu3Q6N3AdmwQQba2AhdGaPc9FkBmGcdn5G6wPALoDkM3qnE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606245361; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=5tXH//GB+5oE5UUqMZx9Ru6auoq3e4bC5lCjgB63GZA=; b=BY2ICCzqcqQjYrFteJOJsX5S2EBRmliuNfpvNsZvghe8qc9uzkzWnHdsR3cnqfnUqGFpBdeXGQDdhdtIPz1q1vm4SjC/URCR6s93KiXRM3MeunnOoGeE0NQsHgxiqvGzEB65eYbAqPL36UVqFeOM6xwYxVNQ4zLawUGBS6pmlVc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67907+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1606245361094126.34333939469661; Tue, 24 Nov 2020 11:16:01 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id A97HYY1788612x9hUX5H3me8; Tue, 24 Nov 2020 11:16:00 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.1918.1606245354866460706 for ; Tue, 24 Nov 2020 11:15:55 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 781AB1478; Tue, 24 Nov 2020 11:15:54 -0800 (PST) X-Received: from U203705.Arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1EAD73F70D; Tue, 24 Nov 2020 11:15:54 -0800 (PST) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Zhichao Gao , Ray Ni , Ard Biesheuvel , Pete Batard Subject: [edk2-devel] [PATCH v1 2/3] MdeModulePkg/Graphics: Fix spelling mistakes Date: Tue, 24 Nov 2020 14:15:45 -0500 Message-Id: <20201124191546.17403-3-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20201124191546.17403-1-Samer.El-Haj-Mahmoud@arm.com> References: <20201124191546.17403-1-Samer.El-Haj-Mahmoud@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,samer.el-haj-mahmoud@arm.com X-Gm-Message-State: ilzUi8WouKY7oV4WddY2eYKyx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1606245360; bh=MbWxmJBQercnhUDQQNmcvlL+gpog8OYa8siaQdHvfk4=; h=Cc:Date:From:Reply-To:Subject:To; b=gv5Fa0iiJ5qgvXfAO/RGIChbtbTgWb7NHVLLkZZ5hMf7pXrDIu3XRZS7r9RcDGy3RGD EzyMfweYtKIHNWDy1qUEjSHvI1QPgv5VibYD7tuvMt60WFksMNDLP1w4m/b9cqOaUfbQo Mm00SQ5VXDBexJ5lz5djdatpTG8m0IB+Zes= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Fix various spelling mistakes in GraphicsConsoleDxe, ConsPlitter, and SimpleTextOut header Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Cc: Ard Biesheuvel Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud Reviewed-by: Zhichao Gao --- MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.h | 8 += -- MdePkg/Include/Protocol/SimpleTextOut.h | 6 +- MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 66 += +++++++++---------- MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c | 12 += +-- 4 files changed, 46 insertions(+), 46 deletions(-) diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsCons= ole.h b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.h index 28d47ac7cb1e..11d254b70f32 100644 --- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.h +++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.h @@ -205,7 +205,7 @@ GraphicsConsoleComponentNameGetControllerName ( Reset the text output device hardware and optionally run diagnostics. =20 Implements SIMPLE_TEXT_OUTPUT.Reset(). - If ExtendeVerification is TRUE, then perform dependent Graphics Console + If ExtendedVerification is TRUE, then perform dependent Graphics Console device reset, and set display mode to mode 0. If ExtendedVerification is FALSE, only set display mode to mode 0. =20 @@ -286,7 +286,7 @@ GraphicsConsoleConOutTestString ( supports =20 Implements SIMPLE_TEXT_OUTPUT.QueryMode(). - It returnes information for an available text mode that the Graphics Con= sole supports. + It returns information for an available text mode that the Graphics Cons= ole supports. In this driver,we only support text mode 80x25, which is defined as mode= 0. =20 @param This Protocol instance pointer. @@ -422,7 +422,7 @@ GraphicsConsoleConOutEnableCursor ( /** Test to see if Graphics Console could be supported on the Controller. =20 - Graphics Console could be supported if Graphics Output Protocol or UGA D= raw + Graphics Console could be supported if Graphics Output Protocol or UGADr= aw Protocol exists on the Controller. (UGA Draw Protocol could be skipped if PcdUgaConsumeSupport is set to FALSE.) =20 @@ -510,7 +510,7 @@ EfiLocateHiiProtocol ( =20 =20 /** - Gets Graphics Console devcie's foreground color and background color. + Gets Graphics Console device's foreground color and background color. =20 @param This Protocol instance pointer. @param Foreground Returned text foreground color. diff --git a/MdePkg/Include/Protocol/SimpleTextOut.h b/MdePkg/Include/Proto= col/SimpleTextOut.h index a849c08d66df..100d69a23a9b 100644 --- a/MdePkg/Include/Protocol/SimpleTextOut.h +++ b/MdePkg/Include/Protocol/SimpleTextOut.h @@ -32,7 +32,7 @@ typedef struct _EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL EFI_SIMPL= E_TEXT_OUTPUT_PROTOCOL; typedef EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL SIMPLE_TEXT_OUTPUT_INTERFACE; =20 // -// Define's for required EFI Unicode Box Draw characters +// Defines for required EFI Unicode Box Draw characters // #define BOXDRAW_HORIZONTAL 0x2500 #define BOXDRAW_VERTICAL 0x2502 @@ -151,7 +151,7 @@ typedef EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL SIMPLE_TEXT_O= UTPUT_INTERFACE; #define EFI_WIDE_ATTRIBUTE 0x80 =20 /** - Reset the text output device hardware and optionaly run diagnostics + Reset the text output device hardware and optionally run diagnostics =20 @param This The protocol instance pointer. @param ExtendedVerification Driver may perform more exhaustive verifica= tion @@ -373,7 +373,7 @@ typedef struct { /// INT32 CursorRow; /// - /// The cursor is currently visbile or not. + /// The cursor is currently visible or not. /// BOOLEAN CursorVisible; } EFI_SIMPLE_TEXT_OUTPUT_MODE; diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/= MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c index 9c38271b65f9..b090de288517 100644 --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c @@ -1,5 +1,5 @@ /** @file - Console Splitter Driver. Any Handle that attatched console I/O protocols + Console Splitter Driver. Any Handle that attached console I/O protocols (Console In device, Console Out device, Console Error device, Simple Poi= nter protocol, Absolute Pointer protocol) can be bound by this driver. =20 @@ -13,7 +13,7 @@ =20 Each virtual handle, that supports the Console I/O protocol, will be pro= duced in the driver entry point. The virtual handle are added on driver entry = and - never removed. Such design ensures sytem function well during none conso= le + never removed. Such design ensures system function well during none cons= ole device situation. =20 Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
@@ -381,7 +381,7 @@ ToggleStateSyncInitialization ( } =20 /** - Reinitialization for toggle state sync. + Re-initialization for toggle state sync. =20 @param Private Text In Splitter pointer. =20 @@ -594,7 +594,7 @@ ConSplitterDriverEntry( structure. =20 @retval EFI_OUT_OF_RESOURCES Out of resources. - @retval EFI_SUCCESS Text Input Devcie's private data has be= en constructed. + @retval EFI_SUCCESS Text Input Device's private data has be= en constructed. @retval other Failed to construct private data. =20 **/ @@ -761,7 +761,7 @@ ConSplitterTextOutConstructor ( } =20 // - // Initilize console output splitter's private data. + // Initialize console output splitter's private data. // ConOutPrivate->TextOut.Mode =3D &ConOutPrivate->TextOutMode; =20 @@ -860,7 +860,7 @@ ConSplitterTextOutConstructor ( @param Guid The specified protocol. =20 @retval EFI_SUCCESS The specified protocol is supported on this = device. - @retval EFI_UNSUPPORTED The specified protocol attempts to be instal= led on virtul handle. + @retval EFI_UNSUPPORTED The specified protocol attempts to be instal= led on virtual handle. @retval other Failed to open specified protocol on this de= vice. =20 **/ @@ -1108,7 +1108,7 @@ ConSplitterStart ( } =20 // - // Open InterfaceGuid on the virtul handle. + // Open InterfaceGuid on the virtual handle. // Status =3D gBS->OpenProtocol ( ControllerHandle, @@ -1174,7 +1174,7 @@ ConSplitterConInDriverBindingStart ( =20 // // Start ConSplitter on ControllerHandle, and create the virtual - // agrogated console device on first call Start for a SimpleTextIn handl= e. + // aggregated console device on first call Start for a SimpleTextIn hand= le. // Status =3D ConSplitterStart ( This, @@ -1241,7 +1241,7 @@ ConSplitterSimplePointerDriverBindingStart ( =20 // // Start ConSplitter on ControllerHandle, and create the virtual - // agrogated console device on first call Start for a SimplePointer hand= le. + // aggregated console device on first call Start for a SimplePointer han= dle. // Status =3D ConSplitterStart ( This, @@ -1287,7 +1287,7 @@ ConSplitterAbsolutePointerDriverBindingStart ( =20 // // Start ConSplitter on ControllerHandle, and create the virtual - // agrogated console device on first call Start for a AbsolutePointer ha= ndle. + // aggregated console device on first call Start for a AbsolutePointer h= andle. // Status =3D ConSplitterStart ( This, @@ -1338,7 +1338,7 @@ ConSplitterConOutDriverBindingStart ( =20 // // Start ConSplitter on ControllerHandle, and create the virtual - // agrogated console device on first call Start for a ConsoleOut handle. + // aggregated console device on first call Start for a ConsoleOut handle. // Status =3D ConSplitterStart ( This, @@ -1451,7 +1451,7 @@ ConSplitterStdErrDriverBindingStart ( =20 // // Start ConSplitter on ControllerHandle, and create the virtual - // agrogated console device on first call Start for a StandardError hand= le. + // aggregated console device on first call Start for a StandardError han= dle. // Status =3D ConSplitterStart ( This, @@ -1522,7 +1522,7 @@ ConSplitterStop ( return Status; } // - // close the protocol refered. + // close the protocol referred. // gBS->CloseProtocol ( ControllerHandle, @@ -1543,7 +1543,7 @@ ConSplitterStop ( =20 =20 /** - Stop Console In ConSplitter on ControllerHandle by closing Console In De= vcice GUID. + Stop Console In ConSplitter on ControllerHandle by closing Console In De= vice GUID. =20 @param This Driver Binding protocol instance pointer. @param ControllerHandle Handle of device to stop driver on @@ -1718,7 +1718,7 @@ ConSplitterAbsolutePointerDriverBindingStop ( =20 =20 /** - Stop Console Out ConSplitter on device handle by closing Console Out Dev= cice GUID. + Stop Console Out ConSplitter on device handle by closing Console Out Dev= cie GUID. =20 @param This Driver Binding protocol instance pointer. @param ControllerHandle Handle of device to stop driver on @@ -2725,7 +2725,7 @@ ConSplitterGetIntersectionBetweenConOutAndStrErr ( =20 =20 /** - Add Grahpics Output modes into Consplitter Text Out list. + Add Graphics Output modes into Consplitter Text Out list. =20 @param Private Text Out Splitter pointer. @param GraphicsOutput Graphics Output protocol pointer. @@ -3392,7 +3392,7 @@ ConSplitterTextOutDeleteDevice ( return EFI_SUCCESS; } // - // Max Mode is realy an intersection of the QueryMode command to all + // Max Mode is really an intersection of the QueryMode command to all // devices. So we must copy the QueryMode of the first device to // QueryData. // @@ -3430,7 +3430,7 @@ ConSplitterTextOutDeleteDevice ( =20 =20 /** - Reset the input device and optionaly run diagnostics + Reset the input device and optionally run diagnostics =20 @param This Protocol instance pointer. @param ExtendedVerification Driver may perform diagnostics on reset. @@ -3514,7 +3514,7 @@ ConSplitterTextInExDequeueKey ( =20 /** Reads the next keystroke from the input device. The WaitForKey Event can - be used to test for existance of a keystroke via WaitForEvent () call. + be used to test for existence of a keystroke via WaitForEvent () call. =20 @param Private Protocol instance pointer. @param Key Driver may perform diagnostics on reset. @@ -3587,7 +3587,7 @@ ConSplitterTextInPrivateReadKeyStroke ( =20 /** Reads the next keystroke from the input device. The WaitForKey Event can - be used to test for existance of a keystroke via WaitForEvent () call. + be used to test for existence of a keystroke via WaitForEvent () call. =20 @param This Protocol instance pointer. @param Key Driver may perform diagnostics on reset. @@ -3631,7 +3631,7 @@ ConSplitterTextInReadKeyStroke ( spliter event. This will cause the calling code to call ConSplitterTextInReadKeyStroke (). =20 - @param Event The Event assoicated with callback. + @param Event The Event associated with callback. @param Context Context registered when Event was creat= ed. =20 **/ @@ -3681,7 +3681,7 @@ ConSplitterTextInWaitForKey ( pressed. =20 @retval TRUE Key be pressed matches a registered key. - @retval FLASE Match failed. + @retval FALSE Match failed. =20 **/ BOOLEAN @@ -3715,7 +3715,7 @@ IsKeyRegistered ( =20 =20 /** - Reset the input device and optionaly run diagnostics + Reset the input device and optionally run diagnostics =20 @param This Protocol instance pointer. @param ExtendedVerification Driver may perform diagnostics on reset. @@ -3769,7 +3769,7 @@ ConSplitterTextInResetEx ( =20 /** Reads the next keystroke from the input device. The WaitForKey Event can - be used to test for existance of a keystroke via WaitForEvent () call. + be used to test for existence of a keystroke via WaitForEvent () call. =20 @param This Protocol instance pointer. @param KeyData A pointer to a buffer that is filled in= with the @@ -3978,7 +3978,7 @@ ConSplitterTextInSetState ( =20 @retval EFI_SUCCESS The notification function was registered successfully. - @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necess= sary data + @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necess= ary data structures. @retval EFI_INVALID_PARAMETER KeyData or KeyNotificationFunction or N= otifyHandle is NULL. =20 @@ -4126,7 +4126,7 @@ ConSplitterTextInUnregisterKeyNotify ( =20 =20 /** - Reset the input device and optionaly run diagnostics + Reset the input device and optionally run diagnostics =20 @param This Protocol instance pointer. @param ExtendedVerification Driver may perform diagnostics on reset. @@ -4174,7 +4174,7 @@ ConSplitterSimplePointerReset ( =20 /** Reads the next keystroke from the input device. The WaitForKey Event can - be used to test for existance of a keystroke via WaitForEvent () call. + be used to test for existence of a keystroke via WaitForEvent () call. =20 @param Private Protocol instance pointer. @param State The state information of simple pointer= device. @@ -4279,12 +4279,12 @@ ConSplitterSimplePointerGetState ( =20 =20 /** - This event agregates all the events of the ConIn devices in the spliter. + This event aggregates all the events of the ConIn devices in the spliter. If any events of physical ConIn devices are signaled, signal the ConIn spliter event. This will cause the calling code to call ConSplitterTextInReadKeyStroke (). =20 - @param Event The Event assoicated with callback. + @param Event The Event associated with callback. @param Context Context registered when Event was creat= ed. =20 **/ @@ -4493,12 +4493,12 @@ ConSplitterAbsolutePointerGetState ( =20 =20 /** - This event agregates all the events of the pointer devices in the splitt= er. + This event aggregates all the events of the pointer devices in the split= ter. If any events of physical pointer devices are signaled, signal the point= er splitter event. This will cause the calling code to call ConSplitterAbsolutePointerGetState (). =20 - @param Event The Event assoicated with callback. + @param Event The Event associated with callback. @param Context Context registered when Event was creat= ed. =20 **/ @@ -4537,10 +4537,10 @@ ConSplitterAbsolutePointerWaitForInput ( =20 =20 /** - Reset the text output device hardware and optionaly run diagnostics + Reset the text output device hardware and optionally run diagnostics =20 @param This Protocol instance pointer. - @param ExtendedVerification Driver may perform more exhaustive verf= ication + @param ExtendedVerification Driver may perform more exhaustive veri= fication operation of the device during reset. =20 @retval EFI_SUCCESS The text output device was reset. diff --git a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsCons= ole.c b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c index 6b8d11d587d1..d6d8db51d5e9 100644 --- a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c +++ b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.c @@ -214,7 +214,7 @@ Error: =20 @param[in] HorizontalResolution The size of video screen in pixels = in the X dimension. @param[in] VerticalResolution The size of video screen in pixels = in the Y dimension. - @param[in] GopModeNumber The graphics mode number which grap= his console is based on. + @param[in] GopModeNumber The graphics mode number which grap= hics console is based on. @param[out] TextModeCount The total number of text modes that= graphics console supports. @param[out] TextModeData The buffer to the text modes column= and row information. Caller is responsible to free it wh= en it's non-NULL. @@ -491,7 +491,7 @@ GraphicsConsoleControllerDriverStart ( Mode =3D Private->GraphicsOutput->Mode; if (EFI_ERROR (Status) && Mode->MaxMode !=3D 0) { // - // Set default mode failed or device don't support default mode,= then get the current mode information + // If set default mode failed or device doesn't support default = mode, then get the current mode information // HorizontalResolution =3D Mode->Info->HorizontalResolution; VerticalResolution =3D Mode->Info->VerticalResolution; @@ -501,7 +501,7 @@ GraphicsConsoleControllerDriverStart ( } if (ModeNumber !=3D Private->GraphicsOutput->Mode->Mode) { // - // Current graphics mode is not set or is not set to the mode which = we has found, + // Current graphics mode is not set or is not set to the mode which = we have found, // set the new graphic mode. // Status =3D Private->GraphicsOutput->SetMode (Private->GraphicsOutput= , ModeNumber); @@ -740,7 +740,7 @@ GraphicsConsoleControllerDriverStop ( Check if the current specific mode supported the user defined resolution for the Graphics Console device based on Graphics Output Protocol. =20 - If yes, set the graphic devcice's current mode to this specific mode. + If yes, set the graphic device's current mode to this specific mode. =20 @param GraphicsOutput Graphics Output Protocol instance pointer. @param HorizontalResolution User defined horizontal resolution @@ -843,7 +843,7 @@ EfiLocateHiiProtocol ( Reset the text output device hardware and optionally run diagnostics. =20 Implements SIMPLE_TEXT_OUTPUT.Reset(). - If ExtendeVerification is TRUE, then perform dependent Graphics Console + If ExtendedVerification is TRUE, then perform dependent Graphics Console device reset, and set display mode to mode 0. If ExtendedVerification is FALSE, only set display mode to mode 0. =20 @@ -1713,7 +1713,7 @@ GraphicsConsoleConOutEnableCursor ( } =20 /** - Gets Graphics Console devcie's foreground color and background color. + Gets Graphics Console device's foreground color and background color. =20 @param This Protocol instance pointer. @param Foreground Returned text foreground color. --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67907): https://edk2.groups.io/g/devel/message/67907 Mute This Topic: https://groups.io/mt/78484574/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 19:46:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67908+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67908+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1606245356; cv=none; d=zohomail.com; s=zohoarc; b=lgW1aEJ1+B81gg4vJLeW8cykgmaJcQ2p1FX56c5GW97VzWOchKBcLP/WK8Mb4DPt5+U5I8poAHQVlq4Kvt8oPnmkOpUMK17qh7f2ThKySCVOfQi0E77l8D+9cVRyKUqL9FUV19YoO+EdwMBugOT8LyrC4Lz6DeEYCa8XBAvQSEQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606245356; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ntrg6f5k0N/VHZAlP7UOpMD1hGW6hZFRGw6WAHYiZKg=; b=MeTMKdGmqIoJSAmJmCJJcthzNEpJK4pD5sS8JI0G/x5UEF+onJfeWR0YErkNCFY1N4twrSIZhxFaPGBwDfcZ8v/NmyhkbBQxyB0LCrv0DTH3RwHfxkoq8+SFN39EtalyqijBKiGRCNj4KJ3rdCvPqN4BuZjc3hQgsk6kn7eD8A8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67908+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1606245356058304.86158033222455; Tue, 24 Nov 2020 11:15:56 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id ayWIYY1788612xB9faovatUt; Tue, 24 Nov 2020 11:15:55 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.1713.1606245355180078446 for ; Tue, 24 Nov 2020 11:15:55 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D8C9A1480; Tue, 24 Nov 2020 11:15:54 -0800 (PST) X-Received: from U203705.Arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 89F003F70D; Tue, 24 Nov 2020 11:15:54 -0800 (PST) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Zhichao Gao , Ray Ni , Ard Biesheuvel Subject: [edk2-devel] [PATCH v1 3/3] MdeModulePkg/ConSplitter: Change StdErr color to EFI_LIGHTGRAY Date: Tue, 24 Nov 2020 14:15:46 -0500 Message-Id: <20201124191546.17403-4-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20201124191546.17403-1-Samer.El-Haj-Mahmoud@arm.com> References: <20201124191546.17403-1-Samer.El-Haj-Mahmoud@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,samer.el-haj-mahmoud@arm.com X-Gm-Message-State: QlXQyopr2ZmRuSC4K09gZ0YRx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1606245355; bh=eXZ3C2g6AcaWHZLDuYg4j9WmEQSvpjt462zuDIlngLI=; h=Cc:Date:From:Reply-To:Subject:To; b=XJLpZ6H9vRAbHOaqiCMc8diHzRhir5FwZ11hPRC9ckKmTSuIopm1jL9xyVcIDgRUiAS MJEVdHjo41LmpEdOHleVBL17oXaxIqgTZagQwCrC012UAoVDx4EMtGz4ugdpxEGSufA4X 6p1wId6s0B09CjNaNiLd/BMreDeqaA+1oZs= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" ConSplitter was using EFI_LIGHTGRAY foreground color for ConOut and EFI_MAGENTA for StdErr. This does not work all the time, and StdErr ends up showing parts in MAGENTA and other parts in LIGHTGRAY. Changing StdErr to LIGHTGRAY looks better and is more consistent. Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/= MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c index b090de288517..e8cd4ce120a0 100644 --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c @@ -1476,7 +1476,7 @@ ConSplitterStdErrDriverBindingStart ( // their MaxMode and QueryData should be the intersection of both. // Status =3D ConSplitterTextOutAddDevice (&mStdErr, TextOut, NULL, NULL); - ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_MAG= ENTA, EFI_BLACK)); + ConSplitterTextOutSetAttribute (&mStdErr.TextOut, EFI_TEXT_ATTR (EFI_LIG= HTGRAY, EFI_BLACK)); =20 return Status; } --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67908): https://edk2.groups.io/g/devel/message/67908 Mute This Topic: https://groups.io/mt/78484575/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-