[edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port

Abner Chang posted 3 patches 3 years, 4 months ago
Failed in applying to current master (apply log)
.gitmodules                                   |   3 +
MdeModulePkg/Include/Library/JsonLib.h        | 596 +++++++++++++
.../Library/JsonLib/JanssonCrtLibSupport.c    | 705 +++++++++++++++
.../Library/JsonLib/JanssonCrtLibSupport.h    | 198 +++++
MdeModulePkg/Library/JsonLib/JsonLib.c        | 805 ++++++++++++++++++
MdeModulePkg/Library/JsonLib/JsonLib.inf      |  81 ++
MdeModulePkg/Library/JsonLib/JsonUtilities.c  | 417 +++++++++
MdeModulePkg/Library/JsonLib/JsonUtilities.h  |  69 ++
MdeModulePkg/Library/JsonLib/assert.h         |  11 +
MdeModulePkg/Library/JsonLib/errno.h          |  11 +
MdeModulePkg/Library/JsonLib/jansson          |   1 +
MdeModulePkg/Library/JsonLib/jansson_config.h |  57 ++
.../Library/JsonLib/jansson_private_config.h  |  19 +
MdeModulePkg/Library/JsonLib/limits.h         |  11 +
MdeModulePkg/Library/JsonLib/math.h           |  11 +
MdeModulePkg/Library/JsonLib/stdarg.h         |  11 +
MdeModulePkg/Library/JsonLib/stddef.h         |  11 +
MdeModulePkg/Library/JsonLib/stdio.h          |  11 +
MdeModulePkg/Library/JsonLib/stdlib.h         |  11 +
MdeModulePkg/Library/JsonLib/string.h         |  11 +
MdeModulePkg/Library/JsonLib/sys/time.h       |  11 +
MdeModulePkg/Library/JsonLib/sys/types.h      |  10 +
MdeModulePkg/Library/JsonLib/time.h           |  11 +
MdeModulePkg/MdeModulePkg.dec                 |   7 +-
MdeModulePkg/MdeModulePkg.dsc                 |   4 +-
ReadMe.rst                                    |   1 +
26 files changed, 3092 insertions(+), 2 deletions(-)
create mode 100644 MdeModulePkg/Include/Library/JsonLib.h
create mode 100644 MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.c
create mode 100644 MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.h
create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.c
create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.inf
create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.c
create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.h
create mode 100644 MdeModulePkg/Library/JsonLib/assert.h
create mode 100644 MdeModulePkg/Library/JsonLib/errno.h
create mode 160000 MdeModulePkg/Library/JsonLib/jansson
create mode 100644 MdeModulePkg/Library/JsonLib/jansson_config.h
create mode 100644 MdeModulePkg/Library/JsonLib/jansson_private_config.h
create mode 100644 MdeModulePkg/Library/JsonLib/limits.h
create mode 100644 MdeModulePkg/Library/JsonLib/math.h
create mode 100644 MdeModulePkg/Library/JsonLib/stdarg.h
create mode 100644 MdeModulePkg/Library/JsonLib/stddef.h
create mode 100644 MdeModulePkg/Library/JsonLib/stdio.h
create mode 100644 MdeModulePkg/Library/JsonLib/stdlib.h
create mode 100644 MdeModulePkg/Library/JsonLib/string.h
create mode 100644 MdeModulePkg/Library/JsonLib/sys/time.h
create mode 100644 MdeModulePkg/Library/JsonLib/sys/types.h
create mode 100644 MdeModulePkg/Library/JsonLib/time.h
[edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
Posted by Abner Chang 3 years, 4 months ago
This set of pactehs is sent for the comments on edk2 JSON library.
edk2 JSON library is based on jansson open source
(https://github.com/akheron/jansson) and wrapped as an edk2
library. edk2 JsonLib will be used by edk2 Redfish feature
drivers (not contributed yet) and the edk2 port of libredfish
library (not contributed yet) based on DMTF GitHub
(https://github.com/DMTF/libredfish).

You will encounterred the build error with the jansson library
pointed in submoudle (v2.13.1) and the fix is already submitted to
jansson open source
(https://github.com/akheron/jansson/pull/558).

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Peter O'Hanley <peter.ohanley@hpe.com>

Abner Chang (3):
  edk2: jansson submodule of JSON library
  MdeModulePkg/library: EDK2 port jansson library
  MdeModulePkg: Add EDK2 port jansson library

 .gitmodules                                   |   3 +
 MdeModulePkg/Include/Library/JsonLib.h        | 596 +++++++++++++
 .../Library/JsonLib/JanssonCrtLibSupport.c    | 705 +++++++++++++++
 .../Library/JsonLib/JanssonCrtLibSupport.h    | 198 +++++
 MdeModulePkg/Library/JsonLib/JsonLib.c        | 805 ++++++++++++++++++
 MdeModulePkg/Library/JsonLib/JsonLib.inf      |  81 ++
 MdeModulePkg/Library/JsonLib/JsonUtilities.c  | 417 +++++++++
 MdeModulePkg/Library/JsonLib/JsonUtilities.h  |  69 ++
 MdeModulePkg/Library/JsonLib/assert.h         |  11 +
 MdeModulePkg/Library/JsonLib/errno.h          |  11 +
 MdeModulePkg/Library/JsonLib/jansson          |   1 +
 MdeModulePkg/Library/JsonLib/jansson_config.h |  57 ++
 .../Library/JsonLib/jansson_private_config.h  |  19 +
 MdeModulePkg/Library/JsonLib/limits.h         |  11 +
 MdeModulePkg/Library/JsonLib/math.h           |  11 +
 MdeModulePkg/Library/JsonLib/stdarg.h         |  11 +
 MdeModulePkg/Library/JsonLib/stddef.h         |  11 +
 MdeModulePkg/Library/JsonLib/stdio.h          |  11 +
 MdeModulePkg/Library/JsonLib/stdlib.h         |  11 +
 MdeModulePkg/Library/JsonLib/string.h         |  11 +
 MdeModulePkg/Library/JsonLib/sys/time.h       |  11 +
 MdeModulePkg/Library/JsonLib/sys/types.h      |  10 +
 MdeModulePkg/Library/JsonLib/time.h           |  11 +
 MdeModulePkg/MdeModulePkg.dec                 |   7 +-
 MdeModulePkg/MdeModulePkg.dsc                 |   4 +-
 ReadMe.rst                                    |   1 +
 26 files changed, 3092 insertions(+), 2 deletions(-)
 create mode 100644 MdeModulePkg/Include/Library/JsonLib.h
 create mode 100644 MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.c
 create mode 100644 MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.h
 create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.c
 create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.inf
 create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.c
 create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.h
 create mode 100644 MdeModulePkg/Library/JsonLib/assert.h
 create mode 100644 MdeModulePkg/Library/JsonLib/errno.h
 create mode 160000 MdeModulePkg/Library/JsonLib/jansson
 create mode 100644 MdeModulePkg/Library/JsonLib/jansson_config.h
 create mode 100644 MdeModulePkg/Library/JsonLib/jansson_private_config.h
 create mode 100644 MdeModulePkg/Library/JsonLib/limits.h
 create mode 100644 MdeModulePkg/Library/JsonLib/math.h
 create mode 100644 MdeModulePkg/Library/JsonLib/stdarg.h
 create mode 100644 MdeModulePkg/Library/JsonLib/stddef.h
 create mode 100644 MdeModulePkg/Library/JsonLib/stdio.h
 create mode 100644 MdeModulePkg/Library/JsonLib/stdlib.h
 create mode 100644 MdeModulePkg/Library/JsonLib/string.h
 create mode 100644 MdeModulePkg/Library/JsonLib/sys/time.h
 create mode 100644 MdeModulePkg/Library/JsonLib/sys/types.h
 create mode 100644 MdeModulePkg/Library/JsonLib/time.h

-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67807): https://edk2.groups.io/g/devel/message/67807
Mute This Topic: https://groups.io/mt/78454019/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
Posted by Wu, Hao A 3 years, 4 months ago
> -----Original Message-----
> From: Abner Chang <abner.chang@hpe.com>
> Sent: Monday, November 23, 2020 9:47 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
> Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif
> Lindholm <leif@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Nickle Wang <nickle.wang@hpe.com>;
> Peter O'Hanley <peter.ohanley@hpe.com>
> Subject: [PATCH 0/3] JsonLib: jansson edk2 port
> 
> This set of pactehs is sent for the comments on edk2 JSON library.
> edk2 JSON library is based on jansson open source
> (https://github.com/akheron/jansson) and wrapped as an edk2 library. edk2
> JsonLib will be used by edk2 Redfish feature drivers (not contributed yet)


Hello,

Sorry for possibly missing previous discussions on the Redfish feature.
I am wondering is it more straight-forward to put the JsonLib together with the Readfish codes under RedfishPkg?

Best Regards,
Hao Wu


> and the edk2 port of libredfish library (not contributed yet) based on DMTF
> GitHub (https://github.com/DMTF/libredfish).
> 
> You will encounterred the build error with the jansson library pointed in
> submoudle (v2.13.1) and the fix is already submitted to jansson open source
> (https://github.com/akheron/jansson/pull/558).
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> 
> Abner Chang (3):
>   edk2: jansson submodule of JSON library
>   MdeModulePkg/library: EDK2 port jansson library
>   MdeModulePkg: Add EDK2 port jansson library
> 
>  .gitmodules                                   |   3 +
>  MdeModulePkg/Include/Library/JsonLib.h        | 596 +++++++++++++
>  .../Library/JsonLib/JanssonCrtLibSupport.c    | 705 +++++++++++++++
>  .../Library/JsonLib/JanssonCrtLibSupport.h    | 198 +++++
>  MdeModulePkg/Library/JsonLib/JsonLib.c        | 805 ++++++++++++++++++
>  MdeModulePkg/Library/JsonLib/JsonLib.inf      |  81 ++
>  MdeModulePkg/Library/JsonLib/JsonUtilities.c  | 417 +++++++++
> MdeModulePkg/Library/JsonLib/JsonUtilities.h  |  69 ++
>  MdeModulePkg/Library/JsonLib/assert.h         |  11 +
>  MdeModulePkg/Library/JsonLib/errno.h          |  11 +
>  MdeModulePkg/Library/JsonLib/jansson          |   1 +
>  MdeModulePkg/Library/JsonLib/jansson_config.h |  57
> ++  .../Library/JsonLib/jansson_private_config.h  |  19 +
>  MdeModulePkg/Library/JsonLib/limits.h         |  11 +
>  MdeModulePkg/Library/JsonLib/math.h           |  11 +
>  MdeModulePkg/Library/JsonLib/stdarg.h         |  11 +
>  MdeModulePkg/Library/JsonLib/stddef.h         |  11 +
>  MdeModulePkg/Library/JsonLib/stdio.h          |  11 +
>  MdeModulePkg/Library/JsonLib/stdlib.h         |  11 +
>  MdeModulePkg/Library/JsonLib/string.h         |  11 +
>  MdeModulePkg/Library/JsonLib/sys/time.h       |  11 +
>  MdeModulePkg/Library/JsonLib/sys/types.h      |  10 +
>  MdeModulePkg/Library/JsonLib/time.h           |  11 +
>  MdeModulePkg/MdeModulePkg.dec                 |   7 +-
>  MdeModulePkg/MdeModulePkg.dsc                 |   4 +-
>  ReadMe.rst                                    |   1 +
>  26 files changed, 3092 insertions(+), 2 deletions(-)  create mode 100644
> MdeModulePkg/Include/Library/JsonLib.h
>  create mode 100644
> MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.c
>  create mode 100644
> MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.h
>  create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.c
>  create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.inf
>  create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.c
>  create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.h
>  create mode 100644 MdeModulePkg/Library/JsonLib/assert.h
>  create mode 100644 MdeModulePkg/Library/JsonLib/errno.h
>  create mode 160000 MdeModulePkg/Library/JsonLib/jansson
>  create mode 100644 MdeModulePkg/Library/JsonLib/jansson_config.h
>  create mode 100644
> MdeModulePkg/Library/JsonLib/jansson_private_config.h
>  create mode 100644 MdeModulePkg/Library/JsonLib/limits.h
>  create mode 100644 MdeModulePkg/Library/JsonLib/math.h
>  create mode 100644 MdeModulePkg/Library/JsonLib/stdarg.h
>  create mode 100644 MdeModulePkg/Library/JsonLib/stddef.h
>  create mode 100644 MdeModulePkg/Library/JsonLib/stdio.h
>  create mode 100644 MdeModulePkg/Library/JsonLib/stdlib.h
>  create mode 100644 MdeModulePkg/Library/JsonLib/string.h
>  create mode 100644 MdeModulePkg/Library/JsonLib/sys/time.h
>  create mode 100644 MdeModulePkg/Library/JsonLib/sys/types.h
>  create mode 100644 MdeModulePkg/Library/JsonLib/time.h
> 
> --
> 2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67850): https://edk2.groups.io/g/devel/message/67850
Mute This Topic: https://groups.io/mt/78454019/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
Posted by Abner Chang 3 years, 4 months ago

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Tuesday, November 24, 2020 9:20 AM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish <afish@apple.com>;
> Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Wang, Nickle (HPS SW)
> <nickle.wang@hpe.com>; O'Hanley, Peter (EXL) <peter.ohanley@hpe.com>
> Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> 
> > -----Original Message-----
> > From: Abner Chang <abner.chang@hpe.com>
> > Sent: Monday, November 23, 2020 9:47 PM
> > To: devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> > <hao.a.wu@intel.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek
> > <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney,
> > Michael D <michael.d.kinney@intel.com>; Nickle Wang
> > <nickle.wang@hpe.com>; Peter O'Hanley <peter.ohanley@hpe.com>
> > Subject: [PATCH 0/3] JsonLib: jansson edk2 port
> >
> > This set of pactehs is sent for the comments on edk2 JSON library.
> > edk2 JSON library is based on jansson open source
> > (https://github.com/akheron/jansson) and wrapped as an edk2 library.
> > edk2 JsonLib will be used by edk2 Redfish feature drivers (not
> > contributed yet)
> 
> 
> Hello,
> 
> Sorry for possibly missing previous discussions on the Redfish feature.
> I am wondering is it more straight-forward to put the JsonLib together with
> the Readfish codes under RedfishPkg?
Hi Hao, 
The idea is JSON is not the representation of data payload for Redfish only and JsonLib could be not only for Redfish neither. Any applications which use JSON as data payload can leverage JsonLib.

Thanks
Abner
> 
> Best Regards,
> Hao Wu
> 
> 
> > and the edk2 port of libredfish library (not contributed yet) based on
> > DMTF GitHub (https://github.com/DMTF/libredfish).
> >
> > You will encounterred the build error with the jansson library pointed
> > in submoudle (v2.13.1) and the fix is already submitted to jansson
> > open source (https://github.com/akheron/jansson/pull/558).
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> >
> > Abner Chang (3):
> >   edk2: jansson submodule of JSON library
> >   MdeModulePkg/library: EDK2 port jansson library
> >   MdeModulePkg: Add EDK2 port jansson library
> >
> >  .gitmodules                                   |   3 +
> >  MdeModulePkg/Include/Library/JsonLib.h        | 596 +++++++++++++
> >  .../Library/JsonLib/JanssonCrtLibSupport.c    | 705 +++++++++++++++
> >  .../Library/JsonLib/JanssonCrtLibSupport.h    | 198 +++++
> >  MdeModulePkg/Library/JsonLib/JsonLib.c        | 805
> ++++++++++++++++++
> >  MdeModulePkg/Library/JsonLib/JsonLib.inf      |  81 ++
> >  MdeModulePkg/Library/JsonLib/JsonUtilities.c  | 417 +++++++++
> > MdeModulePkg/Library/JsonLib/JsonUtilities.h  |  69 ++
> >  MdeModulePkg/Library/JsonLib/assert.h         |  11 +
> >  MdeModulePkg/Library/JsonLib/errno.h          |  11 +
> >  MdeModulePkg/Library/JsonLib/jansson          |   1 +
> >  MdeModulePkg/Library/JsonLib/jansson_config.h |  57
> > ++  .../Library/JsonLib/jansson_private_config.h  |  19 +
> >  MdeModulePkg/Library/JsonLib/limits.h         |  11 +
> >  MdeModulePkg/Library/JsonLib/math.h           |  11 +
> >  MdeModulePkg/Library/JsonLib/stdarg.h         |  11 +
> >  MdeModulePkg/Library/JsonLib/stddef.h         |  11 +
> >  MdeModulePkg/Library/JsonLib/stdio.h          |  11 +
> >  MdeModulePkg/Library/JsonLib/stdlib.h         |  11 +
> >  MdeModulePkg/Library/JsonLib/string.h         |  11 +
> >  MdeModulePkg/Library/JsonLib/sys/time.h       |  11 +
> >  MdeModulePkg/Library/JsonLib/sys/types.h      |  10 +
> >  MdeModulePkg/Library/JsonLib/time.h           |  11 +
> >  MdeModulePkg/MdeModulePkg.dec                 |   7 +-
> >  MdeModulePkg/MdeModulePkg.dsc                 |   4 +-
> >  ReadMe.rst                                    |   1 +
> >  26 files changed, 3092 insertions(+), 2 deletions(-)  create mode
> > 100644 MdeModulePkg/Include/Library/JsonLib.h
> >  create mode 100644
> > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.c
> >  create mode 100644
> > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.h
> >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.c
> >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.inf
> >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.c
> >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.h
> >  create mode 100644 MdeModulePkg/Library/JsonLib/assert.h
> >  create mode 100644 MdeModulePkg/Library/JsonLib/errno.h
> >  create mode 160000 MdeModulePkg/Library/JsonLib/jansson
> >  create mode 100644 MdeModulePkg/Library/JsonLib/jansson_config.h
> >  create mode 100644
> > MdeModulePkg/Library/JsonLib/jansson_private_config.h
> >  create mode 100644 MdeModulePkg/Library/JsonLib/limits.h
> >  create mode 100644 MdeModulePkg/Library/JsonLib/math.h
> >  create mode 100644 MdeModulePkg/Library/JsonLib/stdarg.h
> >  create mode 100644 MdeModulePkg/Library/JsonLib/stddef.h
> >  create mode 100644 MdeModulePkg/Library/JsonLib/stdio.h
> >  create mode 100644 MdeModulePkg/Library/JsonLib/stdlib.h
> >  create mode 100644 MdeModulePkg/Library/JsonLib/string.h
> >  create mode 100644 MdeModulePkg/Library/JsonLib/sys/time.h
> >  create mode 100644 MdeModulePkg/Library/JsonLib/sys/types.h
> >  create mode 100644 MdeModulePkg/Library/JsonLib/time.h
> >
> > --
> > 2.17.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67857): https://edk2.groups.io/g/devel/message/67857
Mute This Topic: https://groups.io/mt/78454019/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
Posted by Wu, Hao A 3 years, 4 months ago
> -----Original Message-----
> From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Sent: Tuesday, November 24, 2020 9:31 AM
> To: devel@edk2.groups.io; Wu, Hao A <hao.a.wu@intel.com>
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish <afish@apple.com>;
> Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Wang, Nickle (HPS SW)
> <nickle.wang@hpe.com>; O'Hanley, Peter (EXL) <peter.ohanley@hpe.com>
> Subject: RE: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> 
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Wu, Hao A
> > Sent: Tuesday, November 24, 2020 9:20 AM
> > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> > devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish
> > <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> > <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; O'Hanley, Peter (EXL)
> > <peter.ohanley@hpe.com>
> > Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> >
> > > -----Original Message-----
> > > From: Abner Chang <abner.chang@hpe.com>
> > > Sent: Monday, November 23, 2020 9:47 PM
> > > To: devel@edk2.groups.io
> > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> > > <hao.a.wu@intel.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek
> > > <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney,
> > > Michael D <michael.d.kinney@intel.com>; Nickle Wang
> > > <nickle.wang@hpe.com>; Peter O'Hanley <peter.ohanley@hpe.com>
> > > Subject: [PATCH 0/3] JsonLib: jansson edk2 port
> > >
> > > This set of pactehs is sent for the comments on edk2 JSON library.
> > > edk2 JSON library is based on jansson open source
> > > (https://github.com/akheron/jansson) and wrapped as an edk2 library.
> > > edk2 JsonLib will be used by edk2 Redfish feature drivers (not
> > > contributed yet)
> >
> >
> > Hello,
> >
> > Sorry for possibly missing previous discussions on the Redfish feature.
> > I am wondering is it more straight-forward to put the JsonLib together
> > with the Readfish codes under RedfishPkg?
> Hi Hao,
> The idea is JSON is not the representation of data payload for Redfish only
> and JsonLib could be not only for Redfish neither. Any applications which use
> JSON as data payload can leverage JsonLib.


Thanks,

My concern is for the case of adding a common library/module, MdeModulePkg
usually seems to be the destination. But since MdeModulePkg is already a huge
and complex package, I am not sure if this is the right way to go.

I would like to get the inputs on other reviewers for putting the JsonLib under
MdeModulePkg.

If this is the right direction, could you help to add an item in the
Maintainers.txt for the Json related stuff in MdeModulePkg and list you
(and 1 more person will be appreciated) as the reviewer?

Thanks in advance.

Best Regards,
Hao Wu


> 
> Thanks
> Abner
> >
> > Best Regards,
> > Hao Wu
> >
> >
> > > and the edk2 port of libredfish library (not contributed yet) based
> > > on DMTF GitHub (https://github.com/DMTF/libredfish).
> > >
> > > You will encounterred the build error with the jansson library
> > > pointed in submoudle (v2.13.1) and the fix is already submitted to
> > > jansson open source (https://github.com/akheron/jansson/pull/558).
> > >
> > > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > >
> > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > Cc: Andrew Fish <afish@apple.com>
> > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > Cc: Leif Lindholm <leif@nuviainc.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Nickle Wang <nickle.wang@hpe.com>
> > > Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> > >
> > > Abner Chang (3):
> > >   edk2: jansson submodule of JSON library
> > >   MdeModulePkg/library: EDK2 port jansson library
> > >   MdeModulePkg: Add EDK2 port jansson library
> > >
> > >  .gitmodules                                   |   3 +
> > >  MdeModulePkg/Include/Library/JsonLib.h        | 596 +++++++++++++
> > >  .../Library/JsonLib/JanssonCrtLibSupport.c    | 705 +++++++++++++++
> > >  .../Library/JsonLib/JanssonCrtLibSupport.h    | 198 +++++
> > >  MdeModulePkg/Library/JsonLib/JsonLib.c        | 805
> > ++++++++++++++++++
> > >  MdeModulePkg/Library/JsonLib/JsonLib.inf      |  81 ++
> > >  MdeModulePkg/Library/JsonLib/JsonUtilities.c  | 417 +++++++++
> > > MdeModulePkg/Library/JsonLib/JsonUtilities.h  |  69 ++
> > >  MdeModulePkg/Library/JsonLib/assert.h         |  11 +
> > >  MdeModulePkg/Library/JsonLib/errno.h          |  11 +
> > >  MdeModulePkg/Library/JsonLib/jansson          |   1 +
> > >  MdeModulePkg/Library/JsonLib/jansson_config.h |  57
> > > ++  .../Library/JsonLib/jansson_private_config.h  |  19 +
> > >  MdeModulePkg/Library/JsonLib/limits.h         |  11 +
> > >  MdeModulePkg/Library/JsonLib/math.h           |  11 +
> > >  MdeModulePkg/Library/JsonLib/stdarg.h         |  11 +
> > >  MdeModulePkg/Library/JsonLib/stddef.h         |  11 +
> > >  MdeModulePkg/Library/JsonLib/stdio.h          |  11 +
> > >  MdeModulePkg/Library/JsonLib/stdlib.h         |  11 +
> > >  MdeModulePkg/Library/JsonLib/string.h         |  11 +
> > >  MdeModulePkg/Library/JsonLib/sys/time.h       |  11 +
> > >  MdeModulePkg/Library/JsonLib/sys/types.h      |  10 +
> > >  MdeModulePkg/Library/JsonLib/time.h           |  11 +
> > >  MdeModulePkg/MdeModulePkg.dec                 |   7 +-
> > >  MdeModulePkg/MdeModulePkg.dsc                 |   4 +-
> > >  ReadMe.rst                                    |   1 +
> > >  26 files changed, 3092 insertions(+), 2 deletions(-)  create mode
> > > 100644 MdeModulePkg/Include/Library/JsonLib.h
> > >  create mode 100644
> > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.c
> > >  create mode 100644
> > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.h
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.c
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.inf
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.c
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.h
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/assert.h
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/errno.h
> > >  create mode 160000 MdeModulePkg/Library/JsonLib/jansson
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/jansson_config.h
> > >  create mode 100644
> > > MdeModulePkg/Library/JsonLib/jansson_private_config.h
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/limits.h
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/math.h
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/stdarg.h
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/stddef.h
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/stdio.h
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/stdlib.h
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/string.h
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/sys/time.h
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/sys/types.h
> > >  create mode 100644 MdeModulePkg/Library/JsonLib/time.h
> > >
> > > --
> > > 2.17.1
> >
> >
> >
> > 
> >
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67860): https://edk2.groups.io/g/devel/message/67860
Mute This Topic: https://groups.io/mt/78454019/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
Posted by Abner Chang 3 years, 4 months ago

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Tuesday, November 24, 2020 9:50 AM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish <afish@apple.com>;
> Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Wang, Nickle (HPS SW)
> <nickle.wang@hpe.com>; O'Hanley, Peter (EXL) <peter.ohanley@hpe.com>
> Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> 
> > -----Original Message-----
> > From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> > Sent: Tuesday, November 24, 2020 9:31 AM
> > To: devel@edk2.groups.io; Wu, Hao A <hao.a.wu@intel.com>
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish
> > <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> > <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; O'Hanley, Peter (EXL)
> > <peter.ohanley@hpe.com>
> > Subject: RE: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> >
> >
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > > Of Wu, Hao A
> > > Sent: Tuesday, November 24, 2020 9:20 AM
> > > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> > > devel@edk2.groups.io
> > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish
> > > <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> > > <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; O'Hanley, Peter (EXL)
> > > <peter.ohanley@hpe.com>
> > > Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> > >
> > > > -----Original Message-----
> > > > From: Abner Chang <abner.chang@hpe.com>
> > > > Sent: Monday, November 23, 2020 9:47 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> > > > <hao.a.wu@intel.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek
> > > > <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney,
> > > > Michael D <michael.d.kinney@intel.com>; Nickle Wang
> > > > <nickle.wang@hpe.com>; Peter O'Hanley <peter.ohanley@hpe.com>
> > > > Subject: [PATCH 0/3] JsonLib: jansson edk2 port
> > > >
> > > > This set of pactehs is sent for the comments on edk2 JSON library.
> > > > edk2 JSON library is based on jansson open source
> > > > (https://github.com/akheron/jansson) and wrapped as an edk2 library.
> > > > edk2 JsonLib will be used by edk2 Redfish feature drivers (not
> > > > contributed yet)
> > >
> > >
> > > Hello,
> > >
> > > Sorry for possibly missing previous discussions on the Redfish feature.
> > > I am wondering is it more straight-forward to put the JsonLib
> > > together with the Readfish codes under RedfishPkg?
> > Hi Hao,
> > The idea is JSON is not the representation of data payload for Redfish
> > only and JsonLib could be not only for Redfish neither. Any
> > applications which use JSON as data payload can leverage JsonLib.
> 
> 
> Thanks,
> 
> My concern is for the case of adding a common library/module,
> MdeModulePkg usually seems to be the destination. But since
> MdeModulePkg is already a huge and complex package, I am not sure if this
> is the right way to go.
> 
> I would like to get the inputs on other reviewers for putting the JsonLib
> under MdeModulePkg.
> 
> If this is the right direction, could you help to add an item in the
> Maintainers.txt for the Json related stuff in MdeModulePkg and list you (and
> 1 more person will be appreciated) as the reviewer?
That's no problem. We are pleased to be the reviewer of JSON lib.

Yes, see others input for JsonLib location.

Thanks
Abner
> 
> Thanks in advance.
> 
> Best Regards,
> Hao Wu
> 
> 
> >
> > Thanks
> > Abner
> > >
> > > Best Regards,
> > > Hao Wu
> > >
> > >
> > > > and the edk2 port of libredfish library (not contributed yet)
> > > > based on DMTF GitHub (https://github.com/DMTF/libredfish).
> > > >
> > > > You will encounterred the build error with the jansson library
> > > > pointed in submoudle (v2.13.1) and the fix is already submitted to
> > > > jansson open source (https://github.com/akheron/jansson/pull/558).
> > > >
> > > > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > > >
> > > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > > Cc: Andrew Fish <afish@apple.com>
> > > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > > Cc: Leif Lindholm <leif@nuviainc.com>
> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > Cc: Nickle Wang <nickle.wang@hpe.com>
> > > > Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> > > >
> > > > Abner Chang (3):
> > > >   edk2: jansson submodule of JSON library
> > > >   MdeModulePkg/library: EDK2 port jansson library
> > > >   MdeModulePkg: Add EDK2 port jansson library
> > > >
> > > >  .gitmodules                                   |   3 +
> > > >  MdeModulePkg/Include/Library/JsonLib.h        | 596 +++++++++++++
> > > >  .../Library/JsonLib/JanssonCrtLibSupport.c    | 705 +++++++++++++++
> > > >  .../Library/JsonLib/JanssonCrtLibSupport.h    | 198 +++++
> > > >  MdeModulePkg/Library/JsonLib/JsonLib.c        | 805
> > > ++++++++++++++++++
> > > >  MdeModulePkg/Library/JsonLib/JsonLib.inf      |  81 ++
> > > >  MdeModulePkg/Library/JsonLib/JsonUtilities.c  | 417 +++++++++
> > > > MdeModulePkg/Library/JsonLib/JsonUtilities.h  |  69 ++
> > > >  MdeModulePkg/Library/JsonLib/assert.h         |  11 +
> > > >  MdeModulePkg/Library/JsonLib/errno.h          |  11 +
> > > >  MdeModulePkg/Library/JsonLib/jansson          |   1 +
> > > >  MdeModulePkg/Library/JsonLib/jansson_config.h |  57
> > > > ++  .../Library/JsonLib/jansson_private_config.h  |  19 +
> > > >  MdeModulePkg/Library/JsonLib/limits.h         |  11 +
> > > >  MdeModulePkg/Library/JsonLib/math.h           |  11 +
> > > >  MdeModulePkg/Library/JsonLib/stdarg.h         |  11 +
> > > >  MdeModulePkg/Library/JsonLib/stddef.h         |  11 +
> > > >  MdeModulePkg/Library/JsonLib/stdio.h          |  11 +
> > > >  MdeModulePkg/Library/JsonLib/stdlib.h         |  11 +
> > > >  MdeModulePkg/Library/JsonLib/string.h         |  11 +
> > > >  MdeModulePkg/Library/JsonLib/sys/time.h       |  11 +
> > > >  MdeModulePkg/Library/JsonLib/sys/types.h      |  10 +
> > > >  MdeModulePkg/Library/JsonLib/time.h           |  11 +
> > > >  MdeModulePkg/MdeModulePkg.dec                 |   7 +-
> > > >  MdeModulePkg/MdeModulePkg.dsc                 |   4 +-
> > > >  ReadMe.rst                                    |   1 +
> > > >  26 files changed, 3092 insertions(+), 2 deletions(-)  create mode
> > > > 100644 MdeModulePkg/Include/Library/JsonLib.h
> > > >  create mode 100644
> > > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.c
> > > >  create mode 100644
> > > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.h
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.c
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.inf
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.c
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.h
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/assert.h
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/errno.h
> > > >  create mode 160000 MdeModulePkg/Library/JsonLib/jansson
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/jansson_config.h
> > > >  create mode 100644
> > > > MdeModulePkg/Library/JsonLib/jansson_private_config.h
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/limits.h
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/math.h
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/stdarg.h
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/stddef.h
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/stdio.h
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/stdlib.h
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/string.h
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/sys/time.h
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/sys/types.h
> > > >  create mode 100644 MdeModulePkg/Library/JsonLib/time.h
> > > >
> > > > --
> > > > 2.17.1
> > >
> > >
> > >
> > >
> > >
> >
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67861): https://edk2.groups.io/g/devel/message/67861
Mute This Topic: https://groups.io/mt/78454019/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


回复: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
Posted by gaoliming 3 years, 4 months ago
Abner:
  I agree JsonLib is the generic module. But now, we know its consumer is
only RedFish. 
  So, I suggest to place it into RedFishPkg. If there is more usage model,
we can consider to move it later. 

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+67861+4905953+8761045@groups.io
> <bounce+27952+67861+4905953+8761045@groups.io> 代表 Abner Chang
> 发送时间: 2020年11月24日 10:03
> 收件人: devel@edk2.groups.io; hao.a.wu@intel.com
> 抄送: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish <afish@apple.com>;
> Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Wang, Nickle (HPS SW)
> <nickle.wang@hpe.com>; O'Hanley, Peter (EXL) <peter.ohanley@hpe.com>
> 主题: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> 
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Wu, Hao A
> > Sent: Tuesday, November 24, 2020 9:50 AM
> > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> > devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish <afish@apple.com>;
> > Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>;
> > Kinney, Michael D <michael.d.kinney@intel.com>; Wang, Nickle (HPS SW)
> > <nickle.wang@hpe.com>; O'Hanley, Peter (EXL) <peter.ohanley@hpe.com>
> > Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> >
> > > -----Original Message-----
> > > From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> > > Sent: Tuesday, November 24, 2020 9:31 AM
> > > To: devel@edk2.groups.io; Wu, Hao A <hao.a.wu@intel.com>
> > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish
> > > <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> > > <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; O'Hanley, Peter (EXL)
> > > <peter.ohanley@hpe.com>
> > > Subject: RE: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > > > Of Wu, Hao A
> > > > Sent: Tuesday, November 24, 2020 9:20 AM
> > > > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> > > > devel@edk2.groups.io
> > > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish
> > > > <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> > > > <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > > > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; O'Hanley, Peter (EXL)
> > > > <peter.ohanley@hpe.com>
> > > > Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> > > >
> > > > > -----Original Message-----
> > > > > From: Abner Chang <abner.chang@hpe.com>
> > > > > Sent: Monday, November 23, 2020 9:47 PM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> > > > > <hao.a.wu@intel.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek
> > > > > <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney,
> > > > > Michael D <michael.d.kinney@intel.com>; Nickle Wang
> > > > > <nickle.wang@hpe.com>; Peter O'Hanley <peter.ohanley@hpe.com>
> > > > > Subject: [PATCH 0/3] JsonLib: jansson edk2 port
> > > > >
> > > > > This set of pactehs is sent for the comments on edk2 JSON library.
> > > > > edk2 JSON library is based on jansson open source
> > > > > (https://github.com/akheron/jansson) and wrapped as an edk2
library.
> > > > > edk2 JsonLib will be used by edk2 Redfish feature drivers (not
> > > > > contributed yet)
> > > >
> > > >
> > > > Hello,
> > > >
> > > > Sorry for possibly missing previous discussions on the Redfish
feature.
> > > > I am wondering is it more straight-forward to put the JsonLib
> > > > together with the Readfish codes under RedfishPkg?
> > > Hi Hao,
> > > The idea is JSON is not the representation of data payload for Redfish
> > > only and JsonLib could be not only for Redfish neither. Any
> > > applications which use JSON as data payload can leverage JsonLib.
> >
> >
> > Thanks,
> >
> > My concern is for the case of adding a common library/module,
> > MdeModulePkg usually seems to be the destination. But since
> > MdeModulePkg is already a huge and complex package, I am not sure if
this
> > is the right way to go.
> >
> > I would like to get the inputs on other reviewers for putting the
JsonLib
> > under MdeModulePkg.
> >
> > If this is the right direction, could you help to add an item in the
> > Maintainers.txt for the Json related stuff in MdeModulePkg and list you
(and
> > 1 more person will be appreciated) as the reviewer?
> That's no problem. We are pleased to be the reviewer of JSON lib.
> 
> Yes, see others input for JsonLib location.
> 
> Thanks
> Abner
> >
> > Thanks in advance.
> >
> > Best Regards,
> > Hao Wu
> >
> >
> > >
> > > Thanks
> > > Abner
> > > >
> > > > Best Regards,
> > > > Hao Wu
> > > >
> > > >
> > > > > and the edk2 port of libredfish library (not contributed yet)
> > > > > based on DMTF GitHub (https://github.com/DMTF/libredfish).
> > > > >
> > > > > You will encounterred the build error with the jansson library
> > > > > pointed in submoudle (v2.13.1) and the fix is already submitted to
> > > > > jansson open source (https://github.com/akheron/jansson/pull/558).
> > > > >
> > > > > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > > > >
> > > > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > > > Cc: Andrew Fish <afish@apple.com>
> > > > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > > > Cc: Leif Lindholm <leif@nuviainc.com>
> > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > > Cc: Nickle Wang <nickle.wang@hpe.com>
> > > > > Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> > > > >
> > > > > Abner Chang (3):
> > > > >   edk2: jansson submodule of JSON library
> > > > >   MdeModulePkg/library: EDK2 port jansson library
> > > > >   MdeModulePkg: Add EDK2 port jansson library
> > > > >
> > > > >  .gitmodules                                   |   3 +
> > > > >  MdeModulePkg/Include/Library/JsonLib.h        | 596
> +++++++++++++
> > > > >  .../Library/JsonLib/JanssonCrtLibSupport.c    | 705
> +++++++++++++++
> > > > >  .../Library/JsonLib/JanssonCrtLibSupport.h    | 198 +++++
> > > > >  MdeModulePkg/Library/JsonLib/JsonLib.c        | 805
> > > > ++++++++++++++++++
> > > > >  MdeModulePkg/Library/JsonLib/JsonLib.inf      |  81 ++
> > > > >  MdeModulePkg/Library/JsonLib/JsonUtilities.c  | 417 +++++++++
> > > > > MdeModulePkg/Library/JsonLib/JsonUtilities.h  |  69 ++
> > > > >  MdeModulePkg/Library/JsonLib/assert.h         |  11 +
> > > > >  MdeModulePkg/Library/JsonLib/errno.h          |  11 +
> > > > >  MdeModulePkg/Library/JsonLib/jansson          |   1 +
> > > > >  MdeModulePkg/Library/JsonLib/jansson_config.h |  57
> > > > > ++  .../Library/JsonLib/jansson_private_config.h  |  19 +
> > > > >  MdeModulePkg/Library/JsonLib/limits.h         |  11 +
> > > > >  MdeModulePkg/Library/JsonLib/math.h           |  11 +
> > > > >  MdeModulePkg/Library/JsonLib/stdarg.h         |  11 +
> > > > >  MdeModulePkg/Library/JsonLib/stddef.h         |  11 +
> > > > >  MdeModulePkg/Library/JsonLib/stdio.h          |  11 +
> > > > >  MdeModulePkg/Library/JsonLib/stdlib.h         |  11 +
> > > > >  MdeModulePkg/Library/JsonLib/string.h         |  11 +
> > > > >  MdeModulePkg/Library/JsonLib/sys/time.h       |  11 +
> > > > >  MdeModulePkg/Library/JsonLib/sys/types.h      |  10 +
> > > > >  MdeModulePkg/Library/JsonLib/time.h           |  11 +
> > > > >  MdeModulePkg/MdeModulePkg.dec                 |   7 +-
> > > > >  MdeModulePkg/MdeModulePkg.dsc                 |   4 +-
> > > > >  ReadMe.rst                                    |   1 +
> > > > >  26 files changed, 3092 insertions(+), 2 deletions(-)  create mode
> > > > > 100644 MdeModulePkg/Include/Library/JsonLib.h
> > > > >  create mode 100644
> > > > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.c
> > > > >  create mode 100644
> > > > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.h
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.c
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.inf
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.c
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.h
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/assert.h
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/errno.h
> > > > >  create mode 160000 MdeModulePkg/Library/JsonLib/jansson
> > > > >  create mode 100644
> MdeModulePkg/Library/JsonLib/jansson_config.h
> > > > >  create mode 100644
> > > > > MdeModulePkg/Library/JsonLib/jansson_private_config.h
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/limits.h
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/math.h
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/stdarg.h
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/stddef.h
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/stdio.h
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/stdlib.h
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/string.h
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/sys/time.h
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/sys/types.h
> > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/time.h
> > > > >
> > > > > --
> > > > > 2.17.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67926): https://edk2.groups.io/g/devel/message/67926
Mute This Topic: https://groups.io/mt/78493194/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
Posted by Abner Chang 3 years, 4 months ago
Ok, Liming. Let's move this to under RedfishPkg.

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> gaoliming
> Sent: Wednesday, November 25, 2020 11:20 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>; hao.a.wu@intel.com
> Cc: 'Wang, Jian J' <jian.j.wang@intel.com>; 'Andrew Fish' <afish@apple.com>;
> 'Laszlo Ersek' <lersek@redhat.com>; 'Leif Lindholm' <leif@nuviainc.com>;
> 'Kinney, Michael D' <michael.d.kinney@intel.com>; Wang, Nickle (HPS SW)
> <nickle.wang@hpe.com>; O'Hanley, Peter (EXL) <peter.ohanley@hpe.com>
> Subject: 回复: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> 
> Abner:
>   I agree JsonLib is the generic module. But now, we know its consumer is
> only RedFish.
>   So, I suggest to place it into RedFishPkg. If there is more usage model, we
> can consider to move it later.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: bounce+27952+67861+4905953+8761045@groups.io
> > <bounce+27952+67861+4905953+8761045@groups.io> 代表 Abner Chang
> > 发送时间: 2020年11月24日 10:03
> > 收件人: devel@edk2.groups.io; hao.a.wu@intel.com
> > 抄送: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish
> > <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> > <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; O'Hanley, Peter (EXL)
> > <peter.ohanley@hpe.com>
> > 主题: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> >
> >
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > > Of Wu, Hao A
> > > Sent: Tuesday, November 24, 2020 9:50 AM
> > > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> > > devel@edk2.groups.io
> > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish
> > > <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> > > <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; O'Hanley, Peter (EXL)
> > > <peter.ohanley@hpe.com>
> > > Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> > >
> > > > -----Original Message-----
> > > > From: Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> > > > Sent: Tuesday, November 24, 2020 9:31 AM
> > > > To: devel@edk2.groups.io; Wu, Hao A <hao.a.wu@intel.com>
> > > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish
> > > > <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> > > > <leif@nuviainc.com>; Kinney, Michael D
> > > > <michael.d.kinney@intel.com>; Wang, Nickle (HPS SW)
> > > > <nickle.wang@hpe.com>; O'Hanley, Peter (EXL)
> > > > <peter.ohanley@hpe.com>
> > > > Subject: RE: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> > > >
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On
> > > > > Behalf Of Wu, Hao A
> > > > > Sent: Tuesday, November 24, 2020 9:20 AM
> > > > > To: Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>;
> > > > > devel@edk2.groups.io
> > > > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish
> > > > > <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif
> > > > > Lindholm <leif@nuviainc.com>; Kinney, Michael D
> > > > > <michael.d.kinney@intel.com>; Wang, Nickle (HPS SW)
> > > > > <nickle.wang@hpe.com>; O'Hanley, Peter (EXL)
> > > > > <peter.ohanley@hpe.com>
> > > > > Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Abner Chang <abner.chang@hpe.com>
> > > > > > Sent: Monday, November 23, 2020 9:47 PM
> > > > > > To: devel@edk2.groups.io
> > > > > > Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> > > > > > <hao.a.wu@intel.com>; Andrew Fish <afish@apple.com>; Laszlo
> > > > > > Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>;
> > > > > > Kinney, Michael D <michael.d.kinney@intel.com>; Nickle Wang
> > > > > > <nickle.wang@hpe.com>; Peter O'Hanley
> <peter.ohanley@hpe.com>
> > > > > > Subject: [PATCH 0/3] JsonLib: jansson edk2 port
> > > > > >
> > > > > > This set of pactehs is sent for the comments on edk2 JSON library.
> > > > > > edk2 JSON library is based on jansson open source
> > > > > > (https://github.com/akheron/jansson) and wrapped as an edk2
> library.
> > > > > > edk2 JsonLib will be used by edk2 Redfish feature drivers (not
> > > > > > contributed yet)
> > > > >
> > > > >
> > > > > Hello,
> > > > >
> > > > > Sorry for possibly missing previous discussions on the Redfish
> feature.
> > > > > I am wondering is it more straight-forward to put the JsonLib
> > > > > together with the Readfish codes under RedfishPkg?
> > > > Hi Hao,
> > > > The idea is JSON is not the representation of data payload for
> > > > Redfish only and JsonLib could be not only for Redfish neither.
> > > > Any applications which use JSON as data payload can leverage JsonLib.
> > >
> > >
> > > Thanks,
> > >
> > > My concern is for the case of adding a common library/module,
> > > MdeModulePkg usually seems to be the destination. But since
> > > MdeModulePkg is already a huge and complex package, I am not sure if
> this
> > > is the right way to go.
> > >
> > > I would like to get the inputs on other reviewers for putting the
> JsonLib
> > > under MdeModulePkg.
> > >
> > > If this is the right direction, could you help to add an item in the
> > > Maintainers.txt for the Json related stuff in MdeModulePkg and list
> > > you
> (and
> > > 1 more person will be appreciated) as the reviewer?
> > That's no problem. We are pleased to be the reviewer of JSON lib.
> >
> > Yes, see others input for JsonLib location.
> >
> > Thanks
> > Abner
> > >
> > > Thanks in advance.
> > >
> > > Best Regards,
> > > Hao Wu
> > >
> > >
> > > >
> > > > Thanks
> > > > Abner
> > > > >
> > > > > Best Regards,
> > > > > Hao Wu
> > > > >
> > > > >
> > > > > > and the edk2 port of libredfish library (not contributed yet)
> > > > > > based on DMTF GitHub (https://github.com/DMTF/libredfish).
> > > > > >
> > > > > > You will encounterred the build error with the jansson library
> > > > > > pointed in submoudle (v2.13.1) and the fix is already
> > > > > > submitted to jansson open source
> (https://github.com/akheron/jansson/pull/558).
> > > > > >
> > > > > > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > > > > >
> > > > > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > > > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > > > > Cc: Andrew Fish <afish@apple.com>
> > > > > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > > > > Cc: Leif Lindholm <leif@nuviainc.com>
> > > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > > > Cc: Nickle Wang <nickle.wang@hpe.com>
> > > > > > Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> > > > > >
> > > > > > Abner Chang (3):
> > > > > >   edk2: jansson submodule of JSON library
> > > > > >   MdeModulePkg/library: EDK2 port jansson library
> > > > > >   MdeModulePkg: Add EDK2 port jansson library
> > > > > >
> > > > > >  .gitmodules                                   |   3 +
> > > > > >  MdeModulePkg/Include/Library/JsonLib.h        | 596
> > +++++++++++++
> > > > > >  .../Library/JsonLib/JanssonCrtLibSupport.c    | 705
> > +++++++++++++++
> > > > > >  .../Library/JsonLib/JanssonCrtLibSupport.h    | 198 +++++
> > > > > >  MdeModulePkg/Library/JsonLib/JsonLib.c        | 805
> > > > > ++++++++++++++++++
> > > > > >  MdeModulePkg/Library/JsonLib/JsonLib.inf      |  81 ++
> > > > > >  MdeModulePkg/Library/JsonLib/JsonUtilities.c  | 417 +++++++++
> > > > > > MdeModulePkg/Library/JsonLib/JsonUtilities.h  |  69 ++
> > > > > >  MdeModulePkg/Library/JsonLib/assert.h         |  11 +
> > > > > >  MdeModulePkg/Library/JsonLib/errno.h          |  11 +
> > > > > >  MdeModulePkg/Library/JsonLib/jansson          |   1 +
> > > > > >  MdeModulePkg/Library/JsonLib/jansson_config.h |  57
> > > > > > ++  .../Library/JsonLib/jansson_private_config.h  |  19 +
> > > > > >  MdeModulePkg/Library/JsonLib/limits.h         |  11 +
> > > > > >  MdeModulePkg/Library/JsonLib/math.h           |  11 +
> > > > > >  MdeModulePkg/Library/JsonLib/stdarg.h         |  11 +
> > > > > >  MdeModulePkg/Library/JsonLib/stddef.h         |  11 +
> > > > > >  MdeModulePkg/Library/JsonLib/stdio.h          |  11 +
> > > > > >  MdeModulePkg/Library/JsonLib/stdlib.h         |  11 +
> > > > > >  MdeModulePkg/Library/JsonLib/string.h         |  11 +
> > > > > >  MdeModulePkg/Library/JsonLib/sys/time.h       |  11 +
> > > > > >  MdeModulePkg/Library/JsonLib/sys/types.h      |  10 +
> > > > > >  MdeModulePkg/Library/JsonLib/time.h           |  11 +
> > > > > >  MdeModulePkg/MdeModulePkg.dec                 |   7 +-
> > > > > >  MdeModulePkg/MdeModulePkg.dsc                 |   4 +-
> > > > > >  ReadMe.rst                                    |   1 +
> > > > > >  26 files changed, 3092 insertions(+), 2 deletions(-)  create
> > > > > > mode
> > > > > > 100644 MdeModulePkg/Include/Library/JsonLib.h
> > > > > >  create mode 100644
> > > > > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.c
> > > > > >  create mode 100644
> > > > > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.h
> > > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.c
> > > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.inf
> > > > > >  create mode 100644
> > > > > > MdeModulePkg/Library/JsonLib/JsonUtilities.c
> > > > > >  create mode 100644
> > > > > > MdeModulePkg/Library/JsonLib/JsonUtilities.h
> > > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/assert.h
> > > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/errno.h
> > > > > >  create mode 160000 MdeModulePkg/Library/JsonLib/jansson
> > > > > >  create mode 100644
> > MdeModulePkg/Library/JsonLib/jansson_config.h
> > > > > >  create mode 100644
> > > > > > MdeModulePkg/Library/JsonLib/jansson_private_config.h
> > > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/limits.h
> > > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/math.h
> > > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/stdarg.h
> > > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/stddef.h
> > > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/stdio.h
> > > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/stdlib.h
> > > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/string.h
> > > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/sys/time.h
> > > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/sys/types.h
> > > > > >  create mode 100644 MdeModulePkg/Library/JsonLib/time.h
> > > > > >
> > > > > > --
> > > > > > 2.17.1
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68008): https://edk2.groups.io/g/devel/message/68008
Mute This Topic: https://groups.io/mt/78513140/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-