From nobody Sun Apr 28 10:00:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67741+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67741+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1605849809; cv=none; d=zohomail.com; s=zohoarc; b=BzyhK80/yA3ek1kOjSZlvWdf6TdT8vVLzyYqRT4IBKUvf/gGDCu2OyI4+pwh+FGa2ZCId44fMPIHA6PxxBEIg+j8iWfmmMASlFXvWtTOMwxaY5MmtUNOq/FEHfbkjhKCx09HZqmrGB7jGmLnruaIcn3us2r9HTphEbJ8U/uat6E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605849809; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=JkycX+sbrwugNzWJa/k4uDUxpKkM6llMNGp3QkpWFZI=; b=L9Upnn00ouhD2eOPdtaBpbVrL6IY5bB/s68Z2E6VQAAm7P2qS6VHKTNmp/Tdurt3/UfaMya+bpXBHCC4b0J86e6/OmyObFUvk4pYCUpx8v6j4uf6mbXTPLUn75j+uu05QTKqFenpMr5+PQpgiJ/+4wNW/qcvgOhFXzowRrCC0HE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67741+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1605849809028124.94673929691419; Thu, 19 Nov 2020 21:23:29 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id ZVDCYY1788612xaHbqCfD84H; Thu, 19 Nov 2020 21:23:28 -0800 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web08.21270.1605849805563488207 for ; Thu, 19 Nov 2020 21:23:27 -0800 IronPort-SDR: hdVWyAHCEaGNN925fdSXECRXM/W/siZqNsRBghsqeZgxFOCuOaHvKQimepEU2kiw4GteWB5H+N fGbCX1XGqAZQ== X-IronPort-AV: E=McAfee;i="6000,8403,9810"; a="170636483" X-IronPort-AV: E=Sophos;i="5.78,355,1599548400"; d="scan'208";a="170636483" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2020 21:23:24 -0800 IronPort-SDR: 2vfYvDyIQC56imSEp4CAIo5uieVv+IOIdh1nsTTIIFl7QT63ZfH6dly8Yj+1JR0V08mBlBy6Yb LLE9VKkUpZ2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,355,1599548400"; d="scan'208";a="545306395" X-Received: from hengluo-dev.ccr.corp.intel.com ([10.239.153.154]) by orsmga005.jf.intel.com with ESMTP; 19 Nov 2020 21:23:23 -0800 From: "Heng Luo" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone Subject: [edk2-devel] [PATCH] UpXtreme: Enable USB DCI debug Date: Fri, 20 Nov 2020 13:23:15 +0800 Message-Id: <20201120052316.3707-1-heng.luo@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,heng.luo@intel.com X-Gm-Message-State: suOmbgGdwU2ksnqQiRBfoAeex1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1605849808; bh=drjnQdQyE2Qoy/d5MmxWOOLHR93Hu7oUfTMnS2/G20E=; h=Cc:Date:From:Reply-To:Subject:To; b=qici1lqBuKg9YdSVuS8OfYR9Y116BR9w4UFU4TsRVJ63X1/ksvBSLWQk8rPagXtN5OU YL/b1daoHEHb/qXLlQ3H7muN0T+6pa1L9N4SJf2vi0MUZtsPoU8gEdFRDOcJVXqmm2YpN NTPD1L0+C/4W1O8b6tweboryMu1Xusu6Gag= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3081 Allow to debug BIOS via DCI cable. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Heng Luo --- Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/P= eiPchPolicyUpdatePreMem.c | 1 - Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoardConf= igLib/PeiCpuPolicyBoardConfig.c | 5 +++++ Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoardConf= igLib/PeiPchPolicyBoardConfigPreMem.c | 7 +++++++ Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoardConf= igLib/PeiPolicyBoardConfigLib.inf | 1 + Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPolicyBo= ardConfigLib/PeiPchPolicyBoardConfigPreMem.c | 6 ++++++ Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPolicyBo= ardConfigLib/PeiPolicyBoardConfigLib.inf | 1 + 6 files changed, 20 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolic= yUpdateLib/PeiPchPolicyUpdatePreMem.c b/Platform/Intel/WhiskeylakeOpenBoard= Pkg/Policy/Library/PeiPolicyUpdateLib/PeiPchPolicyUpdatePreMem.c index 2d48b09175..ac5b583f89 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPchPolicyUpdatePreMem.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdate= Lib/PeiPchPolicyUpdatePreMem.c @@ -83,7 +83,6 @@ UpdatePeiPchPolicyPreMem ( Status =3D GetConfigBlock ((VOID *) SiPreMemPolicy, &gIshPreMemConfigGui= d, (VOID *) &IshPreMemConfig); ASSERT_EFI_ERROR (Status); =20 - DciPreMemConfig->DciUsb3TypecUfpDbg =3D 2; PchTraceHubPreMemConfig->MemReg0Size =3D 3; PchTraceHubPreMemConfig->MemReg1Size =3D 3; // diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPol= icyBoardConfigLib/PeiCpuPolicyBoardConfig.c b/Platform/Intel/WhiskeylakeOpe= nBoardPkg/UpXtreme/Library/PeiPolicyBoardConfigLib/PeiCpuPolicyBoardConfig.c index d1d1920823..d4c5136c0a 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar= dConfigLib/PeiCpuPolicyBoardConfig.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar= dConfigLib/PeiCpuPolicyBoardConfig.c @@ -44,6 +44,11 @@ UpdatePeiCpuPolicyBoardConfig ( Status =3D GetConfigBlock ((VOID *) SiPolicyPpi, &gCpuConfigGuid, (VOID = *) &CpuConfig); ASSERT_EFI_ERROR (Status); =20 + // + //Enable processor debug features + // + CpuConfig->DebugInterfaceEnable =3D 1; + return Status; } =20 diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPol= icyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c b/Platform/Intel/Whiskeyl= akeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoardConfigLib/PeiPchPolicyBoardC= onfigPreMem.c index 01bb75525b..c79718f4ee 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar= dConfigLib/PeiPchPolicyBoardConfigPreMem.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar= dConfigLib/PeiPchPolicyBoardConfigPreMem.c @@ -25,12 +25,19 @@ UpdatePeiPchPolicyBoardConfigPreMem ( { EFI_STATUS Status; PCH_GENERAL_PREMEM_CONFIG *PchGeneralPreMemConfig; + PCH_DCI_PREMEM_CONFIG *DciPreMemConfig; =20 DEBUG((DEBUG_INFO, "Updating PCH Policy by board config in Pre Mem\n")); =20 Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, &gPchGeneralPreMe= mConfigGuid, (VOID *) &PchGeneralPreMemConfig); ASSERT_EFI_ERROR (Status); =20 + Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, &gDciPreMemConfig= Guid, (VOID *) &DciPreMemConfig); + ASSERT_EFI_ERROR (Status); + + DciPreMemConfig->PlatformDebugConsent =3D 3; + DciPreMemConfig->DciUsb3TypecUfpDbg =3D 1; + return Status; } =20 diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPol= icyBoardConfigLib/PeiPolicyBoardConfigLib.inf b/Platform/Intel/WhiskeylakeO= penBoardPkg/UpXtreme/Library/PeiPolicyBoardConfigLib/PeiPolicyBoardConfigLi= b.inf index aaf0abbf04..affb322c59 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar= dConfigLib/PeiPolicyBoardConfigLib.inf +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/PeiPolicyBoar= dConfigLib/PeiPolicyBoardConfigLib.inf @@ -54,6 +54,7 @@ gPchGeneralConfigGuid ## CONSUMES gEfiTpmDeviceInstanceTpm20DtpmGuid gEfiTpmDeviceInstanceTpm12Guid + gDciPreMemConfigGuid =20 [Ppis] gEfiPeiReadOnlyVariable2PpiGuid ## CONSUMES diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library= /PeiPolicyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c b/Platform/Intel/W= hiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPolicyBoardConfigLib/PeiP= chPolicyBoardConfigPreMem.c index 00cf73dfd9..5d75bc5e1c 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPol= icyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPol= icyBoardConfigLib/PeiPchPolicyBoardConfigPreMem.c @@ -25,12 +25,18 @@ UpdatePeiPchPolicyBoardConfigPreMem ( { EFI_STATUS Status; PCH_GENERAL_PREMEM_CONFIG *PchGeneralPreMemConfig; + PCH_DCI_PREMEM_CONFIG *DciPreMemConfig; =20 DEBUG((DEBUG_INFO, "Updating PCH Policy by board config in Pre Mem\n")); =20 Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, &gPchGeneralPreMe= mConfigGuid, (VOID *) &PchGeneralPreMemConfig); ASSERT_EFI_ERROR (Status); =20 + Status =3D GetConfigBlock ((VOID *) SiPreMemPolicyPpi, &gDciPreMemConfig= Guid, (VOID *) &DciPreMemConfig); + ASSERT_EFI_ERROR (Status); + + DciPreMemConfig->DciUsb3TypecUfpDbg =3D 2; + return Status; } =20 diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library= /PeiPolicyBoardConfigLib/PeiPolicyBoardConfigLib.inf b/Platform/Intel/Whisk= eylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPolicyBoardConfigLib/PeiPolic= yBoardConfigLib.inf index 15ef223050..5de11d62e4 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPol= icyBoardConfigLib/PeiPolicyBoardConfigLib.inf +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/PeiPol= icyBoardConfigLib/PeiPolicyBoardConfigLib.inf @@ -54,6 +54,7 @@ gPchGeneralConfigGuid ## CONSUMES gEfiTpmDeviceInstanceTpm20DtpmGuid gEfiTpmDeviceInstanceTpm12Guid + gDciPreMemConfigGuid =20 [Ppis] gEfiPeiReadOnlyVariable2PpiGuid ## CONSUMES --=20 2.24.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67741): https://edk2.groups.io/g/devel/message/67741 Mute This Topic: https://groups.io/mt/78383406/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-