From nobody Fri May 3 14:48:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67235+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67235+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1605029835; cv=none; d=zohomail.com; s=zohoarc; b=Y6DL0rvtk+fFkvbH1t/KHoL6vgYQvm0iVPBBO+QpAJVNcU0sPUJwAMJnOQxzP1m4zF5qYIlgHSr2vvw7Z8ED/awy54iDCeiaXKxqheRLt6bkOg3gf5lWUyDwy7Q+Okf/iAlrRYZnDM7xmPErO0aBmZJP0zQLGWcavKAGFxZHXXg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605029835; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=QvkBCsW/3ibVdXRNvldt/EJWzuMbbkcr+S1YV2mUSeg=; b=lluNR/12Qc4wY96XPgx2x0Zp1dUeJ+SkH5QkFTm1G0yi5+QyIY9K8SUTCBjxinTSTfqc3gP3eEm4Lih5SUM/KwNRUdnmzv9m9yTwOlFP1FXKsvg2nJVeMSpKJDkYc0kfx8Xb68ijApmL9nzer/xsuQzGqUkHzGlyqCMF7G0ayyM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67235+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1605029835435567.3884491683591; Tue, 10 Nov 2020 09:37:15 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id cRr1YY1788612xQySzpH2VZS; Tue, 10 Nov 2020 09:37:15 -0800 X-Received: from mga17.intel.com (mga17.intel.com []) by mx.groups.io with SMTP id smtpd.web09.31448.1605029824101645772 for ; Tue, 10 Nov 2020 09:37:04 -0800 IronPort-SDR: Z50gaZQqxW2qKi4e4yM3gp3CwPwBFe+HC1RCK76rVT3i43ZZjI5XT5uNGS5Ur98JE2Xsdkg3OQ 4auLud0txCHw== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="149867196" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="149867196" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 09:37:02 -0800 IronPort-SDR: ZgdZVWsUVRnONH5eR5inK+AIqpfIrd89sxXmSrHf/dQgC+veXSFV8SUlsR6SWXvNy4sfK33/Ou aYyLgB96wVtA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="473509528" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by orsmga004.jf.intel.com with ESMTP; 10 Nov 2020 09:36:59 -0800 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Jiewen Yao Subject: [edk2-devel] [PATCH V3 01/12] SecurityPkg/Hash2DxeCrypto: Remove MD5 support Date: Wed, 11 Nov 2020 01:36:40 +0800 Message-Id: <20201110173651.54036-2-zhichao.gao@intel.com> In-Reply-To: <20201110173651.54036-1-zhichao.gao@intel.com> References: <20201110173651.54036-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: CCHsKsFuagNJOdWhQXaXfcCdx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1605029835; bh=lVgE+N0fKst+wPEcn5cxDetfpavv+rlgfZyuJGwEQ0E=; h=Cc:Date:From:Reply-To:Subject:To; b=kETCvilADiLKE1MpIzYxMyBKH8yvhJfzKG0sWtKLLjwzHfErav397WuEVXaHfjz0fQp GOZk1BU/IEXorLWB81hxQzDbR0nkuKOUjjfpaa8ZTZk1v4HFNxFXxGp7dVgsY7RkpwiFy NFUD+G4FNY39VE8lhhQ5MsqRcToa0fU+jOk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3027 Remove the deprecated MD5 support of Hash2DxeCrypto driver. Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Zhichao Gao Reviewed-by: Jiewen Yao --- SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 1 - SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c b/SecurityPkg/Hash= 2DxeCrypto/Hash2DxeCrypto.c index d96bc136e2..50a6157bd9 100644 --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c @@ -120,7 +120,6 @@ typedef struct { } EFI_HASH_INFO; =20 EFI_HASH_INFO mHashInfo[] =3D { - {&gEfiHashAlgorithmMD5Guid, sizeof(EFI_MD5_HASH2), Md5GetContextS= ize, Md5Init, Md5Update, Md5Final }, {&gEfiHashAlgorithmSha1Guid, sizeof(EFI_SHA1_HASH2), Sha1GetContext= Size, Sha1Init, Sha1Update, Sha1Final }, {&gEfiHashAlgorithmSha256Guid, sizeof(EFI_SHA256_HASH2), Sha256GetConte= xtSize, Sha256Init, Sha256Update, Sha256Final }, {&gEfiHashAlgorithmSha384Guid, sizeof(EFI_SHA384_HASH2), Sha384GetConte= xtSize, Sha384Init, Sha384Update, Sha384Final }, diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf b/SecurityPkg/Ha= sh2DxeCrypto/Hash2DxeCrypto.inf index a0b57f0514..a65943056a 100644 --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf @@ -4,7 +4,7 @@ # This module will use EDKII crypto library to HASH2 protocol. # # (C) Copyright 2015 Hewlett-Packard Development Company, L.P.
-# Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.
+# Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # ## @@ -44,7 +44,6 @@ UefiLib =20 [Guids] - gEfiHashAlgorithmMD5Guid ## CONSUMES ## GUID gEfiHashAlgorithmSha1Guid ## CONSUMES ## GUID gEfiHashAlgorithmSha256Guid ## CONSUMES ## GUID gEfiHashAlgorithmSha384Guid ## CONSUMES ## GUID --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67235): https://edk2.groups.io/g/devel/message/67235 Mute This Topic: https://groups.io/mt/78164657/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 14:48:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67233+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67233+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1605029829; cv=none; d=zohomail.com; s=zohoarc; b=g359r6F8SEaeKqO6MWOCLum1cOIbu4D889vk/lvWCsQ0v9caPdBYKovK9svDMVUieF4oCUebxrzyqSQ8VRBlAKE8a5/kOjyJM/tD5sNCH60AmJ9CIlbLg6Np5npHwefGxsSTTKNJghDBO58NLL1GZpjl9t84t97pWqVdh/A74A8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605029829; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=IPLTSOtlw1UdCNf0EgIqPEvTiz/Q/I0Z2xyDiYcC9kE=; b=c3rhOCxbVwvFA8YiLfGY7+1uEPb642TVIEnFU7koVN30d3yLnuv0jcsWow4FOf5KK7Hf7ao9RMv33eMNJmqH8X5hOpxlqohydMnjjHpOvqzKUmLiPe08vIOs47twrpxT3ioLayml57UvSS06LPfjRiW+orqlaQejHbvhxt0PMXg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67233+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 160502982935052.164001770335744; Tue, 10 Nov 2020 09:37:09 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id uG8aYY1788612xPiG3UU3XVA; Tue, 10 Nov 2020 09:37:09 -0800 X-Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.31252.1605029823360870501 for ; Tue, 10 Nov 2020 09:37:03 -0800 IronPort-SDR: 3QzCxS3uXFT6p2a3SASV9476x7RVP3DHUKWJnRFb1h9kZypZwn3y2+GjuUAO+j3abLkQ1migPf CKxETYXqf+Tg== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="149293709" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="149293709" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 09:37:01 -0800 IronPort-SDR: a61boW3jXOFD64b44QgJ3kijAgiWQsWAVIMA8QRMTA1lJj2y+4H4nYKDHM6uiodqAsHHGeGy7+ mjBFOYlspHkQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="473509547" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by orsmga004.jf.intel.com with ESMTP; 10 Nov 2020 09:37:00 -0800 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Jiewen Yao Subject: [edk2-devel] [PATCH V3 02/12] SecurityPkg/Hash2DxeCrypto: Remove SHA1 support Date: Wed, 11 Nov 2020 01:36:41 +0800 Message-Id: <20201110173651.54036-3-zhichao.gao@intel.com> In-Reply-To: <20201110173651.54036-1-zhichao.gao@intel.com> References: <20201110173651.54036-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: ZKyPpzwa6xrYFAksmYfON0CCx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1605029829; bh=nhcfL+6mC8IirwSYdV68h/28lxQg9LSt/jXXf+8UuFE=; h=Cc:Date:From:Reply-To:Subject:To; b=qW79MQTWeaHksy5BpvP0dmgk0WkHaFF58srk+1j8e0LJH4nny0x3MArMAkbYDuwNDz7 1jMfUkMHTIthwd4DRjCM9fhexmxCQfBdsyYZ6/E0ffuJDsuOUQ7cP+HX+JIdD7LTwyIDa znsWo8+wHqQZJXIWaLY5V4bnLA9rclzmZYE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3027 Remove the deprecated SHA1 support of Hash2DxeCrypto driver. Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Zhichao Gao Reviewed-by: Jiewen Yao --- SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 1 - SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 1 - 2 files changed, 2 deletions(-) diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c b/SecurityPkg/Hash= 2DxeCrypto/Hash2DxeCrypto.c index 50a6157bd9..c1c0470be9 100644 --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c @@ -120,7 +120,6 @@ typedef struct { } EFI_HASH_INFO; =20 EFI_HASH_INFO mHashInfo[] =3D { - {&gEfiHashAlgorithmSha1Guid, sizeof(EFI_SHA1_HASH2), Sha1GetContext= Size, Sha1Init, Sha1Update, Sha1Final }, {&gEfiHashAlgorithmSha256Guid, sizeof(EFI_SHA256_HASH2), Sha256GetConte= xtSize, Sha256Init, Sha256Update, Sha256Final }, {&gEfiHashAlgorithmSha384Guid, sizeof(EFI_SHA384_HASH2), Sha384GetConte= xtSize, Sha384Init, Sha384Update, Sha384Final }, {&gEfiHashAlgorithmSha512Guid, sizeof(EFI_SHA512_HASH2), Sha512GetConte= xtSize, Sha512Init, Sha512Update, Sha512Final }, diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf b/SecurityPkg/Ha= sh2DxeCrypto/Hash2DxeCrypto.inf index a65943056a..6a456ed2a6 100644 --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf @@ -44,7 +44,6 @@ UefiLib =20 [Guids] - gEfiHashAlgorithmSha1Guid ## CONSUMES ## GUID gEfiHashAlgorithmSha256Guid ## CONSUMES ## GUID gEfiHashAlgorithmSha384Guid ## CONSUMES ## GUID gEfiHashAlgorithmSha512Guid ## CONSUMES ## GUID --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67233): https://edk2.groups.io/g/devel/message/67233 Mute This Topic: https://groups.io/mt/78164654/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 14:48:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67236+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67236+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1605029828; cv=none; d=zohomail.com; s=zohoarc; b=jQ1LqOtBRuXyOeDDDqnoDpZSFOdCCgufMS77L5lUmvP3oIMp4SJwkzjEQDPS7QXco5avaOHaWMcQzhIPpVNh8z55MsgloPs6Ve7dprBYw3PyxPW/nMI1Mgm90SGIzsGaFpq6q4ep3F1PPxc0IDuo9WUbzQmhFLFtfTD6yBnXJA0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605029828; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=FeF+ZMSJl+rxzYlkz0q/9qeepKMQuUCeW4UOkrjr6aY=; b=boNTazbnSiqTt/RLRWIGpvD1/IUSixX2ZkZrMMDWSVlaGM47FDxiQavCLVMQ6UEPtkqxDuJGryINqiNgutnwSnNqrKSS4Gzw0bYBP6MzYICOPYUaYbrUd2gYAXvuB8LBte5bm6INnoFWZOLD4HD2LM9jmk6bmoQY7sUSfWsSnIY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67236+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1605029828031698.0456941112734; Tue, 10 Nov 2020 09:37:08 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id njQMYY1788612xW97JZ1AAVV; Tue, 10 Nov 2020 09:37:07 -0800 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.31256.1605029827145466395 for ; Tue, 10 Nov 2020 09:37:07 -0800 IronPort-SDR: DMSfA6eEknPqHtDGR8rwAB4rmKxUmlE1bfNZjSDzGLtRnruFRkRx0Ji6oBwxPaa2gH79aK1RdE MAReGoGrPTOw== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="169234214" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="169234214" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 09:37:03 -0800 IronPort-SDR: PRbaFuRo3pVwCg205gUe5OuYaTy0vEYaJ+sIgqqnZ2gaNU32w7vP4Bii9A7o/axuguAt33C5yv t2GwxVcTujLQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="473509570" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by orsmga004.jf.intel.com with ESMTP; 10 Nov 2020 09:37:02 -0800 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Jiewen Yao Subject: [edk2-devel] [PATCH V3 03/12] CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5 Date: Wed, 11 Nov 2020 01:36:42 +0800 Message-Id: <20201110173651.54036-4-zhichao.gao@intel.com> In-Reply-To: <20201110173651.54036-1-zhichao.gao@intel.com> References: <20201110173651.54036-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: i9rMmxdMUqBT6G4JHTI7Iflsx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1605029827; bh=3TxVADFQhDP6kPoBBWNgmQstLazVNlpY/gKIqKRbbW8=; h=Cc:Date:From:Reply-To:Subject:To; b=xFLFGLSl1SpZLXbrUmbiFgj5UJ8Xt7W0gpBRfEAxtghTpC1no5mkh+90jS0/CW/W2PD lPviVooEqus94q8dVJy45PEmjKJub5RFIxwUS5OSwWOq+CjQHEGuw+dMuZRuoRJdY69Dg PNl2Ueu7U626nLr9Ls+bJS85d+cpYdgvTzY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3021 CRYPTO_SERVICES PACKAGES and ALL config would enable MD5 function. So explicitly enable MD5 while CRYPTO_SERVICES are set PACKAGES and ALL. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Zhichao Gao Reviewed-by: Jiewen Yao --- CryptoPkg/CryptoPkg.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc index 7e51f6fac5..8dac4b1614 100644 --- a/CryptoPkg/CryptoPkg.dsc +++ b/CryptoPkg/CryptoPkg.dsc @@ -308,3 +308,6 @@ =20 [BuildOptions] *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES +!if $(CRYPTO_SERVICES) IN "PACKAGE ALL" + *_*_*_CC_FLAGS =3D -D ENABLE_MD5_DEPRECATED_INTERFACES +!endif --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67236): https://edk2.groups.io/g/devel/message/67236 Mute This Topic: https://groups.io/mt/78164659/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 14:48:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67237+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67237+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1605029828; cv=none; d=zohomail.com; s=zohoarc; b=QHOoa42tn4aXEGPOsqLzjlDkaS0Yq8RhOOzSHM5VlapNlZb/NYbwwO+YcSUqBDHORU4a4nkV459FLCrGondxBesAWzNA5qShL6S1wyaNYnSmPoy/2T2NQZi91gRtXak9tjeyit2HUTs7Ukf+3GmsJkIAbO2l8DmHjaZRyVj6cvs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605029828; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=cmJtey03sWKsc3CxegeVPqOoRfKOljHt8osUjko3kZM=; b=S24+K46lobm5z3qhdKPGbCFbS42cuv4ttx7v8k4dYQdznAE6kVDpu/CSroKPuDLeyTlpwL1iTFnCbx0Ctk7KXWPIwq3IGcBFOAUR0aLMvErDoODS7LJE2Ie5b1eAL/21Le0QZtqVmqTC7Q6J9+QNnK0o9ENhwuuGSFpNbqc81og= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67237+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1605029828565604.1412808509251; Tue, 10 Nov 2020 09:37:08 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id VW7xYY1788612x6djmVmpJum; Tue, 10 Nov 2020 09:37:08 -0800 X-Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web10.31256.1605029827145466395 for ; Tue, 10 Nov 2020 09:37:07 -0800 IronPort-SDR: 11/LW8XkxbPFlch6ZfGdnsRMPKNZzQlVVAixFZd7IJXkdMul0k4Gk2qu0DMMvoDBcmRw2BT/7Q v+2BFRC5s3Gg== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="169234225" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="169234225" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 09:37:05 -0800 IronPort-SDR: Cu7zLpDRLm1sSq9u9G4SYFnws2GHVdDFeNbMtf3e99oNMYhgvWjGwqzCX0Ltt+7T2UIPtH5N/I UHyD0GIiZ7mg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="473509593" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by orsmga004.jf.intel.com with ESMTP; 10 Nov 2020 09:37:03 -0800 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Maciej Rabeda , Jiaxin Wu , Siyuan Fu Subject: [edk2-devel] [PATCH V3 04/12] NetworkPkg: Enable MD5 while enable iSCSI Date: Wed, 11 Nov 2020 01:36:43 +0800 Message-Id: <20201110173651.54036-5-zhichao.gao@intel.com> In-Reply-To: <20201110173651.54036-1-zhichao.gao@intel.com> References: <20201110173651.54036-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: IXi04X9q8amoYay7dCNsn6xWx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1605029828; bh=IbYjfEG/D/134JHwBKXK5WrE54loUjxQQdIhhfs8o8g=; h=Cc:Date:From:Reply-To:Subject:To; b=jPqmFInpYNzBuftfWArjbYxChPtq+zZgu+XTLFkpBGaJOe0YLFNiJI/pBur8kCbjV70 sFKiYfLnVoxeMjF7Nrrh3C6S2COSMP5XgXzQFngoWu6ypHGkLe2Wrp3tvAQYzgI7P+0ft +yyadMo4Wgh1cdxgKRPirlSThVOWdzjG4vU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3003 There is a plan to make MD5 disable as default. The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES would be introduced to enable MD5. Make the definition ahead of the change to avoid build error after the MACRO changed. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Zhichao Gao --- NetworkPkg/Network.dsc.inc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/NetworkPkg/Network.dsc.inc b/NetworkPkg/Network.dsc.inc index 16f090a187..b761df900b 100644 --- a/NetworkPkg/Network.dsc.inc +++ b/NetworkPkg/Network.dsc.inc @@ -30,6 +30,11 @@ [LibraryClasses] !include NetworkPkg/NetworkLibs.dsc.inc =20 +[BuildOptions] +!if $(NETWORK_ISCSI_ENABLE) =3D=3D TRUE + *_*_*_CC_FLAGS =3D -D ENABLE_MD5_DEPRECATED_INTERFACES +!endif + !if $(PLATFORMX64_ENABLE) =3D=3D TRUE [Components.X64] !include NetworkPkg/NetworkComponents.dsc.inc --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67237): https://edk2.groups.io/g/devel/message/67237 Mute This Topic: https://groups.io/mt/78164661/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 14:48:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67238+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67238+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1605029829; cv=none; d=zohomail.com; s=zohoarc; b=Y6aFnDMjUhzpPVW9/xd3MjI3vRdYq4Y7NvQUvss7JYk+B8Zk3t26b1NQzo0+RWt92Bxugx9PO1Z1lp5KnuD9efbCjtTTUBn/tPuoqq6htah+VOq1kBDAk1kNTwTzH9fvdmaEaTYV51k0wFu/2imaHn/XlT11YojPMBbVU1JLY04= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605029829; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=qkvxA6UsK+8dfwU04q5GCo537PQfO0SaqCDa7MiPxCY=; b=di0yr1n9VcSyws2bs6hrkO9qpezaWQpi+gsDcE0BfktoIUkVEXYHAYDyVE0h77i0glNRivn2vLadgszvBj+QBX2mC+U8oc5m7GPWplkDePfI/P7Oph2oHYSgdiGUFbf6C8/qMvYoTiwv8QOaOPpVZh+/DhvBYf9IE7vRhAxBazE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67238+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1605029829096321.4180179457999; Tue, 10 Nov 2020 09:37:09 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 872uYY1788612x88x17iddx4; Tue, 10 Nov 2020 09:37:08 -0800 X-Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web10.31256.1605029827145466395 for ; Tue, 10 Nov 2020 09:37:07 -0800 IronPort-SDR: 9Lvt1lV8PIw3NBhp4z3ivGPS05xwB7LWTydHNSc2KETPz7LdXepwNkec7InXhsE+gqeSRWUbcE grEvxpQt2R5w== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="169234241" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="169234241" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 09:37:06 -0800 IronPort-SDR: 0eb6mW38enkVTWedsWWqqd8r5lQDV9Cg4HlOtNpgIJpz2IS6WhDtmEwLefz6RYn6Y9Fy8qoI0t UsMMQMcYkFpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="473509597" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by orsmga004.jf.intel.com with ESMTP; 10 Nov 2020 09:37:05 -0800 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Laszlo Ersek , Ard Biesheuvel , Leif Lindholm Subject: [edk2-devel] [PATCH V3 05/12] ArmVirtPkg/ArmVirtQemu.dsc: Enable MD5 while enable iSCSI Date: Wed, 11 Nov 2020 01:36:44 +0800 Message-Id: <20201110173651.54036-6-zhichao.gao@intel.com> In-Reply-To: <20201110173651.54036-1-zhichao.gao@intel.com> References: <20201110173651.54036-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: Zqc0swUG0onGLCXxgolEl7WWx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1605029828; bh=OewnXFHU7Xj2a8UcT300QIV8HQ7dQ+19gF41zPPTcR0=; h=Cc:Date:From:Reply-To:Subject:To; b=LYs3PsOZswIL+4K/cXLtDgsckvugP79dqiJKobbJ4bmpt9bBaq87E7LPm46CQdJKzOh oUy4y+P7cBwTMwdqy15ddwFuXwpITQlDppsH95JRuj1U89h7niyBzyqNUke3JO8BV7ltI Wy37B3MYrcfF4eoGgQaJ4jNDnpZWZjSsFqQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3003 There is a plan to make MD5 disable as default. The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES would be introduced to enable MD5. Make the definition ahead of the change to avoid build error after the MACRO changed. Enalbe iSCSI. Signed-off-by: Zhichao Gao Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm --- ArmVirtPkg/ArmVirtQemu.dsc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index 3f649c91d8..3be8448d0b 100644 --- a/ArmVirtPkg/ArmVirtQemu.dsc +++ b/ArmVirtPkg/ArmVirtQemu.dsc @@ -1,7 +1,7 @@ # # Copyright (c) 2011-2015, ARM Limited. All rights reserved. # Copyright (c) 2014, Linaro Limited. All rights reserved. -# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved. +# Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -40,6 +40,7 @@ DEFINE NETWORK_SNP_ENABLE =3D FALSE DEFINE NETWORK_TLS_ENABLE =3D FALSE DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE + DEFINE NETWORK_ISCSI_ENABLE =3D TRUE =20 !if $(NETWORK_SNP_ENABLE) =3D=3D TRUE !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only" @@ -49,6 +50,11 @@ =20 !include ArmVirtPkg/ArmVirt.dsc.inc =20 +[BuildOptions] +!if $(NETWORK_ISCSI_ENABLE) =3D=3D TRUE + *_*_*_CC_FLAGS =3D -D ENABLE_MD5_DEPRECATED_INTERFACES +!endif + [LibraryClasses.common] ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67238): https://edk2.groups.io/g/devel/message/67238 Mute This Topic: https://groups.io/mt/78164663/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 14:48:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67239+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67239+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1605029829; cv=none; d=zohomail.com; s=zohoarc; b=l4Q26Wk7NQFQWqFuBotelWwFuVWHMji1p7EL2MrCP2jTJcQNAh8CGqhKq9jXZpqUUqJjY+pOc9m1CepraDEcTx7bcD0qHsu1ePIB4W7BPgoqr6LyCsHeyyP5FqgCq65E9fELUCx7gXmV2QMR7JyGGcS1tkttfK61UC/AnhsJq+Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605029829; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=2X48itpgd1owOqHpRoJ7ckMD+/7efeT7oF7C0r0NqbM=; b=EDuUkRiew9gIwOIfT3FTkgSpIT0jmSC8FM3sIaWO9HfUtgdoxSbNDNOxIIEGa0na8yhxOz1ZgO3RnXfzu+xIMehgpLGMSYxt6qY2kMxrwNDWUmmVA+R/LK+S959IfKJoHt24ZijbD4c3k0yxVPpOeSN/LdtbC05Lb0EfIA+Ous0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67239+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1605029829617873.78364846509; Tue, 10 Nov 2020 09:37:09 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id UjbQYY1788612xLRNCJu8965; Tue, 10 Nov 2020 09:37:09 -0800 X-Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web10.31256.1605029827145466395 for ; Tue, 10 Nov 2020 09:37:08 -0800 IronPort-SDR: k9hw9tIpvILWi5LBQ88kBTVTrU/VJKuwIuaOkdycnqw7nzEhqlW4Gd6T7ktelkpoFAWdkCiPnC ZQdXyw3Z3SfA== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="169234252" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="169234252" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 09:37:08 -0800 IronPort-SDR: Efv7hDKUS1cMC6Wz8xXkKOC6c2dXvhnzcw+dmE0r/f3EJP1v/kj2p1i8TQF7bkGJ/YAThrU4g9 SHdZ5Sxxwxjw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="473509614" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by orsmga004.jf.intel.com with ESMTP; 10 Nov 2020 09:37:07 -0800 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Laszlo Ersek , Ard Biesheuvel , Leif Lindholm Subject: [edk2-devel] [PATCH V3 06/12] ArmVirtPkg/ArmVirtQemuKernel.dsc: Enable MD5 while enable iSCSI Date: Wed, 11 Nov 2020 01:36:45 +0800 Message-Id: <20201110173651.54036-7-zhichao.gao@intel.com> In-Reply-To: <20201110173651.54036-1-zhichao.gao@intel.com> References: <20201110173651.54036-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: xVEhCPBq2vBoCyGcBophNL6Rx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1605029829; bh=zdbHuARMkqdGqgXUxMP5KiWJ+L0ZRphVA9LqVhaF3pQ=; h=Cc:Date:From:Reply-To:Subject:To; b=qhMy78ZtbciGqyrz2o5CahMLq17YsYFj1qlyEZEA5zDVHI6JiZ4mJz66R0kDYZPcQUC eOUaJuDh1oNdZ7dbbYmtLWzr3/fT6qIdbNGVPxOmfuGXR78ktK8AKqQSzYQFPEA0MSa85 0xYmdCpgYQYZ1H52AGtsjTBLTG4KcJI2hqU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3003 There is a plan to make MD5 disable as default. The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES would be introduced to enable MD5. Make the definition ahead of the change to avoid build error after the MACRO changed. Enalbe iSCSI. Signed-off-by: Zhichao Gao Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm --- ArmVirtPkg/ArmVirtQemuKernel.dsc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKerne= l.dsc index 9449a01d6e..714dc6cf89 100644 --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc @@ -1,7 +1,7 @@ # # Copyright (c) 2011-2015, ARM Limited. All rights reserved. # Copyright (c) 2014, Linaro Limited. All rights reserved. -# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved. +# Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -38,6 +38,7 @@ DEFINE NETWORK_SNP_ENABLE =3D FALSE DEFINE NETWORK_TLS_ENABLE =3D FALSE DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE + DEFINE NETWORK_ISCSI_ENABLE =3D TRUE =20 !if $(NETWORK_SNP_ENABLE) =3D=3D TRUE !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only" @@ -47,6 +48,11 @@ =20 !include ArmVirtPkg/ArmVirt.dsc.inc =20 +[BuildOptions] +!if $(NETWORK_ISCSI_ENABLE) =3D=3D TRUE + *_*_*_CC_FLAGS =3D -D ENABLE_MD5_DEPRECATED_INTERFACES +!endif + [LibraryClasses.common] ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67239): https://edk2.groups.io/g/devel/message/67239 Mute This Topic: https://groups.io/mt/78164665/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 14:48:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67240+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67240+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1605029836; cv=none; d=zohomail.com; s=zohoarc; b=RAeksaUcJPIbv9Eit5/Q0fle4h/vXZ3HoZYJ17uBUXe339/Sdhyym1Wf1lDuJhBhWKtj8sJNUqot7sH1mGk/wZiFdgxHW/AwDej8PSJgW6DMUHf7eA2gRi7fZqVnteCIROUuwQJLs6llOqJ90U+u4O/rTJeKviyUuqOs+mzPtiU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605029836; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=8kchBBxs3fjGZZnEO1A0U9osG9Ftuq5Z4WPDEONen+k=; b=SRwixDeqfwox3QezkTLHZyG13IqW2Q+O5mxlpDNdL7MckMCqJzpo0A6mwTBgn9oQTlS1sgLcOvvN9sUVxgPzsOry7WNJal3RVyFctcIzRfNztf5wcR4TAC96E/HZI+kI8V/qOZO0aOC0R09kUlT+rbt52rcQSOWrZrQvDXDlO80= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67240+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1605029836058205.31683404403373; Tue, 10 Nov 2020 09:37:16 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id jh7xYY1788612xevv8IzZ2pu; Tue, 10 Nov 2020 09:37:15 -0800 X-Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web10.31256.1605029827145466395 for ; Tue, 10 Nov 2020 09:37:10 -0800 IronPort-SDR: +Ow5mpVPQDsjuBH50X6IwL4C2lNd64Cc8B3PDgn1MsR9XWcWqTAeTez1qV1/rbWhi5dEXsfAwW N11Pf/I4KxGQ== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="169234270" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="169234270" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 09:37:09 -0800 IronPort-SDR: hc60nBVmPhNybx2HVE3wjXWWF+/yVRSo1Tf83QMgzW1Oae0zLKoPSEn7ZrK87kI4/G4hY0ChIC +AKT+mT/A9Hw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="473509633" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by orsmga004.jf.intel.com with ESMTP; 10 Nov 2020 09:37:08 -0800 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel Subject: [edk2-devel] [PATCH V3 07/12] OvmfPkg/OvmfPkgIa32.dsc: Enable MD5 while enable iSCSI Date: Wed, 11 Nov 2020 01:36:46 +0800 Message-Id: <20201110173651.54036-8-zhichao.gao@intel.com> In-Reply-To: <20201110173651.54036-1-zhichao.gao@intel.com> References: <20201110173651.54036-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: DWaY0gIT1oCfskMk7Ex5RyHyx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1605029835; bh=YZv52dWXZ6shFvxY74ura8fB2Hk86g8C2gjrRQOjTa8=; h=Cc:Date:From:Reply-To:Subject:To; b=PuXZi4zM8efcY5C2+oEhjN7O7R/p9JNrmzV9hVwLklS87GxTAoGfFoTZGxOCezj1YHs vT5jtQXYrbj5faF8dlyHcDuFiOlzwNg8sT1d7d/FXrChH9lr6/LPakPPf0PEbhzHMpPJV MH5k9f3RDijHl6zTrjsvZkk3lxrsJ+Y3WVo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3003 There is a plan to make MD5 disable as default. The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES would be introduced to enable MD5. Make the definition ahead of the change to avoid build error after the MACRO changed. Enalbe iSCSI. Signed-off-by: Zhichao Gao Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel --- OvmfPkg/OvmfPkgIa32.dsc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index 58d9f292f9..c0ddb0b375 100644 --- a/OvmfPkg/OvmfPkgIa32.dsc +++ b/OvmfPkg/OvmfPkgIa32.dsc @@ -42,6 +42,7 @@ DEFINE NETWORK_IP6_ENABLE =3D FALSE DEFINE NETWORK_HTTP_BOOT_ENABLE =3D FALSE DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE + DEFINE NETWORK_ISCSI_ENABLE =3D TRUE =20 !include NetworkPkg/NetworkDefines.dsc.inc =20 @@ -86,6 +87,10 @@ INTEL:*_*_*_CC_FLAGS =3D /D DISABLE_NEW_DEPRECATED_INTERFACES GCC:*_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES =20 +!if $(NETWORK_ISCSI_ENABLE) =3D=3D TRUE + *_*_*_CC_FLAGS =3D -D ENABLE_MD5_DEPRECATED_INTERFACES +!endif + [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 XCODE:*_*_*_DLINK_FLAGS =3D -seg1addr 0x1000 -segalign 0x1000 --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67240): https://edk2.groups.io/g/devel/message/67240 Mute This Topic: https://groups.io/mt/78164666/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 14:48:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67241+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67241+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1605029836; cv=none; d=zohomail.com; s=zohoarc; b=MbbRkqQbnfkeAceLdbZMR27RMYN1qgz3aPCZqy0+OwzMBeY1mPHllcmEhAusOtE5uH6dDrmr5gxgBUJzWuTsju8XrirrKvV9A0SCCD44SHPhPwvexGY/V0QGSP0IM7Rz80nFeQ7CS0PjdsQMGVOZnGVuI8Y/VtSjpom5e78a+ew= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605029836; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=kFLXzZEpfYSNXCGhEt4M3KBwJXwT8r+UzxOz8Vo702Q=; b=JMcumi2nCvOOmAhhE/Nn7EYrezSEO6KaBbQzz1E+bFN+Or/KudEAAn6YE3OJ0qdg84ek4+XDX4uKBOih7BgB9chmgK4osioLXb1/3npHkxgU9UaDNfzyOaeXP79pJYVpuFSTMpVTl+E1KtQUdWbAqRag0wrWvUWUkW8RGP9QFDw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67241+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1605029836559671.8324289423143; Tue, 10 Nov 2020 09:37:16 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id LLGpYY1788612xWTJYy5jQRD; Tue, 10 Nov 2020 09:37:16 -0800 X-Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web10.31256.1605029827145466395 for ; Tue, 10 Nov 2020 09:37:11 -0800 IronPort-SDR: 6rJiMTa9KnMZ9ALijdcWlB7HaXDM95mBfVt9XikKMJyWxrDaY12U9G++mt/Of3/DXQvCWrWIOl 6VUcQunC/28g== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="169234280" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="169234280" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 09:37:11 -0800 IronPort-SDR: 87GLjADm2FpufTnQvSP4X62MRPrgN+hr5flcwP2CugBSzI1R4vBjKWW8eP5iOgPWSJJp5KjoiO lqw6LZBQ1VeQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="473509640" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by orsmga004.jf.intel.com with ESMTP; 10 Nov 2020 09:37:09 -0800 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel Subject: [edk2-devel] [PATCH V3 08/12] OvmfPkg/OvmfPkgIa32X64.dsc: Enable MD5 while enable iSCSI Date: Wed, 11 Nov 2020 01:36:47 +0800 Message-Id: <20201110173651.54036-9-zhichao.gao@intel.com> In-Reply-To: <20201110173651.54036-1-zhichao.gao@intel.com> References: <20201110173651.54036-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: InitbAp4r8IijI7F9PcEIQaTx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1605029836; bh=s/Ij9V09FJdrQ7VDtgFL2MHZhpbVcY6u5r2GagQ8DbM=; h=Cc:Date:From:Reply-To:Subject:To; b=Z0Vc4nEE8BkqXTB6z4UgrshgBGaUEoSUGDuZwuRB6aEiIVvzkvHhm0bXY4xCSGjs3wT BYBSi3oBnBNgxGXTYrrHf8NK+UdN13RnJxP3WgRvyRNVzVvkw2qBlBt1l3mIVoJgJBDIG QmmbOXm4MO9LwnRqYOfDDwaw557AF6geQak= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3003 There is a plan to make MD5 disable as default. The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES would be introduced to enable MD5. Make the definition ahead of the change to avoid build error after the MACRO changed. Enalbe iSCSI. Signed-off-by: Zhichao Gao Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel --- OvmfPkg/OvmfPkgIa32X64.dsc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc index 3551f9710a..7ddb363d7d 100644 --- a/OvmfPkg/OvmfPkgIa32X64.dsc +++ b/OvmfPkg/OvmfPkgIa32X64.dsc @@ -41,6 +41,7 @@ DEFINE NETWORK_IP6_ENABLE =3D FALSE DEFINE NETWORK_HTTP_BOOT_ENABLE =3D FALSE DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE + DEFINE NETWORK_ISCSI_ENABLE =3D TRUE =20 !include NetworkPkg/NetworkDefines.dsc.inc =20 @@ -90,6 +91,10 @@ INTEL:*_*_*_CC_FLAGS =3D /D DISABLE_NEW_DEPRECATED_INTERFACES GCC:*_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES =20 +!if $(NETWORK_ISCSI_ENABLE) =3D=3D TRUE + *_*_*_CC_FLAGS =3D -D ENABLE_MD5_DEPRECATED_INTERFACES +!endif + [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 XCODE:*_*_*_DLINK_FLAGS =3D -seg1addr 0x1000 -segalign 0x1000 --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67241): https://edk2.groups.io/g/devel/message/67241 Mute This Topic: https://groups.io/mt/78164667/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 14:48:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67242+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67242+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1605029835; cv=none; d=zohomail.com; s=zohoarc; b=Xqco3MfCFs1EFGXHRIOif0GqHX89ORpdxbVt4aPAshFwVSjjtxp+9KG3VLkuxT5pJz8xNKdTKi89r66d/dQMmYI83EYHmw1UcpSaBy5BKJ4YHZuhYHqYl3og/xN18//HSdl+pnxUClo9JoyetYx7tez8rOotar7ZaFqGZQpLqd4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605029835; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=imPcuxgWkjpydgrW0i2ktUhvhUV6FgHYjR85DLjDIZ0=; b=BvLJbvB9yN8enIFwHg6UkKTSthAVAppJGaDulSqSLGRux1mFswbDNIQuAvchrx6XHTnu+JWzLz5MbNwMH173EG2vIlqVgEnaD3z7RG4xfqxTp4pdHSVxCnSqB1JkQwRyDHJMZTstJ2lnMYyOnPVGARGGUnS7yV6RYmeywozedYg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67242+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 160502983579294.63505079989011; Tue, 10 Nov 2020 09:37:15 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id yjVwYY1788612xerqaIUGQc9; Tue, 10 Nov 2020 09:37:15 -0800 X-Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web10.31256.1605029827145466395 for ; Tue, 10 Nov 2020 09:37:12 -0800 IronPort-SDR: +5EfT/qCpaYP9yefmhbMrBwqwajLASG8mR5AuLHob3dPug7FBYVGV1qQBvz6F+OjtRlf/HxlQm SNCc9q1CUnVw== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="169234283" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="169234283" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 09:37:12 -0800 IronPort-SDR: JlZQpiBARh7wZwULOk2MxsGminhQ6s7z/+JxCWHDxrE05NQI5rH/nBTyEb84D99/1hEbMhlD2r nlPeiotPYMaQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="473509647" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by orsmga004.jf.intel.com with ESMTP; 10 Nov 2020 09:37:11 -0800 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel Subject: [edk2-devel] [PATCH V3 09/12] OvmfPkg/OvmfPkgX64.dsc: Enable MD5 while enable iSCSI Date: Wed, 11 Nov 2020 01:36:48 +0800 Message-Id: <20201110173651.54036-10-zhichao.gao@intel.com> In-Reply-To: <20201110173651.54036-1-zhichao.gao@intel.com> References: <20201110173651.54036-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: GJFL0H0FPKPpGg0WCmpn4CtWx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1605029835; bh=u2jgR+rsKpnmqItnTxiraWSjXP2pjAzVavIgydawjBw=; h=Cc:Date:From:Reply-To:Subject:To; b=emrw7eix5wdiGZgrB06tzjNzrhVqYtMVrE9Locmh0nTZMgEG8wL45NOy5R6UMG0FtRv hAkZLAcrOX4bjPvjulCUkasIGcNLwDvAL66BBZAPHuqWoUKd/OCdQonp+dg5EAx5SQWJO 7RxkHRrD1NmNYjIm2KpVfLWi80VWfSzQC2k= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3003 There is a plan to make MD5 disable as default. The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES would be introduced to enable MD5. Make the definition ahead of the change to avoid build error after the MACRO changed. Enalbe iSCSI. Signed-off-by: Zhichao Gao Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel --- OvmfPkg/OvmfPkgX64.dsc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index 7a8bdb8a86..b4b2eb718c 100644 --- a/OvmfPkg/OvmfPkgX64.dsc +++ b/OvmfPkg/OvmfPkgX64.dsc @@ -41,6 +41,7 @@ DEFINE NETWORK_IP6_ENABLE =3D FALSE DEFINE NETWORK_HTTP_BOOT_ENABLE =3D FALSE DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE + DEFINE NETWORK_ISCSI_ENABLE =3D TRUE =20 !include NetworkPkg/NetworkDefines.dsc.inc =20 @@ -90,6 +91,10 @@ INTEL:*_*_*_CC_FLAGS =3D /D DISABLE_NEW_DEPRECATED_INTERFACES GCC:*_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES =20 +!if $(NETWORK_ISCSI_ENABLE) =3D=3D TRUE + *_*_*_CC_FLAGS =3D -D ENABLE_MD5_DEPRECATED_INTERFACES +!endif + [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 XCODE:*_*_*_DLINK_FLAGS =3D -seg1addr 0x1000 -segalign 0x1000 --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67242): https://edk2.groups.io/g/devel/message/67242 Mute This Topic: https://groups.io/mt/78164668/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 14:48:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67243+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67243+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1605029858; cv=none; d=zohomail.com; s=zohoarc; b=lcSjqJe0M9rQCrPB03K51G8A7+z9dIfrZoUkQJTbLU9oMwStIWP8HuxB4n/r6QSo1jLB4eNl1MVSTZ/j1p++r5768aQEkPv82g6Hw03VxYg16GTVa0+A3mYrZ9Qpa/QffqQ6RRn/X2K3aTf3Y9drtXn+yazSypZQLmwOh8M3K8Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605029858; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=CFZaey20RLOMT7Pn6X5F/51pStLfTvZJMfuT8AstJOA=; b=AQomyhZ0ZYAjINkvgirSKfq/2w/caehkXun7nFbZPYWUSwiVIxvEEVkWwrWtTh53fwYKg54wzxudRVQ8IbORIY+Uc+Y39ghJ5QM4w5L4JSYT4LVqrjGtcVnETz3uiZOKDNd7ygsIjXThVNfRKvkOTZ4XFQx99x02XtFQKKlAuXM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67243+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1605029858567642.4683285303626; Tue, 10 Nov 2020 09:37:38 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id ti4mYY1788612xAScnl79CXc; Tue, 10 Nov 2020 09:37:38 -0800 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.31129.1605029857666972063 for ; Tue, 10 Nov 2020 09:37:37 -0800 IronPort-SDR: 7dL9JuWuK4C2ldKYBdM31o780lh6SE5l7wRP5J+EOBjj996ABCsjSm+bIo+OKgPGB1S8O0DSIC CrLHtY9F28aQ== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="169234292" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="169234292" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 09:37:14 -0800 IronPort-SDR: 9r1b34bn+fG9Co0Xfu8uYxqJwSRpPKstvW/98jen0kJpenhepSNa8ALXVLEgljxnnFBgjZoalV ZL+TWWD7cgNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="473509654" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by orsmga004.jf.intel.com with ESMTP; 10 Nov 2020 09:37:12 -0800 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel Subject: [edk2-devel] [PATCH V3 10/12] OvmfPkg/BhyveX64.dsc: Enable MD5 while enable iSCSI Date: Wed, 11 Nov 2020 01:36:49 +0800 Message-Id: <20201110173651.54036-11-zhichao.gao@intel.com> In-Reply-To: <20201110173651.54036-1-zhichao.gao@intel.com> References: <20201110173651.54036-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: ldTv5cOi5sjIEIqFNTSZEIcUx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1605029858; bh=yZIJ+ySdcDX1Aw5Duc5g7mFl3lpQ0QofTvU1/2r5mhs=; h=Cc:Date:From:Reply-To:Subject:To; b=Z0s1qZJmruXC0Da8wx57l82VZUERMFFqMOBnSrn15S7jK/j6N2s6kGRxx5pupZfmxG/ 16HeX+jhgHtIpaWh1vqv24xTEimKXJaYFjqFuYrMX8LrctIdHUqMspgH3HPaRk3yBQWAu KFiHk9ULBEC9ykFSn24LHq8LjxzJgCPKfRc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3003 There is a plan to make MD5 disable as default. The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES would be introduced to enable MD5. Make the definition ahead of the change to avoid build error after the MACRO changed. Enalbe iSCSI. Signed-off-by: Zhichao Gao Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel --- OvmfPkg/Bhyve/BhyveX64.dsc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc index 16d2233d77..3820a01ca6 100644 --- a/OvmfPkg/Bhyve/BhyveX64.dsc +++ b/OvmfPkg/Bhyve/BhyveX64.dsc @@ -1,6 +1,6 @@ # # Copyright (c) 2020, Rebecca Cran -# Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
+# Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.
# (C) Copyright 2016 Hewlett Packard Enterprise Development LP
# Copyright (c) 2014, Pluribus Networks, Inc. # @@ -41,6 +41,7 @@ DEFINE NETWORK_IP6_ENABLE =3D FALSE DEFINE NETWORK_HTTP_BOOT_ENABLE =3D FALSE DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE + DEFINE NETWORK_ISCSI_ENABLE =3D TRUE =20 !include NetworkPkg/NetworkDefines.dsc.inc =20 @@ -83,6 +84,10 @@ INTEL:*_*_*_CC_FLAGS =3D /D DISABLE_NEW_DEPRECATED_INTERFACES GCC:*_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES =20 +!if $(NETWORK_ISCSI_ENABLE) =3D=3D TRUE + *_*_*_CC_FLAGS =3D -D ENABLE_MD5_DEPRECATED_INTERFACES +!endif + [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 XCODE:*_*_*_DLINK_FLAGS =3D -seg1addr 0x1000 -segalign 0x1000 --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67243): https://edk2.groups.io/g/devel/message/67243 Mute This Topic: https://groups.io/mt/78164679/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 14:48:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67244+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67244+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1605029860; cv=none; d=zohomail.com; s=zohoarc; b=l2rPgJ2THuQnJcEWQ9olK38RMXRPW9JmxIb4RDMXO7CnFu/Cpqh26NWCpoMYNo2v4fcsFoB/ExYIlrfGK/nIktPFP5x9caLysFEiQYR6LwEb0c9zT2/k8AsVuxcck6zHrjE2nbfTr43Lnb+GRWQtWT0wTfbC+QmneYXybOUCJ8o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605029860; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=G1D4sYoQSrP0tyJiqC4FVCsRdHCFPVlM/b4z2R+yPIc=; b=S13So9WYB2Ep0G90lJ3UhQr0mZHt0yaWBY40ppxnajWDN7FaxiPRnTq+G9raKr2u+sopBGfLQDwGfdZZavks3vcSJmYelqaIkIwBDJhxwX/xxNgZAWjenwdFV84tmaAI2ITE0ct7yb+pOXUY8FHkcuPjRDPOZFKuSxIiph9xpB0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67244+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1605029860653555.2253007575088; Tue, 10 Nov 2020 09:37:40 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id rJWUYY1788612xM7jbKze9rv; Tue, 10 Nov 2020 09:37:40 -0800 X-Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web12.31129.1605029857666972063 for ; Tue, 10 Nov 2020 09:37:39 -0800 IronPort-SDR: jdIRusfe9vm4DMznd8ZncBs1BuD3+j0/iFmMYQXm5yBeqFbIHP5Q4ZF2S+SiZTXw1cVcw0y4DD s9x71/3FHOtg== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="169234329" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="169234329" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 09:37:18 -0800 IronPort-SDR: VT1/Bn3+5kErbMnJtTaPafH61YNHsSejDlVe3hvwMItbF9EEW7rW4P3pe1HYwQZUkqFzPAlWKj 2MwtW89Mt7+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="473509681" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by orsmga004.jf.intel.com with ESMTP; 10 Nov 2020 09:37:14 -0800 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Sami Mujawar , Leif Lindholm , Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Michael D Kinney , Kelly Steele , Zailiang Sun , Yi Qian , Liming Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu Subject: [edk2-devel] [PATCH V3 11/12] NetworkPkg/Defines: Make iSCSI disable as default Date: Wed, 11 Nov 2020 01:36:50 +0800 Message-Id: <20201110173651.54036-12-zhichao.gao@intel.com> In-Reply-To: <20201110173651.54036-1-zhichao.gao@intel.com> References: <20201110173651.54036-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: i2J7PoWMazdVn782ENeYFeS3x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1605029860; bh=0ERm9wONmPbexWj+/46y4vU0lhzI5cfREbOtT17fYpM=; h=Cc:Date:From:Reply-To:Subject:To; b=C0/rVDs8rR2yWlaj2mjGK6Y/DqacIyh5gd+nhQBPLaSYzMc9EOWOsOzJ4fVAi7fLUXW xgYp6wJ9E0glHfZUPlhngrQ5y2Hl9Hb84mck1LB7cFG+6aNKhAp2IWnbqtq3GCag32MsN Wc6A+K7ucJtBg5RRu/PZmHcEv3YSjKqLJG8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3003 iSCSI is using the undeprecated function MD5. It is better to make the default setting secure. If the platforms want to use the iSCSI, they should enable it in the platforms' dsc file and be aware they are using an unsafe function. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Leif Lindholm Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Michael D Kinney Cc: Kelly Steele Cc: Zailiang Sun Cc: Yi Qian Cc: Liming Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Zhichao Gao Reviewed-by: Laszlo Ersek --- NetworkPkg/NetworkDefines.dsc.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/NetworkDefines.dsc.inc b/NetworkPkg/NetworkDefines.= dsc.inc index a442d1b157..18921d81f6 100644 --- a/NetworkPkg/NetworkDefines.dsc.inc +++ b/NetworkPkg/NetworkDefines.dsc.inc @@ -17,7 +17,7 @@ # DEFINE NETWORK_TLS_ENABLE =3D TRUE # DEFINE NETWORK_HTTP_BOOT_ENABLE =3D TRUE # DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D FALSE -# DEFINE NETWORK_ISCSI_ENABLE =3D TRUE +# DEFINE NETWORK_ISCSI_ENABLE =3D FALSE # DEFINE NETWORK_VLAN_ENABLE =3D TRUE # # Copyright (c) 2019, Intel Corporation. All rights reserved.
@@ -101,7 +101,7 @@ # Both OpensslLib.inf and OpensslLibCrypto.inf library instance ca= n be used # since libssl is not required for iSCSI. # - DEFINE NETWORK_ISCSI_ENABLE =3D TRUE + DEFINE NETWORK_ISCSI_ENABLE =3D FALSE !endif =20 !if $(NETWORK_ENABLE) =3D=3D TRUE --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67244): https://edk2.groups.io/g/devel/message/67244 Mute This Topic: https://groups.io/mt/78164681/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 14:48:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67245+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67245+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1605029863; cv=none; d=zohomail.com; s=zohoarc; b=JEHoIbrnSUaDz2A7jEI+zZ+Nn5nXL0+vtjsUcEQmNbScGkUqSHME6wUpO+I6YJ+TIuSIo6H0BARkytOBTNBVIhCABR0MY6jQlnnRawhkIlQS4GdKFFcYMRmuGYj6L5T3Thq7PT1rRcaqngabzT60P/RCgB1FgNYz8n0TNuUiqig= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605029863; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=iw3sFVi9M+s5DdrmSmSGIz5IhGOhjYBIbuOW5HKViP0=; b=EVq7vh7/AGgBawiBcWFOjDMubvZi8AVfvnJomp3cS8t1M9bYqlpRlLx1h0OW/89QbBhhDXhKzM+alNpWDhKmv6TzmjOLaPilFCAcok2e8MTKnfyoLNLdZxIs3inNmZ1mC83VWEJpwDnAxa5NmLBGx1uVkc4zLOJ+j5o2tBd59LE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67245+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 160502986378750.37980674285632; Tue, 10 Nov 2020 09:37:43 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 4IYwYY1788612xoqospH80qW; Tue, 10 Nov 2020 09:37:43 -0800 X-Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web12.31129.1605029857666972063 for ; Tue, 10 Nov 2020 09:37:43 -0800 IronPort-SDR: qjMkhNeYDCJwG6fP5smq7DXSE8iaACBT0+X4Mqqy0u+br0Qcm9akpciODDUj7RMtlIjrcje2yF VRcsf8uRdyGg== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="169234371" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="169234371" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 09:37:20 -0800 IronPort-SDR: VEmsUHK/8n6MTaju8j4DhvOtJ+jpDm9inCL6iO3IGy7q0Ve1+CziLgGEqY4gz1JcHMvI8Bb0/Y CqAcc2XkGvNw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="473509689" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by orsmga004.jf.intel.com with ESMTP; 10 Nov 2020 09:37:18 -0800 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Jiewen Yao Subject: [edk2-devel] [PATCH V3 12/12] CryptoPkg: Make the MD5 disable as default for security Date: Wed, 11 Nov 2020 01:36:51 +0800 Message-Id: <20201110173651.54036-13-zhichao.gao@intel.com> In-Reply-To: <20201110173651.54036-1-zhichao.gao@intel.com> References: <20201110173651.54036-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: 8oxgsRAewiVKTQGYCfxLdAt1x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1605029863; bh=dR9IaFE9JEnq44KqX+DCvxCTv04jW/KROjdlmD8c3gk=; h=Cc:Date:From:Reply-To:Subject:To; b=KTHzjP8ZA5+Vc7Qgx+ijXCKVuyLubcotSOWJ37VsiltXAZV78Lfr2rlLTighCuxzGyt cArjVU5Qj3nnN0P77WPbCXBj7WrRUHFbwJKqMbt+dFtqL3otrh0Efe5KY4dBwP1Hxd3Db hdytMo3P2Wfr/C2Rf0PgEgdOXIvhyHmyYL0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3021 Make the deprecated MD5 disable as default setting for security. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Zhichao Gao Reviewed-by: Jiewen Yao --- CryptoPkg/Driver/Crypto.c | 4 ++-- CryptoPkg/Include/Library/BaseCryptLib.h | 2 +- CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c | 2 +- CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CryptoPkg/Driver/Crypto.c b/CryptoPkg/Driver/Crypto.c index d9096ea603..26f280cd5d 100644 --- a/CryptoPkg/Driver/Crypto.c +++ b/CryptoPkg/Driver/Crypto.c @@ -243,7 +243,7 @@ DeprecatedCryptoServiceMd4HashAll ( return BaseCryptLibServiceDeprecated ("Md4HashAll"), FALSE; } =20 -#ifdef DISABLE_MD5_DEPRECATED_INTERFACES +#ifndef ENABLE_MD5_DEPRECATED_INTERFACES /** Retrieves the size, in bytes, of the context buffer required for MD5 has= h operations. =20 @@ -4494,7 +4494,7 @@ const EDKII_CRYPTO_PROTOCOL mEdkiiCrypto =3D { DeprecatedCryptoServiceMd4Update, DeprecatedCryptoServiceMd4Final, DeprecatedCryptoServiceMd4HashAll, -#ifdef DISABLE_MD5_DEPRECATED_INTERFACES +#ifndef ENABLE_MD5_DEPRECATED_INTERFACES /// Md5 - deprecated and unsupported DeprecatedCryptoServiceMd5GetContextSize, DeprecatedCryptoServiceMd5Init, diff --git a/CryptoPkg/Include/Library/BaseCryptLib.h b/CryptoPkg/Include/L= ibrary/BaseCryptLib.h index ae9bde9e37..496121e6a4 100644 --- a/CryptoPkg/Include/Library/BaseCryptLib.h +++ b/CryptoPkg/Include/Library/BaseCryptLib.h @@ -72,7 +72,7 @@ typedef enum { // One-Way Cryptographic Hash Primitives //=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 -#ifndef DISABLE_MD5_DEPRECATED_INTERFACES +#ifdef ENABLE_MD5_DEPRECATED_INTERFACES /** Retrieves the size, in bytes, of the context buffer required for MD5 has= h operations. =20 diff --git a/CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c b/CryptoPkg/Lib= rary/BaseCryptLib/Hash/CryptMd5.c index b85e7f4d12..d670f17424 100644 --- a/CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c +++ b/CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c @@ -9,7 +9,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include "InternalCryptLib.h" #include =20 -#ifndef DISABLE_MD5_DEPRECATED_INTERFACES +#ifdef ENABLE_MD5_DEPRECATED_INTERFACES /** Retrieves the size, in bytes, of the context buffer required for MD5 has= h operations. =20 diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c b/Crypt= oPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c index 3f14c6d262..8b43d1363c 100644 --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c @@ -99,7 +99,7 @@ CryptoServiceNotAvailable ( // One-Way Cryptographic Hash Primitives //=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 -#ifndef DISABLE_MD5_DEPRECATED_INTERFACES +#ifdef ENABLE_MD5_DEPRECATED_INTERFACES /** Retrieves the size, in bytes, of the context buffer required for MD5 has= h operations. =20 --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67245): https://edk2.groups.io/g/devel/message/67245 Mute This Topic: https://groups.io/mt/78164684/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-