From nobody Mon May 6 03:35:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67164+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67164+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1604909326; cv=none; d=zohomail.com; s=zohoarc; b=QuICTfAl1wvw12uHls7ZmnBOSI6/efjFy1OIafbzCV3JmswNWvyJ2E+0CZk3M6CIj8Epw8M49bKV8+mq/yFBu4Fe+NWDdPNU9CZPBsAQDXFKbvyaBjUYOrdU87Rka01N6QD52YjJPKC08UBr5VMw5A25uy/1ohdX8CbfFGAVC54= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604909326; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=BCzxGhFREMtOHHSJRbKDL9lgpXFOY0HzYPVECDFY7aY=; b=VPDa8HMVCFx7CX3HmI9h3r4TSLP1rQQy6uW0YcLidNCMTHqa098PJjGPLtM5cSQcFLWlL/zbYCTDyfxym1nTCMxMG0i/oPldFnJjiUiXz5OdfYVjfpWSFl+b6V/wMwR1GWuTkUm8VahXimWF9aOeMRfBsjrQBdkTJ6ZuDDUJ/aU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67164+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1604909325412147.92326226755836; Mon, 9 Nov 2020 00:08:45 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id UQXfYY1788612xw6dnQqVa8J; Mon, 09 Nov 2020 00:08:44 -0800 X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.8571.1604909323935394020 for ; Mon, 09 Nov 2020 00:08:44 -0800 X-Received: from localhost.localdomain ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 09 Nov 2020 16:08:42 +0800 X-WM-Sender: fengyunhua@byosoft.com.cn From: "fengyunhua" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Yuwei Chen Subject: [edk2-devel] [PATCH v3 1/2] BaseTools: Add image type into generate map file Date: Mon, 9 Nov 2020 16:08:01 +0800 Message-Id: <20201109080802.2217-2-fengyunhua@byosoft.com.cn> In-Reply-To: <20201109080802.2217-1-fengyunhua@byosoft.com.cn> References: <20201109080802.2217-1-fengyunhua@byosoft.com.cn> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,fengyunhua@byosoft.com.cn X-Gm-Message-State: tjNXmx0H7BLY4KSettaWm6r3x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1604909324; bh=EJGR/O11o8ksRZXXCfOPODA97LzbLACuzA/lZP//sJU=; h=Cc:Date:From:Reply-To:Subject:To; b=gGE9X0iK17ZI2XBKTkSIoiMt8/+Aa3FNBNftp9H0BAnVaSo7djlZqdlsqGyC80YSn88 LQU9KP6gBnX4i6RDcKKgNUbV4qW+Zz2xfK9IKBaTQASDGg0EdCK+gGZRdhmE5lQraOCNI ilE2WEF2kFcjzv3NMsdGV5pghbLwcyiO+Ew= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2977 For a source-level BIOS debugger the .map files are quite useful with one major shortcoming: the debugger cannot know, solely from the .map file, the format (PE/COFF vs. TE) of the image included in the final BIOS ROM Add Type=3DPE or TE in the map file Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Yunhua Feng --- BaseTools/Source/C/GenFv/GenFvInternalLib.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c b/BaseTools/Source= /C/GenFv/GenFvInternalLib.c index b5ffed93a9..6e296b8ad6 100644 --- a/BaseTools/Source/C/GenFv/GenFvInternalLib.c +++ b/BaseTools/Source/C/GenFv/GenFvInternalLib.c @@ -903,7 +903,12 @@ Returns: fprintf (FvMapFile, "BaseAddress=3D0x%010llx, ", (unsigned long long) = (ImageBaseAddress + Offset)); } =20 - fprintf (FvMapFile, "EntryPoint=3D0x%010llx", (unsigned long long) (Imag= eBaseAddress + AddressOfEntryPoint)); + fprintf (FvMapFile, "EntryPoint=3D0x%010llx, ", (unsigned long long) (Im= ageBaseAddress + AddressOfEntryPoint)); + if (!pImageContext->IsTeImage) { + fprintf (FvMapFile, "Type=3DPE"); + } else { + fprintf (FvMapFile, "Type=3DTE"); + } fprintf (FvMapFile, ")\n"); =20 fprintf (FvMapFile, "(GUID=3D%s", FileGuidName); --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67164): https://edk2.groups.io/g/devel/message/67164 Mute This Topic: https://groups.io/mt/78131394/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 03:35:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67165+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67165+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1604909332; cv=none; d=zohomail.com; s=zohoarc; b=cJ83pGoq78iiyZeuLz1Dg1ZCy1P+/Lj9srqEGN26uP/GlPwN0WBb6ZDaCXz1PkCp3Kgg5Zxg9EV5Ic85HZdyyYz/yVY87YRhUbI8Z5P0s1J2vhQZfYkOcT9YW9LIkrLTh7r0QEWU6dgUH3aj+KawFcaX3QyRH1GlspUJZC6YkgA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604909332; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=+97eJ6zPHAz2SmOuFydr3GnDUwS3j4dmmH/YxwfmXDg=; b=lnve8WDsAPlGVBbpfcSYNmocZC5bk4ZOeMsj3RTmcADNwS67/+Y3vdvHHw3jtgfNsAkyqwjLac3o0kBrP2zURytjwBihgz0gex1gIeJ3n561yjB97XaPJdilBnp4rs6SPjtrokDFxRSo8zcFA9NxYEaFlPyYt7vXTGmaaTwKiUU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67165+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1604909332143281.65203400044936; Mon, 9 Nov 2020 00:08:52 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id FwsnYY1788612xaL9G5aARjs; Mon, 09 Nov 2020 00:08:51 -0800 X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.8572.1604909330873356620 for ; Mon, 09 Nov 2020 00:08:51 -0800 X-Received: from localhost.localdomain ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 09 Nov 2020 16:08:49 +0800 X-WM-Sender: fengyunhua@byosoft.com.cn From: "fengyunhua" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Yuwei Chen Subject: [edk2-devel] [PATCH v3 2/2] BaseTools: Update report map file format Date: Mon, 9 Nov 2020 16:08:02 +0800 Message-Id: <20201109080802.2217-3-fengyunhua@byosoft.com.cn> In-Reply-To: <20201109080802.2217-1-fengyunhua@byosoft.com.cn> References: <20201109080802.2217-1-fengyunhua@byosoft.com.cn> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,fengyunhua@byosoft.com.cn X-Gm-Message-State: KEThWMiCvCzxFeDAWtAvf3jlx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1604909331; bh=V7lQmt3Xi4P0A/p4u3+jZMz44kMcaUqTAzX8q84AySo=; h=Cc:Date:From:Reply-To:Subject:To; b=cJHNukSdnDDkMXsprH/hLUFEjg32Jcp59D53HamlEqZG4hARkUrWtRF59zBK8Vpoyfu ecK2FIjNsllCHUXOO6TS58qFFUQOaE7WR7YWAzcLSwDI+KpsU0Ja7nlTF80TbSnEUPqkr hfyNIHpVR5kQmbHaqAlU2IVxNn5K15XdycE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2977 For a source-level BIOS debugger the .map files are quite useful with one major shortcoming: the debugger cannot know, solely from the .map file, the format (PE/COFF vs. TE) of the image included in the final BIOS ROM Update report map file format Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Yunhua Feng Reviewed-by: Bob Feng --- BaseTools/Source/Python/build/BuildReport.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Sourc= e/Python/build/BuildReport.py index 8efa869162..330234e5af 100644 --- a/BaseTools/Source/Python/build/BuildReport.py +++ b/BaseTools/Source/Python/build/BuildReport.py @@ -60,7 +60,7 @@ gPcdGuidPattern =3D re.compile(r"PCD\((\w+)[.](\w+)\)") gOffsetGuidPattern =3D re.compile(r"(0x[0-9A-Fa-f]+) ([-A-Fa-f0-9]+)") =20 ## Pattern to find module base address and entry point in fixed flash map = file -gModulePattern =3D r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=3D%(Address)s,\s*= EntryPoint=3D%(Address)s\)\s*\(GUID=3D([-0-9A-Fa-f]+)[^)]*\)" +gModulePattern =3D r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=3D%(Address)s,\s*= EntryPoint=3D%(Address)s,\s*Type=3D\w+\)\s*\(GUID=3D([-0-9A-Fa-f]+)[^)]*\)" gMapFileItemPattern =3D re.compile(gModulePattern % {"Address" : "(-?0[xX]= [0-9A-Fa-f]+)"}) =20 ## Pattern to find all module referenced header files in source files --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67165): https://edk2.groups.io/g/devel/message/67165 Mute This Topic: https://groups.io/mt/78131395/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-