From nobody Mon Feb 9 06:34:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+66905+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+66905+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1604377815; cv=none; d=zohomail.com; s=zohoarc; b=U7m1HPiBj1sHOHERjm4SQAhQi6q9KlquVh2lqQmXO68HBsjphdnnwLtu1raO3ErS87/U6aZh5Fwz8EcRvzNucUuzIn2hv5VmRtion0hGnlbjOGe6zfJmkqqSlEqS9LGPvwQ/b+9NpwITtmfJ7ybLNdaY+pDHFXhINYiImEpwSto= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604377815; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=Qv7H/I9LY5MGB3VuVO4YSKJ/3nfUGj2iLfvprYkz5hw=; b=j5qFLSfte7C5HUv1dfcIR/SqiIWtWFjICM0oljSOhhv13Qe2v7MQggSo5eAZ25TGntdLX9F/LO3KRuMFlKL/aQkNP8cfclXa6BEJT7RlfAVZB5dQojIGvQ32nTt/U5CKIHHaqTJyYBv3x/SiCNfTxFtnDDTXFDvxm1klEWz0wBE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+66905+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1604377815657297.4756007105842; Mon, 2 Nov 2020 20:30:15 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id uMqgYY1788612xmNiRnF4S7h; Mon, 02 Nov 2020 20:30:15 -0800 X-Received: from mga05.intel.com (mga05.intel.com []) by mx.groups.io with SMTP id smtpd.web11.57.1604377813420333081 for ; Mon, 02 Nov 2020 20:30:14 -0800 IronPort-SDR: b7k+3vPtN4titAD9tJ7wGXC/chbNjxCDFAzCcfNHKY1zZ49sCzS9qT2DA+nTHxbU3px8TLqBHS mFCk3mjBAwhA== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="253706056" X-IronPort-AV: E=Sophos;i="5.77,446,1596524400"; d="scan'208";a="253706056" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 20:30:14 -0800 IronPort-SDR: w0Jv3EafKaVnQ092Wdcy7jKhRjoQySYTElj50nSDcj1BSECpr/1vb7LuLhTcSwlDoDEF4YWdcS cvQW39CxFD2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,446,1596524400"; d="scan'208";a="470640375" X-Received: from shwdesssddpdwei.ccr.corp.intel.com ([10.239.157.46]) by orsmga004.jf.intel.com with ESMTP; 02 Nov 2020 20:30:12 -0800 From: "Sheng Wei" To: devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Laszlo Ersek , Rahul Kumar , Jiewen Yao Subject: [edk2-devel] [PATCH v4 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Correct the Cr3 typo Date: Tue, 3 Nov 2020 12:30:07 +0800 Message-Id: <20201103043008.26536-2-w.sheng@intel.com> In-Reply-To: <20201103043008.26536-1-w.sheng@intel.com> References: <20201103043008.26536-1-w.sheng@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,w.sheng@intel.com X-Gm-Message-State: 5DNpqoWJTWUDphaQvrqVygMHx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1604377815; bh=KLVZk493q3vhBY/dtE2e1dbnV79QQvNzgBAFYX7e4FE=; h=Cc:Date:From:Reply-To:Subject:To; b=lmpGPlzpnTgkUt/vLgtuu0BA62HK+WGDl+eyQhdbaermrF4ATncd7uokBNoXSHjqvcH ca5DvDIutO5t+nwr9AKrvMGLmc3sEJNiUHqkVwuqRBLmC/wHzKyk6QdU0iOYI+dhICory +R19qJZM8Tpywc0qeVXD+AFZwI8h0g5KqOY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Change the variable name from mInternalGr3 to mInternalCr3. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3015 Signed-off-by: Sheng Wei Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Jiewen Yao Reviewed-by: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c b/UefiCpuPk= g/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c index ebfc46ad45..d67f036aea 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c @@ -32,7 +32,7 @@ PAGE_ATTRIBUTE_TABLE mPageAttributeTable[] =3D { {Page1G, SIZE_1GB, PAGING_1G_ADDRESS_MASK_64}, }; =20 -UINTN mInternalGr3; +UINTN mInternalCr3; =20 /** Set the internal page table base address. @@ -46,7 +46,7 @@ SetPageTableBase ( IN UINTN Cr3 ) { - mInternalGr3 =3D Cr3; + mInternalCr3 =3D Cr3; } =20 /** @@ -59,8 +59,8 @@ GetPageTableBase ( VOID ) { - if (mInternalGr3 !=3D 0) { - return mInternalGr3; + if (mInternalCr3 !=3D 0) { + return mInternalCr3; } return (AsmReadCr3 () & PAGING_4K_ADDRESS_MASK_64); } @@ -252,7 +252,7 @@ ConvertPageEntryAttribute ( if ((Attributes & EFI_MEMORY_RO) !=3D 0) { if (IsSet) { NewPageEntry &=3D ~(UINT64)IA32_PG_RW; - if (mInternalGr3 !=3D 0) { + if (mInternalCr3 !=3D 0) { // Environment setup // ReadOnly page need set Dirty bit for shadow stack NewPageEntry |=3D IA32_PG_D; --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66905): https://edk2.groups.io/g/devel/message/66905 Mute This Topic: https://groups.io/mt/78000109/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-