From nobody Sat May 4 09:07:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+66596+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66596+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1603703140; cv=none; d=zohomail.com; s=zohoarc; b=GOhPlY5od4xE+Oa5vVlxbTP3NWmyqkapBLmCHimNO4N42Hn4APL8HRkGmkoHIk4NRdI6Cow7FIQUKzax6Q9LEWE5JLsLDOg9NLKGsPLSuYtlTPoOXaC5Km6UVxhI54IBxli9jt/klD3QjBrPkmARwR+yqbatzJEaBR7Bok9yJ1k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603703140; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=PYoNsARCC4OQGvipCS6Ye9pXRZCtSVYPBuyTrkyVHeI=; b=bZ+cs9jbjZPyQ7vUg2WCiAfn3OOcqZw1tR2WyEH1qkXh7pqbxism7Ta/nHgf5MiL3mahpsUh2DIQCx6DVimDKpZs6MjKrML4D1TJ5G+Qvc8WOrUGXqqCRuiPq+v5sDxZQB99qp/apbgD9CrM4YUmPitSFBYeS3lJUD8y++6oeDA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66596+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1603703140358712.8915215358112; Mon, 26 Oct 2020 02:05:40 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id lz1dYY1788612x000MSkqCLc; Mon, 26 Oct 2020 02:05:39 -0700 X-Received: from mga05.intel.com (mga05.intel.com []) by mx.groups.io with SMTP id smtpd.web11.10079.1603703131777658711 for ; Mon, 26 Oct 2020 02:05:34 -0700 IronPort-SDR: EzNwF3/B1ZPedouSt2nwQawM0RMjYgp63T/YB0LodTu0gOLTIs7289QW5wrvfC9r39zK2XkDhA Jg3ZSYxVq+pg== X-IronPort-AV: E=McAfee;i="6000,8403,9785"; a="252595208" X-IronPort-AV: E=Sophos;i="5.77,417,1596524400"; d="scan'208";a="252595208" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 02:05:33 -0700 IronPort-SDR: hLJdMh649WW1D2xSfkGAMqIOvUbXeVQ1jxnj19w8xk/EBqq9JEnJMJkI/6E+Pf0l8llgUarabq XOChqK2jqv/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,417,1596524400"; d="scan'208";a="350038496" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by fmsmga004.fm.intel.com with ESMTP; 26 Oct 2020 02:05:30 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Sami Mujawar , Leif Lindholm , Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Michael D Kinney , Kelly Steele , Zailiang Sun , Yi Qian , Liming Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu Subject: [edk2-devel] [PATCH 1/5] NetworkPkg/Defines: Make iSCSI disable as default Date: Mon, 26 Oct 2020 17:03:39 +0800 Message-Id: <20201026090343.13048-2-zhichao.gao@intel.com> In-Reply-To: <20201026090343.13048-1-zhichao.gao@intel.com> References: <20201026090343.13048-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: sVGEtMHiZ98JNKQHWgBin9ynx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1603703139; bh=rMWhiFq1nWp2fAK+F0Bm+tQe2ehMWkoF41oXoa1oq0M=; h=Cc:Date:From:Reply-To:Subject:To; b=qoqLFWUOQItlZyp5tdNcWqtaoNsb4p94hlsEmBiXGEaTZB1Rzp+WP7p8xF0kbTq/RgC GTeOBKq85DzvPeWIM5x9CC4ZvSi8Ea2U4Z4/AnIrr0NPaTaY2jwbHiCrXDKoSOCYSBCCP mvhYg3zhjxOyoYJMds3YOaAur/zpr8heixc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3003 iSCSI is using the undeprecated function MD5. It is better to make the default setting secure. If the platforms want to use the iSCSI, they should enable it in the platforms' dsc file and be aware they are using an unsafe function. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Leif Lindholm Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Michael D Kinney Cc: Kelly Steele Cc: Zailiang Sun Cc: Yi Qian Cc: Liming Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Zhichao Gao --- NetworkPkg/NetworkDefines.dsc.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/NetworkDefines.dsc.inc b/NetworkPkg/NetworkDefines.= dsc.inc index a442d1b157..18921d81f6 100644 --- a/NetworkPkg/NetworkDefines.dsc.inc +++ b/NetworkPkg/NetworkDefines.dsc.inc @@ -17,7 +17,7 @@ # DEFINE NETWORK_TLS_ENABLE =3D TRUE # DEFINE NETWORK_HTTP_BOOT_ENABLE =3D TRUE # DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D FALSE -# DEFINE NETWORK_ISCSI_ENABLE =3D TRUE +# DEFINE NETWORK_ISCSI_ENABLE =3D FALSE # DEFINE NETWORK_VLAN_ENABLE =3D TRUE # # Copyright (c) 2019, Intel Corporation. All rights reserved.
@@ -101,7 +101,7 @@ # Both OpensslLib.inf and OpensslLibCrypto.inf library instance ca= n be used # since libssl is not required for iSCSI. # - DEFINE NETWORK_ISCSI_ENABLE =3D TRUE + DEFINE NETWORK_ISCSI_ENABLE =3D FALSE !endif =20 !if $(NETWORK_ENABLE) =3D=3D TRUE --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66596): https://edk2.groups.io/g/devel/message/66596 Mute This Topic: https://groups.io/mt/77811111/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 09:07:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+66597+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66597+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1603703141; cv=none; d=zohomail.com; s=zohoarc; b=KMY7H1mHi6rxhdwUgaDJoMIHCdW/Pj+ZQOi90arzNyjbyBF6Jal650dkuGCTqV1lHtvuK/gY7NMsZfk2QR2UU/ITmoTea6Ykzw55drOS5zZF+aJa4rNgTNGkl6XZ4B7IbOmXBGbn94tcAcxH60zKbvve4KjXLNTR+kb+G5uLhFM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603703141; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=sYrDuchemrWgoAtkThNZHXfS2fIqNcljHbOIVAkVn94=; b=SumoNLtHLmQ3zZgG6f37CgYY0xx2c/yFpmxsWXrE1xqKpe0USsUj53S1wLdAMTAM9nAsENjBwbLUmUDfrP/GjxMsdrm8AlVnu+pY2eVAs5gSYvH4Hsgbx7k4GSSwYL+Epj6l/aFDPI/Y4XLEnO9L2VYSRwNmE1ZYEFYoN1x0KQM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66597+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1603703141425149.7410349816156; Mon, 26 Oct 2020 02:05:41 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id cGMFYY1788612x8WE1twj5m1; Mon, 26 Oct 2020 02:05:41 -0700 X-Received: from mga05.intel.com (mga05.intel.com []) by mx.groups.io with SMTP id smtpd.web11.10079.1603703131777658711 for ; Mon, 26 Oct 2020 02:05:35 -0700 IronPort-SDR: xKLdXQxNUHHB986a1LGV8DxYhaszU796D9ZS9asdbfhV3KPg47lN0c1hSbjOJd/GUZUUJ2MNox 42d5K+XeVjmA== X-IronPort-AV: E=McAfee;i="6000,8403,9785"; a="252595218" X-IronPort-AV: E=Sophos;i="5.77,417,1596524400"; d="scan'208";a="252595218" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 02:05:35 -0700 IronPort-SDR: Pia7WHktKMKbF8zPWUnMpTXroBJJ8wrIaTGss+p0geo+/FEL0ydsQinHYY6hF5Fz98f22OJQ/F +wuvzXRZ0m0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,417,1596524400"; d="scan'208";a="350038502" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by fmsmga004.fm.intel.com with ESMTP; 26 Oct 2020 02:05:33 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Maciej Rabeda , Jiaxin Wu , Siyuan Fu Subject: [edk2-devel] [PATCH 2/5] NetworkPkg: Enable MD5 while enable iSCSI Date: Mon, 26 Oct 2020 17:03:40 +0800 Message-Id: <20201026090343.13048-3-zhichao.gao@intel.com> In-Reply-To: <20201026090343.13048-1-zhichao.gao@intel.com> References: <20201026090343.13048-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: reIArBSmA10mJgzaiYNsLSZxx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1603703141; bh=/GiNfL41ptzq2AG9x22nlvSbME7ZU16dxfgZ03NT4wk=; h=Cc:Date:From:Reply-To:Subject:To; b=tcgH5QpgJzFErMNunHdNROZyptd2DbKNvXsWWrd7mBpArxwKapp2ugBXWFF+Vupl1Zs ISIKtHdqYcqugOQgl1bZM5/uMP+BlbkIdedPKFese8EEtPX//pzb4xQs1uuQNGgzxIQ4u e7sY85Tfh/OOkDv4lmFeAIAXZozWtfuO8So= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3003 There is a plan to make MD5 disable as default. The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES would be introduced to enable MD5. Make the definition ahead of the change to avoid build error after the MACRO changed. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Zhichao Gao --- NetworkPkg/Network.dsc.inc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/NetworkPkg/Network.dsc.inc b/NetworkPkg/Network.dsc.inc index 16f090a187..b761df900b 100644 --- a/NetworkPkg/Network.dsc.inc +++ b/NetworkPkg/Network.dsc.inc @@ -30,6 +30,11 @@ [LibraryClasses] !include NetworkPkg/NetworkLibs.dsc.inc =20 +[BuildOptions] +!if $(NETWORK_ISCSI_ENABLE) =3D=3D TRUE + *_*_*_CC_FLAGS =3D -D ENABLE_MD5_DEPRECATED_INTERFACES +!endif + !if $(PLATFORMX64_ENABLE) =3D=3D TRUE [Components.X64] !include NetworkPkg/NetworkComponents.dsc.inc --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66597): https://edk2.groups.io/g/devel/message/66597 Mute This Topic: https://groups.io/mt/77811115/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 09:07:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+66598+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66598+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1603703137; cv=none; d=zohomail.com; s=zohoarc; b=Cbf1e4FedmKVAasItuzhDCvsiGmoYJp6w/8K2EJlousGMw2RchU8HAr6PMFBPTM4Q5IswdIpU7FGwlkTcZ15hvfFosqYZEq/jneIhIBRSQbCQIT8Zj6YWZXgXuf+2so7Kb/k7r+Vb9TDiBYjOV1CVcwoT04Wwo8L5yxGy/JVJyQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603703137; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=dSoGZsxTRRcEY5SUYog6lgGDRCFG99ia9F8lENCPnDc=; b=H16Io6whx81IzhGJiS/BWwcwT1skrcLHAdVvpHjfDOrNITjg/qtPbFhiQ2kswFTJrZsnQMBT+LeQtEOpoVIcAsVLWD/AuhVL8Dj+cdtld51XP5/BfugRPaDUgu26PWbB32XzpMzsA2/+nGEwZ8dffquv2In+BaW2XOvLZP5trZA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66598+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1603703137080986.6227908143997; Mon, 26 Oct 2020 02:05:37 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id WnmxYY1788612x49Q8i9LOIg; Mon, 26 Oct 2020 02:05:36 -0700 X-Received: from mga05.intel.com (mga05.intel.com []) by mx.groups.io with SMTP id smtpd.web11.10079.1603703131777658711 for ; Mon, 26 Oct 2020 02:05:36 -0700 IronPort-SDR: KGMHqhDqE57LRAxyOhocMomM8wB3uXlT9k9WuHg+ZCtOU8bMWMTY1tOt7vkT+STU+IBv9badtY UcNPS/BLZHbg== X-IronPort-AV: E=McAfee;i="6000,8403,9785"; a="252595223" X-IronPort-AV: E=Sophos;i="5.77,417,1596524400"; d="scan'208";a="252595223" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 02:05:35 -0700 IronPort-SDR: IkNGLnoOh74HEbVWOYWn8Pv0LBm1hd0KnwkQwuSsQFsGbvdQ1QbjYHgmc3VeUH2o6I+aGe5ltj r4BG/AwQFuXQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,417,1596524400"; d="scan'208";a="350038509" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by fmsmga004.fm.intel.com with ESMTP; 26 Oct 2020 02:05:35 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang Subject: [edk2-devel] [PATCH 3/5] SecurityPkg/dsc: Explicitly enable MD5 for package build Date: Mon, 26 Oct 2020 17:03:41 +0800 Message-Id: <20201026090343.13048-4-zhichao.gao@intel.com> In-Reply-To: <20201026090343.13048-1-zhichao.gao@intel.com> References: <20201026090343.13048-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: yHN8cTbKufxQL9UDXLjCWAY0x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1603703136; bh=A1wgnsCjPXtgAK0Oy6Svi1DovMtfrJ4QWas6K8bQ6Ao=; h=Cc:Date:From:Reply-To:Subject:To; b=AoXbqci/2CV004Vj1xm4el1l5Thxpzl8GP7awPHULKpI2gos7Tcz/M04Hy7TJE/A07d RCItzygd8ZknmnygnX2dVc/569bGYKV2QBll+nmIMVZ5LRWWClr3z+qga9wmjLlSk6HG7 06TIREtP2UdaXtHPN8mHSKvhKCS3N5Q4oyc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3021 Hash2DxeCrypto.inf supports MD5. MD5 would be disable as default setting for edk2. Explicitly enable MD5 thru ENABLE_MD5_DEPRECATED_INTERFACES for package build. Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Zhichao Gao --- SecurityPkg/SecurityPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc index 36d15b79f9..7af0a8c7eb 100644 --- a/SecurityPkg/SecurityPkg.dsc +++ b/SecurityPkg/SecurityPkg.dsc @@ -342,5 +342,5 @@ [BuildOptions] MSFT:*_*_IA32_DLINK_FLAGS =3D /ALIGN:256 INTEL:*_*_IA32_DLINK_FLAGS =3D /ALIGN:256 - *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES + *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES -D E= NABLE_MD5_DEPRECATED_INTERFACES =20 --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66598): https://edk2.groups.io/g/devel/message/66598 Mute This Topic: https://groups.io/mt/77811117/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 09:07:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+66599+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66599+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1603703138; cv=none; d=zohomail.com; s=zohoarc; b=CLFqXKAxIzV0aMWBBp/3DBIXHp5ND6kcptf01g47E4592s4bL0F1BOUyxvMbNfFPiPj658PDmLshX6FKVcUuenWSAUhqAEbJT3Y+WL+WxsS7ZULaIUDKViGeiuKgG3UmTcp/qsKkQH8ouAcI7y9Lw6P+S49v1zc8FQQn10Sisp0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603703138; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Cb7S+592HM24Ke22YlRIpMXsDv6I7z1ied9HHPhEQH0=; b=j+cLLWxiwcKS+UkMKWmFaS4Wi4FymyrQAdHBMZw+ltMgAKGa8s+WbvDixpp1yBUbxZFQ4IW3rtToDCOvwbt21mYr0sl9RzBwlBC/AIdnSlMUrQEMchaIEspg9+Ohm/xmQSqButZ9qjP7LNL4XSsOuplfPXfvNg2JBReaLRWLdr4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66599+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1603703138260193.17604574169707; Mon, 26 Oct 2020 02:05:38 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id kGmKYY1788612xkjiFkh29Il; Mon, 26 Oct 2020 02:05:37 -0700 X-Received: from mga05.intel.com (mga05.intel.com []) by mx.groups.io with SMTP id smtpd.web11.10079.1603703131777658711 for ; Mon, 26 Oct 2020 02:05:37 -0700 IronPort-SDR: uaqYWwhZH7Tfta+5Ket1nonq/gqInQwnHcAeXOgcD3BJaSVfvQtkisYJXqIRW8bb0K0wYL8BED 4EtNkz7Kvg/w== X-IronPort-AV: E=McAfee;i="6000,8403,9785"; a="252595231" X-IronPort-AV: E=Sophos;i="5.77,417,1596524400"; d="scan'208";a="252595231" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 02:05:37 -0700 IronPort-SDR: HcE6xQ8PtkwZWYXjrubqGyxWmtx4f2CIG89dLPNDs0gj26jYXKUNg0p/Rl6MYnaa+HCbO+y0rA etUATpxab5RQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,417,1596524400"; d="scan'208";a="350038516" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by fmsmga004.fm.intel.com with ESMTP; 26 Oct 2020 02:05:36 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang Subject: [edk2-devel] [PATCH 4/5] CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5 Date: Mon, 26 Oct 2020 17:03:42 +0800 Message-Id: <20201026090343.13048-5-zhichao.gao@intel.com> In-Reply-To: <20201026090343.13048-1-zhichao.gao@intel.com> References: <20201026090343.13048-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: XzkQIy2jdR6IuKopqa3une1Xx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1603703137; bh=XHt7uk7GLt0XIFthL6+LzHFQe5draw8869wGQ83/ZIA=; h=Cc:Date:From:Reply-To:Subject:To; b=sI4LQENWiMpopur1KTY34pwDRpGna0u9rQjkaprX/i3B6eysLJjKOWRFwbFw/CwSHbJ xxAGMd0HxwQMj49RTz2zHJSSj+1niAPFauJaiyAZF81zQobpxapYSsicviLHqXFcVLTLR VPZip0tWnFHgTEKtDKcNbUeoSuuNGAmLtes= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3021 CRYPTO_SERVICES PACKAGES and ALL config would enable MD5 function. So explicitly enable MD5 while CRYPTO_SERVICES are set PACKAGES and ALL. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Zhichao Gao --- CryptoPkg/CryptoPkg.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc index 0490eeb7e2..30c4909397 100644 --- a/CryptoPkg/CryptoPkg.dsc +++ b/CryptoPkg/CryptoPkg.dsc @@ -285,3 +285,6 @@ =20 [BuildOptions] *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES +!if $(CRYPTO_SERVICES) IN "PACKAGE ALL" + *_*_*_CC_FLAGS =3D -D ENABLE_MD5_DEPRECATED_INTERFACES +!endif --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66599): https://edk2.groups.io/g/devel/message/66599 Mute This Topic: https://groups.io/mt/77811119/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 09:07:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+66600+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66600+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1603703139; cv=none; d=zohomail.com; s=zohoarc; b=RQCe73n7p4/9wnQ2FGrnGPxe1MWzme1U5C4GaFF50pB+KnxOvvkXDfeXN5obPRLvznXE56472GCIIdcCyzwKM0QXQ///rfhgCE6G8Z9c58nIzoE7R/F3e8k0tmu/Wour2MInD7nszwIW98vI/91gd4fWTNyUel9PknXerqYM/54= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603703139; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=D2tk8SEiiSZ4eMPMTkW/x6ux18QcdhoMDHDxiqiN4PM=; b=RfHPhYKo+hEHZAnt20k7Qr57ImkNPK8bRzITtZkQ4hoM3hev60nZQEkHKXdBR427e6yd4F5bsEx0MshZ78dVHQdApErSLEo3A/ecHTqZUgOaSG3iLt5A9eVs0qLA47xkhIpwHz+3Zg3wpS4lMfElzUEv67j6j1J1gFV/HEAaBnw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66600+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1603703139710200.5916977795422; Mon, 26 Oct 2020 02:05:39 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id rKXmYY1788612xbH3JWea2fD; Mon, 26 Oct 2020 02:05:39 -0700 X-Received: from mga05.intel.com (mga05.intel.com []) by mx.groups.io with SMTP id smtpd.web11.10079.1603703131777658711 for ; Mon, 26 Oct 2020 02:05:38 -0700 IronPort-SDR: JeK9oV5gqmSh2KNJRRsXawQpcus6eGz/GACo4DQNYMYYR6Pr7QaxX5K0TPiYUfTrKmWe8yl+EX fQWHHkq5jBSw== X-IronPort-AV: E=McAfee;i="6000,8403,9785"; a="252595236" X-IronPort-AV: E=Sophos;i="5.77,417,1596524400"; d="scan'208";a="252595236" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 02:05:38 -0700 IronPort-SDR: NJ7wThWcTsAvl9jwWNcABDEJUPsuOg6XGHOGpvkzs5lKD9POdW1iTz7OjNBaNPDcBYPN+Kyody DOIMYw+ZK6hw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,417,1596524400"; d="scan'208";a="350038521" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by fmsmga004.fm.intel.com with ESMTP; 26 Oct 2020 02:05:37 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang Subject: [edk2-devel] [PATCH 5/5] CryptoPkg: Make the MD5 disable as default for security Date: Mon, 26 Oct 2020 17:03:43 +0800 Message-Id: <20201026090343.13048-6-zhichao.gao@intel.com> In-Reply-To: <20201026090343.13048-1-zhichao.gao@intel.com> References: <20201026090343.13048-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: JAHZg8AHPLkyTP1jUxSIFO9Ex1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1603703139; bh=7J/+T8qifrFy7BkNRtGqNKVPyolHZUOlm9RZKMV18i4=; h=Cc:Date:From:Reply-To:Subject:To; b=Nzh/0LkHP75OYHz+BIfQsEWNsh/QSGsJEb6OKgQJwP0wwjkjscwTRo60BcPeHTRlcvq shATGauOqKo96tnmVLcxQVHFzOmQY1MAID8F3nsASxd8G8+FOxKGvXGVA3tv4oZNbHeVT fcfKWoIpPiTZkP865KAt+U9y06nkykjR41w= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3021 Make the deprecated MD5 disable as default setting for security. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Zhichao Gao --- CryptoPkg/Driver/Crypto.c | 4 ++-- CryptoPkg/Include/Library/BaseCryptLib.h | 2 +- CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c | 2 +- CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CryptoPkg/Driver/Crypto.c b/CryptoPkg/Driver/Crypto.c index d9096ea603..26f280cd5d 100644 --- a/CryptoPkg/Driver/Crypto.c +++ b/CryptoPkg/Driver/Crypto.c @@ -243,7 +243,7 @@ DeprecatedCryptoServiceMd4HashAll ( return BaseCryptLibServiceDeprecated ("Md4HashAll"), FALSE; } =20 -#ifdef DISABLE_MD5_DEPRECATED_INTERFACES +#ifndef ENABLE_MD5_DEPRECATED_INTERFACES /** Retrieves the size, in bytes, of the context buffer required for MD5 has= h operations. =20 @@ -4494,7 +4494,7 @@ const EDKII_CRYPTO_PROTOCOL mEdkiiCrypto =3D { DeprecatedCryptoServiceMd4Update, DeprecatedCryptoServiceMd4Final, DeprecatedCryptoServiceMd4HashAll, -#ifdef DISABLE_MD5_DEPRECATED_INTERFACES +#ifndef ENABLE_MD5_DEPRECATED_INTERFACES /// Md5 - deprecated and unsupported DeprecatedCryptoServiceMd5GetContextSize, DeprecatedCryptoServiceMd5Init, diff --git a/CryptoPkg/Include/Library/BaseCryptLib.h b/CryptoPkg/Include/L= ibrary/BaseCryptLib.h index ae9bde9e37..496121e6a4 100644 --- a/CryptoPkg/Include/Library/BaseCryptLib.h +++ b/CryptoPkg/Include/Library/BaseCryptLib.h @@ -72,7 +72,7 @@ typedef enum { // One-Way Cryptographic Hash Primitives //=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 -#ifndef DISABLE_MD5_DEPRECATED_INTERFACES +#ifdef ENABLE_MD5_DEPRECATED_INTERFACES /** Retrieves the size, in bytes, of the context buffer required for MD5 has= h operations. =20 diff --git a/CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c b/CryptoPkg/Lib= rary/BaseCryptLib/Hash/CryptMd5.c index b85e7f4d12..d670f17424 100644 --- a/CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c +++ b/CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c @@ -9,7 +9,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include "InternalCryptLib.h" #include =20 -#ifndef DISABLE_MD5_DEPRECATED_INTERFACES +#ifdef ENABLE_MD5_DEPRECATED_INTERFACES /** Retrieves the size, in bytes, of the context buffer required for MD5 has= h operations. =20 diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c b/Crypt= oPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c index 3f14c6d262..8b43d1363c 100644 --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c @@ -99,7 +99,7 @@ CryptoServiceNotAvailable ( // One-Way Cryptographic Hash Primitives //=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 -#ifndef DISABLE_MD5_DEPRECATED_INTERFACES +#ifdef ENABLE_MD5_DEPRECATED_INTERFACES /** Retrieves the size, in bytes, of the context buffer required for MD5 has= h operations. =20 --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66600): https://edk2.groups.io/g/devel/message/66600 Mute This Topic: https://groups.io/mt/77811123/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-