From nobody Sat Apr 27 20:07:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+66532+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+66532+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1603363458; cv=none; d=zohomail.com; s=zohoarc; b=DpZtA1twuGsdQ9vW1bKXcyJKb07L4ZXdVm/1Pdtm27OfA3EN20SB8036znrwJh7pBRxg0r5yQtFDA+b9f3+nPmJAcGWckRhXUe0/acK4hrRvx3De/y5dKxYqOYrOBTI9PtCItUc+LKBACqJmy9GekX2bHofURtENY72gjjIUWQo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603363458; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=kG3NqzDtaOqJo1HYermeW8DDFc5q1NcRwRDC7ZqLjMI=; b=NeK5Lhdi/VG64TMTWoZzWESX29QT8exXv2AkT5tIFmP/grhf61bbO4SyJ6hkMLVLeb88Oh/4q80hd2FnnQm0SH6iOJ9zFQNWY4uvGS8YKOMyAGk1N4miCYvdQEAvGKR+5AgXK5TR/nGnlg1ArkxzWABRz/hTsYf4rIk0ERwLn68= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+66532+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1603363458941100.75415550047785; Thu, 22 Oct 2020 03:44:18 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 5MnuYY1788612xh7tfatgViD; Thu, 22 Oct 2020 03:44:18 -0700 X-Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.4712.1603335108993561604 for ; Wed, 21 Oct 2020 19:51:49 -0700 IronPort-SDR: OTSuyCgt5mwa4BPDLIX9AtVzNxME6lyXsAOv2VjC4SpdRXMpbF+sT1lc7zDjfR0LM26BVj+pip KH6QcI5OHuAA== X-IronPort-AV: E=McAfee;i="6000,8403,9781"; a="185137188" X-IronPort-AV: E=Sophos;i="5.77,403,1596524400"; d="scan'208";a="185137188" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2020 19:51:48 -0700 IronPort-SDR: zkFLwPBf7NWpp631zNtU01mHYYrVCtkYL7Jr/fRiYQcq70iixJsgjjzJ/q7XbCMwrwi1XRUuZk rPUoHRmWcC1g== X-IronPort-AV: E=Sophos;i="5.77,403,1596524400"; d="scan'208";a="321222921" X-Received: from dangpham-mobl.ccr.corp.intel.com (HELO cosmolai-MOBL.gar.corp.intel.com) ([10.252.190.168]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2020 19:51:46 -0700 From: Cosmo Lai To: devel@edk2.groups.io Cc: Cosmo Lai , Maurice Ma , Nate DeSimone , Star Zeng , Chasel Chiu Subject: [edk2-devel] [PATCH] IntelFsp2Pkg/FspSecCore: LoadMicrocodeDefault() failed with padding in FV. Date: Thu, 22 Oct 2020 10:51:27 +0800 Message-Id: <20201022025127.1136-1-cosmo.lai@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,cosmo.lai@intel.com X-Gm-Message-State: F1ILPV8WJih9itZAl4ABzjNex1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1603363458; bh=Khn2Yl0oAtNlE/UrMQJIrVFCqhBA30fel9zleuN5Exc=; h=Cc:Date:From:Reply-To:Subject:To; b=mLjt2/u/TvSwY5vV4XUuE3FPcsO/rKc9CmydEgJOQ9xU+3xWjr0z4YD11VvTck6ejHP i/NDCpsuiQg8K+URiFMORoFPNfzdZaVP1Ud8XAxiyQha3VDLyJq6ZAc1s9TqpYfnU5kCt 8ViMyrOio8EtAhbjAz/tuP65WyC4gUpzf6E= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3017 Platform microcode FV may have padding between each version of microcode binary, and current FSP-T/LoadMicrocodeDefault() cannot handle this case and return not_found unexpectedly. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Cosmo Lai Reviewed-by: Chasel Chiu Reviewed-by: Nate DeSimone --- IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm b/IntelFsp2Pkg/= FspSecCore/Ia32/FspApiEntryT.nasm index 7934eab6d7..7fd3d6d843 100644 --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm @@ -307,10 +307,6 @@ AdvanceFixedSize: add esi, dword 1024 =20 CheckAddress: - ; Is valid Microcode start point ? - cmp dword [esi + MicrocodeHdr.MicrocodeHdrVersion], 0ffffffffh - jz Done - ; Check UPD header revision cmp byte [esp + LoadMicrocodeParamsFsp22.FspUpdHeaderRevision], 2 jae Fsp22UpdHeader1 @@ -341,6 +337,10 @@ Fsp22UpdHeader1: jmp CheckMainHeader =20 LoadMicrocodeDefault4: + ; Is valid Microcode start point ? + cmp dword [esi + MicrocodeHdr.MicrocodeHdrVersion], 0ffffffffh + jz Done + LoadCheck: ; Get the revision of the current microcode update loaded mov ecx, MSR_IA32_BIOS_SIGN_ID --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66532): https://edk2.groups.io/g/devel/message/66532 Mute This Topic: https://groups.io/mt/77723600/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-