From nobody Fri Apr 26 04:21:28 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+66200+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66200+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1602643825; cv=none; d=zohomail.com; s=zohoarc; b=csdiydjeXHupBm6qk6bA8Y6+EeWSAir2DQwjRlhKPDaxiGvG6TI6SsPOhC6HOGs0IYo6NPhJD0vmItati48L++jFkKKMCTfyWQlu/2jVhccQW+F2aI6CsCmGxRsxJKvONVxZww+1DJ8Bn7NmCRBo6JL7567SxBN4OsF5bido6Bw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602643825; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=04+hvUG8+Cxl0tZ1lbVayS8SG5SfVj65ivp3lqpkhlg=; b=H5OFwqlXc7XUkF4ULITzofYE0nKZUu/heVSamfSsPcZEc19jh4LoHgsc/VE+WW8GnLAODRH2qS2/20vNseWR3O4iZsUL9EVEOMDnuIXZJvhyHVp/I/yipAkSwzIS++LB9XY8E4funqv4IiKp/qYyVsNbALNA0p+t/Eyaov1IkLE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66200+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1602643824874598.36907808713; Tue, 13 Oct 2020 19:50:24 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id d4hGYY1788612x4sCb3voLUB; Tue, 13 Oct 2020 19:50:24 -0700 X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.2684.1602643822121292313 for ; Tue, 13 Oct 2020 19:50:23 -0700 X-Received: from localhost.localdomain ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 14 Oct 2020 10:50:17 +0800 X-WM-Sender: fengyunhua@byosoft.com.cn From: "fengyunhua" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao Subject: [edk2-devel] [edk2-staging][PATCH v2] BaseTools/Fmmt: Fixed FMMT Linux build break issue Date: Wed, 14 Oct 2020 10:49:29 +0800 Message-Id: <20201014024929.1945-1-fengyunhua@byosoft.com.cn> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,fengyunhua@byosoft.com.cn X-Gm-Message-State: q2LPW95bQ6fPBOBUK90CdiK5x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1602643824; bh=thF78IhAWyopL1V0LwgC8LsM0noiaaq3UMSOP65dmV8=; h=Cc:Date:From:Reply-To:Subject:To; b=uxHYhkZhyceZL0SghXRz4UW6DpOT2pfDEvNSGPIFXwYId/DxGfHp3kOriMHg7i1onpc UMNgvdW1oUCIHq+qT/FE/bssHEh1ZEHwO4QrcI8BRq07nEba3fIiq0yzqZLFEr2dFqkbO yFJlnGjRbtX+MVe5lLM+Uvz8kw6uVafhNXU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Remove some defined variable but not used. Linux build option[-Werror=3Dunused-but-set-variable] treat all warnings a= s errors. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yunhua Feng Reviewed-by: Bob Feng Reviewed-by: Liming Gao --- BaseTools/Source/C/FMMT/FirmwareModuleManagement.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/BaseTools/Source/C/FMMT/FirmwareModuleManagement.c b/BaseTools= /Source/C/FMMT/FirmwareModuleManagement.c index 20663ba163..38056153fb 100644 --- a/BaseTools/Source/C/FMMT/FirmwareModuleManagement.c +++ b/BaseTools/Source/C/FMMT/FirmwareModuleManagement.c @@ -1717,11 +1717,6 @@ FmmtImageExtract ( FV_INFORMATION *FvInFd; UINT32 Index; UINT32 FfsFoundFlag; - FFS_INFORMATION *OutputFileName; - FILE* NewFdFile; - FILE* NewFvFile; - UINT64 NewFvLength; - VOID* Buffer; CHAR8 *TemDir; UINT8 FvNumInFd; UINT32 Offset; @@ -1736,23 +1731,18 @@ FmmtImageExtract ( UINT32 FfsSize; UINT32 FdSize; int j; - CHAR8 FfsOutputFileName[_MAX_DIR]; + CHAR8 FfsOutputFileName[_MAX_PATH]; =20 FdSize =3D 0; Index =3D 0; - NewFvLength =3D 0; FfsFoundFlag =3D 0; FdData =3D NULL; FvInFd =3D NULL; - OutputFileName =3D NULL; - NewFdFile =3D NULL; - NewFvFile =3D NULL; - Buffer =3D NULL; TemDir =3D NULL; FvNumInFd =3D 0; Offset =3D 0; FdBuffer =3D NULL; - if (sizeof(FfsOutFileOrDirName) > _MAX_DIR) { + if (strlen(FfsOutFileOrDirName) > _MAX_PATH - 1) { Error("FMMT", 0, 0004, "error while input file name", "Output director= y path is too long" ); return EFI_ABORTED; } --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66200): https://edk2.groups.io/g/devel/message/66200 Mute This Topic: https://groups.io/mt/77498244/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-