From nobody Fri Mar 29 15:02:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+66124+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66124+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1602487381; cv=none; d=zohomail.com; s=zohoarc; b=OW+xmg/a3lTjR8f72MeXnuNAcwjpq4EkOGX8jr+GiWrSpor0LY09zzm+HrUJXqCg/KqJu64DB6oh3LoX9Db1jPfx5IzBymVekUR4mkz/yfFL03PUp5UxGWZPK6R4m4KoOxwdhnVjwY82vzgHAx2IIU0Qbh2G7jprX3VMGFqB+ss= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602487381; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=0RRQHJ7sZtQqhX2RbIokdhZTv9+/fvMXWL2oJq2T7AQ=; b=lbKnqw6fjg0wQe6JA2na37RpiheBgck1qO2TQVJ5razOA76N6ghOQ4br8V92CY2aUePV2SOfFf05MML6s1AKpFtUB5hT1Sml5HXAHLJGWbxJoX/piTzp8D9O4ylBhBlSJqVF5yUpl+HnkF9V3HsACa05pubUHFKi4Hzh76EgggI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+66124+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 160248738103794.52393823683781; Mon, 12 Oct 2020 00:23:01 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id tWP7YY1788612xTYS8Aoh2j3; Mon, 12 Oct 2020 00:23:00 -0700 X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.35410.1602487379796370747 for ; Mon, 12 Oct 2020 00:23:00 -0700 IronPort-SDR: qZH8PWKdzwyaCAFZhoXTWFCVlPn6S80mZB/jJtcBeJhJWnstS1KcekmU75irUU/3/RSaiPJiN1 dzUbJgJdAZYg== X-IronPort-AV: E=McAfee;i="6000,8403,9771"; a="229882955" X-IronPort-AV: E=Sophos;i="5.77,366,1596524400"; d="scan'208";a="229882955" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2020 00:22:55 -0700 IronPort-SDR: GijlnCIADZWJAk97APt0ASWc5lq8/qfjjJkQdsrTobgiQkv/61sUAHKYJxFY0OnIQaTEnuDwCW MgmUZ7a+I1UQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,366,1596524400"; d="scan'208";a="529850595" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.108]) by orsmga005.jf.intel.com with ESMTP; 12 Oct 2020 00:22:54 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Ray Ni , Hao A Wu Subject: [edk2-devel] [PATCH] MdeModulePkg/PartitionDxe: Revert the child handler blocksize change Date: Mon, 12 Oct 2020 15:22:30 +0800 Message-Id: <20201012072230.46152-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: b9uWc4vD9q8hYAAQM9RpdCisx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1602487380; bh=PYke/CdL51ZRHymIoSde3UHyN5XKt8Lidz386SCeWHA=; h=Cc:Date:From:Reply-To:Subject:To; b=lZ619nDbMd6ZJdobcbBhp4mtbayXO+/eEfJlFoXl6zS+VQ4gRwUquMi/SPUBe8GqwRJ w3iSP+2YPg3fDkQI0GPtmgYuTJt7cHuH2n5UKrcquxzCQ/GXo37fFQv4PybyZ6CQqViot cv3kazPOX3QMuA7gWop3IprH4Hfv0JDg5To= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2843 Revert the patch to change the block size in child handler. It would block the CD (Eltorito) Hard disk media type's sub partition being observed. The blocksize patch used to fix the CD image's MBR table issue. The CD MBR table would always be ignored because it would be handled by the Eltorito partition handler first and never go into the MBR handler. So directly revert it. Cc: Ray Ni Cc: Hao A Wu Signed-off-by: Zhichao Gao Acked-by. Reviewed-by: Ray Ni Tested-by: Gary Lin --- MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c b/MdeModu= lePkg/Universal/Disk/PartitionDxe/Partition.c index f10ce7c65b..473e091320 100644 --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c @@ -1149,8 +1149,8 @@ PartitionInstallChildHandle ( =20 Private->Signature =3D PARTITION_PRIVATE_DATA_SIGNATURE; =20 - Private->Start =3D MultU64x32 (Start, BlockSize); - Private->End =3D MultU64x32 (End + 1, BlockSize); + Private->Start =3D MultU64x32 (Start, ParentBlockIo->Media->B= lockSize); + Private->End =3D MultU64x32 (End + 1, ParentBlockIo->Media-= >BlockSize); =20 Private->BlockSize =3D BlockSize; Private->ParentBlockIo =3D ParentBlockIo; @@ -1187,7 +1187,13 @@ PartitionInstallChildHandle ( =20 Private->Media.IoAlign =3D 0; Private->Media.LogicalPartition =3D TRUE; - Private->Media.LastBlock =3D End - Start; + Private->Media.LastBlock =3D DivU64x32 ( + MultU64x32 ( + End - Start + 1, + ParentBlockIo->Media->BlockSize + ), + BlockSize + ) - 1; =20 Private->Media.BlockSize =3D (UINT32) BlockSize; =20 --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66124): https://edk2.groups.io/g/devel/message/66124 Mute This Topic: https://groups.io/mt/77455892/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-