From nobody Sat May 18 06:50:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+65658+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65658+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1601131967; cv=none; d=zohomail.com; s=zohoarc; b=j4X17YAWdqZwoHbxNdLkc9bn517nJCc8qa2ReBNwiVOQsy22EfvSAOfbyOJdXy0L1v7NSJIZC2SAQD5xCLTfNiFaQ9uwR1U2g+UkUplzJMmUAcIsxd61ZHrAg+gvzaSPClszhIfQbjgbTbaFy4vdxauDdOoPI282WIt6SHB/wVk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601131967; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=eV+15S/dPCfuaCRfFxTkNWqxZVoeisS3dsNqn2IfAcQ=; b=LjbEiovx808RQ6Eg2tF4CK+WpOtDLzALkY9ZEC5ncfPBLfNPJ9P+MFcnPW1NEmssRPrhsd3+lDmKolMIdDQ01V2vFWx5oKAsU+8DbQTJo8gej2+9jpJ3QeeUgZ28nwE1vNA/rmI6b1a+3moqdHLIsTiDY74L5Gj3L9ss5vjg84o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65658+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1601131967078657.0795140700054; Sat, 26 Sep 2020 07:52:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id mwCRYY1788612xZBXdwZK3UY; Sat, 26 Sep 2020 07:52:46 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.12985.1601131963451871887 for ; Sat, 26 Sep 2020 07:52:43 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 98C971063; Sat, 26 Sep 2020 07:52:42 -0700 (PDT) X-Received: from U203705.Arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5621B3F73B; Sat, 26 Sep 2020 07:52:42 -0700 (PDT) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Pete Batard , Andrei Warkentin Subject: [edk2-devel] [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Fix RPi4 RngLib build error Date: Sat, 26 Sep 2020 10:52:29 -0400 Message-Id: <20200926145230.5332-2-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20200926145230.5332-1-Samer.El-Haj-Mahmoud@arm.com> References: <20200926145230.5332-1-Samer.El-Haj-Mahmoud@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,samer.el-haj-mahmoud@arm.com X-Gm-Message-State: 75mlfA3kpwtLzqUybSog9aIex1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1601131966; bh=8+x5RfL/1jbz2HyBmh+dJDyFE3PX7MtXLsobM2IwutY=; h=Cc:Date:From:Reply-To:Subject:To; b=rvl94SX7MzR5TRfwGom8xeWzXONIYlKstt9gzW6ho45RpcKC69JKDhAowKNgSbhmX+6 WENmoIcFWAu8ekNVDhO4BENokZwyAZRXlUpg24KKDYKzix18HJO1xJUwZNObGNrIvQpcI TjSED/brmZd1IC0XmvqbeyclR2hLF7gzr/8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Commit b5701a4c7a0fb185e0c5b9db9525939c78664bfd introduced RngLib dependency for OpensslLib, and caused the RPi build to break for lack of an RngLib instance. This patch adds RngLib using the DxeRngLib flavor, which is a wrapper around the the EFI_RNG_PROTOCOL that the platform already produces. Tested booting OSes and running the SCT test for EFI_RNG_PROTOCOL. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud Reviewed-by: Andrei Warkentin --- Platform/RaspberryPi/RPi4/RPi4.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4= /RPi4.dsc index 823c9fc007d4..c994f56d658d 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.dsc +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc @@ -130,6 +130,7 @@ [LibraryClasses.common] SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/DebugDualSe= rialPortLib.inf =20 # Cryptographic libraries + RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65658): https://edk2.groups.io/g/devel/message/65658 Mute This Topic: https://groups.io/mt/77137686/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 18 06:50:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+65656+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65656+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1601131968; cv=none; d=zohomail.com; s=zohoarc; b=ITVHcEdkngbW05leg/f+a0orcWIPKZRIWaXYpQHrTkYtJttM5XwTEqJPsVzY8/OEC9FyHk/Zd5+I03C5a6EozfAb0VzO/TqvsrUkVb46xddAILAcyCCCfREMDoS+QnOzBtLsuSdKA1p8EGPoigGERoN1pUREY5Tn9YQ8562li4k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601131968; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=ySeEIMMUw9etGWyxBRnovYqdW/7pUOF4Q55NWpg9znw=; b=SlJoB1fRKMHdqTpwq34njeLjo/OaaM1+8rldQiEICp7DaKNyzprAhZh8U6nacSs6sToO0Gr5/FpQTBFMRnXzDcXLCvjYUu7hUY2Hy+xaE74ScCGbrstW3HKqrKQFyduonppoB5oB+RccvpQs58GM9T+1dJdAN6nj/j8trI+kn+o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65656+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1601131968080262.26235889323857; Sat, 26 Sep 2020 07:52:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 8505YY1788612xEQRDgSqzmq; Sat, 26 Sep 2020 07:52:47 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.12984.1601131963333680405 for ; Sat, 26 Sep 2020 07:52:43 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EA248106F; Sat, 26 Sep 2020 07:52:42 -0700 (PDT) X-Received: from U203705.Arm.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A8B973F73B; Sat, 26 Sep 2020 07:52:42 -0700 (PDT) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Pete Batard , Andrei Warkentin Subject: [edk2-devel] [edk2-platform][PATCH v1 2/2] Platforms/RaspberryPi: Fix RPi3 RngLib build error Date: Sat, 26 Sep 2020 10:52:30 -0400 Message-Id: <20200926145230.5332-3-Samer.El-Haj-Mahmoud@arm.com> In-Reply-To: <20200926145230.5332-1-Samer.El-Haj-Mahmoud@arm.com> References: <20200926145230.5332-1-Samer.El-Haj-Mahmoud@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,samer.el-haj-mahmoud@arm.com X-Gm-Message-State: nQ557etmYplris6tF7KTO084x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1601131967; bh=43ttgVUFUx6mSW/SqxkSvV83pPG2sk1dVm6oGpnZGkE=; h=Cc:Date:From:Reply-To:Subject:To; b=I99hR8BFGggIjWk2o3G37jmhQ2Zg9QKv0j0HtQjWBJ7HTZzCvLHm4ib4WP0Z/oiywPZ r4jPiGDtWccRw/yFHEJT97UFjupFL1a6pUFWnvljHgqM0e5P9a0s5D0BkDIlMeJ/yUwMr eA2GipGawY/uhdt9UcWThzF8hPyP9ip+KQY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Commit b5701a4c7a0fb185e0c5b9db9525939c78664bfd introduced RngLib dependency for OpensslLib, and caused the RPi build to break for lack of an RngLib instance. This patch adds RngLib using the DxeRngLib flavor, which is a wrapper around the the EFI_RNG_PROTOCOL that the platform already produces. Build tested only. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud Reviewed-by: Andrei Warkentin --- Platform/RaspberryPi/RPi3/RPi3.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3= /RPi3.dsc index 484a46ffba87..325d7bdb7269 100644 --- a/Platform/RaspberryPi/RPi3/RPi3.dsc +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc @@ -130,6 +130,7 @@ [LibraryClasses.common] SerialPortLib|Platform/RaspberryPi/Library/DualSerialPortLib/DebugDualSe= rialPortLib.inf =20 # Cryptographic libraries + RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65656): https://edk2.groups.io/g/devel/message/65656 Mute This Topic: https://groups.io/mt/77137684/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-