From nobody Sun Apr 28 17:33:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+65529+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65529+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1600864636; cv=none; d=zohomail.com; s=zohoarc; b=eyZKQc6Lc9mC6xrMx5kYe+VfWUSu0cv80on5uBMio8jcmGh4KFNhBauWjX4k9B6K8zs5YM0ogu/jtpfjmZ62Ewq7OVGHALivsFu/AwggUGb+0mx9dSW3U1DfU2eSVmATnAOzV66GinenfJtSqxhFT9k6/NTcHff4iJ0Gl1//GZI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600864636; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=+sYfEWlRry9ob6yuDfC91FiNGZtVqLPNgpTq0NiFR14=; b=WpY+5cJiG7vpxfg2W2s5noBpG/GrZgOBf2ihjLq3Px++6paIqS6R80CLoz5aRVtMpWMSwdoEpPwyNPJ1FOt3dyUG04WhH3+lrdBLwF3X30MxNbM27zra/UUX9kHeIiEiQ6X1QUx+aC+jQ2aZVtxzxKTqPPnpoPrK++phrje0GPA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65529+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1600864636871780.7727283677337; Wed, 23 Sep 2020 05:37:16 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id V76FYY1788612xFClGeNKkRp; Wed, 23 Sep 2020 05:37:16 -0700 X-Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.12512.1600864635742306349 for ; Wed, 23 Sep 2020 05:37:15 -0700 IronPort-SDR: zZsZbJimyxM/4tX4LUlZ7w1MloaroGmgN+m9Rci+LcB00J1p44BrgjVtH9Ihtmuz+CFX+prTap kK5CJKlOeImg== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="160950941" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="160950941" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 05:37:14 -0700 IronPort-SDR: 24Vd2hc3k4CfH5ysZf/fleL0e2JGYJ5vMw7IucluoIHQ0l2eus5K7JqISkc/F0OFXoM6GClVfH 4a+gkYCASp6g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="511631207" X-Received: from shwdepsi1121.ccr.corp.intel.com ([10.239.158.66]) by fmsmga005.fm.intel.com with ESMTP; 23 Sep 2020 05:37:13 -0700 From: "Bob Feng" To: devel@edk2.groups.io Cc: Liming Gao , Yuwei Chen Subject: [edk2-devel] [Patch] BaseTools: Remove CanSkip calling for incremental build Date: Wed, 23 Sep 2020 20:36:58 +0800 Message-Id: <20200923123658.40652-1-bob.c.feng@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,bob.c.feng@intel.com X-Gm-Message-State: TNXE7LeJ5XteaeAReHIzOe4ax1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1600864636; bh=1Y1HEz4K9MitgcR+AgFCxpdNS0otoRAoui/4IHDM7yc=; h=Cc:Date:From:Reply-To:Subject:To; b=uurzUaZAgRtHDt7YURX4FIgJHwjW22kaUGPjLBos7BAWVBmI2Yt13Qzr9FePieLNjNx KARCVMkucChmhSFDVwPf5Wi45GVHwSc9/l7qcOMzL+uT2Ng9IUt7lqE87EvEj7+b+2IsY iu/DT+9gI3IbEAgftDUeAoCHov/ODb1/N1w= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2978 If a module add a new PCD, the pcd token number will be reassigned. The new Pcd token number should be updated to all module's autogen files. CanSkip can only detect a single module's change but not others. CanSkip block the pcd token number update in incremental build, so this patch is going to remove this call. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Reviewed-by: Yuwei Chen --- BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py b/BaseTools/S= ource/Python/AutoGen/ModuleAutoGen.py index dc8b1fe3d1..eebf6e87f5 100755 --- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py +++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py @@ -1820,13 +1820,10 @@ class ModuleAutoGen(AutoGen): =20 if not self.IsLibrary and CreateLibraryCodeFile: for LibraryAutoGen in self.LibraryAutoGenList: LibraryAutoGen.CreateCodeFile() =20 - # CanSkip uses timestamps to determine build skipping - if self.CanSkip(): - return self.LibraryAutoGenList AutoGenList =3D [] IgoredAutoGenList =3D [] =20 for File in self.AutoGenFileList: --=20 2.20.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65529): https://edk2.groups.io/g/devel/message/65529 Mute This Topic: https://groups.io/mt/77033757/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-