From nobody Tue Apr 30 20:21:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65451+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1600785805199550.6611735893056; Tue, 22 Sep 2020 07:43:25 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id KljGYY1788612xW45b1jLCFs; Tue, 22 Sep 2020 07:43:24 -0700 X-Received: from EUR02-HE1-obe.outbound.protection.outlook.com (EUR02-HE1-obe.outbound.protection.outlook.com [40.107.1.74]) by mx.groups.io with SMTP id smtpd.web11.144.1600785803941377093 for ; Tue, 22 Sep 2020 07:43:24 -0700 X-Received: from AM6PR02CA0032.eurprd02.prod.outlook.com (2603:10a6:20b:6e::45) by DB8PR08MB5082.eurprd08.prod.outlook.com (2603:10a6:10:ec::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15; Tue, 22 Sep 2020 14:43:20 +0000 X-Received: from VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::ea) by AM6PR02CA0032.outlook.office365.com (2603:10a6:20b:6e::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.13 via Frontend Transport; Tue, 22 Sep 2020 14:43:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+65451+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT054.mail.protection.outlook.com (10.152.19.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:43:19 +0000 X-Received: ("Tessian outbound 34b830c8a0ef:v64"); Tue, 22 Sep 2020 14:43:19 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a6b0d0eb947e3a74 X-CR-MTA-TID: 64aa7808 X-Received: from 4d5acb61c8f4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BBD97813-EED0-45F8-AF81-3166170685A5.1; Tue, 22 Sep 2020 14:42:41 +0000 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4d5acb61c8f4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Sep 2020 14:42:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g1PKLyvgZd0vD/ME2WPlmUjHxe0pk9hO6DjDKxHrj20lAeiTdASJr6h6YDzlncOuVBBcnacigPiqLnhO4BECe6uqS0vDoXLkZSWLxWTdtpT4A8LExRVcJd0AxhsmkWezddL+YBC6dkGsxchDMufCsX0cx3QwZnSdpDHOiOuggqyXWtZ8bq3uXxXpu3Riv+9E0y11qQMus2O4TshydqvC6uTULJz5QFlbv4YG3zi1d4ffVd1zLgODpSrJxPdt4iLLMxx59ydH6YLW310MQSnOsVkJz872Y2cAYtFdiccSoKIAd+nWY+47/Ed6eSlVRKGJkE2ud/gfEpjUSvReWAMwxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XKjkuFbRE9A2u08RMhpjDWsTzkMA5dYMq1zBckes6oE=; b=fJ7hcgcJ4pkajFjDjX5zGpGH2Dg2IjaDoaC2IiY2TAv0wwuNtD2/6jyYPjjz3VzFhq2L0BpmVYhwDDUcpn7oZJXnFWkhkYNTo9CWCcD9kpSnDL481QhPq6qeRIoB0WxQoWYmdC9xkoOp/LiMrvorTjlRFw67nh/Vt/DuMwNIEqx0v9+Jkbr4k4W25bN7mVxsfbSb1kVi58S8m0pORO8wDIOLGdBSQ6UCOymiTKS3+k/Q0bqFtHDRMYLqsAvv6CacvpLsvX7CvToTmugo44f+/w0ECdFmjltIHxqaw3Pn7izO5hMSdaMY9zBJfpIZkoqtBxtOi2LeTJstGp5PVfYeMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from DB6PR07CA0110.eurprd07.prod.outlook.com (2603:10a6:6:2c::24) by VI1PR08MB2862.eurprd08.prod.outlook.com (2603:10a6:802:22::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.26; Tue, 22 Sep 2020 14:42:40 +0000 X-Received: from DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2c:cafe::7e) by DB6PR07CA0110.outlook.office365.com (2603:10a6:6:2c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.8 via Frontend Transport; Tue, 22 Sep 2020 14:42:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT006.mail.protection.outlook.com (10.152.20.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:42:40 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Tue, 22 Sep 2020 14:42:36 +0000 X-Received: from E107187.Arm.com (10.57.47.90) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Tue, 22 Sep 2020 14:42:36 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v1 1/7] DynamicTablesPkg: Fix order of assert checks Date: Tue, 22 Sep 2020 15:42:29 +0100 Message-ID: <20200922144235.76292-2-sami.mujawar@arm.com> In-Reply-To: <20200922144235.76292-1-sami.mujawar@arm.com> References: <20200922144235.76292-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8dcf8b06-87dc-476c-fa27-08d85f05d8ee X-MS-TrafficTypeDiagnostic: VI1PR08MB2862:|DB8PR08MB5082: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:1360;OLM:1360; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8jdJdiY4DjtlK4GpLJGxRRCBH2aoCpG2L+BLpvMVRptSQiYQS/S880q/tM1IJ9KpjQDrTwfVvAMmjTXNcbe9vV1r5BEfI9o6u8nhGgghO/hFYlDUBtSK5NpWw68RV+g9UYV078GgaaIgT6iNvs0XMrbBWsCikeJkOs1TS446qjqG52ee7I5FwETuT8nHo2L+G+FJHJmj/hNnO+ZafdyW7HMqRFKCyZ+X/fLjPeH7HNpPgKPtgBgba2XCyNTg8WyU8opHgTABUa09Fm0Z0D+tuTDwn3QBM092nPhVfc+umLj2mUmJHXy/ZRNTEqsF3zvC5swGqtO228XYZ7PCs+n3NgshtsgPZEqPtmj96Sy5lI0V2t5Q0K4O34NEhdCskO3uMWDr/1NnmOGmeOCJehGrN5qyb1p11hVn2E9lvK0DYSMCwb1DGeI6AbRPlBrrcVOb X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(136003)(39860400002)(346002)(396003)(376002)(46966005)(47076004)(7696005)(36756003)(2616005)(316002)(44832011)(86362001)(1076003)(6916009)(6666004)(70586007)(70206006)(2906002)(54906003)(478600001)(8676002)(4326008)(5660300002)(356005)(26005)(336012)(186003)(426003)(8936002)(82740400003)(83380400001)(82310400003)(81166007);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2862 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: c3ca4a43-3e04-4d64-3a97-08d85f05c1a6 X-Microsoft-Antispam-Message-Info: 4DcWTi3uSYzQRN+3rXsFMM+M0PfqNOeleKogbNp1TKibdOnZpjM36agfCbzNORMbEkABqrSm9koQXu6CsoSsugJBsM26Bdd/vnCAx25PT9lyiDakGFmUZS/y5UFL7eaI4iCh6uv+A9PcquC5u3IHZzVrZaNs5/F51sAVBG1vAc8CZGVnnaIyUeyoT+9gwf0XRTBNBQ7N8bOaXXOUFja5vPA8L/3TCoG7trKMSqQuBmfDVI4pLsgF3Za7ibaExL5V8sy5Zxk2BqmIC7BcL1VZDlP5OIyVfCSMxSY58Nj3AOwS4IusYEF5htkh67TfV6Z1/VEvt2IorBO/06l/LdjPCzwR151W8KI+0GOEqsorRfu3MUeIOH2ORhiczc0nWJDp7EMms55Eo8jyrvn/As0NzQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2020 14:43:19.0837 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8dcf8b06-87dc-476c-fa27-08d85f05d8ee X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5082 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: pcC7hxOiPvBoJ989P5qvbtTrx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1600785804; bh=X/BxzQE+jQT4WchfCmzDuJ8xBFoZqwKkPHEqc+iil78=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=UZD861MKah0pYEsbYr9UsWfz5E+/jLScx2Aeu/1LIUTSWZUsGf18Q/XFK4/RV+ei5c6 6XSTsc15zhB5Fav2lHbK91jQqZBGJnVE9NetJXyrIH18z5cN3F2s1vmxqiGzGerbDepls Xyw6IZDUR1gsILBAdaxZMbE3t5vpiI6Wvvw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reordered the asserts to first check if the pointer is valid before de-referencing the pointer. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortG= enerator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/Ssd= tSerialPortGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPo= rtLibArm/SsdtSerialPortGenerator.c index 2197e50dc714707f7ed7cc37759d3dba5a45f0e0..a705d771be1a2d59c4b0f645269= eb838ff605a1a 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerial= PortGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerial= PortGenerator.c @@ -90,10 +90,10 @@ FreeSsdtSerialPortTableEx ( UINTN Index; =20 ASSERT (This !=3D NULL); + ASSERT (AcpiTableInfo !=3D NULL); + ASSERT (CfgMgrProtocol !=3D NULL); ASSERT (AcpiTableInfo->TableGeneratorId =3D=3D This->GeneratorID); ASSERT (AcpiTableInfo->AcpiTableSignature =3D=3D This->AcpiTableSignatur= e); - ASSERT (CfgMgrProtocol !=3D NULL); - ASSERT (AcpiTableInfo !=3D NULL); =20 if ((Table =3D=3D NULL) || (*Table =3D=3D NULL) || --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65451): https://edk2.groups.io/g/devel/message/65451 Mute This Topic: https://groups.io/mt/77014348/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 20:21:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65450+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1600785802512339.65366378382566; Tue, 22 Sep 2020 07:43:22 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id qHUoYY1788612xWGIesEp5YN; Tue, 22 Sep 2020 07:43:22 -0700 X-Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.58]) by mx.groups.io with SMTP id smtpd.web10.175.1600785800715687345 for ; Tue, 22 Sep 2020 07:43:21 -0700 X-Received: from DB6PR07CA0181.eurprd07.prod.outlook.com (2603:10a6:6:42::11) by VI1PR08MB4255.eurprd08.prod.outlook.com (2603:10a6:803:100::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14; Tue, 22 Sep 2020 14:43:17 +0000 X-Received: from DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:42:cafe::d) by DB6PR07CA0181.outlook.office365.com (2603:10a6:6:42::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.4 via Frontend Transport; Tue, 22 Sep 2020 14:43:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+65450+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT010.mail.protection.outlook.com (10.152.20.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:43:16 +0000 X-Received: ("Tessian outbound a0bffebca527:v64"); Tue, 22 Sep 2020 14:43:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 43eb02c42570c08e X-CR-MTA-TID: 64aa7808 X-Received: from 9bf59975822a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 17F2CEC7-757C-4D17-BB49-AD53277E3591.1; Tue, 22 Sep 2020 14:42:48 +0000 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9bf59975822a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Sep 2020 14:42:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K0AX5dAkKDtZHUYUPDHCXmweYcfUqhF4lEmHF6NN6f1B/Evs9Pi9rI5f3th4bQDrHwwwil/HNd7ZakOkKVNoH+YIuLe/jVvkMKu05S6lh7A8KHyGryYs9e7tNDyKa61wZzhZlpQyGF8FE2NKA+VhJYRZcgplwDVHUkH8QCfSOB4CIdFSx5QCMNFj1hESid73njYk/r0qKMr97b+UdQaYIRbOaKhykerm2bPYLGsB45opOLjnsLdEVixsM7zJCtdt3nlf6r1LZkA6q1uc+xjiK24fxnC4+EwYVulJvS2FmrZQ8OLmuLazoIbob6Nd3lVmIKMtoBXwRTCFJmZjDOiBwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a92Y7kPENP8QaRYBGPe7q2mB5PhmJ8fsj0qQ+JAmoCs=; b=I/We/9prnHpw831kZuwfXpLGmbrqPtvUb8SckTvX8VuC/LVBGlVkkWxMtLgDx9gnJAsKXCZsanzfnIWA1kyhqEXk7lc+EbgI+TPXAmq/DBRsRFCXPKYQVoJDcpiGAz3GvtOnC0gxQ2IZ7dCFD9S/346NDtqFmVU1nHqH1DVnbjxdi3SpM7BEF4yPuAhBPYI4Pqg9zx8TgTppduyN28lKFMJweRQqHZY5jRzfTJG/l3WDU/YMw3YtF0Nfnh7Kj8wUsBey5cBwJtq3+ZLFDcpIpH889zcbYS1jQT3/ifP/HqM2BlEB++yCkioFIZ+XG/beDHv2FfJJ9uVDCmX3SshUwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM5PR0101CA0034.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::47) by DB6PR08MB2629.eurprd08.prod.outlook.com (2603:10a6:6:22::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Tue, 22 Sep 2020 14:42:40 +0000 X-Received: from VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:16:cafe::94) by AM5PR0101CA0034.outlook.office365.com (2603:10a6:206:16::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.13 via Frontend Transport; Tue, 22 Sep 2020 14:42:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT039.mail.protection.outlook.com (10.152.19.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:42:39 +0000 X-Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2044.4; Tue, 22 Sep 2020 14:42:37 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Tue, 22 Sep 2020 14:42:37 +0000 X-Received: from E107187.Arm.com (10.57.47.90) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Tue, 22 Sep 2020 14:42:36 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v1 2/7] DynamicTablesPkg: SsdtSerialPortLibArm fix ECC error Date: Tue, 22 Sep 2020 15:42:30 +0100 Message-ID: <20200922144235.76292-3-sami.mujawar@arm.com> In-Reply-To: <20200922144235.76292-1-sami.mujawar@arm.com> References: <20200922144235.76292-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7b0d0d37-b26c-4c7b-4901-08d85f05d78f X-MS-TrafficTypeDiagnostic: DB6PR08MB2629:|VI1PR08MB4255: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MMO1EJz1Hf/7vVcorEZn1o65IbTRXe5OUFu8bmE04MgghXXYQY1u8hj5VG9uTbYnerUqk0EKNJTKjSZD/P+Pdi55/1h9MBz9pfSDHiQ5qI7E2s0DO2KUvITrMQa69UlPDhkGpiW+eKujpCqrmlHZO1sAIYxaP4z75KfuUjtCk8CQJ/B4qFEENqwVMN68WjXXuoh3SGjHS8GBPUgzbq8VRfPgfqffj9U48wGNzP6ruYqluKiHUA3Xx0Cc/w1vVE1Z32d3FKStGMJ7d0kd7E/d6Pqzy8B4QG6ZV+7RvbzbmjYStoTVdkEMYQdP3omJ7ifuTEcPG3nH4Zk5HCrf/Dz/28zR6DBC6GlEGiMJzPl6c/3aQ1y82F/SRCxYEfgH+1Y3sFbcFktyLFSgTK6j1KKfLEJF0pjgxDlQ/6GZFFO/2/A= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(136003)(396003)(376002)(346002)(39860400002)(46966005)(83380400001)(86362001)(44832011)(8936002)(6666004)(54906003)(2616005)(82740400003)(478600001)(356005)(81166007)(47076004)(36756003)(26005)(82310400003)(70206006)(8676002)(316002)(5660300002)(70586007)(336012)(426003)(4326008)(6916009)(2906002)(1076003)(186003)(7696005)(213903007);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2629 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 55a8ce23-4b3b-4336-9966-08d85f05c13c X-Microsoft-Antispam-Message-Info: AOL2jbwfkwUtga3MpP9qWIamkVvVmOlMVbANe9nyTXTW44whOOyagaOzxo73wWdnnvdtUZgUUjOXad996m7/RiTQyxsppYxHKtJJJA/oaxQiB+uZRFDX5z0M/XE9+O7cwtu984Tk4JMOGyTsgeUHgbinbYmXaHCNOtwSCa7wKXcDkLZu+2vcd69ylyMNfaxfpKkSxL23MBQ+5lgOoFbqgJiE+1UdzeU6N5EZRdzO8pIJnqqlVMp5o14Kowt2mHQ1DJoFZxN1AW4LHPOWVX5KqqHKWBCJmColBX73da8HewkmWgyYWAF3Vh+/Twdb1B+8F+wnKht65g+nq/EvTJwtlFT6wVgvkhQt3QmyFRHh1sY9oQLdS7bYkxKkiHDX0cnoE0AoZVYmrnwTQKplcfGqsZIbdHAAuoSlnCQql+ec8DE= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2020 14:43:16.8832 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7b0d0d37-b26c-4c7b-4901-08d85f05d78f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4255 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: xcnmZff1BI622Hm0dZChbmzZx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1600785802; bh=Fm3NGHeaTqTXPBhvfCPKHi27pQ8tP1mt69dvg2OuhE0=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=evp6Jf/rzixCOH9KmoI5CTEUf8/oD2xu9PQU+bc54SdzA4uqro+sg9zehCzFNBr7eHf QnMp/jx8GU164yw1UAvjt96ziMcgBCiqQanhayYEgjsYQivto9udz6yezmAp5+oyc97G5 xr7Mz+urSOeCKYhQcJupYcLBAkjLjwhlRaY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix the following ECC reported error in SsdtSerialPortLibArm. - [5007] There should be no initialization of a variable as part of its declaration Variable Name. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortG= enerator.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/Ssd= tSerialPortGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPo= rtLibArm/SsdtSerialPortGenerator.c index a705d771be1a2d59c4b0f645269eb838ff605a1a..6a1e7487dfaf4ceb2e074e52cef= 2fc30bfce7152 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerial= PortGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerial= PortGenerator.c @@ -171,7 +171,7 @@ BuildSsdtSerialPortTableEx ( CM_ARM_SERIAL_PORT_INFO * SerialPortInfo; UINT32 SerialPortCount; UINTN Index; - CHAR8 NewName[] =3D "COMx"; + CHAR8 NewName[5]; UINT64 Uid; EFI_ACPI_DESCRIPTION_HEADER ** TableList; =20 @@ -243,6 +243,10 @@ BuildSsdtSerialPortTableEx ( // can be done in case of failure. *Table =3D TableList; =20 + NewName[0] =3D 'C'; + NewName[1] =3D 'O'; + NewName[2] =3D 'M'; + NewName[4] =3D '\0'; for (Index =3D 0; Index < SerialPortCount; Index++) { Uid =3D SERIAL_PORT_START_UID + Index; NewName[3] =3D AsciiFromHex ((UINT8)(Uid)); --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65450): https://edk2.groups.io/g/devel/message/65450 Mute This Topic: https://groups.io/mt/77014347/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 20:21:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65453+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1600785805694152.01930449277916; Tue, 22 Sep 2020 07:43:25 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 5np9YY1788612xXDgfefrxUG; Tue, 22 Sep 2020 07:43:25 -0700 X-Received: from FRA01-PR2-obe.outbound.protection.outlook.com (FRA01-PR2-obe.outbound.protection.outlook.com [40.107.12.88]) by mx.groups.io with SMTP id smtpd.web11.145.1600785804270708712 for ; Tue, 22 Sep 2020 07:43:24 -0700 X-Received: from DB6P191CA0019.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::29) by PR2PR08MB4731.eurprd08.prod.outlook.com (2603:10a6:101:18::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.17; Tue, 22 Sep 2020 14:43:20 +0000 X-Received: from DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:28:cafe::7) by DB6P191CA0019.outlook.office365.com (2603:10a6:6:28::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14 via Frontend Transport; Tue, 22 Sep 2020 14:43:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+65453+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT005.mail.protection.outlook.com (10.152.20.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:43:20 +0000 X-Received: ("Tessian outbound 7161e0c2a082:v64"); Tue, 22 Sep 2020 14:43:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2dcc3bbc76469430 X-CR-MTA-TID: 64aa7808 X-Received: from f27f2b23cc2e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CF5EC899-55AE-4A62-82BB-AF576D1EEF7A.1; Tue, 22 Sep 2020 14:42:42 +0000 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f27f2b23cc2e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Sep 2020 14:42:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cOk5OuakZ0jjGGn/4fNadbxu44Aq/b1ADd+KkzTG6f5BvuN1Yi01RpSKaF4yn/tGPbpvH/U08Abr6HgD2+6fWbFYFEgNULpyFqrnGoa68T4JvPoBfivo9axzPM/NHRsOPgVGnmUrpONS7UJC7kh3GhgKZQ5A6Mw3kV72BRwTqA92IrrPd9v41jE9Lxyvd6+DCFw/45hBZfjMLD9kUtyEX79lEY+ENo8cn66iNJzcXIqDMHTZmsKi125xZWrGJJfW+6uTXUWF9sB/rX1tngJllr666Ccn3kOfwGD5Pnk5DJCJgQAvI3o9iVKhUjxARRPOlDwrv9jUmxb8HW/aJFpFZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L9JLMMoB2/xZqfrNuP1ExQ2tkR5Qbus11f7lCQVEM6A=; b=LJW/SVFiYan2t8/LsPSV0lGrn+cq1IForajgzYCeXmpS04jKc+7gSWTBGnM0S6L5QVs3uqGmisb1tUD5X+CwJT4CfVWUtfNwIYyIU1XP+tUf9niZNTX04Hy4cKVv5HUIa7mVcP8f29gFtr2eRtDDMXnsNUzs7l8ZTvSSG4jnzQZ2ph9rhTbojGzRUbW3xZK+pOkVAmLI0wbJN4zlTGthQh2LIKt7OKLkH+N3ZidY1VCHoTW5PVmKRumrhUJlA0+pQNFhk9FYbmmwrznUCemFtW1rjWyeaeqJjDngdt9AG1YiYHAbQNRVVig6SaDdozuBpTeF3EJuEaQUTyIkDN24nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from DB6PR07CA0098.eurprd07.prod.outlook.com (2603:10a6:6:2c::12) by VE1PR08MB4941.eurprd08.prod.outlook.com (2603:10a6:803:112::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.13; Tue, 22 Sep 2020 14:42:41 +0000 X-Received: from DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2c:cafe::d) by DB6PR07CA0098.outlook.office365.com (2603:10a6:6:2c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.4 via Frontend Transport; Tue, 22 Sep 2020 14:42:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT006.mail.protection.outlook.com (10.152.20.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:42:41 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Tue, 22 Sep 2020 14:42:37 +0000 X-Received: from E107187.Arm.com (10.57.47.90) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Tue, 22 Sep 2020 14:42:37 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v1 3/7] DynamicTablesPkg: AcpiSratLibArm fix ECC error Date: Tue, 22 Sep 2020 15:42:31 +0100 Message-ID: <20200922144235.76292-4-sami.mujawar@arm.com> In-Reply-To: <20200922144235.76292-1-sami.mujawar@arm.com> References: <20200922144235.76292-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 59ff350f-feeb-44a3-37db-08d85f05d97d X-MS-TrafficTypeDiagnostic: VE1PR08MB4941:|PR2PR08MB4731: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:3383;OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7o7+SCXkqoYg8TSMFRw6xIaQM0ao8deihu5/v4EPLpeSkLFo+D1s8WB0O5sqn9BL9e0FMlE+BLTU2AULxMBzORaF8sSCsWx0f0XUOifP6MQlcgkR4EqRMf2Gqhv576uOb0qWjP47ppW+KviVWWd2kmAJ0ReRNc1dB/N0Ot51dWb1VidXFnoeLh4GQfy24KTiByafVUoJ4u1XCLL+n7LszUFFQyIIdIjbSq1WtgEP5qmUxgur42/mZ3CKnnL+u72I/gtncgo+5gN51/gf+dTP3J80goR95P81ovTSH+3OYL6NdKdSjxCUn8W3V61gQeQgfKO+lKad6xbHnhc8nG00ze/T7ebdclQzfIt2dq75AmRfR/KNqqk8czLeqb8vQAcYTHwwTuhiRrhOQ6mq0RqKPw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(39840400004)(396003)(376002)(136003)(346002)(46966005)(4326008)(186003)(6916009)(6666004)(83380400001)(70206006)(70586007)(5660300002)(7696005)(82310400003)(8676002)(44832011)(1076003)(86362001)(47076004)(54906003)(81166007)(316002)(356005)(426003)(478600001)(8936002)(2616005)(336012)(26005)(36756003)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4941 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a14e696a-5336-4023-9051-08d85f05c26d X-Microsoft-Antispam-Message-Info: c09AzKPDArXFF8HVw+4ooEmkG0r0LuGem2a85z+h362TJSDnSgpOs+sMj/KyYerDAnCIDR9OVoXOwPIF6Ti/aFfS3pY7esBfNP0RVJzVQz1sU0hrqiot5Kp+1dqiiXRUy7fTVjzeEUQqGEBYa9BIiJ4L+gq1i06xSiEMi0qctBnRPKzh6snk+Gec7rGyRoQ6JyKcxVA3EByYD7FOgyu5c1FdDGYMmuROYY2vmpOnEZ6wxA0f8vm41NL+26jQU2RatBxifkN/rkFD9cRQLRoVShJFpxJ9+BWtYLziaxjqMi1DRG48AHlebg7UH1K1ED/QufX54N06mHBT2QPGZcZZOthxCmggc5vdAwvWgGjYbsoiFyIoYcv4imlva43pouWwjK6sui5HW3Bkc1rkJ6j3BQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2020 14:43:20.1192 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59ff350f-feeb-44a3-37db-08d85f05d97d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4731 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: AOzsOpzHDErJni8vHg2QNd05x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1600785805; bh=BTGx5hnY69rcZfXHILE/f6wLed97xm8mCj2HuQaKyQA=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=n+5Y4I4RQIzEVCkvFt96rbs6bSFEWrtgiTtiyPqGFOGAiaeo6m0+rVbMkMRFamUPonI 3rVN1UfHO9rWPQLJTftj57i07pupY1DjyMVV4Ac7CiURVYaSyQfGvmXT7/WE+HZA2n+PW HXWsdSLr2a05gDPo/zRP3wD1H7o/Z/kNOWY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix the following ECC reported error in AcpiSratLibArm. - [9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 Comment does NOT have tail **/ Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c index 6844bb40eb02e994bb6a4edfaf25689685ca01fc..453ca49fcd737ac236e276c81c4= 0abb0db784205 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c @@ -1,7 +1,7 @@ /** @file SRAT Table Generator =20 - Copyright (c) 2019 - 2020, ARM Limited. All rights reserved. + Copyright (c) 2019 - 2020, Arm Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 @par Reference(s): @@ -107,7 +107,7 @@ GET_OBJECT_LIST ( @param [in] DeviceHandlePci Pointer to the PCI Device Handle. =20 @retval BDF value corresponding to the PCI Device Handle. -*/ +**/ STATIC UINT16 GetBdf ( --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65453): https://edk2.groups.io/g/devel/message/65453 Mute This Topic: https://groups.io/mt/77014350/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 20:21:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65448+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 160078580107142.31602516408884; Tue, 22 Sep 2020 07:43:21 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ImOsYY1788612xRttNUBRFSa; Tue, 22 Sep 2020 07:43:20 -0700 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.66]) by mx.groups.io with SMTP id smtpd.web12.163.1600785799275508948 for ; Tue, 22 Sep 2020 07:43:19 -0700 X-Received: from MR2P264CA0003.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1::15) by HE1PR0802MB2474.eurprd08.prod.outlook.com (2603:10a6:3:e2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Tue, 22 Sep 2020 14:43:15 +0000 X-Received: from VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:1:cafe::66) by MR2P264CA0003.outlook.office365.com (2603:10a6:500:1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.19 via Frontend Transport; Tue, 22 Sep 2020 14:43:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+65448+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT052.mail.protection.outlook.com (10.152.19.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:43:14 +0000 X-Received: ("Tessian outbound e8cdb8c6f386:v64"); Tue, 22 Sep 2020 14:43:14 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4999a56da1a3e1e6 X-CR-MTA-TID: 64aa7808 X-Received: from a365adf861ef.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1512535B-9FE5-408F-9DE6-192C7B206C1F.1; Tue, 22 Sep 2020 14:42:48 +0000 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a365adf861ef.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Sep 2020 14:42:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V2ZXd+nODbr7pNZEZxPYirG7AWhLcA/bgFBt+H0toaUcmOaiy3AZ/Bo0jgAMSH4LDoSfuVsBXc4EWSshAphzqy05SkE1o5atKEZNZXn4cSe2xZgffdLdCjjZzIyCjlxjt/ziI4MWyiM2t7QvmM7brZtb2B0DR25kigw3GdXNOQ9Tm3jjRVXvGVqg0SI88DSAdNgE1+QATVarTTdAxpQtTL1yIV6inBe0kCPMJGjPJRaMbK70JXUXQ5JVtxZL0LSTjHthbXhtW6gk+PzifG/LPMEjztRrms+vMU9SgIaIn5wydG4MYK5OBf+EKrYXni3VZH6dqpmNMfjMV3r/w+kZ/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Wszz1QC2KXkU6zVqIRieLjKIwDFE2GncJoVU/HKyiA=; b=cssuAC/dr+ezTTOGiOeGQHTTKQImO0UsboSzbB9aXIxDiKj/xHPrV/axVKPi6FqwcufIgWFX6UB8NTDu2EUgcrwn5uvWeClfn8DoYpGvdmtH4RWAaPxW4Qqbhk+inSpCU4uuwfkcINQLCvIUIZ8q32W2+kL9Wzf9Uit4G0N7QB7H6cmFFl4mDJeicgGKqo2nt7LIpG7dJEtfNh5CZlsWTaI2FHws3p1eVJFRld7j3MSY/10WIkcuMpPx6gVEHQEUN44bd1BHfAM9zrjLXU/LGGWMYmdPqFDnfNxbBzPaJS1wtdagFSNLnrZc9vYjF5/31tUF6teIEVM0bPcaXFY8NA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from DB6PR0202CA0004.eurprd02.prod.outlook.com (2603:10a6:4:29::14) by VI1PR08MB3567.eurprd08.prod.outlook.com (2603:10a6:803:79::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Tue, 22 Sep 2020 14:42:46 +0000 X-Received: from DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:29:cafe::fd) by DB6PR0202CA0004.outlook.office365.com (2603:10a6:4:29::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14 via Frontend Transport; Tue, 22 Sep 2020 14:42:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT042.mail.protection.outlook.com (10.152.21.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:42:46 +0000 X-Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2044.4; Tue, 22 Sep 2020 14:42:38 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Tue, 22 Sep 2020 14:42:38 +0000 X-Received: from E107187.Arm.com (10.57.47.90) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Tue, 22 Sep 2020 14:42:37 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v1 4/7] DynamicTablesPkg: AmlLib fix ECC errors Date: Tue, 22 Sep 2020 15:42:32 +0100 Message-ID: <20200922144235.76292-5-sami.mujawar@arm.com> In-Reply-To: <20200922144235.76292-1-sami.mujawar@arm.com> References: <20200922144235.76292-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a318ebb0-8d77-4f00-a293-08d85f05d62e X-MS-TrafficTypeDiagnostic: VI1PR08MB3567:|HE1PR0802MB2474: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:5797;OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fOhIEO4iqrGJyxp/On+nmCPIwuuve/T3KUkGl02SFSThWhmo8TIR76D6JDXFGfvHr78hb8kF52cvftKVw1GC9Xu4OY0oGnd9VFmvr1ygsGxxTfG5RzB8OGvqIhQocAVRmkESHBA0IKO/59I81/Ab28kJ2/7XQ6Zpz1myh96x1XqF8lLJfMF1DfXIpO2uBGdSIWaWUlQSQh86WHzEZ+rD4a76nI3C6SCEuuLcRVe8QM1V/JTj5QTTETjQo7pDTZXXAA6Sfg37IjnyjtrwKs9WuRdL38iygf+rKkGD62tXVlB0FveRB7wsNPDNl6aWsgK3UEfATfaShCP0nsmOqZnG20dUQFqrDH8bI3N4b3jW8K4i0afKD6m+q592HQjZVz0FgEsRTv8mhd9mm6TUrQlJnQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(396003)(136003)(346002)(39860400002)(376002)(46966005)(7696005)(26005)(8936002)(82310400003)(356005)(81166007)(336012)(316002)(5660300002)(2616005)(426003)(2906002)(44832011)(86362001)(186003)(4326008)(6666004)(6916009)(1076003)(8676002)(54906003)(70206006)(70586007)(19627235002)(83380400001)(478600001)(47076004)(36756003)(82740400003);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3567 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d63adad9-d4ad-48be-24ed-08d85f05c55b X-Microsoft-Antispam-Message-Info: Itgfv7sL8HSrGuuS6qtpGahkhEOcjRGGIreDhUIcco8tt3UBYP9EKR4X1NjgAMIpdJUezsVllS0jWTEf1Rxu8wUGBgci5ryfhesYN/EvTWzF2oiCwOE8T40sCRDDNZdnBZdaqeweC3Ci5qRRc5CMET4k02IMG+i1oJWM1YlSv1ORPpN+Q747qBgzxDnszGTaNI8tzmk9Vt9bTqOKfOZxyjeg5V6NwHyrjHc6XuYl/sqRT7wacft7RAgSh1qEZTioD07KF/ISk11hYa3/BcGDpHDcWLVRi4CX1kw82FRC2brQz87fAnsL+pGjlBXHtZ3WoEkymXr1ZNBIWD9FvrsSD3K0zmWQZQ1YThdwNX6pmAC+dIY6F65ax2b6SrZAvkFLbREAED5r+98YwslFTGdmuA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2020 14:43:14.4321 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a318ebb0-8d77-4f00-a293-08d85f05d62e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2474 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: nE7S5lt9jSsIIzavBBqobSUdx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1600785800; bh=tVi2eKxnOQGsJ1Fqvr/7q780YXmF9+T/4Q8ZXBcJnkM=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=MIOstMtGkeq2k+X2UhpC09AEI9Z1hJSnqMg8Ol0C7zj+UxrSZyDLeztTF4iysVNNyd/ 3nb6rRWvio/CCcLH/YMuNuempRCHKUTkdsPEo8lpvhRrvbsFoGZD51JAnelaCX+iecwy7 TORWcPdaaymn0yWRk3OIOHRLETLLxoIyjbs= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Fix the following ECC reported errors in AmlLib. - [1008] File has invalid Non-ACSII char. - [9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 Comment does NOT have tail **/ Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c | = 4 ++-- DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | = 2 +- DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c | = 2 +- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c | = 4 ++-- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c | = 6 +++--- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | = 6 +++--- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataParser.c | = 2 +- DynamicTablesPkg/Library/Common/AmlLib/Stream/AmlStream.c | = 4 ++-- DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c | = 6 +++--- DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlTree.c | = 2 +- 10 files changed, 19 insertions(+), 19 deletions(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/= DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c index d6d9f5dfe839aa8ef79153459ec9d2c2ffe72316..5d310f201319d94ffe6405aeeec= 65a7038a76c57 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c @@ -33,7 +33,7 @@ EFIAPI LinkNode ( IN AML_OBJECT_NODE * Node, IN AML_NODE_HEADER * ParentNode, - IN AML_OBJECT_NODE ** NewObjectNode + OUT AML_OBJECT_NODE ** NewObjectNode ) { EFI_STATUS Status; @@ -71,7 +71,7 @@ LinkNode ( @param[in] OemId 6-character string OEM identifier. @param[in] OemTableId 8-character string OEM table identifier. @param[in] OemRevision OEM revision number. - @param[out] DefinitionBlockTerm The ASL Term handle representing a + @param[out] NewRootNode Pointer to the root node representing a Definition Block. =20 @retval EFI_SUCCESS Success. diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceData= CodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC= odeGen.c index 9e7a508e60721558ab59b375dbd526c7066d7329..d40a27410dd6fee8264b9c53e67= f7ea67d97fcf0 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c @@ -40,7 +40,7 @@ EFIAPI LinkRdNode ( IN AML_DATA_NODE * RdNode, IN AML_OBJECT_NODE * ParentNode, - IN AML_DATA_NODE ** NewRdNode + OUT AML_DATA_NODE ** NewRdNode ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.= c b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c index dc373748903dd55fa4492874329f2b433c698c02..30d31572d379028a28d532c1709= 2bef585959a50 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c @@ -674,7 +674,7 @@ AmlAddPrefix ( =20 @retval EFI_SUCCESS The function completed successfully. @retval EFI_INVALID_PARAMETER Invalid parameter. -*/ +**/ STATIC EFI_STATUS EFIAPI diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListPars= er.c b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c index c25ee22dc7c4b22b1448e11cf9bbd4e5e77c4316..b9403efe3ca6f44712c91203c27= 410ec15eb3011 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c @@ -41,7 +41,7 @@ @retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_OUT_OF_RESOURCES Could not allocate memory. -*/ +**/ STATIC EFI_STATUS EFIAPI @@ -177,7 +177,7 @@ AmlParseFieldElement ( @retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_OUT_OF_RESOURCES Could not allocate memory. -*/ +**/ STATIC EFI_STATUS EFIAPI diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.= c b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c index bc98d950b579dec3243dab355a711a56dca978ea..4797fa11edebc35628ef9c07a1f= effff6b14a204 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c @@ -1320,7 +1320,7 @@ AmlCreateMethodInvocationNode ( // DefExternal :=3D ExternalOp NameString ObjectType ArgumentCount // ExternalOp :=3D 0x15 // ObjectType :=3D ByteData - // ArgumentCount :=3D ByteData (0 =E2=80=93 7) + // ArgumentCount :=3D ByteData (0 - 7) =20 // Read the ArgumentCount. ArgCountNode =3D (AML_DATA_NODE*)FixedArgs[EAmlParseIndexTerm2]; @@ -1334,7 +1334,7 @@ AmlCreateMethodInvocationNode ( // MethodInvocation :=3D MethodInvocationOp NameString ArgumentCount // MethodInvocationOp :=3D Pseudo Opcode for Method Invocation // NameString :=3D Method Name - // ArgumentCount :=3D ByteData (0 =E2=80=93 7) + // ArgumentCount :=3D ByteData (0 - 7) Status =3D AmlCreateObjectNode ( AmlGetByteEncodingByOpCode (AML_METHOD_INVOC_OP, 0), 0, @@ -1411,7 +1411,7 @@ error_handler: @retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_OUT_OF_RESOURCES Could not allocate memory. -*/ +**/ EFI_STATUS EFIAPI AmlGetMethodInvocationArgCount ( diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c b/Dy= namicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c index 380ac9bbcebef01d1d1f5dbd01971992aaf66d89..4f6623de02d519e5345955603d0= ce3f1056e4f17 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c @@ -1134,7 +1134,7 @@ AmlParseVariableArguments ( @retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_OUT_OF_RESOURCES Could not allocate memory. -*/ +**/ STATIC EFI_STATUS EFIAPI @@ -1179,7 +1179,7 @@ AmlPopulateRootNode ( @retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_OUT_OF_RESOURCES Could not allocate memory. -*/ +**/ STATIC EFI_STATUS EFIAPI @@ -1287,7 +1287,7 @@ AmlPopulateObjectNode ( @retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_OUT_OF_RESOURCES Could not allocate memory. -*/ +**/ STATIC EFI_STATUS EFIAPI diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataP= arser.c b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataPars= er.c index 09fb3e72586c3f31ce6d90f049e77a041330ba18..0f41c68b283794a577c551b0320= afc5b6dcf55d7 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataParser.c @@ -213,7 +213,7 @@ AmlRdIsResourceDataBuffer ( return TRUE; } =20 - // TODO Might want to check the CRC when available. + // @todo Might want to check the CRC when available. // An end tag resource data element must be the last element of the li= st. // Thus the function should have already returned. if (AmlRdCompareDescId ( diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Stream/AmlStream.c b/Dy= namicTablesPkg/Library/Common/AmlLib/Stream/AmlStream.c index 419e796e50cbe29e62234916c6e39c2c625a2951..08ee959475dd26b72c90598daa5= 3db639b075928 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Stream/AmlStream.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Stream/AmlStream.c @@ -52,7 +52,7 @@ AmlStreamInit ( in the ClonedStream. =20 @param [in] Stream Pointer to the stream to clone. - @param [in] ClonedStream Pointer to the stream to initialize. + @param [out] ClonedStream Pointer to the stream to initialize. =20 @retval EFI_SUCCESS The function completed successfully. @retval EFI_INVALID_PARAMETER Invalid parameter. @@ -97,7 +97,7 @@ AmlStreamClone ( =20 @param [in] Stream Pointer to the stream from which a sub-stream = is created. - @param [in] SubStream Pointer to the stream to initialize. + @param [out] SubStream Pointer to the stream to initialize. =20 @retval EFI_SUCCESS The function completed successfully. @retval EFI_INVALID_PARAMETER Invalid parameter. diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c b/Dynami= cTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c index 2c80440a447ad261290a2cf84a8edd3434cf9e5e..3740c0ac7bb8d2697bc1597dc10= 30d8276e6f565 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c @@ -464,7 +464,7 @@ AmlNodeCompareOpCode ( =20 @retval TRUE The Node is an integer node. @retval FALSE Otherwise. -*/ +**/ BOOLEAN EFIAPI IsIntegerNode ( @@ -499,7 +499,7 @@ IsIntegerNode ( =20 @retval TRUE The Node is a ZeroOp or OneOp. @retval FALSE Otherwise. -*/ +**/ BOOLEAN EFIAPI IsSpecialIntegerNode ( @@ -556,7 +556,7 @@ AmlIsMethodDefinitionNode ( // DefExternal :=3D ExternalOp NameString ObjectType ArgumentCount // ExternalOp :=3D 0x15 // ObjectType :=3D ByteData - // ArgumentCount :=3D ByteData (0 =E2=80=93 7) + // ArgumentCount :=3D ByteData (0 - 7) ObjectType =3D (AML_DATA_NODE*)AmlGetFixedArgument ( (AML_OBJECT_NODE*)Node, EAmlParseIndexTerm1 diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlTree.c b/Dynami= cTablesPkg/Library/Common/AmlLib/Tree/AmlTree.c index 65dad95da2760c512563a5152ba4acf42d555019..0931e751709e27ad4f0b4c583d8= b058ce06f5bf7 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlTree.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlTree.c @@ -41,7 +41,7 @@ AmlGetParent ( =20 @return The root node of the tree. NULL if error. -*/ +**/ AML_ROOT_NODE * EFIAPI AmlGetRootNode ( --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65448): https://edk2.groups.io/g/devel/message/65448 Mute This Topic: https://groups.io/mt/77014344/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 20:21:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65447+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1600785802048869.0704484233453; Tue, 22 Sep 2020 07:43:22 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id oNmoYY1788612xJUqngZizEN; Tue, 22 Sep 2020 07:43:21 -0700 X-Received: from EUR03-DB5-obe.outbound.protection.outlook.com (EUR03-DB5-obe.outbound.protection.outlook.com [40.107.4.47]) by mx.groups.io with SMTP id smtpd.web11.141.1600785799024316301 for ; Tue, 22 Sep 2020 07:43:19 -0700 X-Received: from DB6PR07CA0104.eurprd07.prod.outlook.com (2603:10a6:6:2c::18) by DB7PR08MB3641.eurprd08.prod.outlook.com (2603:10a6:10:4e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19; Tue, 22 Sep 2020 14:43:16 +0000 X-Received: from DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2c:cafe::f9) by DB6PR07CA0104.outlook.office365.com (2603:10a6:6:2c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.9 via Frontend Transport; Tue, 22 Sep 2020 14:43:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+65447+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT006.mail.protection.outlook.com (10.152.20.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:43:16 +0000 X-Received: ("Tessian outbound 7a6fb63c1e64:v64"); Tue, 22 Sep 2020 14:43:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: be53d787b3ab46db X-CR-MTA-TID: 64aa7808 X-Received: from 31d1669ad0e6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 007B440A-70A7-4FC9-8269-150791E2C372.1; Tue, 22 Sep 2020 14:42:49 +0000 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 31d1669ad0e6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Sep 2020 14:42:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h+cu9z4FVvMJx6Ixy7kxyGHLYhpBPalijXhDY7NlQMoPeZEUD2sVRJGk60o/kXrNoDyNhuCV4taxumEC27UVrUmp5GqogNCeYQ0Qo9jzTu6/xOl0UYa0Ws9UMo0S4kNhYEmVWzRhq2lz4RARJiRy8p3o5EscTEjF7yzk82demVZIvdb3fsgcdImTSY0cCVqHWc/Sx389gfxGKm6430Yayk2YkbTWneiw6zV+x9LQl5XgeH6KmW/1QLyLU+GuOd7UuQRZl/8r3AzdmhbaHWhvLUt4Ovmp8YTDoQFkrmim6iEzIQZ/L0tSZF2Uanlek6zVpArsGfBn+kI7x3ZXL8ruSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rx3DVtP9hkCesDfPl394VNQM5QymaU0YBgjCCojdOMU=; b=Rq2F4iF5fa5krLM+uUI/peivYbwiCKPlylSKb8c+HKVCZPOFFr59s8UhM2nVYgCzdlPuTd6xx6ZHa1gQGfrEswKJnO2shbyYAcy5zGKELYAlNruXvLF+Bg57x57dm4a0X+6VFsEnkpZg0/IAQYRal1xCN91V57nxtMrLlVR4pqDtLk+nL1Du6R2r0dJE7hbvus1K47G+59GYpqyDAzP8NQxS1BLWugZTvtPllVbz7j+hL0MAME7CwTJ9I9sOfniPs8u1xYF8KPF3IbGFMqa41tSoE+KL16xD8rRa8mKw49yBzBP/g1EIAfLS+t9Y5WMYFl6ybT3GOg3vxKCPG9wqwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from DB6PR0202CA0007.eurprd02.prod.outlook.com (2603:10a6:4:29::17) by AM0PR08MB4532.eurprd08.prod.outlook.com (2603:10a6:208:145::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19; Tue, 22 Sep 2020 14:42:47 +0000 X-Received: from DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:29:cafe::5f) by DB6PR0202CA0007.outlook.office365.com (2603:10a6:4:29::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.13 via Frontend Transport; Tue, 22 Sep 2020 14:42:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT042.mail.protection.outlook.com (10.152.21.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:42:47 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Tue, 22 Sep 2020 14:42:38 +0000 X-Received: from E107187.Arm.com (10.57.47.90) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Tue, 22 Sep 2020 14:42:38 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v1 5/7] DynamicTablesPkg: AmlLib\AmlDbgPrint fix ECC error Date: Tue, 22 Sep 2020 15:42:33 +0100 Message-ID: <20200922144235.76292-6-sami.mujawar@arm.com> In-Reply-To: <20200922144235.76292-1-sami.mujawar@arm.com> References: <20200922144235.76292-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aefc40be-3e7c-460d-c4a8-08d85f05d74f X-MS-TrafficTypeDiagnostic: AM0PR08MB4532:|DB7PR08MB3641: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PBMxqXXJDwqPRZW8CJptI9w+pyuAvamUizc422GSLGHWATvr7TebSQ1ROpXKTLwdVrNWQkx0b2o+yqV0nrm2Gf0cfWXApjIZaS8bNUsPrqINSkhZH+INo+7fPJ91Qrqa0ByxKG9rDjqlRS46LPVwt7F3Z7Ti3vGYMx5/y1mkV/m3EY6U3UXMhsdDBZuCGhkIHV0Fl1S95TZi0fVAGde2EmbAliQBpzLHC8lWVaqgoeLSfq6CLUDT+fizeVZhHkqOsElaL/nbu3sv+IxhUG3RN1O1YuAHOpddoSEG1O1zSj+3HA14X1B1L/3V522JYMHvt0NBgYxadgFFPrUfY8Q8NjLImNS8Sg2hgaaGT4bB6uXdNhRN0MxmusB02gcuS45VVcDqvHp3QQWCSl6jlZTR2u+/04unf+8SClXKfG7QMT88hALKVQKNcTRo9JOAfutF X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(396003)(136003)(39840400004)(346002)(376002)(46966005)(2906002)(6666004)(70206006)(86362001)(7696005)(36756003)(82310400003)(30864003)(4326008)(70586007)(54906003)(5660300002)(26005)(8936002)(2616005)(336012)(83380400001)(426003)(8676002)(356005)(47076004)(6916009)(186003)(478600001)(81166007)(1076003)(316002)(44832011);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4532 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d0ded04a-482a-4b7d-da55-08d85f05c61a X-Microsoft-Antispam-Message-Info: Ck6F/2S7twtPjRpR3avK7V1jjsKsyntMoPiWcCFYpjGE9z+yfyajjQ0ydK9fVBoyQYxfJOLVvii+teR57TzckKii+QQNC18s3JF0NRTB08C43liG8aXNDADpZDxQZmUzsqHYs0Jsa5z5o5Td4HJi9s0myHlBFD2OC9i9WQIHg+kAepsIRdRi02oq3n2MRLoKlTO30bNoHOqv7Id3NbA6uJGv5X6oc5GXXHxMLSHIpFsHOIDyO/jcZDcMzQQx7NByMsBx1A/E4KidmEJ6g7tSqipiRKV/t31D+rEcBanmE3xjlbUbT67GO9MN7+vqH8FkBVO+ySPcKS64gnST7ciZIEgrv931Rd0QpHXSXKMlavRt7Wfa9CcKhzafp7uuaSBvYToODdlwPolwBQtoDnT7SQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2020 14:43:16.4659 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aefc40be-3e7c-460d-c4a8-08d85f05d74f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3641 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: kwVY6E67DnTP4aH0exqKawbjx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1600785801; bh=WBAMpQkJXoHSwivWNGGvcoVMdj50he+hbt4gQo0gI8c=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=thC28574E6SWQyYCLQGgLuhpUcYF2vNI992JOZJK4yoS7Cze+YZ1DhfRZyOuMwl31m2 m2kk6GaNQHPwp00PtScVLt3knvOYjZ7e9cMe6HQvuNkkCN6/TWVMuo+Zdgm91r/QGJSj3 Kj0Mo8agAKGdsWdQ6sLir7HfYAgrb+9CLFQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix ECC error 8001 reported errors in AmlDbgPrint. [8001] Only capital letters are allowed to be used for #define declarations. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 1= + DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.c | 10= ++--- DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.h | 40= ++++++++++++++++---- DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c | 4= +- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c | 4= +- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c | 10= ++--- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | 14= +++---- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataParser.c | 2= +- 8 files changed, 55 insertions(+), 30 deletions(-) diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml b/DynamicTablesPkg/D= ynamicTablesPkg.ci.yaml index c0d09e79fdf7f6003b5bbda45abc82a0caf4e53f..ecb05f06fb2b0b8c79c359294de= 3f91f3e46a5e1 100644 --- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml +++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml @@ -71,6 +71,7 @@ "ExtendWords": [ "ARMHB", # ARMHB000 "ARMLTD", + "AMLDBG", "EISAID", "CCIDX", "CCSIDR", diff --git a/DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint= .c b/DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.c index 7b11cc8e994903b3a9d2dcfd1241b8a447759717..00a61a2fe63a1ac060cd1bd2ed3= f438ca66177ee 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.c @@ -163,11 +163,11 @@ AmlDbgPrintNameString ( } =20 if (SegCount !=3D 0) { - AmlDbgPrintNameSeg (Buffer); + AMLDBG_PRINT_NAMESEG (Buffer); Buffer +=3D AML_NAME_SEG_SIZE; for (Index =3D 0; Index < SegCount - 1; Index++) { DEBUG ((DEBUG_INFO, ".")); - AmlDbgPrintNameSeg (Buffer); + AMLDBG_PRINT_NAMESEG (Buffer); Buffer +=3D AML_NAME_SEG_SIZE; } } @@ -232,7 +232,7 @@ AmlDbgPrintDataNode ( =20 if ((DataNode->DataType =3D=3D EAmlNodeDataTypeNameString) || (DataNode->DataType =3D=3D EAmlNodeDataTypeString)) { - AmlDbgPrintChars ( + AMLDBG_PRINT_CHARS ( DEBUG_INFO, (CONST CHAR8*)DataNode->Buffer, DataNode->Size @@ -316,7 +316,7 @@ AmlDbgPrintObjectNode ( DEBUG ((DEBUG_INFO, "0x%08x | ", ObjectNode->AmlByteEncoding->Attribute)= ); DEBUG ((DEBUG_INFO, "0x%04x | ", ObjectNode->PkgLen)); if (AmlNodeHasAttribute (ObjectNode, AML_IN_NAMESPACE)) { - AmlDbgPrintNameString ( + AMLDBG_PRINT_NAMESTR ( AmlNodeGetName ((CONST AML_OBJECT_NODE*)ObjectNode), FALSE ); @@ -488,7 +488,7 @@ AmlDbgPrintTree ( **/ VOID EFIAPI -DumpRaw ( +AmlDbgDumpRaw ( IN CONST UINT8 * Ptr, IN UINT32 Length ) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint= .h b/DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.h index 68f4c7416948a20484b6d5448c231add3f1186dd..e0d527262eb2c6fbd8111f29e95= 8b022443ffdc1 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.h +++ b/DynamicTablesPkg/Library/Common/AmlLib/AmlDbgPrint/AmlDbgPrint.h @@ -45,7 +45,7 @@ **/ VOID EFIAPI -DumpRaw ( +AmlDbgDumpRaw ( IN CONST UINT8 * Ptr, IN UINT32 Length ); @@ -133,21 +133,45 @@ AmlDbgPrintNameSpace ( IN AML_ROOT_NODE_HANDLE RootNode ); =20 +/* Macros to encapsulate Aml Debug Print APIs. +*/ + +#define AMLDBG_DUMP_RAW(Ptr, Length) \ + AmlDbgDumpRaw (Ptr, Length) + +#define AMLDBG_PRINT_CHARS(ErrorLevel, Buffer, Size) \ + AmlDbgPrintChars (ErrorLevel, Buffer, Size) + +#define AMLDBG_PRINT_NAMESEG(Buffer) \ + AmlDbgPrintNameSeg (Buffer) + +#define AMLDBG_PRINT_NAMESTR(Buffer,NewLine) \ + AmlDbgPrintNameString (Buffer,NewLine) + +#define AMLDBG_PRINT_NODE(Node) \ + AmlDbgPrintNode (Node) + +#define AMLDBG_PRINT_TREE(Node) \ + AmlDbgPrintTree (Node) + +#define AMLDBG_PRINT_NAMESPACE(RootNode) \ + AmlDbgPrintNameSpace (RootNode) + #else =20 -#define DumpRaw(Ptr, Length) +#define AMLDBG_DUMP_RAW(Ptr, Length) =20 -#define AmlDbgPrintChars(ErrorLevel, Buffer, Size) +#define AMLDBG_PRINT_CHARS(ErrorLevel, Buffer, Size) =20 -#define AmlDbgPrintNameSeg(Buffer) +#define AMLDBG_PRINT_NAMESEG(Buffer) =20 -#define AmlDbgPrintNameString(Buffer,NewLine) +#define AMLDBG_PRINT_NAMESTR(Buffer,NewLine) =20 -#define AmlDbgPrintNode(Node) +#define AMLDBG_PRINT_NODE(Node) =20 -#define AmlDbgPrintTree(Node) +#define AMLDBG_PRINT_TREE(Node) =20 -#define AmlDbgPrintNameSpace(RootNode) +#define AMLDBG_PRINT_NAMESPACE(RootNode) =20 #endif // MDEPKG_NDEBUG =20 diff --git a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.= c b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c index 30d31572d379028a28d532c17092bef585959a50..2d055e9fb9645766a2f769b4aa3= 04e91c2602107 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c @@ -1140,13 +1140,13 @@ AmlEnumeratePathCallback ( "Comparing search path with current node path.\n" )); DEBUG ((DEBUG_VERBOSE, "Search path:")); - AmlDbgPrintChars ( + AMLDBG_PRINT_CHARS ( DEBUG_VERBOSE, (CHAR8*)AmlStreamGetCurrPos (SearchPathBStream), AmlStreamGetIndex (SearchPathBStream) ); DEBUG ((DEBUG_VERBOSE, "\nPath of the current node: ")); - AmlDbgPrintChars ( + AMLDBG_PRINT_CHARS ( DEBUG_VERBOSE, (CHAR8*)AmlStreamGetCurrPos (CurrNodePathBStream), AmlStreamGetIndex (CurrNodePathBStream) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListPars= er.c b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c index b9403efe3ca6f44712c91203c27410ec15eb3011..24460f9c8007a900a77f42ba8f7= 18fd8fd5fbeab 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c @@ -82,7 +82,7 @@ AmlParseFieldElement ( } =20 // Skip the field opcode (1 byte) as it is already in the FieldByteEncod= ing. - DumpRaw (CurrPos, 1); + AMLDBG_DUMP_RAW (CurrPos, 1); Status =3D AmlStreamProgress (FStream, 1); if (EFI_ERROR (Status)) { ASSERT (0); @@ -106,7 +106,7 @@ AmlParseFieldElement ( } =20 // Move stream forward as the PkgLen has been read. - DumpRaw (CurrPos, PkgLenOffset); + AMLDBG_DUMP_RAW (CurrPos, PkgLenOffset); Status =3D AmlStreamProgress (FStream, PkgLenOffset); if (EFI_ERROR (Status)) { ASSERT (0); diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.= c b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c index 4797fa11edebc35628ef9c07a1feffff6b14a204..53e91dd6278bcfb5d0be9ff2c9a= 04db6d39ab57c 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c @@ -173,7 +173,7 @@ AmlDbgPrintNameSpaceRefList ( while (CurrLink !=3D NameSpaceRefList) { CurrNameSpaceNode =3D (AML_NAMESPACE_REF_NODE*)CurrLink; =20 - AmlDbgPrintChars ( + AMLDBG_PRINT_CHARS ( DEBUG_INFO, CurrNameSpaceNode->RawAbsolutePath, CurrNameSpaceNode->RawAbsolutePathSize @@ -749,7 +749,7 @@ AmlFindMethodDefinition ( } =20 DEBUG ((DEBUG_VERBOSE, "AmlMethodParser: Checking absolute name: ")); - AmlDbgPrintChars ( + AMLDBG_PRINT_CHARS ( DEBUG_VERBOSE, (CONST CHAR8*)AmlStreamGetCurrPos (RawAbsolutePathFStream), AmlStreamGetMaxBufferSize (RawAbsolutePathFStream) @@ -768,7 +768,7 @@ AmlFindMethodDefinition ( ProbedNameSpaceRefNode =3D (AML_NAMESPACE_REF_NODE*)NextLink; =20 // Print the raw absolute path of the probed node. - AmlDbgPrintChars ( + AMLDBG_PRINT_CHARS ( DEBUG_VERBOSE, ProbedNameSpaceRefNode->RawAbsolutePath, ProbedNameSpaceRefNode->RawAbsolutePathSize @@ -1067,7 +1067,7 @@ AmlIsMethodInvocation ( DEBUG_VERBOSE, "AmlMethodParser: Corresponding method definition: " )); - AmlDbgPrintChars ( + AMLDBG_PRINT_CHARS ( DEBUG_VERBOSE, NameSpaceRefNode->RawAbsolutePath, NameSpaceRefNode->RawAbsolutePathSize @@ -1230,7 +1230,7 @@ AmlAddNameSpaceReference ( DEBUG_VERBOSE, "AmlMethodParser: Adding namespace reference with name:\n" )); - AmlDbgPrintChars ( + AMLDBG_PRINT_CHARS ( DEBUG_VERBOSE, (CONST CHAR8*)AmlStreamGetCurrPos (&RawAbsolutePathBStream), AmlStreamGetIndex (&RawAbsolutePathBStream) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c b/Dy= namicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c index 4f6623de02d519e5345955603d0ce3f1056e4f17..e3b9f249058fee10a14a40a7311= 59cb3c878957c 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c @@ -182,7 +182,7 @@ AmlParseUIntX ( return Status; } =20 - DumpRaw (AmlStreamGetCurrPos (FStream), UIntXSize); + AMLDBG_DUMP_RAW (AmlStreamGetCurrPos (FStream), UIntXSize); =20 // Move stream forward by the size of UIntX. Status =3D AmlStreamProgress (FStream, UIntXSize); @@ -266,7 +266,7 @@ AmlParseNameString ( return Status; } =20 - DumpRaw (AmlStreamGetCurrPos (FStream), StrSize); + AMLDBG_DUMP_RAW (AmlStreamGetCurrPos (FStream), StrSize); =20 // Move the stream forward by StrSize. Status =3D AmlStreamProgress (FStream, StrSize); @@ -335,7 +335,7 @@ AmlParseString ( StrSize++; } while (Byte !=3D '\0'); =20 - DumpRaw (Buffer, StrSize); + AMLDBG_DUMP_RAW (Buffer, StrSize); =20 Status =3D AmlCreateDataNode ( AmlTypeToNodeDataType (ExpectedFormat), @@ -441,7 +441,7 @@ AmlParseObject ( } =20 // Print the opcode. - DumpRaw (Buffer, OpCodeSize); + AMLDBG_DUMP_RAW (Buffer, OpCodeSize); =20 if (!IS_END_OF_STREAM (FStream)) { // 3. Parse the PkgLength field, if present. @@ -454,7 +454,7 @@ AmlParseObject ( } =20 // Print the package length. - DumpRaw (Buffer, PkgOffset); + AMLDBG_DUMP_RAW (Buffer, PkgOffset); =20 // Adjust the size of the stream if it is valid package length. FreeSpace =3D AmlStreamGetFreeSpace (FStream); @@ -559,7 +559,7 @@ AmlParseFieldPkgLen ( return Status; } =20 - DumpRaw (Buffer, PkgOffset); + AMLDBG_DUMP_RAW (Buffer, PkgOffset); =20 Status =3D AmlStreamProgress (FStream, PkgOffset); if (EFI_ERROR (Status)) { @@ -844,7 +844,7 @@ AmlParseByteList ( return Status; } =20 - DumpRaw (Buffer, BufferSize); + AMLDBG_DUMP_RAW (Buffer, BufferSize); =20 // Move the stream forward as we have consumed the Buffer. Status =3D AmlStreamProgress (FStream, BufferSize); diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataP= arser.c b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataPars= er.c index 0f41c68b283794a577c551b0320afc5b6dcf55d7..7f78ed51bf2ef2acdd1c2448b2a= f8b9facfdf5a7 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataParser.c @@ -310,7 +310,7 @@ AmlParseResourceData ( return Status; } =20 - DumpRaw (CurrRdElement, CurrRdElementSize); + AMLDBG_DUMP_RAW (CurrRdElement, CurrRdElementSize); =20 // Exit the loop when finding the resource data end tag. if (AmlRdCompareDescId ( --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65447): https://edk2.groups.io/g/devel/message/65447 Mute This Topic: https://groups.io/mt/77014342/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 20:21:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65454+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1600785806663701.6265624260269; Tue, 22 Sep 2020 07:43:26 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ILpLYY1788612xONfvfRot6r; Tue, 22 Sep 2020 07:43:26 -0700 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.86]) by mx.groups.io with SMTP id smtpd.web12.165.1600785804638518213 for ; Tue, 22 Sep 2020 07:43:25 -0700 X-Received: from AM6PR02CA0024.eurprd02.prod.outlook.com (2603:10a6:20b:6e::37) by DB8PR08MB4057.eurprd08.prod.outlook.com (2603:10a6:10:a5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14; Tue, 22 Sep 2020 14:43:17 +0000 X-Received: from VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::42) by AM6PR02CA0024.outlook.office365.com (2603:10a6:20b:6e::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14 via Frontend Transport; Tue, 22 Sep 2020 14:43:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+65454+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT054.mail.protection.outlook.com (10.152.19.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:43:16 +0000 X-Received: ("Tessian outbound 195a290eb161:v64"); Tue, 22 Sep 2020 14:43:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b35e58a2c5af2634 X-CR-MTA-TID: 64aa7808 X-Received: from f9fc8f710033.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 05C0EB16-42E6-4557-AF36-B94E2496BE8E.1; Tue, 22 Sep 2020 14:42:56 +0000 X-Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f9fc8f710033.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Sep 2020 14:42:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HQ0dqHwiTGblQQlQbUSLUBX18TDZ/J2sEZ9/X35EXHm1bJXn6HfDLCRoLXUgUwE+XvW3RLmDys/Qr8Hj5A0ow7jiEMGgWB8qANKRY3Xxwban85FLIKXBP2NCHzybhlsxKHzqYebM6YsqNZrZoMYnPk5e7lkFFeSpmXyjMT4I22ft4faqKpkevny11ZobBQfnnAYFvpEmk+jy8B5nzkfdGqXYQrlrXIqdyH4Oifn32EAX8JwgQp6pnVkKPXMLQ5SmmUQSo1uWCp7D6M5qwBQ8QTxcmJZaLKkMHBBdgZEvrpPSHUT38vjtIg9GtbOPBUMnpupcDG9OMrVKU6Ba0v5UCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PYr1RdTKcr9l+ctwihnENouhe/CAJMTbLN/ym2S53pE=; b=efoFpxlx85uFEEOPrWTKb/IG4fTt6cbSDGdFFCIL5Jykl+AD3c2j3qpMwFE0p1DycIRKiYtu9o57tGH22o+w5q8zSBxn9AxxnKeQl8sci0kaUCWJ4VqaFG1OnaTl/yaufXmmHHFwBBAtV14LKRzVMYOVw5pEfVkZ/GiGfQcJ/P1A8QO8PTXkpTXzvLu+NgBQ4uAVBbTLg9BKC3Qh6Y6OZ5bd/D42dD+O8I/M18OrDCm9VWdQcFWLua/l2uRQQa8a5kkcPve9FnCk/KOkKbVF6DYQ61Po9h4EplbAWNoEYpkA+YcLFDOLUeeUMF3A1oMC9ECwuzWli7WxheMJg4kVhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from DB6PR0202CA0012.eurprd02.prod.outlook.com (2603:10a6:4:29::22) by VI1PR08MB3424.eurprd08.prod.outlook.com (2603:10a6:803:88::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.17; Tue, 22 Sep 2020 14:42:48 +0000 X-Received: from DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:29:cafe::67) by DB6PR0202CA0012.outlook.office365.com (2603:10a6:4:29::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14 via Frontend Transport; Tue, 22 Sep 2020 14:42:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT042.mail.protection.outlook.com (10.152.21.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:42:48 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Tue, 22 Sep 2020 14:42:39 +0000 X-Received: from E107187.Arm.com (10.57.47.90) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Tue, 22 Sep 2020 14:42:39 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v1 6/7] DynamicTablesPkg: AmlEncoding change debug macro Date: Tue, 22 Sep 2020 15:42:34 +0100 Message-ID: <20200922144235.76292-7-sami.mujawar@arm.com> In-Reply-To: <20200922144235.76292-1-sami.mujawar@arm.com> References: <20200922144235.76292-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d34b2159-6eb0-43d5-cc3d-08d85f05d797 X-MS-TrafficTypeDiagnostic: VI1PR08MB3424:|DB8PR08MB4057: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:7219;OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DN1o4jctSJOfE07UwS9wclnOASZsB22ETOSOzau2dyj74Sb5WLX7w3avKLDGf41F/MTJPk9O41FvLCoqgT3dYSPsIpuPWP0NgKauvedgMn/yXY0S8mzWJSfEz15We6oyNecf1FPc3QSgN8/ecH1JV4nYvRb5f6qvMHjs0Q+mMlWQbeMZn8M9J9PCLBNorR7Lfx591OwmluwFrB+mcvhIiaeVrSXv5AjbBcoRvNXKC3/870qFn1DZM3Md/viuDrtOb2i8AFJUTiSs4Q0dvjApchBWgM2WLsFpGiiJuJwpK5i02xx4vNA34DcQB1u5ngQ3Fdv/MowXQ/vDTfvPr97B2bzUCmKlgpLH18oOsjobYzTcfTxB9XbJJ8emtQUyfBVdjq2ui7W6VTivD4ucqu9ejw== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(346002)(396003)(136003)(39860400002)(376002)(46966005)(82310400003)(478600001)(81166007)(7696005)(6666004)(2616005)(1076003)(54906003)(82740400003)(47076004)(36756003)(86362001)(30864003)(5660300002)(70586007)(2906002)(83380400001)(4326008)(6916009)(44832011)(336012)(186003)(356005)(8936002)(316002)(70206006)(26005)(8676002)(426003)(559001)(579004);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3424 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: eff8c207-d930-4c48-c362-08d85f05c6dd X-Microsoft-Antispam-Message-Info: B6xyYjlSl8/m7HnhfMzFcFUPcePIpoSaI1yn3fiWd52TvZIR4S9NJB30ejFijj+nakr2QZvaxly/MQbBXFCJseFQxsdEAh8b1B+WhClfvJu6FmgdPOKAYR7BCOmvsRk8sUUZDAt0Izr6KAgjlihbUTlgYDq8VEH511J/IhyskP3Kg97G3MsQTAyNInj9DiNO7zXP9krYCu5U/HJz6CSGQSGrJrL8YTiOa0aEuyVoLadSIVliLa+OGz3Yo2zHADKVoF6lca7iqbi64HqNyiaYzWjePGJKFWHpgGd4XvtnHTVwEHKLqYcMfOvl6f6jq0wn00IHtYJfcst+bvTRbFN7410svuP1pd1PvfrevA/5KBmMyLZ8+vEIiu6Y9etrq0RAMpaeJMwXT66WbpwN7bAWFA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2020 14:43:16.7937 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d34b2159-6eb0-43d5-cc3d-08d85f05d797 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4057 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: iFcbVM2uU7oCXTPcRXqBcr4Nx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1600785806; bh=RIMimvAMyBT9PctLYls3OXsPPKyVuS0ewiuMgDKruUs=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=xJmrTBoi6Yn24TaUsNZnOWifUyOCb2imkbr2KGRUyn+10fHa5eq0PP0MBUBPGaIeUbX 8Qyt5JRSpHojGmcF9CiRj2CAxqOL6HsamkgmlqH9c+cEE7rAykRrfLeuZR7q0VXjTB0Bu 8oTxkOsukWj3HbYRTtcHybIVnbGsahN6+x4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change the AML_DEBUG_STR() macro to AML_OPCODE_DEF() that takes a string and the AML OpCode as input so that the text description and the AML OpCode are grouped. The AML_OPCODE_DEF() macro also strips the string description for release builds. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- DynamicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.c | 304 ++++++++++-= --------- DynamicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.h | 4 +- 2 files changed, 154 insertions(+), 154 deletions(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.c b/Dyn= amicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.c index 780bdea67f6035023f0ee995095e50f0ae35f810..eadafca97ea5c0e84718923c329= 7ada828593666 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.c @@ -82,152 +82,152 @@ GLOBAL_REMOVE_IF_UNREFERENCED STATIC CONST AML_BYTE_ENCODING mAmlByteEncoding[] =3D { - // Comment Str OpCode = SubOpCode MaxIndex NameIndex 0 1= 2 3 4 5 = Attribute - /* 0x00 */ {AML_DEBUG_STR ("ZeroOp") AML_ZERO_OP, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x01 */ {AML_DEBUG_STR ("OneOp") AML_ONE_OP, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x06 */ {AML_DEBUG_STR ("AliasOp") AML_ALIAS_OP, = 0, 2, 1, {EAmlName, E= AmlName, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IN_NAMESPACE}, - /* 0x08 */ {AML_DEBUG_STR ("NameOp") AML_NAME_OP, = 0, 2, 0, {EAmlName, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IN_NAMESPACE}, - /* 0x0A */ {AML_DEBUG_STR ("BytePrefix") AML_BYTE_PREFIX, = 0, 1, 0, {EAmlUInt8, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x0B */ {AML_DEBUG_STR ("WordPrefix") AML_WORD_PREFIX, = 0, 1, 0, {EAmlUInt16, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x0C */ {AML_DEBUG_STR ("DWordPrefix") AML_DWORD_PREFIX,= 0, 1, 0, {EAmlUInt32, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x0D */ {AML_DEBUG_STR ("StringPrefix") AML_STRING_PREFIX= , 0, 1, 0, {EAmlString, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x0E */ {AML_DEBUG_STR ("QWordPrefix") AML_QWORD_PREFIX,= 0, 1, 0, {EAmlUInt64, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x10 */ {AML_DEBUG_STR ("ScopeOp") AML_SCOPE_OP, = 0, 1, 0, {EAmlName, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ | AML_IN_NAMESPACE}, - /* 0x11 */ {AML_DEBUG_STR ("BufferOp") AML_BUFFER_OP, = 0, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_HAS_PKG_LENGTH | AML_HAS_BYTE_LIST}, - /* 0x12 */ {AML_DEBUG_STR ("PackageOp") AML_PACKAGE_OP, = 0, 1, 0, {EAmlUInt8, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ}, - /* 0x13 */ {AML_DEBUG_STR ("VarPackageOp") AML_VAR_PACKAGE_O= P, 0, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ}, - /* 0x14 */ {AML_DEBUG_STR ("MethodOp") AML_METHOD_OP, = 0, 2, 0, {EAmlName, E= AmlUInt8, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ | AML_IN_NAMESPACE}, - /* 0x15 */ {AML_DEBUG_STR ("ExternalOp") AML_EXTERNAL_OP, = 0, 3, 0, {EAmlName, E= AmlUInt8, EAmlUInt8, EAmlNone, EAmlNone, EAml= None}, AML_IN_NAMESPACE}, - /* 0x2E */ {AML_DEBUG_STR ("DualNamePrefix") AML_DUAL_NAME_PRE= FIX, 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x2F */ {AML_DEBUG_STR ("MultiNamePrefix") AML_MULTI_NAME_PR= EFIX, 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x41 */ {AML_DEBUG_STR ("NameChar_A") 'A', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x42 */ {AML_DEBUG_STR ("NameChar_B") 'B', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x43 */ {AML_DEBUG_STR ("NameChar_C") 'C', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x44 */ {AML_DEBUG_STR ("NameChar_D") 'D', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x45 */ {AML_DEBUG_STR ("NameChar_E") 'E', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x46 */ {AML_DEBUG_STR ("NameChar_F") 'F', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x47 */ {AML_DEBUG_STR ("NameChar_G") 'G', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x48 */ {AML_DEBUG_STR ("NameChar_H") 'H', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x49 */ {AML_DEBUG_STR ("NameChar_I") 'I', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x4A */ {AML_DEBUG_STR ("NameChar_J") 'J', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x4B */ {AML_DEBUG_STR ("NameChar_K") 'K', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x4C */ {AML_DEBUG_STR ("NameChar_L") 'L', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x4D */ {AML_DEBUG_STR ("NameChar_M") 'M', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x4E */ {AML_DEBUG_STR ("NameChar_N") 'N', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x4F */ {AML_DEBUG_STR ("NameChar_O") 'O', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x50 */ {AML_DEBUG_STR ("NameChar_P") 'P', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x51 */ {AML_DEBUG_STR ("NameChar_Q") 'Q', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x52 */ {AML_DEBUG_STR ("NameChar_R") 'R', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x53 */ {AML_DEBUG_STR ("NameChar_S") 'S', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x54 */ {AML_DEBUG_STR ("NameChar_T") 'T', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x55 */ {AML_DEBUG_STR ("NameChar_U") 'U', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x56 */ {AML_DEBUG_STR ("NameChar_V") 'V', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x57 */ {AML_DEBUG_STR ("NameChar_W") 'W', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x58 */ {AML_DEBUG_STR ("NameChar_X") 'X', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x59 */ {AML_DEBUG_STR ("NameChar_Y") 'Y', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x5A */ {AML_DEBUG_STR ("NameChar_Z") 'Z', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x5B 0x01 */ {AML_DEBUG_STR ("MutexOp") AML_EXT_OP, = AML_EXT_MUTEX_OP, 2, 0, {EAmlName, E= AmlUInt8, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IN_NAMESPACE}, - /* 0x5B 0x02 */ {AML_DEBUG_STR ("EventOp") AML_EXT_OP, = AML_EXT_EVENT_OP, 1, 0, {EAmlName, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IN_NAMESPACE}, - /* 0x5B 0x12 */ {AML_DEBUG_STR ("CondRefOfOp") AML_EXT_OP, = AML_EXT_COND_REF_OF_OP, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x13 */ {AML_DEBUG_STR ("CreateFieldOp") AML_EXT_OP, = AML_EXT_CREATE_FIELD_OP,4, 3, {EAmlObject, E= AmlObject, EAmlObject, EAmlName, EAmlNone, EAml= None}, AML_IN_NAMESPACE}, - /* 0x5B 0x1F */ {AML_DEBUG_STR ("LoadTableOp") AML_EXT_OP, = AML_EXT_LOAD_TABLE_OP, 6, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlObject, EAmlObject, EAml= Object}, 0}, - /* 0x5B 0x20 */ {AML_DEBUG_STR ("LoadOp") AML_EXT_OP, = AML_EXT_LOAD_OP, 2, 0, {EAmlName, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x21 */ {AML_DEBUG_STR ("StallOp") AML_EXT_OP, = AML_EXT_STALL_OP, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x22 */ {AML_DEBUG_STR ("SleepOp") AML_EXT_OP, = AML_EXT_SLEEP_OP, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x23 */ {AML_DEBUG_STR ("AcquireOp") AML_EXT_OP, = AML_EXT_ACQUIRE_OP, 2, 0, {EAmlObject, E= AmlUInt16, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x24 */ {AML_DEBUG_STR ("SignalOp") AML_EXT_OP, = AML_EXT_SIGNAL_OP, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x25 */ {AML_DEBUG_STR ("WaitOp") AML_EXT_OP, = AML_EXT_WAIT_OP, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x26 */ {AML_DEBUG_STR ("ResetOp") AML_EXT_OP, = AML_EXT_RESET_OP, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x27 */ {AML_DEBUG_STR ("ReleaseOp") AML_EXT_OP, = AML_EXT_RELEASE_OP, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x28 */ {AML_DEBUG_STR ("FromBCDOp") AML_EXT_OP, = AML_EXT_FROM_BCD_OP, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x29 */ {AML_DEBUG_STR ("ToBCDOp") AML_EXT_OP, = AML_EXT_TO_BCD_OP, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x2A */ {AML_DEBUG_STR ("UnloadOp") AML_EXT_OP, = AML_EXT_UNLOAD_OP, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x30 */ {AML_DEBUG_STR ("RevisionOp") AML_EXT_OP, = AML_EXT_REVISION_OP, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x31 */ {AML_DEBUG_STR ("DebugOp") AML_EXT_OP, = AML_EXT_DEBUG_OP, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x32 */ {AML_DEBUG_STR ("FatalOp") AML_EXT_OP, = AML_EXT_FATAL_OP, 3, 0, {EAmlUInt8, E= AmlUInt32, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x33 */ {AML_DEBUG_STR ("TimerOp") AML_EXT_OP, = AML_EXT_TIMER_OP, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x5B 0x80 */ {AML_DEBUG_STR ("OpRegionOp") AML_EXT_OP, = AML_EXT_REGION_OP, 4, 0, {EAmlName, E= AmlUInt8, EAmlObject, EAmlObject, EAmlNone, EAml= None}, AML_IN_NAMESPACE}, - /* 0x5B 0x81 */ {AML_DEBUG_STR ("FieldOp") AML_EXT_OP, = AML_EXT_FIELD_OP, 2, 0, {EAmlName, E= AmlUInt8, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_HAS_PKG_LENGTH | AML_HAS_FIELD_LIST}, - /* 0x5B 0x82 */ {AML_DEBUG_STR ("DeviceOp") AML_EXT_OP, = AML_EXT_DEVICE_OP, 1, 0, {EAmlName, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ | AML_IN_NAMESPACE}, - /* 0x5B 0x83 */ {AML_DEBUG_STR ("ProcessorOp") AML_EXT_OP, = AML_EXT_PROCESSOR_OP, 4, 0, {EAmlName, E= AmlUInt8, EAmlUInt32, EAmlUInt8, EAmlNone, EAml= None}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ | AML_IN_NAMESPACE}, - /* 0x5B 0x84 */ {AML_DEBUG_STR ("PowerResOp") AML_EXT_OP, = AML_EXT_POWER_RES_OP, 3, 0, {EAmlName, E= AmlUInt8, EAmlUInt16, EAmlNone, EAmlNone, EAml= None}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ | AML_IN_NAMESPACE}, - /* 0x5B 0x85 */ {AML_DEBUG_STR ("ThermalZoneOp") AML_EXT_OP, = AML_EXT_THERMAL_ZONE_OP,1, 0, {EAmlName, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ | AML_IN_NAMESPACE}, - /* 0x5B 0x86 */ {AML_DEBUG_STR ("IndexFieldOp") AML_EXT_OP, = AML_EXT_INDEX_FIELD_OP, 3, 0, {EAmlName, E= AmlName, EAmlUInt8, EAmlNone, EAmlNone, EAml= None}, AML_HAS_PKG_LENGTH | AML_HAS_FIELD_LIST}, - /* 0x5B 0x87 */ {AML_DEBUG_STR ("BankFieldOp") AML_EXT_OP, = AML_EXT_BANK_FIELD_OP, 4, 0, {EAmlName, E= AmlName, EAmlObject, EAmlUInt8, EAmlNone, EAml= None}, AML_HAS_PKG_LENGTH | AML_HAS_FIELD_LIST}, - /* 0x5B 0x88 */ {AML_DEBUG_STR ("DataRegionOp") AML_EXT_OP, = AML_EXT_DATA_REGION_OP, 4, 0, {EAmlName, E= AmlObject, EAmlObject, EAmlObject, EAmlNone, EAml= None}, AML_IN_NAMESPACE}, - /* 0x5C */ {AML_DEBUG_STR ("RootChar") AML_ROOT_CHAR, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x5E */ {AML_DEBUG_STR ("ParentPrefixChar") AML_PARENT_PREFIX= _CHAR, 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x5F */ {AML_DEBUG_STR ("NameChar") '_', = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_NAME_CHAR}, - /* 0x60 */ {AML_DEBUG_STR ("Local0Op") AML_LOCAL0, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x61 */ {AML_DEBUG_STR ("Local1Op") AML_LOCAL1, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x62 */ {AML_DEBUG_STR ("Local2Op") AML_LOCAL2, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x63 */ {AML_DEBUG_STR ("Local3Op") AML_LOCAL3, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x64 */ {AML_DEBUG_STR ("Local4Op") AML_LOCAL4, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x65 */ {AML_DEBUG_STR ("Local5Op") AML_LOCAL5, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x66 */ {AML_DEBUG_STR ("Local6Op") AML_LOCAL6, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x67 */ {AML_DEBUG_STR ("Local7Op") AML_LOCAL7, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x68 */ {AML_DEBUG_STR ("Arg0Op") AML_ARG0, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x69 */ {AML_DEBUG_STR ("Arg1Op") AML_ARG1, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x6A */ {AML_DEBUG_STR ("Arg2Op") AML_ARG2, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x6B */ {AML_DEBUG_STR ("Arg3Op") AML_ARG3, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x6C */ {AML_DEBUG_STR ("Arg4Op") AML_ARG4, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x6D */ {AML_DEBUG_STR ("Arg5Op") AML_ARG5, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x6E */ {AML_DEBUG_STR ("Arg6Op") AML_ARG6, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x70 */ {AML_DEBUG_STR ("StoreOp") AML_STORE_OP, = 0, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x71 */ {AML_DEBUG_STR ("RefOfOp") AML_REF_OF_OP, = 0, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x72 */ {AML_DEBUG_STR ("AddOp") AML_ADD_OP, = 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x73 */ {AML_DEBUG_STR ("ConcatOp") AML_CONCAT_OP, = 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x74 */ {AML_DEBUG_STR ("SubtractOp") AML_SUBTRACT_OP, = 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x75 */ {AML_DEBUG_STR ("IncrementOp") AML_INCREMENT_OP,= 0, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x76 */ {AML_DEBUG_STR ("DecrementOp") AML_DECREMENT_OP,= 0, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x77 */ {AML_DEBUG_STR ("MultiplyOp") AML_MULTIPLY_OP, = 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x78 */ {AML_DEBUG_STR ("DivideOp") AML_DIVIDE_OP, = 0, 4, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlObject, EAmlNone, EAml= None}, 0}, - /* 0x79 */ {AML_DEBUG_STR ("ShiftLeftOp") AML_SHIFT_LEFT_OP= , 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x7A */ {AML_DEBUG_STR ("ShiftRightOp") AML_SHIFT_RIGHT_O= P, 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x7B */ {AML_DEBUG_STR ("AndOp") AML_AND_OP, = 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x7C */ {AML_DEBUG_STR ("NAndOp") AML_NAND_OP, = 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x7D */ {AML_DEBUG_STR ("OrOp") AML_OR_OP, = 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x7E */ {AML_DEBUG_STR ("NorOp") AML_NOR_OP, = 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x7F */ {AML_DEBUG_STR ("XOrOp") AML_XOR_OP, = 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x80 */ {AML_DEBUG_STR ("NotOp") AML_NOT_OP, = 0, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x81 */ {AML_DEBUG_STR ("FindSetLeftBitOp") AML_FIND_SET_LEFT= _BIT_OP, 0, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x82 */ {AML_DEBUG_STR ("FindSetRightBitOp") AML_FIND_SET_RIGH= T_BIT_OP, 0, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x83 */ {AML_DEBUG_STR ("DerefOfOp") AML_DEREF_OF_OP, = 0, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x84 */ {AML_DEBUG_STR ("ConcatResOp") AML_CONCAT_RES_OP= , 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x85 */ {AML_DEBUG_STR ("ModOp") AML_MOD_OP, = 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x86 */ {AML_DEBUG_STR ("NotifyOp") AML_NOTIFY_OP, = 0, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x87 */ {AML_DEBUG_STR ("SizeOfOp") AML_SIZE_OF_OP, = 0, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x88 */ {AML_DEBUG_STR ("IndexOp") AML_INDEX_OP, = 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x89 */ {AML_DEBUG_STR ("MatchOp") AML_MATCH_OP, = 0, 6, 0, {EAmlObject, E= AmlUInt8, EAmlObject, EAmlUInt8, EAmlObject, EAml= Object}, 0}, - /* 0x8A */ {AML_DEBUG_STR ("CreateDWordFieldOp") AML_CREATE_DWORD_= FIELD_OP, 0, 3, 2, {EAmlObject, E= AmlObject, EAmlName, EAmlNone, EAmlNone, EAml= None}, AML_IN_NAMESPACE}, - /* 0x8B */ {AML_DEBUG_STR ("CreateWordFieldOp") AML_CREATE_WORD_F= IELD_OP, 0, 3, 2, {EAmlObject, E= AmlObject, EAmlName, EAmlNone, EAmlNone, EAml= None}, AML_IN_NAMESPACE}, - /* 0x8C */ {AML_DEBUG_STR ("CreateByteFieldOp") AML_CREATE_BYTE_F= IELD_OP, 0, 3, 2, {EAmlObject, E= AmlObject, EAmlName, EAmlNone, EAmlNone, EAml= None}, AML_IN_NAMESPACE}, - /* 0x8D */ {AML_DEBUG_STR ("CreateBitFieldOp") AML_CREATE_BIT_FI= ELD_OP, 0, 3, 2, {EAmlObject, E= AmlObject, EAmlName, EAmlNone, EAmlNone, EAml= None}, AML_IN_NAMESPACE}, - /* 0x8E */ {AML_DEBUG_STR ("ObjectTypeOp") AML_OBJECT_TYPE_O= P, 0, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x8F */ {AML_DEBUG_STR ("CreateQWordFieldOp") AML_CREATE_QWORD_= FIELD_OP, 0, 3, 2, {EAmlObject, E= AmlObject, EAmlName, EAmlNone, EAmlNone, EAml= None}, AML_IN_NAMESPACE}, - /* 0x90 */ {AML_DEBUG_STR ("LAndOp") AML_LAND_OP, = 0, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x91 */ {AML_DEBUG_STR ("LOrOp") AML_LOR_OP, = 0, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x92 */ {AML_DEBUG_STR ("LNotOp") AML_LNOT_OP, = 0, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x93 */ {AML_DEBUG_STR ("LEqualOp") AML_LEQUAL_OP, = 0, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x94 */ {AML_DEBUG_STR ("LGreaterOp") AML_LGREATER_OP, = 0, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x95 */ {AML_DEBUG_STR ("LLessOp") AML_LLESS_OP, = 0, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x96 */ {AML_DEBUG_STR ("ToBufferOp") AML_TO_BUFFER_OP,= 0, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x97 */ {AML_DEBUG_STR ("ToDecimalStringOp") AML_TO_DEC_STRING= _OP, 0, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x98 */ {AML_DEBUG_STR ("ToHexStringOp") AML_TO_HEX_STRING= _OP, 0, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x99 */ {AML_DEBUG_STR ("ToIntegerOp") AML_TO_INTEGER_OP= , 0, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x9C */ {AML_DEBUG_STR ("ToStringOp") AML_TO_STRING_OP,= 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x9D */ {AML_DEBUG_STR ("CopyObjectOp") AML_COPY_OBJECT_O= P, 0, 2, 0, {EAmlObject, E= AmlObject, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x9E */ {AML_DEBUG_STR ("MidOp") AML_MID_OP, = 0, 3, 0, {EAmlObject, E= AmlObject, EAmlObject, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0x9F */ {AML_DEBUG_STR ("ContinueOp") AML_CONTINUE_OP, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0xA0 */ {AML_DEBUG_STR ("IfOp") AML_IF_OP, = 0, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ}, - /* 0xA1 */ {AML_DEBUG_STR ("ElseOp") AML_ELSE_OP, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ}, - /* 0xA2 */ {AML_DEBUG_STR ("WhileOp") AML_WHILE_OP, = 0, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ}, - /* 0xA3 */ {AML_DEBUG_STR ("NoopOp") AML_NOOP_OP, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0xA4 */ {AML_DEBUG_STR ("ReturnOp") AML_RETURN_OP, = 0, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0xA5 */ {AML_DEBUG_STR ("BreakOp") AML_BREAK_OP, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0xCC */ {AML_DEBUG_STR ("BreakPointOp") AML_BREAK_POINT_O= P, 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, - /* 0xD0 */ {AML_DEBUG_STR ("MethodInvocOp") AML_METHOD_INVOC_= OP, 0, 2, 0, {EAmlName, E= AmlUInt8, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_PSEUDO_OPCODE | AML_HAS_CHILD_OBJ}, - /* 0xFF */ {AML_DEBUG_STR ("OnesOp") AML_ONES_OP, = 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, 0}, + // Comment Str OpCode = SubOpCode MaxIndex NameIndex 0 = 1 2 3 4 5 = Attribute + /* 0x00 */ {AML_OPCODE_DEF ("ZeroOp", AML_ZERO_OP), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x01 */ {AML_OPCODE_DEF ("OneOp", AML_ONE_OP), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x06 */ {AML_OPCODE_DEF ("AliasOp", AML_ALIAS_OP), = 0, 2, 1, {EAmlName, = EAmlName, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IN_NAMESPACE}, + /* 0x08 */ {AML_OPCODE_DEF ("NameOp", AML_NAME_OP), = 0, 2, 0, {EAmlName, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IN_NAMESPACE}, + /* 0x0A */ {AML_OPCODE_DEF ("BytePrefix", AML_BYTE_PREFIX)= , 0, 1, 0, {EAmlUInt8, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x0B */ {AML_OPCODE_DEF ("WordPrefix", AML_WORD_PREFIX)= , 0, 1, 0, {EAmlUInt16, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x0C */ {AML_OPCODE_DEF ("DWordPrefix", AML_DWORD_PREFIX= ), 0, 1, 0, {EAmlUInt32, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x0D */ {AML_OPCODE_DEF ("StringPrefix", AML_STRING_PREFI= X), 0, 1, 0, {EAmlString, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x0E */ {AML_OPCODE_DEF ("QWordPrefix", AML_QWORD_PREFIX= ), 0, 1, 0, {EAmlUInt64, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x10 */ {AML_OPCODE_DEF ("ScopeOp", AML_SCOPE_OP), = 0, 1, 0, {EAmlName, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ | AML_IN_NAMESPACE}, + /* 0x11 */ {AML_OPCODE_DEF ("BufferOp", AML_BUFFER_OP), = 0, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_HAS_PKG_LENGTH | AML_HAS_BYTE_LIST}, + /* 0x12 */ {AML_OPCODE_DEF ("PackageOp", AML_PACKAGE_OP),= 0, 1, 0, {EAmlUInt8, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ}, + /* 0x13 */ {AML_OPCODE_DEF ("VarPackageOp", AML_VAR_PACKAGE_= OP), 0, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ}, + /* 0x14 */ {AML_OPCODE_DEF ("MethodOp", AML_METHOD_OP), = 0, 2, 0, {EAmlName, = EAmlUInt8, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ | AML_IN_NAMESPACE}, + /* 0x15 */ {AML_OPCODE_DEF ("ExternalOp", AML_EXTERNAL_OP)= , 0, 3, 0, {EAmlName, = EAmlUInt8, EAmlUInt8, EAmlNone, EAmlNone, EAm= lNone}, AML_IN_NAMESPACE}, + /* 0x2E */ {AML_OPCODE_DEF ("DualNamePrefix", AML_DUAL_NAME_PR= EFIX), 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x2F */ {AML_OPCODE_DEF ("MultiNamePrefix", AML_MULTI_NAME_P= REFIX), 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x41 */ {AML_OPCODE_DEF ("NameChar_A", 'A'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x42 */ {AML_OPCODE_DEF ("NameChar_B", 'B'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x43 */ {AML_OPCODE_DEF ("NameChar_C", 'C'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x44 */ {AML_OPCODE_DEF ("NameChar_D", 'D'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x45 */ {AML_OPCODE_DEF ("NameChar_E", 'E'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x46 */ {AML_OPCODE_DEF ("NameChar_F", 'F'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x47 */ {AML_OPCODE_DEF ("NameChar_G", 'G'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x48 */ {AML_OPCODE_DEF ("NameChar_H", 'H'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x49 */ {AML_OPCODE_DEF ("NameChar_I", 'I'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x4A */ {AML_OPCODE_DEF ("NameChar_J", 'J'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x4B */ {AML_OPCODE_DEF ("NameChar_K", 'K'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x4C */ {AML_OPCODE_DEF ("NameChar_L", 'L'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x4D */ {AML_OPCODE_DEF ("NameChar_M", 'M'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x4E */ {AML_OPCODE_DEF ("NameChar_N", 'N'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x4F */ {AML_OPCODE_DEF ("NameChar_O", 'O'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x50 */ {AML_OPCODE_DEF ("NameChar_P", 'P'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x51 */ {AML_OPCODE_DEF ("NameChar_Q", 'Q'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x52 */ {AML_OPCODE_DEF ("NameChar_R", 'R'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x53 */ {AML_OPCODE_DEF ("NameChar_S", 'S'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x54 */ {AML_OPCODE_DEF ("NameChar_T", 'T'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x55 */ {AML_OPCODE_DEF ("NameChar_U", 'U'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x56 */ {AML_OPCODE_DEF ("NameChar_V", 'V'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x57 */ {AML_OPCODE_DEF ("NameChar_W", 'W'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x58 */ {AML_OPCODE_DEF ("NameChar_X", 'X'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x59 */ {AML_OPCODE_DEF ("NameChar_Y", 'Y'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x5A */ {AML_OPCODE_DEF ("NameChar_Z", 'Z'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x5B 0x01 */ {AML_OPCODE_DEF ("MutexOp", AML_EXT_OP), = AML_EXT_MUTEX_OP, 2, 0, {EAmlName, = EAmlUInt8, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IN_NAMESPACE}, + /* 0x5B 0x02 */ {AML_OPCODE_DEF ("EventOp", AML_EXT_OP), = AML_EXT_EVENT_OP, 1, 0, {EAmlName, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IN_NAMESPACE}, + /* 0x5B 0x12 */ {AML_OPCODE_DEF ("CondRefOfOp", AML_EXT_OP), = AML_EXT_COND_REF_OF_OP, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x13 */ {AML_OPCODE_DEF ("CreateFieldOp", AML_EXT_OP), = AML_EXT_CREATE_FIELD_OP,4, 3, {EAmlObject, = EAmlObject, EAmlObject, EAmlName, EAmlNone, EAm= lNone}, AML_IN_NAMESPACE}, + /* 0x5B 0x1F */ {AML_OPCODE_DEF ("LoadTableOp", AML_EXT_OP), = AML_EXT_LOAD_TABLE_OP, 6, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlObject, EAmlObject, EAm= lObject}, 0}, + /* 0x5B 0x20 */ {AML_OPCODE_DEF ("LoadOp", AML_EXT_OP), = AML_EXT_LOAD_OP, 2, 0, {EAmlName, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x21 */ {AML_OPCODE_DEF ("StallOp", AML_EXT_OP), = AML_EXT_STALL_OP, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x22 */ {AML_OPCODE_DEF ("SleepOp", AML_EXT_OP), = AML_EXT_SLEEP_OP, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x23 */ {AML_OPCODE_DEF ("AcquireOp", AML_EXT_OP), = AML_EXT_ACQUIRE_OP, 2, 0, {EAmlObject, = EAmlUInt16, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x24 */ {AML_OPCODE_DEF ("SignalOp", AML_EXT_OP), = AML_EXT_SIGNAL_OP, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x25 */ {AML_OPCODE_DEF ("WaitOp", AML_EXT_OP), = AML_EXT_WAIT_OP, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x26 */ {AML_OPCODE_DEF ("ResetOp", AML_EXT_OP), = AML_EXT_RESET_OP, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x27 */ {AML_OPCODE_DEF ("ReleaseOp", AML_EXT_OP), = AML_EXT_RELEASE_OP, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x28 */ {AML_OPCODE_DEF ("FromBCDOp", AML_EXT_OP), = AML_EXT_FROM_BCD_OP, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x29 */ {AML_OPCODE_DEF ("ToBCDOp", AML_EXT_OP), = AML_EXT_TO_BCD_OP, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x2A */ {AML_OPCODE_DEF ("UnloadOp", AML_EXT_OP), = AML_EXT_UNLOAD_OP, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x30 */ {AML_OPCODE_DEF ("RevisionOp", AML_EXT_OP), = AML_EXT_REVISION_OP, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x31 */ {AML_OPCODE_DEF ("DebugOp", AML_EXT_OP), = AML_EXT_DEBUG_OP, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x32 */ {AML_OPCODE_DEF ("FatalOp", AML_EXT_OP), = AML_EXT_FATAL_OP, 3, 0, {EAmlUInt8, = EAmlUInt32, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x33 */ {AML_OPCODE_DEF ("TimerOp", AML_EXT_OP), = AML_EXT_TIMER_OP, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x5B 0x80 */ {AML_OPCODE_DEF ("OpRegionOp", AML_EXT_OP), = AML_EXT_REGION_OP, 4, 0, {EAmlName, = EAmlUInt8, EAmlObject, EAmlObject, EAmlNone, EAm= lNone}, AML_IN_NAMESPACE}, + /* 0x5B 0x81 */ {AML_OPCODE_DEF ("FieldOp", AML_EXT_OP), = AML_EXT_FIELD_OP, 2, 0, {EAmlName, = EAmlUInt8, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_HAS_PKG_LENGTH | AML_HAS_FIELD_LIST}, + /* 0x5B 0x82 */ {AML_OPCODE_DEF ("DeviceOp", AML_EXT_OP), = AML_EXT_DEVICE_OP, 1, 0, {EAmlName, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ | AML_IN_NAMESPACE}, + /* 0x5B 0x83 */ {AML_OPCODE_DEF ("ProcessorOp", AML_EXT_OP), = AML_EXT_PROCESSOR_OP, 4, 0, {EAmlName, = EAmlUInt8, EAmlUInt32, EAmlUInt8, EAmlNone, EAm= lNone}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ | AML_IN_NAMESPACE}, + /* 0x5B 0x84 */ {AML_OPCODE_DEF ("PowerResOp", AML_EXT_OP), = AML_EXT_POWER_RES_OP, 3, 0, {EAmlName, = EAmlUInt8, EAmlUInt16, EAmlNone, EAmlNone, EAm= lNone}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ | AML_IN_NAMESPACE}, + /* 0x5B 0x85 */ {AML_OPCODE_DEF ("ThermalZoneOp", AML_EXT_OP), = AML_EXT_THERMAL_ZONE_OP,1, 0, {EAmlName, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ | AML_IN_NAMESPACE}, + /* 0x5B 0x86 */ {AML_OPCODE_DEF ("IndexFieldOp", AML_EXT_OP), = AML_EXT_INDEX_FIELD_OP, 3, 0, {EAmlName, = EAmlName, EAmlUInt8, EAmlNone, EAmlNone, EAm= lNone}, AML_HAS_PKG_LENGTH | AML_HAS_FIELD_LIST}, + /* 0x5B 0x87 */ {AML_OPCODE_DEF ("BankFieldOp", AML_EXT_OP), = AML_EXT_BANK_FIELD_OP, 4, 0, {EAmlName, = EAmlName, EAmlObject, EAmlUInt8, EAmlNone, EAm= lNone}, AML_HAS_PKG_LENGTH | AML_HAS_FIELD_LIST}, + /* 0x5B 0x88 */ {AML_OPCODE_DEF ("DataRegionOp", AML_EXT_OP), = AML_EXT_DATA_REGION_OP, 4, 0, {EAmlName, = EAmlObject, EAmlObject, EAmlObject, EAmlNone, EAm= lNone}, AML_IN_NAMESPACE}, + /* 0x5C */ {AML_OPCODE_DEF ("RootChar", AML_ROOT_CHAR), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x5E */ {AML_OPCODE_DEF ("ParentPrefixChar", AML_PARENT_PREFI= X_CHAR), 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x5F */ {AML_OPCODE_DEF ("NameChar", '_'), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_NAME_CHAR}, + /* 0x60 */ {AML_OPCODE_DEF ("Local0Op", AML_LOCAL0), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x61 */ {AML_OPCODE_DEF ("Local1Op", AML_LOCAL1), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x62 */ {AML_OPCODE_DEF ("Local2Op", AML_LOCAL2), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x63 */ {AML_OPCODE_DEF ("Local3Op", AML_LOCAL3), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x64 */ {AML_OPCODE_DEF ("Local4Op", AML_LOCAL4), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x65 */ {AML_OPCODE_DEF ("Local5Op", AML_LOCAL5), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x66 */ {AML_OPCODE_DEF ("Local6Op", AML_LOCAL6), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x67 */ {AML_OPCODE_DEF ("Local7Op", AML_LOCAL7), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x68 */ {AML_OPCODE_DEF ("Arg0Op", AML_ARG0), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x69 */ {AML_OPCODE_DEF ("Arg1Op", AML_ARG1), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x6A */ {AML_OPCODE_DEF ("Arg2Op", AML_ARG2), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x6B */ {AML_OPCODE_DEF ("Arg3Op", AML_ARG3), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x6C */ {AML_OPCODE_DEF ("Arg4Op", AML_ARG4), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x6D */ {AML_OPCODE_DEF ("Arg5Op", AML_ARG5), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x6E */ {AML_OPCODE_DEF ("Arg6Op", AML_ARG6), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x70 */ {AML_OPCODE_DEF ("StoreOp", AML_STORE_OP), = 0, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x71 */ {AML_OPCODE_DEF ("RefOfOp", AML_REF_OF_OP), = 0, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x72 */ {AML_OPCODE_DEF ("AddOp", AML_ADD_OP), = 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x73 */ {AML_OPCODE_DEF ("ConcatOp", AML_CONCAT_OP), = 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x74 */ {AML_OPCODE_DEF ("SubtractOp", AML_SUBTRACT_OP)= , 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x75 */ {AML_OPCODE_DEF ("IncrementOp", AML_INCREMENT_OP= ), 0, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x76 */ {AML_OPCODE_DEF ("DecrementOp", AML_DECREMENT_OP= ), 0, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x77 */ {AML_OPCODE_DEF ("MultiplyOp", AML_MULTIPLY_OP)= , 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x78 */ {AML_OPCODE_DEF ("DivideOp", AML_DIVIDE_OP), = 0, 4, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlObject, EAmlNone, EAm= lNone}, 0}, + /* 0x79 */ {AML_OPCODE_DEF ("ShiftLeftOp", AML_SHIFT_LEFT_O= P), 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x7A */ {AML_OPCODE_DEF ("ShiftRightOp", AML_SHIFT_RIGHT_= OP), 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x7B */ {AML_OPCODE_DEF ("AndOp", AML_AND_OP), = 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x7C */ {AML_OPCODE_DEF ("NAndOp", AML_NAND_OP), = 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x7D */ {AML_OPCODE_DEF ("OrOp", AML_OR_OP), = 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x7E */ {AML_OPCODE_DEF ("NorOp", AML_NOR_OP), = 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x7F */ {AML_OPCODE_DEF ("XOrOp", AML_XOR_OP), = 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x80 */ {AML_OPCODE_DEF ("NotOp", AML_NOT_OP), = 0, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x81 */ {AML_OPCODE_DEF ("FindSetLeftBitOp", AML_FIND_SET_LEF= T_BIT_OP), 0, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x82 */ {AML_OPCODE_DEF ("FindSetRightBitOp", AML_FIND_SET_RIG= HT_BIT_OP),0, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x83 */ {AML_OPCODE_DEF ("DerefOfOp", AML_DEREF_OF_OP)= , 0, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x84 */ {AML_OPCODE_DEF ("ConcatResOp", AML_CONCAT_RES_O= P), 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x85 */ {AML_OPCODE_DEF ("ModOp", AML_MOD_OP), = 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x86 */ {AML_OPCODE_DEF ("NotifyOp", AML_NOTIFY_OP), = 0, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x87 */ {AML_OPCODE_DEF ("SizeOfOp", AML_SIZE_OF_OP),= 0, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x88 */ {AML_OPCODE_DEF ("IndexOp", AML_INDEX_OP), = 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x89 */ {AML_OPCODE_DEF ("MatchOp", AML_MATCH_OP), = 0, 6, 0, {EAmlObject, = EAmlUInt8, EAmlObject, EAmlUInt8, EAmlObject, EAm= lObject}, 0}, + /* 0x8A */ {AML_OPCODE_DEF ("CreateDWordFieldOp", AML_CREATE_DWORD= _FIELD_OP),0, 3, 2, {EAmlObject, = EAmlObject, EAmlName, EAmlNone, EAmlNone, EAm= lNone}, AML_IN_NAMESPACE}, + /* 0x8B */ {AML_OPCODE_DEF ("CreateWordFieldOp", AML_CREATE_WORD_= FIELD_OP), 0, 3, 2, {EAmlObject, = EAmlObject, EAmlName, EAmlNone, EAmlNone, EAm= lNone}, AML_IN_NAMESPACE}, + /* 0x8C */ {AML_OPCODE_DEF ("CreateByteFieldOp", AML_CREATE_BYTE_= FIELD_OP), 0, 3, 2, {EAmlObject, = EAmlObject, EAmlName, EAmlNone, EAmlNone, EAm= lNone}, AML_IN_NAMESPACE}, + /* 0x8D */ {AML_OPCODE_DEF ("CreateBitFieldOp", AML_CREATE_BIT_F= IELD_OP), 0, 3, 2, {EAmlObject, = EAmlObject, EAmlName, EAmlNone, EAmlNone, EAm= lNone}, AML_IN_NAMESPACE}, + /* 0x8E */ {AML_OPCODE_DEF ("ObjectTypeOp", AML_OBJECT_TYPE_= OP), 0, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x8F */ {AML_OPCODE_DEF ("CreateQWordFieldOp", AML_CREATE_QWORD= _FIELD_OP),0, 3, 2, {EAmlObject, = EAmlObject, EAmlName, EAmlNone, EAmlNone, EAm= lNone}, AML_IN_NAMESPACE}, + /* 0x90 */ {AML_OPCODE_DEF ("LAndOp", AML_LAND_OP), = 0, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x91 */ {AML_OPCODE_DEF ("LOrOp", AML_LOR_OP), = 0, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x92 */ {AML_OPCODE_DEF ("LNotOp", AML_LNOT_OP), = 0, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x93 */ {AML_OPCODE_DEF ("LEqualOp", AML_LEQUAL_OP), = 0, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x94 */ {AML_OPCODE_DEF ("LGreaterOp", AML_LGREATER_OP)= , 0, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x95 */ {AML_OPCODE_DEF ("LLessOp", AML_LLESS_OP), = 0, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x96 */ {AML_OPCODE_DEF ("ToBufferOp", AML_TO_BUFFER_OP= ), 0, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x97 */ {AML_OPCODE_DEF ("ToDecimalStringOp", AML_TO_DEC_STRIN= G_OP), 0, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x98 */ {AML_OPCODE_DEF ("ToHexStringOp", AML_TO_HEX_STRIN= G_OP), 0, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x99 */ {AML_OPCODE_DEF ("ToIntegerOp", AML_TO_INTEGER_O= P), 0, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x9C */ {AML_OPCODE_DEF ("ToStringOp", AML_TO_STRING_OP= ), 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x9D */ {AML_OPCODE_DEF ("CopyObjectOp", AML_COPY_OBJECT_= OP), 0, 2, 0, {EAmlObject, = EAmlObject, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x9E */ {AML_OPCODE_DEF ("MidOp", AML_MID_OP), = 0, 3, 0, {EAmlObject, = EAmlObject, EAmlObject, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0x9F */ {AML_OPCODE_DEF ("ContinueOp", AML_CONTINUE_OP)= , 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0xA0 */ {AML_OPCODE_DEF ("IfOp", AML_IF_OP), = 0, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ}, + /* 0xA1 */ {AML_OPCODE_DEF ("ElseOp", AML_ELSE_OP), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ}, + /* 0xA2 */ {AML_OPCODE_DEF ("WhileOp", AML_WHILE_OP), = 0, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_HAS_PKG_LENGTH | AML_HAS_CHILD_OBJ}, + /* 0xA3 */ {AML_OPCODE_DEF ("NoopOp", AML_NOOP_OP), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0xA4 */ {AML_OPCODE_DEF ("ReturnOp", AML_RETURN_OP), = 0, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0xA5 */ {AML_OPCODE_DEF ("BreakOp", AML_BREAK_OP), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0xCC */ {AML_OPCODE_DEF ("BreakPointOp", AML_BREAK_POINT_= OP), 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, + /* 0xD0 */ {AML_OPCODE_DEF ("MethodInvocOp", AML_METHOD_INVOC= _OP), 0, 2, 0, {EAmlName, = EAmlUInt8, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_PSEUDO_OPCODE | AML_HAS_CHILD_OBJ}, + /* 0xFF */ {AML_OPCODE_DEF ("OnesOp", AML_ONES_OP), = 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, 0}, }; =20 /** AML grammar encoding for field elements. @@ -265,12 +265,12 @@ GLOBAL_REMOVE_IF_UNREFERENCED STATIC CONST AML_BYTE_ENCODING mAmlFieldEncoding[] =3D { - // Comment Str OpCode = SubOpCode MaxIndex NameIndex 0 1= 2 3 4 5 = Attribute - /* 0x00 */ {AML_DEBUG_STR ("FieldReservedOp") AML_FIELD_RESERVE= D_OP, 0, 0, 0, {EAmlNone, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_FIELD_ELEMENT | AML_HAS_PKG_LENGTH}, - /* 0x01 */ {AML_DEBUG_STR ("FieldAccessOp") AML_FIELD_ACCESS_= OP, 0, 2, 0, {EAmlUInt8, E= AmlUInt8, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_FIELD_ELEMENT}, - /* 0x02 */ {AML_DEBUG_STR ("FieldConnectionOp") AML_FIELD_CONNECT= ION_OP, 0, 1, 0, {EAmlObject, E= AmlNone, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_FIELD_ELEMENT}, - /* 0x03 */ {AML_DEBUG_STR ("FieldExtAccessOp") AML_FIELD_EXT_ACC= ESS_OP, 0, 3, 0, {EAmlUInt8, E= AmlUInt8, EAmlUInt8, EAmlNone, EAmlNone, EAml= None}, AML_IS_FIELD_ELEMENT}, - /* 0x04 */ {AML_DEBUG_STR ("FieldNamed") AML_FIELD_NAMED_O= P, 0, 2, 0, {EAmlName, E= AmlFieldPkgLen, EAmlNone, EAmlNone, EAmlNone, EAml= None}, AML_IS_FIELD_ELEMENT | AML_IS_PSEUDO_OPCODE | AML_IN_NAMESPAC= E} + // Comment Str OpCode = SubOpCode MaxIndex NameIndex 0 = 1 2 3 4 5 = Attribute + /* 0x00 */ {AML_OPCODE_DEF ("FieldReservedOp", AML_FIELD_RESERV= ED_OP), 0, 0, 0, {EAmlNone, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_FIELD_ELEMENT | AML_HAS_PKG_LENGTH}, + /* 0x01 */ {AML_OPCODE_DEF ("FieldAccessOp", AML_FIELD_ACCESS= _OP), 0, 2, 0, {EAmlUInt8, = EAmlUInt8, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_FIELD_ELEMENT}, + /* 0x02 */ {AML_OPCODE_DEF ("FieldConnectionOp", AML_FIELD_CONNEC= TION_OP), 0, 1, 0, {EAmlObject, = EAmlNone, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_FIELD_ELEMENT}, + /* 0x03 */ {AML_OPCODE_DEF ("FieldExtAccessOp", AML_FIELD_EXT_AC= CESS_OP), 0, 3, 0, {EAmlUInt8, = EAmlUInt8, EAmlUInt8, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_FIELD_ELEMENT}, + /* 0x04 */ {AML_OPCODE_DEF ("FieldNamed", AML_FIELD_NAMED_= OP), 0, 2, 0, {EAmlName, = EAmlFieldPkgLen, EAmlNone, EAmlNone, EAmlNone, EAm= lNone}, AML_IS_FIELD_ELEMENT | AML_IS_PSEUDO_OPCODE | AML_IN_NAMESPA= CE} }; =20 /** Get the AML_BYTE_ENCODING entry in the AML encoding table. diff --git a/DynamicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.h b/Dyn= amicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.h index ba1228621303f5208f94891d46594c50637195db..35c0680b615987f81ca786cb420= deccd19fce071 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.h +++ b/DynamicTablesPkg/Library/Common/AmlLib/AmlEncoding/Aml.h @@ -15,9 +15,9 @@ #include =20 #if !defined (MDEPKG_NDEBUG) -#define AML_DEBUG_STR(str) str, +#define AML_OPCODE_DEF(str, OpCode) str, OpCode #else -#define AML_DEBUG_STR(x) +#define AML_OPCODE_DEF(str, OpCode) OpCode #endif // MDEPKG_NDEBUG =20 /** AML types. --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65454): https://edk2.groups.io/g/devel/message/65454 Mute This Topic: https://groups.io/mt/77014351/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 20:21:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65449+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 160078580154192.96051237239067; Tue, 22 Sep 2020 07:43:21 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id RS4cYY1788612xKJSTrdRqj0; Tue, 22 Sep 2020 07:43:21 -0700 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.42]) by mx.groups.io with SMTP id smtpd.web12.164.1600785799827726499 for ; Tue, 22 Sep 2020 07:43:20 -0700 X-Received: from DB7PR05CA0032.eurprd05.prod.outlook.com (2603:10a6:10:36::45) by VI1PR08MB5438.eurprd08.prod.outlook.com (2603:10a6:803:12e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14; Tue, 22 Sep 2020 14:43:16 +0000 X-Received: from DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:36:cafe::b8) by DB7PR05CA0032.outlook.office365.com (2603:10a6:10:36::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14 via Frontend Transport; Tue, 22 Sep 2020 14:43:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+65449+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT004.mail.protection.outlook.com (10.152.20.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:43:16 +0000 X-Received: ("Tessian outbound 7fc8f57bdedc:v64"); Tue, 22 Sep 2020 14:43:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 51eb1e05e0825d72 X-CR-MTA-TID: 64aa7808 X-Received: from b364ac1bbaf2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5835012C-1B53-4765-AB52-32E46F1D0153.1; Tue, 22 Sep 2020 14:42:51 +0000 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b364ac1bbaf2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Sep 2020 14:42:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NvDO2aZUXTvO/8Hv079x/iivHfLqLy8hYGLDYSeqizHS0dULP1cv5TFYbszTcQ+orNKyFlWnDz0646WHy/gxt9jjdnLfxCsU7Vh8gFVTqgeok3fCtpw2sNBO/fkUZ3SardJVTga9Z9eFTn4NEjMYs1+/cQmtNyczg6qnNk/XRoA5SEPUY45hgwINYtpCueg25CB1J7zcOg29bvv5wek81ezDuuhgalI4Il942I9wYNjwPInlADMdACK07pLIDlr7xsjp7N61gZCZG/j6za4wPb5OZ5FJU+PRmZETc31EqPvYcnGKpUsP0vq/qLCC10eet5307QlcB1CrtZttVfJW4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ewi2u2jVoZbpmFOcUaRUJKddcGy5uuqkE0tLFZvkuTY=; b=msXAF8eaw/GDZTl1y1/at76s9vqpw6Z1HIOFzK18ihmrsv61tx1kqBIXcI1hvN7tBZ4Ukg+n2iSA9L84dTb16n4G3n2mrFmdIs4ZUumBtyEFFJVmv3RjrA2flMVxqkXUf6P/OXzCjoSTY+hbOI/znBWHgyp6KOVuKuDfwAvzI8SbM2FZWmrtGFGX2FKvVI3udzNp4p80VQFqFL5X93CDzUBeHuFQEn9Yywccyvq9F1vzXzHZ+Hv75ts16iOai7B4Z+vwI6QuaMVO1aMg839L3/wTU/PWbW56ZBTERtztgUqRmd8wH6Azy6dgJyxuXr3YbEr4EQg6Z5Lvbxt5aESGyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from DB6PR0202CA0024.eurprd02.prod.outlook.com (2603:10a6:4:29::34) by VI1PR08MB5376.eurprd08.prod.outlook.com (2603:10a6:803:13e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Tue, 22 Sep 2020 14:42:50 +0000 X-Received: from DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:29:cafe::31) by DB6PR0202CA0024.outlook.office365.com (2603:10a6:4:29::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14 via Frontend Transport; Tue, 22 Sep 2020 14:42:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT042.mail.protection.outlook.com (10.152.21.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:42:49 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Tue, 22 Sep 2020 14:42:40 +0000 X-Received: from E107187.Arm.com (10.57.47.90) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Tue, 22 Sep 2020 14:42:40 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v1 7/7] DynamicTablesPkg: SsdtSerialPortFixupLib fix ECC errors Date: Tue, 22 Sep 2020 15:42:35 +0100 Message-ID: <20200922144235.76292-8-sami.mujawar@arm.com> In-Reply-To: <20200922144235.76292-1-sami.mujawar@arm.com> References: <20200922144235.76292-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eadba027-984a-4b1a-5a9f-08d85f05d778 X-MS-TrafficTypeDiagnostic: VI1PR08MB5376:|VI1PR08MB5438: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:7219;OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: uABwZm1Iz9VWCTVisJPGQfSzUe0ecDHee4dpCTUgoOfxlxA720n4qIdJYQ1Ws4/bZKxlslo0SHbkUEIpqavZQw9bY4IEuYu2UO6SgvqBle2+2KaGsOsjRSSSBgmKemFm56DRPT6EnYffBXXTosoP1tOqcWlPDpBzNHlSWd5XbO3qrfljeT7/O4XuNjpPZJyTB4anIshgDaZoD1WpqbHPx+q5JW1R2+LjX+r6Rg+Q2DPT5Dd8eVYqdQozfJ+UBDBndOKxtYKMhNgjtROzqXq1NCMxR2ereBBpl1y8k9p+Q1lSM0kBFrTtgdyIN/2/88eylELcq+GqCZaDLxeBV7SSuWyM1QIlncrUTH4l5P2RPfzUjJXXTv9s+klIQVoaaPW9mxhyVKItWLQhoanafGaXK6jGVSMZpK6IdviBSi7yNFU= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(136003)(396003)(39840400004)(346002)(376002)(46966005)(86362001)(316002)(81166007)(356005)(7696005)(426003)(83380400001)(4326008)(186003)(26005)(54906003)(6916009)(336012)(47076004)(6666004)(5660300002)(8676002)(1076003)(8936002)(36756003)(2616005)(478600001)(2906002)(82310400003)(70206006)(70586007)(44832011)(213903007);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5376 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 685fc7f4-4ced-4ce7-7ee0-08d85f05c777 X-Microsoft-Antispam-Message-Info: xW0SQxkhQIzRfJCHmseUtwbrOuv/VH2rZ3lbrvMTm1zS01l8SPwSKdWOOho5SyN1Ax24aCH4982lTLoTpcYCsVuW8m1IUsMPYtWNLPPe2b/0RLvvBavOr0Bc0hB5uezfQiZ8HExDbHTTKGRNED+EHTr8jXjrZ0frRE3/d/P0csYxCyCzofwQmnW4ERAnRey7Othq9zG1K+azrIC4IeY64W58cUeALn8pRoV4oP90M8RU1Fod1i/KzU+ldIxJPK/b8QmgF7A3pvYj7IHe5fBK4AhLpFdLbW2ffR3Y/PvNXiOfCu5RSzIOqwtFoOnI1AzIoTWo4cfHIa3SiXnZeiQJkNbtjHzulYNZ8h0Bbj5zlujrpZU0lkOthhBxsDlNH8cvIiU/O4zGejKRMc8vt6n8TyTF1BV38jPwmFgJ7Hxj+SBa/fjfG51+QxiX2hfKvi3KCkH7ShMQUzXdXZ6KzMa9FoLLVRTCn9cbDcBdhmAdAFw= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2020 14:43:16.7309 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eadba027-984a-4b1a-5a9f-08d85f05d778 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5438 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: i4DKZ6tu5MZnYS0zPplywvcAx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1600785801; bh=CphnuY0rgjGOCmiJtIOUUs8LsxxTdjEhUSV1m4sI1ss=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=qPADbrZAJMkZemNMI8G5s81PTPKEQF43HSjKNApx2a4ZUKnHQ4Zv6qdzOArsNIz0AYU SIxEFCHKfmOOZx8lBDSmv2YX/UhxfbYGMsTrMxcnQthbqtkkDaxg13QRS+pJNpzvgnF9b UxP6oHgwF049riWhlupbAK7/lGirIBW0+5w= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix the following ECC reported errors in SsdtSerialPortFixupLib. - [9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 in Comment, <@param [in]> does NOT have [in, out] Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixup= Lib.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSer= ialPortFixupLib.c b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/= SsdtSerialPortFixupLib.c index 944bfd6eaaabc9dbc7223c9888fb5f11eeb1bda9..0ff071485ef25f4ca63de0eeab5= 120d1beece4db 100644 --- a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPort= FixupLib.c +++ b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPort= FixupLib.c @@ -130,9 +130,9 @@ STATIC EFI_STATUS EFIAPI FixupIds ( - IN OUT AML_ROOT_NODE_HANDLE RootNodeHandle, - IN CONST UINT64 Uid, - IN CONST CM_ARM_SERIAL_PORT_INFO * SerialPortInfo + IN AML_ROOT_NODE_HANDLE RootNodeHandle, + IN CONST UINT64 Uid, + IN CONST CM_ARM_SERIAL_PORT_INFO * SerialPortInfo ) { EFI_STATUS Status; @@ -243,8 +243,8 @@ STATIC EFI_STATUS EFIAPI FixupCrs ( - IN OUT AML_ROOT_NODE_HANDLE RootNodeHandle, - IN CONST CM_ARM_SERIAL_PORT_INFO * SerialPortInfo + IN AML_ROOT_NODE_HANDLE RootNodeHandle, + IN CONST CM_ARM_SERIAL_PORT_INFO * SerialPortInfo ) { EFI_STATUS Status; @@ -318,9 +318,9 @@ STATIC EFI_STATUS EFIAPI FixupName ( - IN OUT AML_ROOT_NODE_HANDLE RootNodeHandle, - IN CONST CM_ARM_SERIAL_PORT_INFO * SerialPortInfo, - IN CONST CHAR8 * Name + IN AML_ROOT_NODE_HANDLE RootNodeHandle, + IN CONST CM_ARM_SERIAL_PORT_INFO * SerialPortInfo, + IN CONST CHAR8 * Name ) { EFI_STATUS Status; @@ -362,7 +362,7 @@ STATIC EFI_STATUS EFIAPI FixupSerialPortInfo ( - IN OUT AML_ROOT_NODE_HANDLE RootNodeHandle, + IN AML_ROOT_NODE_HANDLE RootNodeHandle, IN CONST CM_ARM_SERIAL_PORT_INFO * SerialPortInfo, IN CONST CHAR8 * Name, IN CONST UINT64 Uid, --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65449): https://edk2.groups.io/g/devel/message/65449 Mute This Topic: https://groups.io/mt/77014345/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-