From nobody Sat Feb 7 06:20:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+65082+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65082+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=scott.ph ARC-Seal: i=1; a=rsa-sha256; t=1599476050; cv=none; d=zohomail.com; s=zohoarc; b=l07VMnNTKN+40RPK8XNIEAkbJtdEq6enLxNWMkXS1HEdDhlpJMGsWzS2POlU1gSItLbZSazNHvuK9Mm3K8EvosHfkz+kfcrtj06UBBbQe7t3qGK5j5u2sdE4mD9iYc57iaJtTKvuScY+xBYTie2Wcinhzfw4CgCtIiwzEbj1Wu0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599476050; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=EfK0337aDNKCiDF9/mcjlB0jxLVJBGdaL+J8v6rZtIo=; b=YN6qiqIRYOqRdTyMjR73tmVOEcrSvFO0vNBcrOzAEWs+H4PI1ULhPYtpSbT4vXFB4Cks9MkzC551tnhyOkQzaZhojgV/gw/TQbYyFkJOq3qtycs5jaO/bGwiDY/Pk3UNX68uY5sxW5rieRIV1Uyahv/cx1x02JDKivBzxNzqNiI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65082+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1599476050297989.3374286816153; Mon, 7 Sep 2020 03:54:10 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ZoTIYY1788612xI7JiB4dsh2; Mon, 07 Sep 2020 03:54:09 -0700 X-Received: from mail2.protonmail.ch (mail2.protonmail.ch [185.70.40.22]) by mx.groups.io with SMTP id smtpd.web10.9947.1599268552704689282 for ; Fri, 04 Sep 2020 18:15:54 -0700 Date: Sat, 05 Sep 2020 01:15:44 +0000 To: devel@edk2.groups.io From: D Scott Phillips Reply-To: devel@edk2.groups.io,scott@scott.ph Subject: [edk2-devel] [PATCH] NetworkPkg/HttpDxe: Clear TlsChildHandle during cleanup Message-ID: <20200905011540.6847-1-scott@scott.ph> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io X-Gm-Message-State: m26gE7RaEQwJZKuZ775vaAO8x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1599476049; bh=pxFKsPibSLdhc5GlVKUkSSgDeZbzmJWJYFPzBbYTiQ8=; h=Content-Type:Date:From:Reply-To:Subject:To; b=F5TKB2mYAkgRnL5io5FINpBVxoARVMAxRPPbx62XEYIxwp434iR2pMI0c2MnoZ0kzZB XQ4aIi7koTT+L07bj0eWxTl6JWv+6sqbVICqpE7DDWkdlYyTZwwBi9sDKwrBwQ6vK/Vx0 t3JpAhTuVPDSEaZjN6/CpHvmqFHO5jPpa8g= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: D Scott Phillips Leaving TlsChildHandle with the stale handle causes later use of https with the http instance to incorrectly skip tls reconfiguration, use the stale handle, and eventually call a garbage function pointer. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1917 Signed-off-by: D Scott Phillips --- NetworkPkg/HttpDxe/HttpProto.c | 1 + 1 file changed, 1 insertion(+) diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c index 3c7c6ff9f0..afc7db5a72 100644 --- a/NetworkPkg/HttpDxe/HttpProto.c +++ b/NetworkPkg/HttpDxe/HttpProto.c @@ -873,6 +873,7 @@ HttpCleanProtocol ( // Destroy the TLS instance. // HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance->= TlsChildHandle); + HttpInstance->TlsChildHandle =3D NULL; } =20 if (HttpInstance->Tcp4ChildHandle !=3D NULL) { --=20 2.26.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65082): https://edk2.groups.io/g/devel/message/65082 Mute This Topic: https://groups.io/mt/76683729/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-