From nobody Fri Apr 19 15:59:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+65058+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65058+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599234349; cv=none; d=zohomail.com; s=zohoarc; b=i4FDPe4zE8ozr/8DTgJX6LWJlmr+JzmsFtXbyWypVtXwSy22PWhqmk6wYmJzqbUG6BLeDUShhl75WEG6PpYszRMPrc1GLiHyOtx6LqDQUgOuEf2Oe0H9NwsVsysEpICtgt1oDYqKKvac+mhCTPBrPX7DVQzcgHlm9nySYUue2aM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599234349; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=KXruY8n+q1F0lmxg6lagB+6E+3Q+2cvU7wIiTkhAR4M=; b=hrShQP8C4dHYIuxNJ/8PI1NmH1FH35txjXi4W2OXEAhC/a0M5txys2aGyb7IKDBrS9GiQE3A2Am08BctX07FwiKTjDN9dMd4js27Pm2FGbYh+U0KR1Q2sEu3GKWuzmcmAZwTpFiWD3ongJLDHwjyeGDtUE3YlbfD9vMKnr8QUxU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65058+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1599234349085865.7332735131516; Fri, 4 Sep 2020 08:45:49 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 5I2KYY1788612xSWYaaekavX; Fri, 04 Sep 2020 08:45:48 -0700 X-Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.580.1599234347551145409 for ; Fri, 04 Sep 2020 08:45:47 -0700 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-343-QX7emLYaObyDISBQUjXJ7A-1; Fri, 04 Sep 2020 11:45:45 -0400 X-MC-Unique: QX7emLYaObyDISBQUjXJ7A-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 60A27801AB7; Fri, 4 Sep 2020 15:45:44 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-161.ams2.redhat.com [10.36.112.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id 02BE55C1D0; Fri, 4 Sep 2020 15:45:42 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , Leif Lindholm , Maciej Rabeda , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [edk2-devel] [PATCH] EmbeddedPkg/TimeBaseLib: remove the SEC_PER_MONTH, SEC_PER_YEAR macros Date: Fri, 4 Sep 2020 17:45:41 +0200 Message-Id: <20200904154541.23340-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: s2yuSn63zDD4oZ3ge83g5Yn8x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1599234348; bh=KXruY8n+q1F0lmxg6lagB+6E+3Q+2cvU7wIiTkhAR4M=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=OYyULBOZyAq+o7JG/kx10F58ej/G2YS2hLX1Xp+sNJYz8fBLzMBpb0KxpSQ54OA15Nk 5paof5h2D0sj45PUgAx4GbjarojDwJGyKVH8FaxVaPJIWWM7j3YcGWUKDeBTnRKcWmxIB uFMdIkVcAa3QLKXJytD+soExH85ekUvN1SU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The SEC_PER_MONTH and SEC_PER_YEAR macros are wrong: they both evaluate to 0 (of type "int"). They are also unused (they could never be used for division, for example); so remove them. The macros were originally introduced in commit 0f4386e775c7 ("ArmPlatformPkg/PL031RealTimeClockLib: Implement PL031 RTC drive", 2011-06-11). Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Maciej Rabeda Cc: Philippe Mathieu-Daud=C3=A9 Reported-by: Maciej Rabeda Signed-off-by: Laszlo Ersek Reviewed-by: Leif Lindholm Reviewed-by: Philippe Mathieu-Daude --- EmbeddedPkg/Include/Library/TimeBaseLib.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/EmbeddedPkg/Include/Library/TimeBaseLib.h b/EmbeddedPkg/Includ= e/Library/TimeBaseLib.h index ee2f191d985b..3c2d3660c66c 100644 --- a/EmbeddedPkg/Include/Library/TimeBaseLib.h +++ b/EmbeddedPkg/Include/Library/TimeBaseLib.h @@ -51,8 +51,6 @@ #define SEC_PER_MIN ((UINTN) 60) #define SEC_PER_HOUR ((UINTN) 3600) #define SEC_PER_DAY ((UINTN) 86400) -#define SEC_PER_MONTH ((UINTN) 2,592,00= 0) -#define SEC_PER_YEAR ((UINTN) 31,536,00= 0) =20 BOOLEAN EFIAPI --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65058): https://edk2.groups.io/g/devel/message/65058 Mute This Topic: https://groups.io/mt/76632579/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-