From nobody Fri Apr 19 21:25:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+64865+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+64865+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1598921728; cv=none; d=zohomail.com; s=zohoarc; b=KMVgVaZ6/WkvTRX7s5K3ytTGjSSzZ+esP9q+3j3Ej4AbpbXw87O+gYUzLuCIH3vR+ph3QrWrfqUfbrauVabs9QxGOjB+QGeO9ApO5EkUJH2O2fdjoRBQnsWLWgJ/p0DjHimyeWISM1OqH0Tcoy9SCobf7NnM3GljlvY7CiK5/pA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598921728; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=WHOaQsXJFhkxCyTBelj3jsL2TbjxGZoXyDbp31BPXq4=; b=l2IHywtKfj4/bCrWqbRfmXkk+M4CrVotlFQwxk7fAQtw67T6uvYwBrsIpv2Ru7cqg9IlQRI/Zh3uCQygOrFX4Oz5WJmLGmJprkxZEKzPHI33dzOKadcdlDO6uka6HUJ8TFNeEwB+eAz6+FW0vLhV3EK9B+dWHwnY/ro6D9Na1i8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+64865+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1598921728200309.45354607196145; Mon, 31 Aug 2020 17:55:28 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 9osoYY1788612xIgw5bhmgIX; Mon, 31 Aug 2020 17:55:27 -0700 X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.2809.1598921726943211881 for ; Mon, 31 Aug 2020 17:55:27 -0700 IronPort-SDR: YZYjTBcZ0k0UVrrI6xiDfK6Fghgxto+nd/0OgJOazdWAbcYz/wAibM5vOr2CLbLdM1Lq9h6j1c V1fo5echgfOA== X-IronPort-AV: E=McAfee;i="6000,8403,9730"; a="221314072" X-IronPort-AV: E=Sophos;i="5.76,376,1592895600"; d="scan'208";a="221314072" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 17:55:25 -0700 IronPort-SDR: VbX/9vqyd+A/EPFgYK++LWTBv8m3x3ahtA3WOy8Y0nbrznVlZU95gYOF/Aw3kasue6GrS/KoX7 6w3HgUsDvxFg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,376,1592895600"; d="scan'208";a="338400521" X-Received: from fieedk002.ccr.corp.intel.com ([10.239.158.125]) by FMSMGA003.fm.intel.com with ESMTP; 31 Aug 2020 17:55:23 -0700 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Qi Zhang , Rahul Kumar , Laszlo Ersek Subject: [edk2-devel] [PATCH] SecurityPkg: Initailize variable Status before it is consumed. Date: Tue, 1 Sep 2020 08:55:05 +0800 Message-Id: <20200901005505.1722-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com X-Gm-Message-State: UY81Tdui1iVYYQ0llkSAhqJvx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1598921727; bh=cEjV8obB+sPWK1CxymZdVsG3v27EG8u50dd8cd/g0HQ=; h=Cc:Date:From:Reply-To:Subject:To; b=k6psTTVaSFszEJNTk+ihw636cc5KRBP/8hftWq5lA2Bx9ZaZBbIo7ZYAbtEOGOF8/Yf Zuj73PeCF7XRn9AdpUV4D9wgLne41jEdwwayLZld8y/Y4hlVMUrFUOZZtIIXmiMhgHT+M 1oRVmjg0CKptS1eqYfEttkehZA9eyfZjxLY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2945 V2: Move "Status =3D EFI_SUCCESS;" before the EDKII_TCG_PRE_HASH check. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Cc: Laszlo Ersek Reviewed-by: Jiewen Yao Signed-off-by: Zhiguang Liu Reviewed-by: Laszlo Ersek --- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 1 + 1 file changed, 1 insertion(+) diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c b/SecurityPkg/Tcg/Tcg2Pei/Tc= g2Pei.c index 0e770f4485..93a8803ff6 100644 --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c @@ -456,6 +456,7 @@ HashLogExtendEvent ( if ((Flags & EDKII_TCG_PRE_HASH) !=3D 0 || (Flags & EDKII_TCG_PRE_HASH_L= OG_ONLY) !=3D 0) { ZeroMem (&DigestList, sizeof(DigestList)); CopyMem (&DigestList, HashData, sizeof(DigestList)); + Status =3D EFI_SUCCESS; if ((Flags & EDKII_TCG_PRE_HASH) !=3D0 ) { Status =3D Tpm2PcrExtend ( NewEventHdr->PCRIndex, --=20 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64865): https://edk2.groups.io/g/devel/message/64865 Mute This Topic: https://groups.io/mt/76530112/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-