From nobody Wed May 1 20:29:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+64142+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+64142+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1597305556; cv=none; d=zohomail.com; s=zohoarc; b=LovCBp+I4CrrUHsthgBKu5ttr8B00FFY/v6zLLqPp7MAnP4LZ0pF/eMQBHpKpejmBXnDxHzQot+6USYQBZPSBreVDVZ2lyq5OcrsI6dPHXBDVj8Wtm1SIrVLb+W9aBNgYLaRmi32KgWTJLFm3eFRVVkfN3Fmg7FWsmMjisGGhSM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597305556; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=mvjJgX6obUWkB5Y6ru5Ak/otwMlWIIfHNTj6jnOTBCM=; b=MXgn67oviujQ+CxqzZa/TYAvJ+CNwBy+ql/bRbt6a3zFOLy3e3uB9/BxRqFryyF1jbs9o5rlGMO9TJWO3O2wQJ0ZUfDc0AI61DelX1G+v1n0fJdKfQsS7ZZScGCnXgX3iY0PuEAvsu/oc/5ecKS2GfXlxjTZhqdBievhUev02JU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+64142+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1597305555979805.7228324885045; Thu, 13 Aug 2020 00:59:15 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id w9P9YY1788612xVnIC8EcSkV; Thu, 13 Aug 2020 00:59:15 -0700 X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.5711.1597305553366674058 for ; Thu, 13 Aug 2020 00:59:13 -0700 IronPort-SDR: dA7KSGljgDgjxmb4+AljXeWLvfVojvYGK3bifgXng9nC1cDVOYdRbYyIPFuzMWJihfXq4ZNMun Abd16eoZyk/g== X-IronPort-AV: E=McAfee;i="6000,8403,9711"; a="239014572" X-IronPort-AV: E=Sophos;i="5.76,307,1592895600"; d="scan'208";a="239014572" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2020 00:59:11 -0700 IronPort-SDR: ro3NDM87I6+/w72L7v6y51zkx1wsu/DntogyZCBymoLQvAh0Ygy14mIl8c6TfYhuHkIEFngdlS wQLoOE/eodAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,307,1592895600"; d="scan'208";a="291302957" X-Received: from shwde7172.ccr.corp.intel.com ([10.239.154.19]) by orsmga003.jf.intel.com with ESMTP; 13 Aug 2020 00:59:09 -0700 From: "Liming Gao" To: devel@edk2.groups.io Cc: Bob Feng , Yuwei Chen Subject: [edk2-devel] [Patch] BaseTools: Fix the issue in VS2017/VS2019 setting Date: Thu, 13 Aug 2020 15:59:05 +0800 Message-Id: <20200813075905.1729-1-liming.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,liming.gao@intel.com X-Gm-Message-State: XdscpJMhbnMsgYyCv9ldGXkxx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1597305555; bh=KaeLnV3fqxfY6cEmMhfE/pMbuiuW//URcLNUwfejr4E=; h=Cc:Date:From:Reply-To:Subject:To; b=YsGI9UZAR7PgVxnE4t3RwJvzcuetIVKxbUs2tVgxpgAW9n3pbsBMKU4mkeCSCKzXv5O NdtgqcG0qgRD+NrE+eMTQ2PSypD5FpunvOUhmDZgycfz4yGhEPrgh5A5/mz+lo8sUzfT7 t17QMD+cZ+gHkRfoWxdcXcwS3d0mY+aVmaM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" edksetup.bat VS2017 should set VS2017 only. But now, it will set VS2017/VS2019 both. This patch corrects it. Signed-off-by: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Reviewed-by: Bob Feng --- This patch bases on the change https://edk2.groups.io/g/devel/message/64138 BaseTools/set_vsprefix_envs.bat | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BaseTools/set_vsprefix_envs.bat b/BaseTools/set_vsprefix_envs.= bat index 2627587ba3..d4eb84f064 100644 --- a/BaseTools/set_vsprefix_envs.bat +++ b/BaseTools/set_vsprefix_envs.bat @@ -167,6 +167,8 @@ if not defined WINSDK_PATH_FOR_RC_EXE ( ) ) =20 +if /I "%1"=3D=3D"VS2017" goto SetWinDDK + :SetVS2019 if not defined VS160COMNTOOLS ( @REM clear two envs so that vcvars32.bat can run successfully. @@ -226,6 +228,8 @@ if not defined WINSDK_PATH_FOR_RC_EXE ( ) ) =20 +if /I "%1"=3D=3D"VS2019" goto SetWinDDK + :SetWinDDK if not defined WINDDK3790_PREFIX ( set WINDDK3790_PREFIX=3DC:\WINDDK\3790.1830\bin\ --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64142): https://edk2.groups.io/g/devel/message/64142 Mute This Topic: https://groups.io/mt/76163640/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-