From nobody Tue May 7 04:45:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+64053+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+64053+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1597216970; cv=none; d=zohomail.com; s=zohoarc; b=OcHqzCp1W59O/tO3bxwFrW0sUR+cvTE8/+F92D6EjrRbejFwalH84D3u/d6Bqbfjdp32gPjuJPY4j5Ve7Umt4BcXf0Mo0o7F/W3bkV+UghPEfddIN8ElDK0lpRz+vlVwZzCirg+4qGeRlIQhbdjMCLVzYg4J0bZbTHrx8yJu1q8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597216970; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=5XtZzWVpKSNiLC36D8A6va9vubuYMcDlAQzp+mJIGYI=; b=BhKY7bq4ZMUxjZMReg04MMD3H+/jdF3PrwDiQ/3MSdi3vWksO2rgDmBkYheI7o1GoYSX8m6J4/nKIY7xO5TDklWWCyKb8jpmq0W/b2cZbLg2eku2ef7PTuA+coCDX+MfBTOgHePyd4jz/o8lHqnOE+zfy/9177Ry3CT/WtUvVdU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+64053+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1597216970210308.4815874396761; Wed, 12 Aug 2020 00:22:50 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 5voCYY1788612xxUl0jRE1pU; Wed, 12 Aug 2020 00:22:48 -0700 X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.9856.1597216967866875012 for ; Wed, 12 Aug 2020 00:22:48 -0700 IronPort-SDR: S+bIimQXkVpxVJtXRsE64DVqdfx1hqyb03QF8feV/HMhikGcpmek+xLJhHx4cfXfhXFw72BAHS 9HxyW+2JU3Gw== X-IronPort-AV: E=McAfee;i="6000,8403,9710"; a="218243548" X-IronPort-AV: E=Sophos;i="5.76,303,1592895600"; d="scan'208";a="218243548" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2020 00:22:47 -0700 IronPort-SDR: d3z66Zx60vysVl5oRFxJ/EjxjgsYOULdc0TrN1NugMYLy6rBoer8w/xt/7Nct0UkXcP0o2llN5 PmjU/hUxidLQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,303,1592895600"; d="scan'208";a="324993582" X-Received: from guominji-mobl.ccr.corp.intel.com ([10.238.13.140]) by orsmga008.jf.intel.com with ESMTP; 12 Aug 2020 00:22:45 -0700 From: "Guomin Jiang" To: devel@edk2.groups.io Cc: Jian J Wang , Liming Gao Subject: [edk2-devel] [edk2-wiki][PATCH v3] Update the Boot Guard TOCTOU wiki page. Date: Wed, 12 Aug 2020 15:20:59 +0800 Message-Id: <20200812072059.1464-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: LrskagFXM0cF9Iho4LjnPieFx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1597216968; bh=3WlqUucRTodYXfNbX5xJvA1rFMltfWHERTprksZ285M=; h=Cc:Date:From:Reply-To:Subject:To; b=Qqay/4IHvUuj0QFgRD+FmC6WN1Y4zBRSIMshVhu7UWVyGnVHPVt4CrCVICeWErgoa2B TEuhrML5N0r0tROdWdIm2IwZD/9ICXtlpXaq8WMt9ERrgxQvuyXDD3m2Jj1qDnXdpbksT c2MZ3cEiOkpR9weRzWs0oMqNv9tEIKkcmu4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The Boot Guard TOCTOU have been migrated into edk2/master. Update the document to meet the change. Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Liming Gao Reviewed-by: Jian J Wang Reviewed-by: Liming Gao --- Boot-Guard-TOCTOU-Vulnerability-Mitigation.md | 30 +++++++------------ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/Boot-Guard-TOCTOU-Vulnerability-Mitigation.md b/Boot-Guard-TOC= TOU-Vulnerability-Mitigation.md index e59c7b1..3fce589 100644 --- a/Boot-Guard-TOCTOU-Vulnerability-Mitigation.md +++ b/Boot-Guard-TOCTOU-Vulnerability-Mitigation.md @@ -45,32 +45,22 @@ references must be updated. In this mitigation, the pro= cess of performing these The changes described in this mitigation are intended to simply integrate = into firmware solutions. For the changes to function as intended, the platform firmware implementation should follow t= hese guidelines. =20 -The changes are currently being staged in the following EDK II fork for ad= ditional validation before being -sent to the EDK II mailing list: https://github.com/makubacki/edk2/tree/bt= g_toctou_mitigation_staging - -The changes should not be considered final or production ready until they = are reviewed and pushed onto edk2/master. - -1. Always ensure PcdShadowPeimOnBoot and PcdShadowPeimOnS3Boot - (if platform supports S3) are set to TRUE if Boot Guard is - enabled and V=3D1 or M=3D1. -2. Always ensure PcdMigrateTemporaryRamFirmwareVolumes is set to TRUE. -3. Ensure that all PEIMs are relocatable. Relocation tables should +1. Always ensure PcdMigrateTemporaryRamFirmwareVolumes is set to TRUE + if Boot Guard is enabled and V=3D1 or M=3D1. +2. Ensure that all PEIMs are relocatable. Relocation tables should not be stripped. -4. If an Intel® Firmware Support Package (FSP) binary solution is +3. If an Intel® Firmware Support Package (FSP) binary solution is used, the binary must have these mitigation changes integrated. -5. Avoid maintaining pointers to pre-memory addresses inside embedded +4. Avoid maintaining pointers to pre-memory addresses inside embedded structures or other non-standard structures that the automatic migration code introduced in this change cannot identify. -6. Migrate the FIT table based on platform requirements for FIT +5. Migrate the FIT table based on platform requirements for FIT access in post-memory. +6. Add the SecMigrationPei.inf component to migrate the pointer from + the SEC phase. =20 -**Very Important** - -7. Enable paging after memory initialization and mark the IBB range - as Not Present (NP). - - This will cause a page fault on access to the IBB region. This CR2 regi= ster can be used to identify the address - accessed and the IP. +Notes: IBB will be set Not Present, you will see a page fault if any code = access to the IBB region after migration. + the address where the code access can be identified in the CR2 regi= ster. =20 # High-Level Migration Required Resources that must be migrated can be categorized as code or data. --=20 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64053): https://edk2.groups.io/g/devel/message/64053 Mute This Topic: https://groups.io/mt/76142970/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-