From nobody Tue Feb 10 01:16:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+64024+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+64024+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1597195291; cv=none; d=zohomail.com; s=zohoarc; b=WmLC4s/Vuql2bgUV0lYHoGTh+Kidy/Yln/AHHuh/C+KpsNa+A7/AZ72KrHiiuF0uKLGNDf3yM76K6kfaYXTQWAJMZIK0finO6dy1x1BAiJAiKVVXWgO5zb1y+X/m08M4QDf65kGBviAN7hoIN0Nwd6CLFZeDkkGhcdctYhzd1GU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597195291; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Es7pFlWBrD0OtazbiGJTrO8C8aQpmKCy5eMAJ6K36Js=; b=CD8AtzBroWyhnmqnu44skzXnq9+g1wZ1Zt0vyBS3NUybv/JvmT4jcuI7s0nHOfD6s5S4MfVI7DrPdVi9j7WqxrnvkTtUeXtsgqgv1Rc37fcbXipe1JwcFw63hL+7My3NabFMammLT6MRR+IAadpwNNEb+vrTSg0Qs4t3EDsM0qk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+64024+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1597195291989320.9990287001415; Tue, 11 Aug 2020 18:21:31 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ICQdYY1788612xM9v7fUF3ah; Tue, 11 Aug 2020 18:21:31 -0700 X-Received: from mga01.intel.com (mga01.intel.com []) by mx.groups.io with SMTP id smtpd.web10.6027.1597195289387869314 for ; Tue, 11 Aug 2020 18:21:30 -0700 IronPort-SDR: F7xTnFyppBFHma/HXyFw4dUp7TkMhp30lSV/rbaaB2iqc31dXCnt5bNQnRe/0lHoRM+VXpuOhC /CgzBbeqkmng== X-IronPort-AV: E=McAfee;i="6000,8403,9710"; a="171908215" X-IronPort-AV: E=Sophos;i="5.76,302,1592895600"; d="scan'208";a="171908215" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2020 18:21:29 -0700 IronPort-SDR: GeuoxCPjaSU/i7d3bcJyJ3pTRRbXJRCeT9V96cw0/Z239YDxgC/LBgJpOEyLWsvkmCahTGd4kB fF3CHiEPL3Dg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,302,1592895600"; d="scan'208";a="494868724" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.153.108]) by fmsmga006.fm.intel.com with ESMTP; 11 Aug 2020 18:21:28 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Ray Ni , Gary Lin , Andrew Fish Subject: [edk2-devel] [PATCH V2 1/3] MdeModulePkg/PartitionDxe: Put the UDF check ahead of MBR Date: Wed, 12 Aug 2020 09:21:22 +0800 Message-Id: <20200812012124.18220-2-zhichao.gao@intel.com> In-Reply-To: <20200812012124.18220-1-zhichao.gao@intel.com> References: <20200812012124.18220-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: aygJl3So6CnXrmx4dGxBF2kXx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1597195291; bh=V50Q062VMbgndbiUEZ3gYYEM8pGKePD0rnRBpnPWxQk=; h=Cc:Date:From:Reply-To:Subject:To; b=cSmKkTTVwaALNYACf7pn+yltPW1Rk3pm1ZHGvhpFXndb7EAUWrOzp/4cdqBvo6IQbK6 TtHVk5npI37ucUBaRWPcJr1vRW9KJZVV35i6fWg2+Q9c3urT0eSc5Dfbf3FVhWYL6/7cl 2MVrppwOLGzVXEjuF8bXnMbkpmWCsHGSLZE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2823 Refer to UEFI spec 2.8, Section 13.3.2, a block device should be scanned as below order: 1. GPT 2. ISO 9660 (El Torito) (UDF should aslo be here) 3. MBR 4. no partition found Note: UDF is using the same boot method as CD, so put it in the same priority with ISO 9660. This would also solve the issue that ISO image with MBR would be treat as MBR device instead of CD/DVD. That would make the behavior of the image boot different: If the CD/DVD's MBR be handled correctly, it would be enumerated as a bootable device with MBR path and FAT filesystem. Some Linux Distributions boot from such path (FAT with MBR path for ISO) would come into the grub console instead of the installation selection. With this change, the CD/DVD would always be enumerated with CD path. And it would always boot to the installation selection. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Gary Lin Cc: Andrew Fish Signed-off-by: Zhichao Gao Reviewed-by: Hao A Wu Reviewed-by: Ray Ni --- MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c b/MdeModu= lePkg/Universal/Disk/PartitionDxe/Partition.c index 6a43c3cafb..473e091320 100644 --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c @@ -35,11 +35,19 @@ EFI_DRIVER_BINDING_PROTOCOL gPartitionDriverBinding =3D= { =20 // // Prioritized function list to detect partition table. +// Refer to UEFI Spec 13.3.2 Partition Discovery, the block device +// should be scanned in below order: +// 1. GPT +// 2. ISO 9660 (El Torito) (or UDF) +// 3. MBR +// 4. no partiton found +// Note: UDF is using a same method as booting from CD-ROM, so put it along +// with CD-ROM check. // PARTITION_DETECT_ROUTINE mPartitionDetectRoutineTable[] =3D { PartitionInstallGptChildHandles, - PartitionInstallMbrChildHandles, PartitionInstallUdfChildHandles, + PartitionInstallMbrChildHandles, NULL }; =20 --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64024): https://edk2.groups.io/g/devel/message/64024 Mute This Topic: https://groups.io/mt/76139479/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-