From nobody Sat Apr 20 06:48:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+63297+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+63297+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1595844423; cv=none; d=zohomail.com; s=zohoarc; b=Iwp8DF2rEYhVZU+4N5x1Sdj/14Hak3F3sQVDyDzqLalfzBn4fIs6mnXkNonlxFTPYn591umBJTuNhKNPSrVhzC2Hjx4cb8cb7reD86m7M+KVo9pQRNvKAobmhwMMSlftaBhJcSwEYzptWdZDhUhXe2tksR1cGBCqf4/AvaCA0gY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595844423; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=/TSoYgVk/SIkOImeXqgUwStvEVmSIvPAFiuNhjrRXJk=; b=CM+4wLP0cVXjCJWXp83VpqZC+PqeAR5kQ3yN/WunyDr0Td31kig8vQL+pVdAdIGrZZ/YjHAeDt7YA3HOGhvokQH0Kkhct+hvOBAbOgMq+mSfsiPQ1WBAo4OlodnG5k8gIZHA4SoKjc/BhSBLfuOAXkl4cgwC+mktIwyZBbTMwo0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+63297+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1595844423295295.72908214653353; Mon, 27 Jul 2020 03:07:03 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 9Ze2YY1788612xiKfxUzW2pX; Mon, 27 Jul 2020 03:07:02 -0700 X-Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web11.46957.1595815157109613705 for ; Sun, 26 Jul 2020 18:59:18 -0700 X-Received: by mail-wm1-f66.google.com with SMTP id f18so3741378wmc.0 for ; Sun, 26 Jul 2020 18:59:16 -0700 (PDT) X-Gm-Message-State: d8Nufm9KU4VAVn06sZJjbTXOx1787277AA= X-Google-Smtp-Source: ABdhPJzhWvP99xm+fN4JP5PrgHMVOk+pmZ3H4/UKWI0oWYip/YFzymbm23GHISm7l65CxbF3WgAEeg== X-Received: by 2002:a1c:9e4c:: with SMTP id h73mr19719177wme.177.1595815155415; Sun, 26 Jul 2020 18:59:15 -0700 (PDT) X-Received: from Jessicas-MacBook.local (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id c4sm1279412wrt.41.2020.07.26.18.59.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 26 Jul 2020 18:59:14 -0700 (PDT) X-Received: by Jessicas-MacBook.local (Postfix, from userid 501) id C9BFE207B5EFDF; Mon, 27 Jul 2020 02:59:13 +0100 (BST) From: Jessica Clarke To: devel@edk2.groups.io Cc: Jessica Clarke , "Gao, Liming" , "leif@nuviainc.com" , "Kinney, Michael D" Subject: [edk2-devel] [PATCH v2] MdePkg Base.h: Delete prototype for __builtin_return_address Date: Mon, 27 Jul 2020 02:58:50 +0100 Message-Id: <20200727015850.16776-1-jrtc27@jrtc27.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jrtc27@jrtc27.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1595844422; bh=O/nBbGynb6uWY8F9nMj/IFi7HXU+L2O+sJXicuzYALU=; h=Cc:Date:From:Reply-To:Subject:To; b=s93cjSuHUbEenI5fotIkGDAuqJoEyfhrlPDYgqm0jomlUpMxk09iohhgSoWlUkwrZiS vuDGFr076WJr5nMMaS13iN3sn/+Y6tjTlM7C105eUYkX8/bxXeeDPcVKJJNA5SLr5AlDR QUvs6gKrugprCtzdqfgCTUQNmlgt+LxlQw0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1004 Being a compiler builtin, the type of __builtin_return_address is already known to the compiler so no prototype is needed. Clang also errors out when redeclaring certain builtins like this[1], though currently only for ones with custom type checking. At the moment, __builtin_return_address does not use custom type checking and so does not trigger this error, however, the CHERI fork of LLVM, which will form the basis of the toolchain for Arm's experimental Morello platform, does use custom type checking for it, and so gives an error. Thus, simply delete the unnecessary line. [1] llvm/llvm-project@41af97137572ad6d4dafc872e7ecf6bbb08d4984 Cc: Leif Lindholm Signed-off-by: Jessica Clarke Reviewed-by: Liming Gao --- Changes in v2: * Shortened [1] reference to fit column limit. The bug report has the full URL already, and this will still link correctly on GitHub. MdePkg/Include/Base.h | 1 - 1 file changed, 1 deletion(-) diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index 85a091b9d5..8e4271f6ea 100644 --- a/MdePkg/Include/Base.h +++ b/MdePkg/Include/Base.h @@ -1273,7 +1273,6 @@ typedef UINTN RETURN_STATUS; **/ #define RETURN_ADDRESS(L) ((L =3D=3D 0) ? _ReturnAddress() : (VOID *= ) 0) #elif defined (__GNUC__) || defined (__clang__) - void * __builtin_return_address (unsigned int level); /** Get the return address of the calling function. =20 -- 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63297): https://edk2.groups.io/g/devel/message/63297 Mute This Topic: https://groups.io/mt/75819415/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-