[edk2-devel] [PATCH v7 0/6] Add capability to let PEIM extend TcgEvent

Qi Zhang posted 6 patches 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20200722082107.12601-1-qi1.zhang@intel.com
SecurityPkg/Include/Ppi/Tcg.h                 |  60 ++++++++++
.../PeiTpmMeasurementLib.c                    |  74 ++++++++++++
.../PeiTpmMeasurementLib.inf                  |  50 ++++++++
.../PeiTpmMeasurementLib.uni                  |  17 +++
SecurityPkg/SecurityPkg.dec                   |   3 +
SecurityPkg/SecurityPkg.dsc                   |   4 +-
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c             | 110 +++++++++++++-----
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf           |   3 +-
SecurityPkg/Tcg/TcgPei/TcgPei.c               |  61 +++++++++-
SecurityPkg/Tcg/TcgPei/TcgPei.inf             |   3 +-
10 files changed, 351 insertions(+), 34 deletions(-)
create mode 100644 SecurityPkg/Include/Ppi/Tcg.h
create mode 100644 SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.c
create mode 100644 SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf
create mode 100644 SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.uni

[edk2-devel] [PATCH v7 0/6] Add capability to let PEIM extend TcgEvent

Posted by Qi Zhang 2 weeks ago
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2841

Currently, we have TCG/TCG2 protocol and DxeTpmMeasurementLib to let DXE
module extend the TCG event.
There is more and more use case in PEI phase that a PEIM need extend TCG
event, such as BootGuard, FSP, Microcode measurement. Currently, we dont
have API to do that so that each module need create TCG/TCG2 event log,
which is a burden.

This bugzilla requests to add PeiTpmMeasurementLib instance.

The implementation includes:
1) A EDKII_TCG_PPI which abstracts the HashLogExtendEvent service.
2) A PeiTpmMeasurementLib instance, so that a PEIM can call this API to
  add TCG event.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Qi Zhang <qi1.zhang@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>

Jiewen Yao (6):
  SecurityPkg/TcgPpi: Add TcgPpi header file.
  SecurityPkg/dec: Add TcgPpi.
  SecurityPkg/Tcg: Add TcgPpi
  SecurityPkg/Tcg2: Add TcgPpi
  SecurityPkg/PeiTpmMeasurementLib: Add PEI instance.
  SecurityPkg/dsc: Add PeiTpmMeasurementLib.

 SecurityPkg/Include/Ppi/Tcg.h                 |  60 ++++++++++
 .../PeiTpmMeasurementLib.c                    |  74 ++++++++++++
 .../PeiTpmMeasurementLib.inf                  |  50 ++++++++
 .../PeiTpmMeasurementLib.uni                  |  17 +++
 SecurityPkg/SecurityPkg.dec                   |   3 +
 SecurityPkg/SecurityPkg.dsc                   |   4 +-
 SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c             | 110 +++++++++++++-----
 SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf           |   3 +-
 SecurityPkg/Tcg/TcgPei/TcgPei.c               |  61 +++++++++-
 SecurityPkg/Tcg/TcgPei/TcgPei.inf             |   3 +-
 10 files changed, 351 insertions(+), 34 deletions(-)
 create mode 100644 SecurityPkg/Include/Ppi/Tcg.h
 create mode 100644 SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.c
 create mode 100644 SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf
 create mode 100644 SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.uni

-- 
2.26.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#63085): https://edk2.groups.io/g/devel/message/63085
Mute This Topic: https://groups.io/mt/75720704/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v7 0/6] Add capability to let PEIM extend TcgEvent

Posted by Wang, Jian J 2 weeks ago
For this patch series,

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: Zhang, Qi1 <qi1.zhang@intel.com>
> Sent: Wednesday, July 22, 2020 4:21 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Qi1 <qi1.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>
> Subject: [PATCH v7 0/6] Add capability to let PEIM extend TcgEvent
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2841
> 
> Currently, we have TCG/TCG2 protocol and DxeTpmMeasurementLib to let DXE
> module extend the TCG event.
> There is more and more use case in PEI phase that a PEIM need extend TCG
> event, such as BootGuard, FSP, Microcode measurement. Currently, we dont
> have API to do that so that each module need create TCG/TCG2 event log,
> which is a burden.
> 
> This bugzilla requests to add PeiTpmMeasurementLib instance.
> 
> The implementation includes:
> 1) A EDKII_TCG_PPI which abstracts the HashLogExtendEvent service.
> 2) A PeiTpmMeasurementLib instance, so that a PEIM can call this API to
>   add TCG event.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Qi Zhang <qi1.zhang@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> 
> Jiewen Yao (6):
>   SecurityPkg/TcgPpi: Add TcgPpi header file.
>   SecurityPkg/dec: Add TcgPpi.
>   SecurityPkg/Tcg: Add TcgPpi
>   SecurityPkg/Tcg2: Add TcgPpi
>   SecurityPkg/PeiTpmMeasurementLib: Add PEI instance.
>   SecurityPkg/dsc: Add PeiTpmMeasurementLib.
> 
>  SecurityPkg/Include/Ppi/Tcg.h                 |  60 ++++++++++
>  .../PeiTpmMeasurementLib.c                    |  74 ++++++++++++
>  .../PeiTpmMeasurementLib.inf                  |  50 ++++++++
>  .../PeiTpmMeasurementLib.uni                  |  17 +++
>  SecurityPkg/SecurityPkg.dec                   |   3 +
>  SecurityPkg/SecurityPkg.dsc                   |   4 +-
>  SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c             | 110 +++++++++++++-----
>  SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf           |   3 +-
>  SecurityPkg/Tcg/TcgPei/TcgPei.c               |  61 +++++++++-
>  SecurityPkg/Tcg/TcgPei/TcgPei.inf             |   3 +-
>  10 files changed, 351 insertions(+), 34 deletions(-)
>  create mode 100644 SecurityPkg/Include/Ppi/Tcg.h
>  create mode 100644
> SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.c
>  create mode 100644
> SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.inf
>  create mode 100644
> SecurityPkg/Library/PeiTpmMeasurementLib/PeiTpmMeasurementLib.uni
> 
> --
> 2.26.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#63131): https://edk2.groups.io/g/devel/message/63131
Mute This Topic: https://groups.io/mt/75720704/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-