From nobody Sun May 19 20:29:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+62840+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62840+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1595253917; cv=none; d=zohomail.com; s=zohoarc; b=FzKTymQn5/4JcAbNdd+jgFUAEm3lA+7sRxlqxnXCqCiKkEmvrOyULW6IKTPmrLxCTDjrjnKoHTsxX4pRirzFtyO/Fet93jwLW6oNgkBLrp9MhJfuVpmIBd7oqVeZzFyZYrxWjWPBZyDlsieUkAv0kux7OJWBNbV7S+LD3XlD0Mo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595253917; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=d5ZXzO/8schihtnSSnOSd60AWmqPt9G/+S+PqPjRoEo=; b=VeN0R8olPhy1N6+aGRkGxi366uc3nKyuIt/FWQ+BkTScOXjAD0pfeDlXgVJ1jU1vDrQTAV+RLDukoKYdxbEtAPBUkcNwHXtaNPA6N3KLhTQGoLdjsN2ET1BTykUHyg+nHvnoh0cDtgO/Qu8zGe1BiwGcfl4KLonpgdDQwMHEzxg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62840+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1595253917857473.92778218481396; Mon, 20 Jul 2020 07:05:17 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Eyz1YY1788612xrAGu81FSRC; Mon, 20 Jul 2020 07:05:17 -0700 X-Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web10.38410.1595252994889496270 for ; Mon, 20 Jul 2020 06:49:55 -0700 X-Received: by mail-wr1-f68.google.com with SMTP id o11so17930433wrv.9 for ; Mon, 20 Jul 2020 06:49:54 -0700 (PDT) X-Gm-Message-State: BnNzq0u3fWKVsCP2CXyW2Q38x1787277AA= X-Google-Smtp-Source: ABdhPJxf4w97MsRimGPE7ZyK6jgvEk3myxfiecxrFS04mass4lcoAuLKfITIofrlS5n0RAbRy/9LHA== X-Received: by 2002:a5d:4a41:: with SMTP id v1mr13274615wrs.371.1595252993105; Mon, 20 Jul 2020 06:49:53 -0700 (PDT) X-Received: from Jessicas-MacBook.local (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id x11sm16026403wrl.28.2020.07.20.06.49.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 Jul 2020 06:49:52 -0700 (PDT) X-Received: by Jessicas-MacBook.local (Postfix, from userid 501) id E7F82207A913E0; Mon, 20 Jul 2020 14:49:51 +0100 (BST) From: Jessica Clarke To: devel@edk2.groups.io Cc: Jessica Clarke , Leif Lindholm Subject: [edk2-devel] [PATCH] MdePkg Base.h: Delete prototype for __builtin_return_address Date: Mon, 20 Jul 2020 14:49:46 +0100 Message-Id: <20200720134946.33723-1-jrtc27@jrtc27.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jrtc27@jrtc27.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1595253917; bh=NS5sht5lkPq41cN3kLixQdzP1dRfQBFl2eeGZAdrgss=; h=Cc:Date:From:Reply-To:Subject:To; b=l2VWkfvWqAvcjyQD1d+JQhB6FluaRs+D3DbhR783FYfVO7YagXIo79Bx+2Ud1lbFZBV F5xtX0VMG6FKqt/B5IHwj3MZZSJmSWlDx4J69cmpDmqLRNlXRSDwiHRiDvQRYfURdiHvL gE4pRNGiSZyWCJfAxvS+5GlmbZ/stsZBvT4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1004 Being a compiler builtin, the type of __builtin_return_address is already known to the compiler so no prototype is needed. Clang also errors out when redeclaring certain builtins like this[1], though currently only for ones with custom type checking. At the moment, __builtin_return_address does not use custom type checking and so does not trigger this error, however, the CHERI fork of LLVM, which will form the basis of the toolchain for Arm's experimental Morello platform, does use custom type checking for it, and so gives an error. Thus, simply delete the unnecessary line. [1] https://github.com/llvm/llvm-project/commit/41af97137572ad6d4dafc872e7e= cf6bbb08d4984 Cc: Leif Lindholm Signed-off-by: Jessica Clarke Reviewed-by: Leif Lindholm Reviewed-by: Zhiguang Liu --- MdePkg/Include/Base.h | 1 - 1 file changed, 1 deletion(-) diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index 85a091b9d5..8e4271f6ea 100644 --- a/MdePkg/Include/Base.h +++ b/MdePkg/Include/Base.h @@ -1273,7 +1273,6 @@ typedef UINTN RETURN_STATUS; **/ #define RETURN_ADDRESS(L) ((L =3D=3D 0) ? _ReturnAddress() : (VOID *= ) 0) #elif defined (__GNUC__) || defined (__clang__) - void * __builtin_return_address (unsigned int level); /** Get the return address of the calling function. =20 --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62840): https://edk2.groups.io/g/devel/message/62840 Mute This Topic: https://groups.io/mt/75682100/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-