From nobody Sat May 4 16:24:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+62762+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62762+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1594980564; cv=none; d=zohomail.com; s=zohoarc; b=Ac6mqzh8Gx4VxFF6EY3bBy9ByM8HvA1WrVDo/tAhmWVtOsPQaI9KzibgXYmcGvUEPTjcWCLEdLJn7k7Ht4UbOTO+/uq2XKW+lV384VYBTyR72QEGc78frLMKloJFRMzC5c0vsNPSJuOAg75TNsdZ13KI4Lwx1ziIuJt2/Ttmm2U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594980564; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=6TmVzVMdQmmyDJKw5I14pgkm4g3zWXmHZvwIr0Mp/oI=; b=AKRNo8/UrVG2kVopyMCNhPiDI+I711WRjjttL14wFoeNA9pWy7wsK4BLFymCAuh/gItIqwbn255KeuzUJgC7a1ZSO+nMEofE2wtbqcB1enNFj5qf3jLiCzSEfINEWIWB9TcOk0ZtBp+TXShHvfKD+ptD74g0FqLjOB7z44Pspv0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62762+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1594980564221622.0467442555517; Fri, 17 Jul 2020 03:09:24 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id QvRBYY1788612xNlSZx8Vzgm; Fri, 17 Jul 2020 03:09:23 -0700 X-Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by mx.groups.io with SMTP id smtpd.web12.8275.1594980563351030588 for ; Fri, 17 Jul 2020 03:09:23 -0700 X-Received: by mail-pf1-f194.google.com with SMTP id 1so5166642pfn.9 for ; Fri, 17 Jul 2020 03:09:23 -0700 (PDT) X-Gm-Message-State: 5kg1mc3nslUZl0atKMDrHUqMx1787277AA= X-Google-Smtp-Source: ABdhPJw8EaO2cwxe8x/4mCZ5IrYm6FxvtglNpy4HJ3Z/RYG2ZH7R4cx5eJD2CpemFAulQe2A3TMRJQ== X-Received: by 2002:a63:8f51:: with SMTP id r17mr8035919pgn.124.1594980562218; Fri, 17 Jul 2020 03:09:22 -0700 (PDT) X-Received: from localhost.localdomain ([2400:2411:502:a100:82fa:5bff:fe4b:26b1]) by smtp.gmail.com with ESMTPSA id q10sm8060358pfk.86.2020.07.17.03.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 03:09:21 -0700 (PDT) From: "Masahisa Kojima" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: masahisa.kojima@linaro.org Subject: [edk2-devel] [PATCH edk2-platforms 1/2] Silicon/SynQuacer: add ACPI descriptor of MMIO TPM Date: Fri, 17 Jul 2020 19:09:11 +0900 Message-Id: <20200717100912.25757-2-masahisa.kojima@linaro.org> In-Reply-To: <20200717100912.25757-1-masahisa.kojima@linaro.org> References: <20200717100912.25757-1-masahisa.kojima@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,masahisa.kojima@linaro.org Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1594980563; bh=jMVlrVdeNnCErJ73NDEh5qlOkc/m7dVY9925Jjjz9R4=; h=Cc:Date:From:Reply-To:Subject:To; b=UWj0nhW3Hav0SuZ4hsr+QPGahBLwGc99vAHMlc2aa/HOsyj21Z6OwZb8qcWrvMtFXKz TVE3XjTpyhiFKjF5G1Sgug82Z6B3FKtH7uVmqssRD1rudF/0vML9jhLNRk0dUyghdW6Iq FgLCeS6ExaI2xiafdUWO0aWOlhogUGtgonk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The second SPI controller is wired to the low speed 96boards connector on Developerbox. SynQuacer platform can exposes its SPI TPM via MMIO window that is backed by the SPI command sequencer in the SPI bus controller. This commit adds the MMIO TPM description to the DSDT. If TPM2_ENABLE build option is not enabled, existing linux SPI driver is used instead of MMIO TPM. Signed-off-by: Masahisa Kojima --- Silicon/Socionext/SynQuacer/Acpi.dsc.inc | 7 ++++++- Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 14 ++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/Silicon/Socionext/SynQuacer/Acpi.dsc.inc b/Silicon/Socionext/S= ynQuacer/Acpi.dsc.inc index acd903553368..ce5a1f6c5007 100644 --- a/Silicon/Socionext/SynQuacer/Acpi.dsc.inc +++ b/Silicon/Socionext/SynQuacer/Acpi.dsc.inc @@ -39,4 +39,9 @@ [Components.common] gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20 } MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf - Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf + Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf { + +!if $(TPM2_ENABLE) =3D=3D TRUE + *_*_*_ASLPP_FLAGS =3D -DTPM2_ENABLE +!endif + } diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Soci= onext/SynQuacer/AcpiTables/Dsdt.asl index 50f1753c3565..bca484763d2c 100644 --- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl @@ -262,6 +262,19 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "S= YNQUACR", Name (_HID, "PNP0C0C") } =20 +#ifdef TPM2_ENABLE + // + // TPM MMIO device. + // This is backed by the SPI command sequencer in the SPI bus controll= er. + // + Device (TPM0) { + Name (_HID, "SCX0009") + Name (_UID, Zero) + Name (_CRS, ResourceTemplate () { + Memory32Fixed (ReadWrite, SYNQUACER_SPI1_MMIO_BASE, SYNQUACER_SPI1= _MMIO_SIZE) + }) + } +#else Device (SPI0) { Name (_HID, "SCX0004") Name (_UID, Zero) @@ -280,5 +293,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SY= NQUACR", } }) } +#endif } // Scope (_SB) } --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62762): https://edk2.groups.io/g/devel/message/62762 Mute This Topic: https://groups.io/mt/75608937/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 16:24:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+62763+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62763+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1594980567; cv=none; d=zohomail.com; s=zohoarc; b=e3PWFogZxTwnUY6DeR0/GCL2f625+QBX4b7CuQFBNO9Fhoy+nkPaKB4lbL5ttoU4bxlUvoomrFuuoRRLJF1/YQ0AhU1d/QnTZqQEbmb+5mimIqI9d+E5atqAP2DtmVb+1o3Hk32lTeFop4jhawPWeazySdl35DUfnDd+cUrn5XU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594980567; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=cP3GBxcGFMwBo/WhG9fTL2QByXs0eswygjGSeSljirw=; b=H5gwoowJ9VBDZOR5xrQ67yCPX4CPLdjiM6zsUlLoNcDSL467gyLKxhNcc4y83rLIZ/SV5z46NZ0kQ0N67WPGO0zDJMfCSSpRHkGUQqlYZkJpKxWiTV2EZn2jWdyrJUYrW3DevXKEKB1t91Izuu4ard+NzRVZHMLBuvDLdteUoJo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62763+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1594980567105637.5329678929688; Fri, 17 Jul 2020 03:09:27 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id CcwrYY1788612xIBHOotyBWi; Fri, 17 Jul 2020 03:09:26 -0700 X-Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by mx.groups.io with SMTP id smtpd.web10.8416.1594980565724195507 for ; Fri, 17 Jul 2020 03:09:25 -0700 X-Received: by mail-pj1-f67.google.com with SMTP id cv18so3964614pjb.1 for ; Fri, 17 Jul 2020 03:09:25 -0700 (PDT) X-Gm-Message-State: bTgfxKGolBJWZlC6Jy4zMjh8x1787277AA= X-Google-Smtp-Source: ABdhPJxtSW+aP4C3IiNaaJ6KySHgZyAJfu4nJrRAm8rBI9g+bB6iVuwICD3c73hbUwRFVH2cuxcTsA== X-Received: by 2002:a17:902:fe8f:: with SMTP id x15mr6889861plm.249.1594980564767; Fri, 17 Jul 2020 03:09:24 -0700 (PDT) X-Received: from localhost.localdomain ([2400:2411:502:a100:82fa:5bff:fe4b:26b1]) by smtp.gmail.com with ESMTPSA id q10sm8060358pfk.86.2020.07.17.03.09.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 03:09:23 -0700 (PDT) From: "Masahisa Kojima" To: devel@edk2.groups.io, ard.biesheuvel@arm.com, leif@nuviainc.com Cc: masahisa.kojima@linaro.org Subject: [edk2-devel] [PATCH edk2-platforms 2/2] Silicon/SynQuacer: CRLF fixup for Acpi.dsc.inc Date: Fri, 17 Jul 2020 19:09:12 +0900 Message-Id: <20200717100912.25757-3-masahisa.kojima@linaro.org> In-Reply-To: <20200717100912.25757-1-masahisa.kojima@linaro.org> References: <20200717100912.25757-1-masahisa.kojima@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,masahisa.kojima@linaro.org Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1594980566; bh=yjd8DW4fU6+WFzLdJs7/BO3Wojh1WwrF52pd/Kme7og=; h=Cc:Date:From:Reply-To:Subject:To; b=cNpxbCsFNH5W86PmDol2lhtFAb7pFXDs9q8ms0BRvQsCLpQAYqfJayib5Z4ucJoPcY7 SLz4cdseI7FMf9PrQW7M3DG2Ctu6Q8JcHqQTK/mDD2FpvMRNEY79AjHNpk0qG43owAcnY 7TX3T1lT8m5KpkI20K/NO4PEFMpgMt5nUac= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" All of line endings of Acpi.dsc.inc are not CRLF, resolve this. Signed-off-by: Masahisa Kojima --- Silicon/Socionext/SynQuacer/Acpi.dsc.inc | 94 ++++++++++---------- 1 file changed, 47 insertions(+), 47 deletions(-) diff --git a/Silicon/Socionext/SynQuacer/Acpi.dsc.inc b/Silicon/Socionext/S= ynQuacer/Acpi.dsc.inc index ce5a1f6c5007..93e6f822e8b8 100644 --- a/Silicon/Socionext/SynQuacer/Acpi.dsc.inc +++ b/Silicon/Socionext/SynQuacer/Acpi.dsc.inc @@ -1,47 +1,47 @@ -# -# Copyright (c) 2018, Linaro Limited. All rights reserved. -# -# SPDX-License-Identifier: BSD-2-Clause-Patent -# - -##########################################################################= ###### -# -# Pcd Section - list of all EDK II PCD Entries defined by this Platform -# -##########################################################################= ###### - -[PcdsFeatureFlag] - gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE - -[PcdsFixedAtBuild.common] - gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId|"SNI " - gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId|0x52434155514e59= 53 # SYNQUACR - gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision|0x20180226 - gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId|0x4f524e4c # LNRO - gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision|1 - -##########################################################################= ###### -# -# Components Section - list of all EDK II Modules needed by this Platform -# -##########################################################################= ###### - -[Components.common] - # - # ACPI support - # - MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf { - - NULL|EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf - - - # support ACPI v5.0 or later - gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20 - } - MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf - Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf { - -!if $(TPM2_ENABLE) =3D=3D TRUE - *_*_*_ASLPP_FLAGS =3D -DTPM2_ENABLE -!endif - } +# +# Copyright (c) 2018, Linaro Limited. All rights reserved. +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +# + +##########################################################################= ###### +# +# Pcd Section - list of all EDK II PCD Entries defined by this Platform +# +##########################################################################= ###### + +[PcdsFeatureFlag] + gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE + +[PcdsFixedAtBuild.common] + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId|"SNI " + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemTableId|0x52434155514e59= 53 # SYNQUACR + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision|0x20180226 + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId|0x4f524e4c # LNRO + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision|1 + +##########################################################################= ###### +# +# Components Section - list of all EDK II Modules needed by this Platform +# +##########################################################################= ###### + +[Components.common] + # + # ACPI support + # + MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf { + + NULL|EmbeddedPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf + + + # support ACPI v5.0 or later + gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20 + } + MdeModulePkg/Universal/Acpi/AcpiPlatformDxe/AcpiPlatformDxe.inf + Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf { + +!if $(TPM2_ENABLE) =3D=3D TRUE + *_*_*_ASLPP_FLAGS =3D -DTPM2_ENABLE +!endif + } --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62763): https://edk2.groups.io/g/devel/message/62763 Mute This Topic: https://groups.io/mt/75608938/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-