From nobody Tue Feb 10 19:14:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+62729+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62729+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1594966330397670.5279081828481; Thu, 16 Jul 2020 23:12:10 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id xc2oYY1788612xuQOf3q2quL; Thu, 16 Jul 2020 23:12:10 -0700 X-Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [62.140.7.102]) by mx.groups.io with SMTP id smtpd.web10.6001.1594966329191921424 for ; Thu, 16 Jul 2020 23:12:09 -0700 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-16-OgIQvlnxN-KRveZcAwx24w-1; Fri, 17 Jul 2020 08:12:06 +0200 X-MC-Unique: OgIQvlnxN-KRveZcAwx24w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VBHiwjyBl07IphcIrRjOeIEExM2giQdgL9qIhnkqM8wACFyevyI7GMuzj8t6uiyWrwZCOiYyu5tvsPDmksIYlixEoX4CT76H+bSB8nRk3+B1BED5y1WN/Zrtdx2BSLpQVKUq/7d8q/y8tdK57pdQhUGWM62QHQWleglpDUIebPseIE7yj0YEwN6bHpbCfhNUiee/Kl5Vy8ZwjbzSrYoyv4+O8+cxqzmU0sbRYYCofFxjKBnYaxtELviwW9kE3ZIBWoGLLKFa1K0t1x9kI6YUnW9jxE5wmRNLDJPNjmeo9iGuEn09O/TI0dVr/WEol7fjHvRoelL+9bhRt4Q6HTq5qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1NOGBTCX6qF++qENzCsiMiVBpRPOcu92a+DtoEpI4cU=; b=JiDWg/OxS6/eXdcxUswfL2lel7DmQlougxfEgO2ykrLsDyGUsGiVC0Hzc5nhUn/YFQso2JtF9L7jB+r6BdEB26kZlxIcSwyNXaKPAT5ciLrJfLJQ+62ZA5WV5+yU7Rkzgn/gyz0f4UYtPeKxE64uIxN01beJPWGD1EHWJ/T2YrCHVjYfwZHIozrmGtcHtmpisRlLDGZ0IKnHDcj+Ez5YJjoqE+ID0JMVbDxROyi+ul3JF/VIInFvre5hYr0QAO6Ably717ErdxgkVcdP0y3+nWCJAyqKt+yRzEE7D1eoheMECIHNbNaKQqxc7/PCJFWnDv67nOgTvTHv+b0lnwnH8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none X-Received: from AM0PR0402MB3809.eurprd04.prod.outlook.com (2603:10a6:208:10::30) by AM0PR04MB4740.eurprd04.prod.outlook.com (2603:10a6:208:c8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Fri, 17 Jul 2020 06:12:05 +0000 X-Received: from AM0PR0402MB3809.eurprd04.prod.outlook.com ([fe80::a14c:d441:c8a9:77ba]) by AM0PR0402MB3809.eurprd04.prod.outlook.com ([fe80::a14c:d441:c8a9:77ba%6]) with mapi id 15.20.3174.026; Fri, 17 Jul 2020 06:12:05 +0000 From: "Gary Lin" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel Subject: [edk2-devel] [PATCH v3 08/11] OvmfPkg/LsiScsiDxe: Map DMA buffer Date: Fri, 17 Jul 2020 14:11:27 +0800 Message-Id: <20200717061130.8881-9-glin@suse.com> In-Reply-To: <20200717061130.8881-1-glin@suse.com> References: <20200717061130.8881-1-glin@suse.com> X-ClientProxiedBy: AM0PR04CA0138.eurprd04.prod.outlook.com (2603:10a6:208:55::43) To AM0PR0402MB3809.eurprd04.prod.outlook.com (2603:10a6:208:10::30) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from GaryWorkstation.suse.cz (60.251.47.115) by AM0PR04CA0138.eurprd04.prod.outlook.com (2603:10a6:208:55::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend Transport; Fri, 17 Jul 2020 06:12:03 +0000 X-Originating-IP: [60.251.47.115] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8592de82-8402-4928-7737-08d82a1853f0 X-MS-TrafficTypeDiagnostic: AM0PR04MB4740: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: ndxVlE+IxaOR6FV2EHNjKA2XvMz3aucYoFESobaYNECWr0sX9XpW933NKmNHSSdc7yfD8VbYuxoxmJOAaDc+xPW4bIc98cxYMQf+9V3AcmT0RxeSoJU9Hvrn6W8YJRauB9MC9on3AUeQ06ZCsjuq2NybC3ssxzvQdYYTYOMFj/rKH1vjFwXXZ8TOS/eH3mzpEYZkIBa3vT4/X3pKRcnehiIS+NjiyIYMkA97c62MHANacm4KrCpgKvkX4gBDnohJw7xr57xwrlke3y2u1Zn/FgRl4rKRuuzXUvJV+F4B9ME1PA1oM+HyHAHiUARKndJTupQKdRIqlkGDVYqvtDqoNQ== X-MS-Exchange-AntiSpam-MessageData: oNBeChtFy1wfc7W/v4IHieTLve14jvBp6wNO/n6Q/yt4I0dqdXxQBrKDZ1bCK7OPMVSOAbytaY51V+iXHodym0roM07zCH1oYflLsYnzLrDf05w/hc0R8+MZvLKyb3WyNbGT08SQmGAo1f9c18xQH9xSaaA1NmdNW9pVs0/BBfOppM0eDPIIZibl22AJK9puIUCB+fB4n0M1Zt/ClHRcoZFIk7xqoQ7Qte/yoRvOQzTis6VH18MpTiaH3NWpJATyCiD1ynieuuxDBbpIcRXBQHB2uvqdTtsRxaz/WZATqEnN/gn4D8bT92TuRR3M75NBkFQuQgnHMVO3Uj9mp0tiv9X3FydiF6ZkTspfXLJQKxYZTrVU+cMbbfFzElSDym096XjmbPhVbr6fxVccAd4isQEXdtyr+hY0Kf4GsD0s8j6JzzPuEXdR5D0gcVAJt+oifxeP42uxSOXvUH626fIfYobiVe5lsbBvbJS17chX+0k= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8592de82-8402-4928-7737-08d82a1853f0 X-MS-Exchange-CrossTenant-AuthSource: AM0PR0402MB3809.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2020 06:12:05.2442 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 35o63UFFPC0SopYAwqu+tYSMEBCGgLehkbHVn4mXheo77MH6DFWNCEbIOqihyA60 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4740 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,glin@suse.com X-Gm-Message-State: zczUbTa1nd1j8J29BfqRJUolx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1594966330; bh=Mf/0wibnHTA/brbiFNZSsab4JEwp+HpsuVOuV9OSol4=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=q/TYw4q9nM1qIVasBzdZBqkLpFCFm50j/2jP8iL+QTQLoXEMspsDTFilwV225oM2gdn o2vERzSRysPpI3zM7gjyW5JbWoqg4aH7kTtCglNG4MJdsZ+gRzigE0Ens2vB39Zv7K0wv gOHCCBw5UKxBX+RiRpbzUnShCzJq9E4RQrQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Map DMA buffer and perpare for the implementation of LsiScsiPassThru(). v2: - Replace 0x10000 with SIZE_64KB macro for the DMA buffer data array - Remove DUAL_ADDRESS_CYCLE from PciIo since we don't really need 64-bit DMA address Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin Reviewed-by: Laszlo Ersek --- OvmfPkg/LsiScsiDxe/LsiScsi.c | 62 +++++++++++++++++++++++++++++++++++- OvmfPkg/LsiScsiDxe/LsiScsi.h | 14 ++++++++ 2 files changed, 75 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/LsiScsiDxe/LsiScsi.c b/OvmfPkg/LsiScsiDxe/LsiScsi.c index a9c107c04ef1..52c224aad9a5 100644 --- a/OvmfPkg/LsiScsiDxe/LsiScsi.c +++ b/OvmfPkg/LsiScsiDxe/LsiScsi.c @@ -356,6 +356,8 @@ LsiScsiControllerStart ( { EFI_STATUS Status; LSI_SCSI_DEV *Dev; + UINTN Pages; + UINTN BytesMapped; =20 Dev =3D AllocateZeroPool (sizeof (*Dev)); if (Dev =3D=3D NULL) { @@ -411,11 +413,45 @@ LsiScsiControllerStart ( goto CloseProtocol; } =20 - Status =3D LsiScsiReset (Dev); + // + // Create buffers for data transfer + // + Pages =3D EFI_SIZE_TO_PAGES (sizeof (*Dev->Dma)); + Status =3D Dev->PciIo->AllocateBuffer ( + Dev->PciIo, + AllocateAnyPages, + EfiBootServicesData, + Pages, + (VOID **)&Dev->Dma, + EFI_PCI_ATTRIBUTE_MEMORY_CACHED + ); if (EFI_ERROR (Status)) { goto RestoreAttributes; } =20 + BytesMapped =3D EFI_PAGES_TO_SIZE (Pages); + Status =3D Dev->PciIo->Map ( + Dev->PciIo, + EfiPciIoOperationBusMasterCommonBuffer, + Dev->Dma, + &BytesMapped, + &Dev->DmaPhysical, + &Dev->DmaMapping + ); + if (EFI_ERROR (Status)) { + goto FreeBuffer; + } + + if (BytesMapped !=3D EFI_PAGES_TO_SIZE (Pages)) { + Status =3D EFI_OUT_OF_RESOURCES; + goto Unmap; + } + + Status =3D LsiScsiReset (Dev); + if (EFI_ERROR (Status)) { + goto Unmap; + } + Status =3D gBS->CreateEvent ( EVT_SIGNAL_EXIT_BOOT_SERVICES, TPL_CALLBACK, @@ -462,6 +498,19 @@ CloseExitBoot: UninitDev: LsiScsiReset (Dev); =20 +Unmap: + Dev->PciIo->Unmap ( + Dev->PciIo, + Dev->DmaMapping + ); + +FreeBuffer: + Dev->PciIo->FreeBuffer ( + Dev->PciIo, + Pages, + Dev->Dma + ); + RestoreAttributes: Dev->PciIo->Attributes ( Dev->PciIo, @@ -524,6 +573,17 @@ LsiScsiControllerStop ( =20 LsiScsiReset (Dev); =20 + Dev->PciIo->Unmap ( + Dev->PciIo, + Dev->DmaMapping + ); + + Dev->PciIo->FreeBuffer ( + Dev->PciIo, + EFI_SIZE_TO_PAGES (sizeof (*Dev->Dma)), + Dev->Dma + ); + Dev->PciIo->Attributes ( Dev->PciIo, EfiPciIoAttributeOperationSet, diff --git a/OvmfPkg/LsiScsiDxe/LsiScsi.h b/OvmfPkg/LsiScsiDxe/LsiScsi.h index 8c2acff6e86f..9f9e5c7fed00 100644 --- a/OvmfPkg/LsiScsiDxe/LsiScsi.h +++ b/OvmfPkg/LsiScsiDxe/LsiScsi.h @@ -12,6 +12,17 @@ #ifndef _LSI_SCSI_DXE_H_ #define _LSI_SCSI_DXE_H_ =20 +typedef struct { + // + // Allocate 64KB for read/write buffer. It seems sufficient for the comm= on + // boot scenarios. + // + // NOTE: The number of bytes for data transmission is bounded by DMA Byte + // Count (DBC), a 24-bit register, so the maximum is 0xFFFFFF (16M= B-1). + // + UINT8 Data[SIZE_64KB]; +} LSI_SCSI_DMA_BUFFER; + typedef struct { UINT32 Signature; UINT64 OrigPciAttrs; @@ -19,6 +30,9 @@ typedef struct { EFI_PCI_IO_PROTOCOL *PciIo; UINT8 MaxTarget; UINT8 MaxLun; + LSI_SCSI_DMA_BUFFER *Dma; + EFI_PHYSICAL_ADDRESS DmaPhysical; + VOID *DmaMapping; EFI_EXT_SCSI_PASS_THRU_MODE PassThruMode; EFI_EXT_SCSI_PASS_THRU_PROTOCOL PassThru; } LSI_SCSI_DEV; --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62729): https://edk2.groups.io/g/devel/message/62729 Mute This Topic: https://groups.io/mt/75607041/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-