From nobody Mon Feb 9 21:20:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+62724+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62724+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1594966320155425.7213127080182; Thu, 16 Jul 2020 23:12:00 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id nF67YY1788612xwa9uhtkYkL; Thu, 16 Jul 2020 23:11:59 -0700 X-Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [62.140.7.102]) by mx.groups.io with SMTP id smtpd.web10.5997.1594966318991211678 for ; Thu, 16 Jul 2020 23:11:59 -0700 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-12-nvIVYSHhOt2IdYA-iAFLmQ-1; Fri, 17 Jul 2020 08:11:56 +0200 X-MC-Unique: nvIVYSHhOt2IdYA-iAFLmQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I6lsUMgzs5efJ9Ravxo3RpNYdy/I3lolmFVYPBhUxHofiIrVjIuc2/VvLPRTtMnmAHx2tB2uswhv+eCeJ+hKmS/qW9ebOZEuMt4LOVrYGa7qKuq5AAjIAstNS5Rg/kY4UNlXo3DTNwqPdR7OUdYioqN8cVPSMgleIjlK2Pf8ijXmz1tkArye78Xa6pPxyHt3deIGFlek/VIDctCu4sME4oEWwTmMsIGSz9JWlk63UWi0659byjUmKaqFQx2jPSyREDO1VWtoHE/CkJpNIDizIfcnpEFOitoxTAVX18uoVQIAstK9TpZPmvkPJ6UyY8OFVX2ci2vgVUVq8jA9k5hSNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=28SI9s2Shz/DoCip7DxOA2Y/cu4qGNCUZ2PWhW5YwWc=; b=CavKT3ymnEq86ED2sP+doq3B6mgWkXVHp7GOSffaXGFW7wxJ5fy/hx/qbirXPFISAfYegbUU9t3N4asnq/RcewGgpYCyvCKkmqnmsOkMvLsranR9+JMzBnNfIwo2oejPk4Et0BFOiXknSJnpbZqW3xmTgjI4sGy3hEjk9T/hPDuVwBq8jVSMAzutFu3EdVfRoMLou/AJU8FArFRW+KdK6svjDuVEC5VuFeL6Ksap2w592MBIn3RKId11VLQHh8j8qMSZHtiQ3GG7r/EE1iqYZLK3auPq/9Alnh4OaplziJ/LHV74Y/ucoXOGJy3xz49TxDmTMi+txMlm2iNIr+l7+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none X-Received: from AM0PR0402MB3809.eurprd04.prod.outlook.com (2603:10a6:208:10::30) by AM0PR04MB4740.eurprd04.prod.outlook.com (2603:10a6:208:c8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Fri, 17 Jul 2020 06:11:55 +0000 X-Received: from AM0PR0402MB3809.eurprd04.prod.outlook.com ([fe80::a14c:d441:c8a9:77ba]) by AM0PR0402MB3809.eurprd04.prod.outlook.com ([fe80::a14c:d441:c8a9:77ba%6]) with mapi id 15.20.3174.026; Fri, 17 Jul 2020 06:11:55 +0000 From: "Gary Lin" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel Subject: [edk2-devel] [PATCH v3 03/11] OvmfPkg/LsiScsiDxe: Report the name of the driver Date: Fri, 17 Jul 2020 14:11:22 +0800 Message-Id: <20200717061130.8881-4-glin@suse.com> In-Reply-To: <20200717061130.8881-1-glin@suse.com> References: <20200717061130.8881-1-glin@suse.com> X-ClientProxiedBy: AM0PR04CA0138.eurprd04.prod.outlook.com (2603:10a6:208:55::43) To AM0PR0402MB3809.eurprd04.prod.outlook.com (2603:10a6:208:10::30) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from GaryWorkstation.suse.cz (60.251.47.115) by AM0PR04CA0138.eurprd04.prod.outlook.com (2603:10a6:208:55::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend Transport; Fri, 17 Jul 2020 06:11:52 +0000 X-Originating-IP: [60.251.47.115] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2c808e99-30a9-4915-8d56-08d82a184dc6 X-MS-TrafficTypeDiagnostic: AM0PR04MB4740: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: gbY7xDm0kDgh1hpBVlO/FWzAfbCBaeH3uX1O4tU12x+F8ghvceh/3yt/GHEIFhlmP4CVkICk7vuo51e4GD3yVXpDK5jBR7QXlM3qk4fqswyUKV5YiEnhcpzLFKZcgzY1rRudMDK4pa1VuCYFmSiktRsWPuVX1bPX6t1qlI93GxNHjKvTSBd6fil+sNkG6Q6kxpZEM1TIc08KE/t6GiNYyFJ17TZwi2Tf4oyxkMp+3wkpIhrqu4MrXsd/W+ijuDKhpDDB7X9Vk2G/9SZwRObOI7ns3P0cXXLmqFT3XDPJ0JPuHOlzmGaepAbf8isLfd3MYbcc5BzEjypihq5m6KQpZQ== X-MS-Exchange-AntiSpam-MessageData: YP2sNfyKMU5TrF/2PixW8UOaT33aXVa6fz//8o/PDYGg+R2zCzm4tPjLe18mg2XDZkj7Fvzq0rGxKX/Mf2K3xTlRn5y6HUQ/xbO0sxzC3zX2Th7W7AZoEXR9odGly+kJCtTns3DLOUsBLUgbS6CsfZm+CBcc+rjzk6atYDTNkMzZU0IpFPw5+Rv5j17VSut9E41n6jClhv8dl97MWCcNwF/oHz9E10Bz2m01+g38BWHLkXg7oCQRptYKRtppZVCoz337BRjTvm4qlY8S4UjllMH2+ow/RmolpHY45jlpT+aw/S9OHRIk30bePHSVOXkfCFkcV+AYzGKUG+W+R7ELZjI4DNNgh62wv2/hZKoBxzvrsIlCjaYkmu18zZy/sPUUOp4VEjo9d6P18sspw5YIbrC2iy9371mx+0yhno/P2C0m2wJH9Vm+6+2FpWltTlnCtXnlXnprhr8WPVZzgaSJm09/ExMFmoCPoijcRorYc1U= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c808e99-30a9-4915-8d56-08d82a184dc6 X-MS-Exchange-CrossTenant-AuthSource: AM0PR0402MB3809.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2020 06:11:55.1561 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LU5mEbBvAKVnwEn28D0+SyD3yiOzUH625SH4Cym37VSAhHwdKseLC9zuKu7QQXs7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4740 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,glin@suse.com X-Gm-Message-State: 0uQQ8xYAqFAzt6lQNmoenASZx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1594966319; bh=IJx3lQpTlvrN8H0PbSax66oocsywzfD+QkaI4zpIg/o=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=YXmW3rPbP/NadfwiLHNA0zFLIar+uJmdUtGMNY1IbUfgdcGtLXUcQECEX90YQWiLbLq Y1iRZFNLTtlEM/t7fZe5eBXmOb3UV7N7um7p6P4Bv7AZx9UlDWNiTeca3XA9Ismb2Y/xh JevPFhkHk1B/qK/ipqS+K9U/sKOo4vV6fw8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Implement LsiScsiGetDriverName() and LsiScsiGetDeviceName() to report the name of the driver. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin Reviewed-by: Laszlo Ersek --- OvmfPkg/LsiScsiDxe/LsiScsi.c | 69 ++++++++++++++++++++++++++++++++++-- OvmfPkg/LsiScsiDxe/LsiScsi.h | 31 ++++++++++++++++ 2 files changed, 98 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/LsiScsiDxe/LsiScsi.c b/OvmfPkg/LsiScsiDxe/LsiScsi.c index 79a2af4fee73..62daa3ab99bf 100644 --- a/OvmfPkg/LsiScsiDxe/LsiScsi.c +++ b/OvmfPkg/LsiScsiDxe/LsiScsi.c @@ -74,6 +74,71 @@ EFI_DRIVER_BINDING_PROTOCOL gDriverBinding =3D { }; =20 =20 +// +// The purpose of the following scaffolding (EFI_COMPONENT_NAME_PROTOCOL a= nd +// EFI_COMPONENT_NAME2_PROTOCOL implementation) is to format the driver's = name +// in English, for display on standard console devices. This is recommende= d for +// UEFI drivers that follow the UEFI Driver Model. Refer to the Driver Wri= ter's +// Guide for UEFI 2.3.1 v1.01, 11 UEFI Driver and Controller Names. +// +// Device type names ("LSI 53C895A SCSI Controller") are not formatted bec= ause +// the driver supports only that device type. Therefore the driver name +// suffices for unambiguous identification. +// + +STATIC +EFI_UNICODE_STRING_TABLE mDriverNameTable[] =3D { + { "eng;en", L"LSI 53C895A SCSI Controller Driver" }, + { NULL, NULL } +}; + +STATIC +EFI_COMPONENT_NAME_PROTOCOL gComponentName; + +EFI_STATUS +EFIAPI +LsiScsiGetDriverName ( + IN EFI_COMPONENT_NAME_PROTOCOL *This, + IN CHAR8 *Language, + OUT CHAR16 **DriverName + ) +{ + return LookupUnicodeString2 ( + Language, + This->SupportedLanguages, + mDriverNameTable, + DriverName, + (BOOLEAN)(This =3D=3D &gComponentName) // Iso639Language + ); +} + +EFI_STATUS +EFIAPI +LsiScsiGetDeviceName ( + IN EFI_COMPONENT_NAME_PROTOCOL *This, + IN EFI_HANDLE DeviceHandle, + IN EFI_HANDLE ChildHandle, + IN CHAR8 *Language, + OUT CHAR16 **ControllerName + ) +{ + return EFI_UNSUPPORTED; +} + +STATIC +EFI_COMPONENT_NAME_PROTOCOL gComponentName =3D { + &LsiScsiGetDriverName, + &LsiScsiGetDeviceName, + "eng" // SupportedLanguages, ISO 639-2 language codes +}; + +STATIC +EFI_COMPONENT_NAME2_PROTOCOL gComponentName2 =3D { + (EFI_COMPONENT_NAME2_GET_DRIVER_NAME) &LsiScsiGetDriverName, + (EFI_COMPONENT_NAME2_GET_CONTROLLER_NAME) &LsiScsiGetDeviceName, + "en" // SupportedLanguages, RFC 4646 language codes +}; + // // Entry point of this driver // @@ -89,7 +154,7 @@ LsiScsiEntryPoint ( SystemTable, &gDriverBinding, ImageHandle, // The handle to install onto - NULL, // TODO Component name - NULL // TODO Component name + &gComponentName, + &gComponentName2 ); } diff --git a/OvmfPkg/LsiScsiDxe/LsiScsi.h b/OvmfPkg/LsiScsiDxe/LsiScsi.h index 328bd289b8e8..6c8dcbd70a0a 100644 --- a/OvmfPkg/LsiScsiDxe/LsiScsi.h +++ b/OvmfPkg/LsiScsiDxe/LsiScsi.h @@ -46,4 +46,35 @@ LsiScsiControllerStop ( IN EFI_HANDLE *ChildHandleBuffer ); =20 + +// +// The purpose of the following scaffolding (EFI_COMPONENT_NAME_PROTOCOL a= nd +// EFI_COMPONENT_NAME2_PROTOCOL implementation) is to format the driver's = name +// in English, for display on standard console devices. This is recommende= d for +// UEFI drivers that follow the UEFI Driver Model. Refer to the Driver Wri= ter's +// Guide for UEFI 2.3.1 v1.01, 11 UEFI Driver and Controller Names. +// +// Device type names ("LSI 53C895A SCSI Controller") are not formatted bec= ause +// the driver supports only that device type. Therefore the driver name +// suffices for unambiguous identification. +// + +EFI_STATUS +EFIAPI +LsiScsiGetDriverName ( + IN EFI_COMPONENT_NAME_PROTOCOL *This, + IN CHAR8 *Language, + OUT CHAR16 **DriverName + ); + +EFI_STATUS +EFIAPI +LsiScsiGetDeviceName ( + IN EFI_COMPONENT_NAME_PROTOCOL *This, + IN EFI_HANDLE DeviceHandle, + IN EFI_HANDLE ChildHandle, + IN CHAR8 *Language, + OUT CHAR16 **ControllerName + ); + #endif // _LSI_SCSI_DXE_H_ --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62724): https://edk2.groups.io/g/devel/message/62724 Mute This Topic: https://groups.io/mt/75607032/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-