From nobody Sun May 5 10:01:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+62680+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62680+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1594898534; cv=none; d=zohomail.com; s=zohoarc; b=FIsiPrmvioOm4DIpLacleZQk0heDogMagAcwm1jYmVbxcKoM/lgD03PeWLET2KZOvK3zoaerc6fEV3QjsekhcxpnftqZVIceDRSLkJAdUXdq2go4i7B6y+XrzYqE+SiLMD2/oRnW9agtJypOlTp/yytpYi6Kx1dGL4Sb7o8VX/U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594898534; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=HS6LUa3AfzhBr9bnFbwz+StwGz20CDUGDKUnOJPYF7U=; b=YfAaQHqptwDyK9js6NIkRzR/+jo2pCLUC2OF0oy6xJOd72FQg/WuXa2t/vNsEBxOBil/yhRq8CxE4iNLFd0qyDUxuH/K3qTj8IJae3I+Ac4NX0pPkhLthN+xtQIW5QrkzkKGAIA13pjnlNP1l5reuC5TkkYbR4ZRAtTwNWxMB4M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62680+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1594898534284988.8679897834328; Thu, 16 Jul 2020 04:22:14 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id z5w7YY1788612xvoVoXV4sPm; Thu, 16 Jul 2020 04:22:13 -0700 X-Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.13343.1594898532800831733 for ; Thu, 16 Jul 2020 04:22:12 -0700 IronPort-SDR: Cie5mXFG5QHqn5cKuqkAPQtT7KyDk28YAK+FI3EorsmtqVDGXOQ8og8kPqnrHpGL9MY/FlGuGr rIt/vfggB9VA== X-IronPort-AV: E=McAfee;i="6000,8403,9683"; a="210888672" X-IronPort-AV: E=Sophos;i="5.75,359,1589266800"; d="scan'208";a="210888672" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2020 04:22:12 -0700 IronPort-SDR: fS6EHjbao75rMn0CFeOuql5oVmuQJWTMFb3EEGhQ7h5bZ8p9yWoRprN5hvAiWbB8jcWv1hPRdR FJ7Hf5eXCpcw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,359,1589266800"; d="scan'208";a="308595192" X-Received: from shwdepsi1121.ccr.corp.intel.com ([10.239.158.83]) by fmsmga004.fm.intel.com with ESMTP; 16 Jul 2020 04:22:11 -0700 From: "Bob Feng" To: devel@edk2.groups.io Cc: Liming Gao Subject: [edk2-devel] [Patch] BaseTools: Remove the file timestamp checking during parsing Date: Thu, 16 Jul 2020 19:22:04 +0800 Message-Id: <20200716112204.42176-1-bob.c.feng@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,bob.c.feng@intel.com X-Gm-Message-State: Ct3fxsoHCV4w96p7xItlJEBXx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1594898533; bh=xbdf7SvRhZIHw0eXZr6XUp4wY1SSX89SeuQ17wExJxs=; h=Cc:Date:From:Reply-To:Subject:To; b=twWefJ0N16QOY3RxrRJQbO4Lh9cSqWm7irjMJ04x6reDon2jMdBNruYEtZBIwWUaNIO l2yVxOAw3Eoc8S2mCc6PACtdBBCv4KKwHZ13G9i/978wxLdFJYd6Pt5rA2Rqo9Cd1Tcox mCHzr2YANcETsfK8mfm+nvwZdWTRI9eGi+I= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" During build, the meta files are not changed, so it's no need to check file timestamp. This patch is to remove useless logic. Signed-off-by: Bob Feng Cc: Liming Gao Reviewed-by: Liming Gao --- .../Source/Python/Workspace/MetaFileTable.py | 12 ++---------- .../Source/Python/Workspace/WorkspaceDatabase.py | 16 ---------------- 2 files changed, 2 insertions(+), 26 deletions(-) diff --git a/BaseTools/Source/Python/Workspace/MetaFileTable.py b/BaseTools= /Source/Python/Workspace/MetaFileTable.py index 0555c91ccc..20cb80e36e 100644 --- a/BaseTools/Source/Python/Workspace/MetaFileTable.py +++ b/BaseTools/Source/Python/Workspace/MetaFileTable.py @@ -44,29 +44,21 @@ class MetaFileTable(): self.TableName =3D "_%s_%s_%s" % (FileType, len(DB.TblFile), u= uid.uuid4().hex) else: self.TableName =3D "_%s_%s" % (FileType, len(DB.TblFile)) =20 def IsIntegrity(self): + Result =3D False try: TimeStamp =3D self.MetaFile.TimeStamp if not self.CurrentContent: Result =3D False else: Result =3D self.CurrentContent[-1][0] < 0 - if not Result: - # update the timestamp in database - self.DB.SetFileTimeStamp(self.FileId, TimeStamp) - return False - - if TimeStamp !=3D self.DB.GetFileTimeStamp(self.FileId): - # update the timestamp in database - self.DB.SetFileTimeStamp(self.FileId, TimeStamp) - return False except Exception as Exc: EdkLogger.debug(EdkLogger.DEBUG_5, str(Exc)) return False - return True + return Result =20 def SetEndFlag(self): self.CurrentContent.append(self._DUMMY_) =20 def GetAll(self): diff --git a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py b/BaseT= ools/Source/Python/Workspace/WorkspaceDatabase.py index 9420eaa608..d955c78b25 100644 --- a/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py +++ b/BaseTools/Source/Python/Workspace/WorkspaceDatabase.py @@ -156,16 +156,10 @@ class WorkspaceDatabase(object): =20 # conversion object for build or file format conversion purpose self.BuildObject =3D WorkspaceDatabase.BuildObjectFactory(self) self.TransformObject =3D WorkspaceDatabase.TransformObjectFactory(= self) =20 - def SetFileTimeStamp(self,FileId,TimeStamp): - self.TblFile[FileId-1][6] =3D TimeStamp - - def GetFileTimeStamp(self,FileId): - return self.TblFile[FileId-1][6] - =20 ## Summarize all packages in the database def GetPackageList(self, Platform, Arch, TargetName, ToolChainTag): self.Platform =3D Platform PackageList =3D [] @@ -191,20 +185,10 @@ class WorkspaceDatabase(object): continue PackageList.append(Package) =20 return PackageList =20 - ## Summarize all platforms in the database - def PlatformList(self): - RetVal =3D [] - for PlatformFile in [item[3] for item in self.TblFile if item[5] = =3D=3D MODEL_FILE_DSC]: - try: - RetVal.append(self.BuildObject[PathClass(PlatformFile), TA= B_COMMON]) - except: - pass - return RetVal - def MapPlatform(self, Dscfile): Platform =3D self.BuildObject[PathClass(Dscfile), TAB_COMMON] if Platform is None: EdkLogger.error('build', PARSER_ERROR, "Failed to parser DSC f= ile: %s" % Dscfile) return Platform --=20 2.20.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62680): https://edk2.groups.io/g/devel/message/62680 Mute This Topic: https://groups.io/mt/75539166/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-