From nobody Sun Feb 8 18:29:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+62662+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62662+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1594885606756538.2650705804648; Thu, 16 Jul 2020 00:46:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ItVXYY1788612x88rdGAvk2j; Thu, 16 Jul 2020 00:46:46 -0700 X-Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [62.140.7.102]) by mx.groups.io with SMTP id smtpd.web11.10942.1594885605708831113 for ; Thu, 16 Jul 2020 00:46:46 -0700 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-26-pSgje2H2MrGpW1OuI73rnQ-1; Thu, 16 Jul 2020 09:46:43 +0200 X-MC-Unique: pSgje2H2MrGpW1OuI73rnQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kQHkVOnbDVAljHbQM93r0uBuFPzdCvZUZpoYTopyEKe50lyWQoE8xQbNzPNTWzSnl5eqq+AkuZ97Z8jpTySEJXMrUwTCl/QC6PM+XulhNfiyAygEGhGjvrBb+oUDUbTk+txtkFE2B9z9ltn0suCvs0TRb2h9+OgSyEp71qteRB/lJJG/I4W+gXmBd+5WI3dWT05qMqCGN9n2d9HGQ8ENPpYs7tFuXE2GRGri3wjgFg1QzOen1HqIWkiCedTIhFXQAulsh48C8yGRArfkQ9KN028AH/IsqHaIdNBewmbP7qK+SqErAIR0xJhl4ZJFtID2bs5B4kY9w6sY1RKqI2IFMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bwT6M3CiwcOGQGLhY2rUJ/yCygWTmgnYWWt6wXD58y0=; b=jTH9JmpG2ZupQa8sIYA+m4pA1OOJKwJijkBg6uX7+uzYTrC6CkUUmQbNJvtdCUJjCwOQI7qBTZWM9T51KwuxkNZQhHZBw/FXYgiGsJYd8FWfYSuAvrb7OgxZPgEMyAmcJGEpQdiHaSHyzwxd4MWG3XWZXS5kMuqoF4u3+NiPUG0l7OevvQX3qpaWrKDHYutFeMf3r/ZYDYfMGHyLIzOHlKXi8kZGOfOTmiBOkNsAvt2XsmmJQP1J74U6SWScriWetFsq9C9PcALD22Vith1y1rQ8azTevtFNGTmUMbbdUWRPAmPdnEUVn7O7Yg2ka5IUitMFo5wEPOGvKUaYs1z2sA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none X-Received: from AM0PR0402MB3809.eurprd04.prod.outlook.com (2603:10a6:208:10::30) by AM0PR04MB4740.eurprd04.prod.outlook.com (2603:10a6:208:c8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Thu, 16 Jul 2020 07:46:42 +0000 X-Received: from AM0PR0402MB3809.eurprd04.prod.outlook.com ([fe80::a14c:d441:c8a9:77ba]) by AM0PR0402MB3809.eurprd04.prod.outlook.com ([fe80::a14c:d441:c8a9:77ba%6]) with mapi id 15.20.3174.026; Thu, 16 Jul 2020 07:46:42 +0000 From: "Gary Lin" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel Subject: [edk2-devel] [PATCH v2 08/12] OvmfPkg/LsiScsiDxe: Map DMA buffer Date: Thu, 16 Jul 2020 15:46:03 +0800 Message-Id: <20200716074607.18048-9-glin@suse.com> In-Reply-To: <20200716074607.18048-1-glin@suse.com> References: <20200716074607.18048-1-glin@suse.com> X-ClientProxiedBy: AM3PR07CA0118.eurprd07.prod.outlook.com (2603:10a6:207:7::28) To AM0PR0402MB3809.eurprd04.prod.outlook.com (2603:10a6:208:10::30) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from GaryWorkstation.suse.cz (60.251.47.115) by AM3PR07CA0118.eurprd07.prod.outlook.com (2603:10a6:207:7::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17 via Frontend Transport; Thu, 16 Jul 2020 07:46:40 +0000 X-Originating-IP: [60.251.47.115] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e94fb639-f6c3-4c1f-df2d-08d8295c6149 X-MS-TrafficTypeDiagnostic: AM0PR04MB4740: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: FujPcG8K3aE9OI/t1YbtE/O9yz9NtSMD4LcU+86hg6yJZBwVvIqn47X8tIiiku8dBtPbDtmONUSfoxpiNGNOoEBts2iNjQ4+FUCoeukhA2AHkeOwQ5i2Yuxg++C18vD+5P2nekl+fBXImC4z4hMyP4B+2sTbRGNA8gqomTl8B4k1vbi3QnzQlpqyV1H3glqz3nQm6HORRwsUcmkrMjgA6+C0AU25XB463HEtC1SoAnCbvcZa9Ur37MAkB/+DlkDfKpmz3oYLu+xYwd2rFRNSSISq3QRF+hb8KwEz9AaGBroBDT8eM+jEIk09zAShd0VAiagHSrdwWbYMnmInEcuhNg== X-MS-Exchange-AntiSpam-MessageData: PhsuasUGVgIUyNLA6HzCkyb1Fe6kSwuKt/TIt0R3sCioQ7gTHuiIh6msx1zFyO5ZZKHQ46DIBRGaJgfsaTdqpNMuGlGuDoLTe9K3JwJgE8gNDR+xe/dtYA/8wEVmLt3Jb92h2nfGQf8R/jjKR5j0OqgVg3GFciI7OVWo6Adp+zyypulf6452i6AkABHqHK+8WLe1sna4/zpLZsgYBs3j4xleg1Yhkc8DVr6KEPS94DKJvR5P371I+fj/5mla47AmH/YmfWVlR8FF0aBoZcZ5IGyHL05VeQV36qjTuErQWLMrfO6FPE+LCvB+0mHmDroUCUJSIy3VUmPEo5wlOAeBLx8vCZ1QzCFE7wo6DOVVXMV8EfrXBLQ7nkv2xUXHvfj6wWfwwGfNbdi3XgfaySUsceFj6+1eZur6PwugllZrcAiLiAHXPnhiNLzI+hUYSUGpOr5890NvZlWH/cIvVOKoJsT4FGRaTWHk88TFOoDzze4= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e94fb639-f6c3-4c1f-df2d-08d8295c6149 X-MS-Exchange-CrossTenant-AuthSource: AM0PR0402MB3809.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2020 07:46:42.2344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yvewTsUxtWFqddKs2vv8csjpAHYbScoLpic0WYWcBgtJC6Oulc0avo7A1o/qJSqt X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4740 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,glin@suse.com X-Gm-Message-State: ouF787HXBayEIZku3ngudSfUx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1594885606; bh=tx1lfA1vvqGSNbe/1L5avta4pYjgmis4R8c38eQHiRI=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=MMUnUn41A9FMXi5IYVuIVFNI8DK0Wr/q9Q145VmznyM9rxFd8ySaWmifRm14T1OJp4p 0IHlUiilslxxawkvyYtX1RBLMDdy0LUSL6pQJMqGeQWi+eW4jUAkyeekx3TCHE9fcVhRK 8Y7yoKEYn4NEpMbDQ5AaGNmlqyLLNX8CJp4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Map DMA buffer and perpare for the implementation of LsiScsiPassThru(). v2: - Replace 0x10000 with SIZE_64KB macro for the DMA buffer data array - Remove DUAL_ADDRESS_CYCLE from PciIo since we don't really need 64-bit DMA address Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin Reviewed-by: Laszlo Ersek --- OvmfPkg/LsiScsiDxe/LsiScsi.c | 62 +++++++++++++++++++++++++++++++++++- OvmfPkg/LsiScsiDxe/LsiScsi.h | 14 ++++++++ 2 files changed, 75 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/LsiScsiDxe/LsiScsi.c b/OvmfPkg/LsiScsiDxe/LsiScsi.c index b21387db6e5a..4e84afa40085 100644 --- a/OvmfPkg/LsiScsiDxe/LsiScsi.c +++ b/OvmfPkg/LsiScsiDxe/LsiScsi.c @@ -356,6 +356,8 @@ LsiScsiControllerStart ( { EFI_STATUS Status; LSI_SCSI_DEV *Dev; + UINTN Pages; + UINTN BytesMapped; =20 Dev =3D AllocateZeroPool (sizeof (*Dev)); if (Dev =3D=3D NULL) { @@ -411,11 +413,45 @@ LsiScsiControllerStart ( goto CloseProtocol; } =20 - Status =3D LsiScsiReset (Dev); + // + // Create buffers for data transfer + // + Pages =3D EFI_SIZE_TO_PAGES (sizeof (*Dev->Dma)); + Status =3D Dev->PciIo->AllocateBuffer ( + Dev->PciIo, + AllocateAnyPages, + EfiBootServicesData, + Pages, + (VOID **)&Dev->Dma, + EFI_PCI_ATTRIBUTE_MEMORY_CACHED + ); if (EFI_ERROR (Status)) { goto RestoreAttributes; } =20 + BytesMapped =3D EFI_PAGES_TO_SIZE (Pages); + Status =3D Dev->PciIo->Map ( + Dev->PciIo, + EfiPciIoOperationBusMasterCommonBuffer, + Dev->Dma, + &BytesMapped, + &Dev->DmaPhysical, + &Dev->DmaMapping + ); + if (EFI_ERROR (Status)) { + goto FreeBuffer; + } + + if (BytesMapped !=3D EFI_PAGES_TO_SIZE (Pages)) { + Status =3D EFI_OUT_OF_RESOURCES; + goto Unmap; + } + + Status =3D LsiScsiReset (Dev); + if (EFI_ERROR (Status)) { + goto Unmap; + } + Status =3D gBS->CreateEvent ( EVT_SIGNAL_EXIT_BOOT_SERVICES, TPL_CALLBACK, @@ -462,6 +498,19 @@ CloseExitBoot: UninitDev: LsiScsiReset (Dev); =20 +Unmap: + Dev->PciIo->Unmap ( + Dev->PciIo, + Dev->DmaMapping + ); + +FreeBuffer: + Dev->PciIo->FreeBuffer ( + Dev->PciIo, + Pages, + Dev->Dma + ); + RestoreAttributes: Dev->PciIo->Attributes ( Dev->PciIo, @@ -524,6 +573,17 @@ LsiScsiControllerStop ( =20 LsiScsiReset (Dev); =20 + Dev->PciIo->Unmap ( + Dev->PciIo, + Dev->DmaMapping + ); + + Dev->PciIo->FreeBuffer ( + Dev->PciIo, + EFI_SIZE_TO_PAGES (sizeof (*Dev->Dma)), + Dev->Dma + ); + Dev->PciIo->Attributes ( Dev->PciIo, EfiPciIoAttributeOperationSet, diff --git a/OvmfPkg/LsiScsiDxe/LsiScsi.h b/OvmfPkg/LsiScsiDxe/LsiScsi.h index 8c2acff6e86f..9f9e5c7fed00 100644 --- a/OvmfPkg/LsiScsiDxe/LsiScsi.h +++ b/OvmfPkg/LsiScsiDxe/LsiScsi.h @@ -12,6 +12,17 @@ #ifndef _LSI_SCSI_DXE_H_ #define _LSI_SCSI_DXE_H_ =20 +typedef struct { + // + // Allocate 64KB for read/write buffer. It seems sufficient for the comm= on + // boot scenarios. + // + // NOTE: The number of bytes for data transmission is bounded by DMA Byte + // Count (DBC), a 24-bit register, so the maximum is 0xFFFFFF (16M= B-1). + // + UINT8 Data[SIZE_64KB]; +} LSI_SCSI_DMA_BUFFER; + typedef struct { UINT32 Signature; UINT64 OrigPciAttrs; @@ -19,6 +30,9 @@ typedef struct { EFI_PCI_IO_PROTOCOL *PciIo; UINT8 MaxTarget; UINT8 MaxLun; + LSI_SCSI_DMA_BUFFER *Dma; + EFI_PHYSICAL_ADDRESS DmaPhysical; + VOID *DmaMapping; EFI_EXT_SCSI_PASS_THRU_MODE PassThruMode; EFI_EXT_SCSI_PASS_THRU_PROTOCOL PassThru; } LSI_SCSI_DEV; --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62662): https://edk2.groups.io/g/devel/message/62662 Mute This Topic: https://groups.io/mt/75537212/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-