From nobody Mon Feb 9 19:04:32 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62551+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1594748777747790.6487634531966; Tue, 14 Jul 2020 10:46:17 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id yUZ5YY1788612xKxgDGgY2pd; Tue, 14 Jul 2020 10:46:17 -0700 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.73]) by mx.groups.io with SMTP id smtpd.web11.2020.1594748775801626925 for ; Tue, 14 Jul 2020 10:46:16 -0700 X-Received: from AM5PR0601CA0036.eurprd06.prod.outlook.com (2603:10a6:203:68::22) by DB8PR08MB5068.eurprd08.prod.outlook.com (2603:10a6:10:e9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Tue, 14 Jul 2020 17:46:12 +0000 X-Received: from AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:68:cafe::8d) by AM5PR0601CA0036.outlook.office365.com (2603:10a6:203:68::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22 via Frontend Transport; Tue, 14 Jul 2020 17:46:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+62551+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT023.mail.protection.outlook.com (10.152.16.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Tue, 14 Jul 2020 17:46:11 +0000 X-Received: ("Tessian outbound 8f45de5545d6:v62"); Tue, 14 Jul 2020 17:46:11 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7df5010fa8dd4300 X-CR-MTA-TID: 64aa7808 X-Received: from 0fdbd003f5e0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1121321B-4843-44AB-BC3E-5D25A6E628CD.1; Tue, 14 Jul 2020 17:46:06 +0000 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0fdbd003f5e0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 14 Jul 2020 17:46:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hOiGZyuVX0d0WUTyxDXfFLGmP9fs+UgHgPa7SDdwI2+4kOkB0Ci/ajO/sVdIlivoUJJK0fv2diAMynBQ2/s8tWJqLHgIW4eajcwiif/MaUflPp2+61liEiEoi3xYVhqHqidUVqpJj1x3Gt9RbrvjUrGnpGAwI5U4BERIoP95ofEn3Z0FpZ1uzTuTCiztcb6CDG54dGaCTwLozVydhw1m0oGfgYULGvryiVC/gOhpDKkFja3SLoSGKUBWUSLJPbBCBBRgbh1cTnVXfWN5cdSMrRTCXx06s4LAoOAS6qCUOGpiLkFf6pBVRsxlWcxmwGw+IliyqKP90KylUkmkK37yBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ecEIXpsFKMdcJ0NWSu9pJiNc5aWrDjdolRX7sp3FOu0=; b=DNKFY43c5EQXOH3ryJ7cw1WinhiScNQ65Mnx+szJBW7n6mVItEAls3CQffxbfdogQdmYgKLotm+A61wxsv7rQ4Yu5pm4t69nNz1bPosQa3Yx+OlMRLcfHJdsIjvFiYE4hBi2o3RPGOsaYeNyuiesoSFwVSzBUmp/6Ajvyl8dTIV4apq7XlM8CbHgAOo0Iml66N9VdNYHrTpdacsFqxYVU0gKNeMucCxRQHQDVogws6ZPJqiQ43BrIltTVA6ovaC+0VIMbyG/AKUBXmIisHWe6Y5YxoWxigl84/rV/r6rDIZ7+VcNi1KilophcqUgs6kolktNeN72QLxxya+AHKiCdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM6P194CA0026.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::39) by AM5PR0801MB2065.eurprd08.prod.outlook.com (2603:10a6:203:4a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Tue, 14 Jul 2020 17:46:05 +0000 X-Received: from AM5EUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:90:cafe::ef) by AM6P194CA0026.outlook.office365.com (2603:10a6:209:90::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17 via Frontend Transport; Tue, 14 Jul 2020 17:46:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT029.mail.protection.outlook.com (10.152.16.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3174.21 via Frontend Transport; Tue, 14 Jul 2020 17:46:04 +0000 X-Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1415.2; Tue, 14 Jul 2020 17:46:02 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Tue, 14 Jul 2020 17:46:02 +0000 X-Received: from localhost.localdomain (10.57.32.194) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Tue, 14 Jul 2020 17:46:01 +0000 From: "Tomas Pilar (tpilar)" To: CC: , , Ray Ni , "Zhichao Gao" Subject: [edk2-devel] [PATCH v3 5/8] ShellPkg/AcpiView: Refactor PrintFieldName Date: Tue, 14 Jul 2020 18:45:43 +0100 Message-ID: <20200714174546.560-6-Tomas.Pilar@arm.com> In-Reply-To: <20200714174546.560-1-Tomas.Pilar@arm.com> References: <20200714174546.560-1-Tomas.Pilar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(4636009)(46966005)(82310400002)(54906003)(81166007)(4326008)(47076004)(70206006)(70586007)(498600001)(5660300002)(83380400001)(8936002)(356005)(36756003)(26005)(2906002)(186003)(6916009)(2616005)(336012)(8676002)(86362001)(19627235002)(6666004)(1076003)(426003);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c3e725e-516a-44ca-634f-08d8281dcc50 X-MS-TrafficTypeDiagnostic: AM5PR0801MB2065:|DB8PR08MB5068: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: l5GqFII+nBhU7VfgL9AtrWNK8dbDrdkpv+kkjwOsAgVp2wyYomInmmgERCM+ROtBXs/b5U8sHRRAUhb1xMtChwGWkffTogU7XMxFdpJNJdtxWyFMTQMomZfxBFtlWpEDpRGXg/+CDP3YPb/5xIvYYv24PxiGLicu9ev2+oXzK73qldyWAq+KCOjFDECKVE3aKNrL+RveZR4tVBoRPjNXApS75d6sH5ZLLRC+Tr+y6nkeoDncYNwYNQkDVEdhiza2pLoNfyQjYC5tLk/ME6WOS4oosYbk2KZachE5VYj8gL1lFtfStHCE9eL2eqP8tBrCaeoyvMeMI30pwbg5a0HR0QOcnIek928m/1nMR2FRxPuQ0NXFggbrWHQws3qqJsSI+UlF4YClNoD5N2ir20cwWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2065 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 568cc5a3-0af1-4743-9083-08d8281dc82e X-Microsoft-Antispam-Message-Info: lCTdmHyE1vLl3sl3eAj0leyKZdqu/DHKUFnVmMfI3YSrLJ7r56Lx63PV/DGNjuHRgFjl4mVSfSdWY/CBrOptZd11utX/4vB6+QQ0Je4eSenl9g4eGcRcwfqUan/mchNI3TbbQFea3fVCUFXvdTaFMH9DFt0Gby7n5qy/AvVdkHLLggJZxjxp1ZbNGlU9QnLy2rmkv9U2aQdgSYt0rjttrzRz8Kx72T6OBkzPUwiHsRfFTjnackELHTB976fWKS6xWdLTRRC8tBCN46rleQy7RuB20/VjwUS0eAxl4mdtu8ebI8yLGcSrIoE5575v1sP010noDZgbR3vConC/V2bu9WpSpFtlB63u6P9hprZaN3RzcD51HyRf5+jK/DesW+wGHVqV7ZbEBhi5S4GHYHbwLQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2020 17:46:11.9268 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c3e725e-516a-44ca-634f-08d8281dcc50 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5068 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Tomas.Pilar@arm.com X-Gm-Message-State: RhhB6d7BB6Ao7g8JstpQijFcx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1594748777; bh=vNDVkOlOjCdxd3wANFU3x2FQSVatI1DziTCUg9Onqqs=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=wj5ax7I8G6KJZV+6t+1Wza/fdzEYPmgYg3WVCOt73KwwlW60CoGD8cqhgxToHMQpsaY miZp37fKpeBFZYLCUBR5sIeIBcbRGmjfzRg8jk1DZrfx2njIFVAwce5KQHlCZZvdQknPG 7E4RP8DeTlOBOA5143CnbX5nmc1N3njnU4g= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The AcpiView core method is refactored to take format and parameters rather than a fully formatted string. This allows for far more flexible parser writing. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Tomas Pilar --- .../UefiShellAcpiViewCommandLib/AcpiParser.c | 30 --------------- .../UefiShellAcpiViewCommandLib/AcpiParser.h | 19 ---------- .../UefiShellAcpiViewCommandLib/AcpiViewLog.c | 38 +++++++++++++++++++ .../UefiShellAcpiViewCommandLib/AcpiViewLog.h | 21 ++++++++++ .../Parsers/Dbg2/Dbg2Parser.c | 1 + .../Parsers/Fadt/FadtParser.c | 1 + .../Parsers/Iort/IortParser.c | 1 + .../Parsers/Pptt/PpttParser.c | 1 + .../Parsers/Slit/SlitParser.c | 1 + .../Parsers/Srat/SratParser.c | 1 + .../Parsers/Xsdt/XsdtParser.c | 1 + 11 files changed, 66 insertions(+), 49 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/Sh= ellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c index b88594cf3865..54d87e2768e1 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c @@ -13,8 +13,6 @@ #include "AcpiViewConfig.h" #include "AcpiViewLog.h" =20 -STATIC UINT32 gIndent; - STATIC ACPI_DESCRIPTION_HEADER_INFO AcpiHdrInfo; =20 /** @@ -390,34 +388,6 @@ Dump12Chars ( ); } =20 -/** - This function indents and prints the ACPI table Field Name. - - @param [in] Indent Number of spaces to add to the global table inde= nt. - The global table indent is 0 by default; however - this value is updated on entry to the ParseAcpi() - by adding the indent value provided to ParseAcpi= () - and restored back on exit. - Therefore the total indent in the output is - dependent on from where this function is called. - @param [in] FieldName Pointer to the Field Name. -**/ -VOID -EFIAPI -PrintFieldName ( - IN UINT32 Indent, - IN CONST CHAR16* FieldName -) -{ - Print ( - L"%*a%-*s : ", - gIndent + Indent, - "", - (OUTPUT_FIELD_COLUMN_WIDTH - gIndent - Indent), - FieldName - ); -} - /** This function is used to parse an ACPI table buffer. =20 diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h b/Sh= ellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h index 84eae61c8889..eb0c74eef144 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h @@ -204,25 +204,6 @@ Dump12Chars ( IN UINT8* Ptr ); =20 -/** - This function indents and prints the ACPI table Field Name. - - @param [in] Indent Number of spaces to add to the global table - indent. The global table indent is 0 by default; - however this value is updated on entry to the - ParseAcpi() by adding the indent value provided = to - ParseAcpi() and restored back on exit. Therefore - the total indent in the output is dependent on f= rom - where this function is called. - @param [in] FieldName Pointer to the Field Name. -**/ -VOID -EFIAPI -PrintFieldName ( - IN UINT32 Indent, - IN CONST CHAR16* FieldName - ); - /** This function pointer is the template for customizing the trace output =20 diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.c b/S= hellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.c index 7ec276ac7528..18bbf67eef0a 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.c @@ -27,6 +27,7 @@ static const CHAR16* mErrorTypeDesc [ACPI_ERROR_MAX] =3D { // Publicly accessible error and warning counters. UINT32 mTableErrorCount; UINT32 mTableWarningCount; +UINT32 gIndent; =20 /** Change the attributes of the standard output console @@ -336,3 +337,40 @@ CheckConstraintInternal ( // Return TRUE if constraint was violated return !Constraint; } + +/** + This function indents and prints the ACPI table Field Name. + + @param [in] Indent Number of spaces to add to the global table inde= nt. + The global table indent is 0 by default; however + this value is updated on entry to the ParseAcpi() + by adding the indent value provided to ParseAcpi= () + and restored back on exit. + Therefore the total indent in the output is + dependent on from where this function is called. + @param [in] FieldName Pointer to the format string for field name. + @param [in] ... Variable List parameters to format. +**/ +VOID +EFIAPI +PrintFieldName ( + IN UINT32 Indent, + IN CONST CHAR16* FieldNameFormat, + ... + ) +{ + VA_LIST Marker; + CHAR16 Buffer[64]; + + VA_START(Marker, FieldNameFormat); + UnicodeVSPrint(Buffer, sizeof(Buffer), FieldNameFormat, Marker); + VA_END(Marker); + + AcpiViewOutput ( + L"%*a%-*s : ", + gIndent + Indent, + "", + (OUTPUT_FIELD_COLUMN_WIDTH - gIndent - Indent), + Buffer + ); +} diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.h b/S= hellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.h index ce276ef7add2..0077646ca253 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.h +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiViewLog.h @@ -40,6 +40,7 @@ typedef enum { // Publicly accessible error and warning counters. extern UINT32 mTableErrorCount; extern UINT32 mTableWarningCount; +extern UINT32 gIndent; =20 /** AcpiView output and logging function. Will log the event to @@ -171,6 +172,26 @@ CheckConstraintInternal ( !!(Constraint), \ ACPI_WARN) =20 +/** + This function indents and prints the ACPI table Field Name. + + @param [in] Indent Number of spaces to add to the global table inde= nt. + The global table indent is 0 by default; however + this value is updated on entry to the ParseAcpi() + by adding the indent value provided to ParseAcpi= () + and restored back on exit. + Therefore the total indent in the output is + dependent on from where this function is called. + @param [in] FieldName Pointer to the format string for field name. + @param [in] ... Variable List parameters to format. +**/ +VOID +EFIAPI +PrintFieldName ( + IN UINT32 Indent, + IN CONST CHAR16* FieldNameFormat, + ... + ); =20 // Maximum string size that can be printed #define MAX_OUTPUT_SIZE 256 diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Pa= rser.c index 9df111ecaa7d..dd69ed6992ba 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c @@ -12,6 +12,7 @@ #include #include "AcpiParser.h" #include "AcpiTableParser.h" +#include "AcpiViewLog.h" =20 // Local variables pointing to the table fields STATIC CONST UINT32* OffsetDbgDeviceInfo; diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/Fadt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPa= rser.c index d86718bab67d..4734864dfdcf 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c @@ -13,6 +13,7 @@ #include "AcpiParser.h" #include "AcpiTableParser.h" #include "AcpiView.h" +#include "AcpiViewLog.h" =20 // Local variables STATIC CONST UINT32* DsdtAddress; diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/Iort= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPa= rser.c index f7447947b230..356f355939aa 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c @@ -14,6 +14,7 @@ #include "AcpiParser.h" #include "AcpiTableParser.h" #include "AcpiViewConfig.h" +#include "AcpiViewLog.h" =20 // Local variables STATIC ACPI_DESCRIPTION_HEADER_INFO AcpiHdrInfo; diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/Pptt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttPa= rser.c index acd2b81bb325..97a5203efb5f 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c @@ -15,6 +15,7 @@ #include "AcpiView.h" #include "AcpiViewConfig.h" #include "PpttParser.h" +#include "AcpiViewLog.h" =20 // Local variables STATIC CONST UINT8* ProcessorTopologyStructureType; diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/Slit= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitPa= rser.c index e4625ee8b139..cedfc8a71849 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c @@ -13,6 +13,7 @@ #include #include "AcpiParser.h" #include "AcpiTableParser.h" +#include "AcpiViewLog.h" =20 // Local Variables STATIC CONST UINT64* SlitSystemLocalityCount; diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/Srat= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratPa= rser.c index b9b67820b89f..568a0400bf07 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c @@ -14,6 +14,7 @@ #include "AcpiParser.h" #include "AcpiTableParser.h" #include "AcpiViewConfig.h" +#include "AcpiViewLog.h" =20 // Local Variables STATIC CONST UINT8* SratRAType; diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/Xsdt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtPa= rser.c index e39061f8e261..771c4f322b8e 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c @@ -13,6 +13,7 @@ #include #include "AcpiParser.h" #include "AcpiTableParser.h" +#include "AcpiViewLog.h" =20 // Local variables STATIC ACPI_DESCRIPTION_HEADER_INFO AcpiHdrInfo; --=20 2.24.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62551): https://edk2.groups.io/g/devel/message/62551 Mute This Topic: https://groups.io/mt/75504252/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-